140312 2015-01-09 14:32:41 -0800 Cache-control should be set only on api/runs 2015-01-09 14:39:30 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa oldest_to_newest 1060276 0 rniwa 2015-01-09 14:32:41 -0800 Some JSON APIs such as api/analysis-tasks can get outdated pretty quickly as they could be modified by the user on demand. Since the only JSON that takes a long time to generate is ones returned by api/runs, just set cache-control in that script instead. 1060279 1 244372 rniwa 2015-01-09 14:37:16 -0800 Created attachment 244372 Fixes the bug 1060280 2 244372 kling 2015-01-09 14:38:10 -0800 Comment on attachment 244372 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=244372&action=review r=me > Websites/perf.webkit.org/public/api/runs.php:18 > +// FIXME: We should support revalication as well as caching results in the server side. Typo, revalidation. 1060283 3 rniwa 2015-01-09 14:39:30 -0800 Committed r178208: <http://trac.webkit.org/changeset/178208> 244372 2015-01-09 14:37:16 -0800 2015-01-09 14:38:10 -0800 Fixes the bug bug-140312-20150109143721.patch text/plain 3808 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTc4MjA2KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE1LTAxLTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIENhY2hlLWNvbnRyb2wgc2hvdWxkIGJlIHNldCBvbmx5IG9uIGFwaS9ydW5zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAzMTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIEpTT04g QVBJcyBzdWNoIGFzIGFwaS9hbmFseXNpcy10YXNrcyBjYW4ndCBiZSBjYWNoZWQgZXZlbiBmb3Ig YSBzaG9ydCBwZXJpb2Qgb2YgdGltZSAoZS5nLiBhIGZldyBtaW51dGVzKQorICAgICAgICBzaW5j ZSB0aGV5IGNhbiBiZSBtb2RpZmllZCBieSB0aGUgdXNlciBvbiBkZW1hbmQuIFNpbmNlIG9ubHkg YXBpL3J1bnMucGhwIHRha2VzIGEgbG9uZyB0aW1lIHRvIGdlbmVyYXRlIEpTT05zLAorICAgICAg ICBqdXN0IHNldCBjYWNoZS1jb250cm9sIHRoZXJlIGluc3RlYWQgb2YganNvbi1oZWFkZXIucGhw IHdoaWNoIGlzIHVzZWQgYnkgb3RoZXIgSlNPTiBBUElzLgorCisgICAgICAgIEFsc28gc2V0IGRh dGVfZGVmYXVsdF90aW1lem9uZV9zZXQgaW4gZGIucGhwIHNpbmNlIHdlIG5ldmVyIHVzZSBub24t VVRDIHRpbWV6b25lIGluIG91ciBzY3JpcHRzLgorCisgICAgICAgICogcHVibGljL2FwaS9hbmFs eXNpcy10YXNrcy5waHA6CisgICAgICAgICogcHVibGljL2FwaS9ydW5zLnBocDogU2V0IHRoZSBj YWNoZSBjb250cm9sIGhlYWRlcnMuCisgICAgICAgICogcHVibGljL2luY2x1ZGUvZGIucGhwOiBT ZXQgdGhlIGRlZmF1bHQgdGltZXpvbmUgdG8gVVRDLgorICAgICAgICAqIHB1YmxpYy9pbmNsdWRl L2pzb24taGVhZGVyLnBocDogRG9uJ3Qgc2V0IHRoZSBjYWNoZSBjb250cm9sIGhlYWRlcnMuCisK IDIwMTUtMDEtMDkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg YXBpL3JlcG9ydC1jb21taXQgc2hvdWxkIGF1dGhlbnRpY2F0ZSB3aXRoIGEgc2xhdmUgbmFtZSBh bmQgcGFzc3dvcmQKSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvYXBpL2Fu YWx5c2lzLXRhc2tzLnBocAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv cHVibGljL2FwaS9hbmFseXNpcy10YXNrcy5waHAJKHJldmlzaW9uIDE3ODIwMykKKysrIFdlYnNp dGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvYXBpL2FuYWx5c2lzLXRhc2tzLnBocAkod29ya2lu ZyBjb3B5KQpAQCAtNjAsNyArNjAsNiBAQCBmdW5jdGlvbiBmZXRjaF9hbmRfcHVzaF9idWdzX3Rv X3Rhc2tzKCRkCiAgICAgcmV0dXJuICRidWdzOwogfQogCi1kYXRlX2RlZmF1bHRfdGltZXpvbmVf c2V0KCdVVEMnKTsKIGZ1bmN0aW9uIGZvcm1hdF90YXNrKCR0YXNrX3JvdykgewogICAgIHJldHVy biBhcnJheSgKICAgICAgICAgJ2lkJyA9PiAkdGFza19yb3dbJ3Rhc2tfaWQnXSwKSW5kZXg6IFdl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvYXBpL3J1bnMucGhwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvYXBpL3J1bnMucGhwCShyZXZpc2lvbiAx NzgyMDMpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2FwaS9ydW5zLnBocAko d29ya2luZyBjb3B5KQpAQCAtMTUsNiArMTUsMTEgQEAgJGRiID0gbmV3IERhdGFiYXNlOwogaWYg KCEkZGItPmNvbm5lY3QoKSkKICAgICBleGl0X3dpdGhfZXJyb3IoJ0RhdGFiYXNlQ29ubmVjdGlv bkZhaWx1cmUnKTsKIAorLy8gRklYTUU6IFdlIHNob3VsZCBzdXBwb3J0IHJldmFsaWNhdGlvbiBh cyB3ZWxsIGFzIGNhY2hpbmcgcmVzdWx0cyBpbiB0aGUgc2VydmVyIHNpZGUuCiskbWF4YWdlID0g Y29uZmlnKCdqc29uQ2FjaGVNYXhBZ2UnKTsKK2hlYWRlcignRXhwaXJlczogJyAuIGdtZGF0ZSgn RCwgZCBNIFkgSDppOnMnLCB0aW1lKCkgKyAkbWF4YWdlKSAuICcgR01UJyk7CitoZWFkZXIoIkNh Y2hlLUNvbnRyb2w6IG1heGFnZT0kbWF4YWdlIik7CisKICRwbGF0Zm9ybV9pZCA9IGludHZhbCgk cGFydHNbMF0pOwogJG1ldHJpY19pZCA9IGludHZhbCgkcGFydHNbMV0pOwogJGNvbmZpZ19yb3dz ID0gJGRiLT5xdWVyeV9hbmRfZmV0Y2hfYWxsKCdTRUxFQ1QgY29uZmlnX2lkLCBjb25maWdfdHlw ZSwgY29uZmlnX3BsYXRmb3JtLCBjb25maWdfbWV0cmljCkBAIC00Nyw3ICs1Miw2IEBAIGZ1bmN0 aW9uIGZldGNoX3J1bnNfZm9yX2NvbmZpZygkZGIsICRjb24KICAgICByZXR1cm4gJGZvcm1hdHRl ZF9ydW5zOwogfQogCi1kYXRlX2RlZmF1bHRfdGltZXpvbmVfc2V0KCdVVEMnKTsKIGZ1bmN0aW9u IHBhcnNlX3JldmlzaW9uc19hcnJheSgkcG9zdGdyZXNfYXJyYXkpIHsKICAgICBnbG9iYWwgJHJl cG9zaXRvcnlfaWRfdG9fbmFtZTsKIApJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1 YmxpYy9pbmNsdWRlL2RiLnBocAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5v cmcvcHVibGljL2luY2x1ZGUvZGIucGhwCShyZXZpc2lvbiAxNzgyMDMpCisrKyBXZWJzaXRlcy9w ZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1ZGUvZGIucGhwCSh3b3JraW5nIGNvcHkpCkBAIC00 MCw2ICs0MCw4IEBAIGlmIChjb25maWcoJ2RlYnVnJykpIHsKIH0gZWxzZQogICAgIGVycm9yX3Jl cG9ydGluZyhFX0VSUk9SKTsKIAorZGF0ZV9kZWZhdWx0X3RpbWV6b25lX3NldCgnVVRDJyk7CisK IGNsYXNzIERhdGFiYXNlCiB7CiAgICAgcHJpdmF0ZSAkY29ubmVjdGlvbiA9IGZhbHNlOwpJbmRl eDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9pbmNsdWRlL2pzb24taGVhZGVyLnBo cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1ZGUv anNvbi1oZWFkZXIucGhwCShyZXZpc2lvbiAxNzgyMDMpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvcHVibGljL2luY2x1ZGUvanNvbi1oZWFkZXIucGhwCSh3b3JraW5nIGNvcHkpCkBAIC0z LDkgKzMsNiBAQAogcmVxdWlyZV9vbmNlKCdkYi5waHAnKTsKIAogaGVhZGVyKCdDb250ZW50LXR5 cGU6IGFwcGxpY2F0aW9uL2pzb24nKTsKLSRtYXhhZ2UgPSBjb25maWcoJ2pzb25DYWNoZU1heEFn ZScpOwotaGVhZGVyKCdFeHBpcmVzOiAnIC4gZ21kYXRlKCdELCBkIE0gWSBIOmk6cycsIHRpbWUo KSArICRtYXhhZ2UpIC4gJyBHTVQnKTsKLWhlYWRlcigiQ2FjaGUtQ29udHJvbDogbWF4YWdlPSRt YXhhZ2UiKTsKIAogZnVuY3Rpb24gZXhpdF93aXRoX2Vycm9yKCRzdGF0dXMsICRkZXRhaWxzID0g YXJyYXkoKSkgewogICAgICRkZXRhaWxzWydzdGF0dXMnXSA9ICRzdGF0dXM7Cg==