140303 2015-01-09 11:56:19 -0800 [Win] Layout Test fast/canvas/canvas-path-addPath.html is failing 2015-01-09 17:31:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 130461 1 bfulgham bfulgham bfulgham cdumez webkit-bug-importer oldest_to_newest 1060214 0 bfulgham 2015-01-09 11:56:19 -0800 The following layout test is failing on Windows. fast/canvas/canvas-path-addPath.html Probable cause: This is crashing because we are attempting to add a path to itself in Path::addPath. The bug is here: void Path::addPath(const Path& path, const AffineTransform& transform) { if (!path.platformPath()) return; if (!transform.isInvertible()) return; CGAffineTransform transformCG = transform; // CG doesn't allow adding a path to itself. Optimize for the common case // and copy the path for the self referencing case. if (ensurePlatformPath() != path.platformPath()) { CGPathAddPath(ensurePlatformPath(), &transformCG, path.platformPath()); return; } CGPathRef pathCopy = CGPathCreateCopy(path.platformPath()); CGPathAddPath(ensurePlatformPath(), &transformCG, path.platformPath()); CGPathRelease(pathCopy); } Note that even though we are creating the pathCopy, we are not using it. Instead, we use the original path (violating the contract of the CG API). I'm not sure why this code seems to work on Mac, but it crashes on Windows. 1060215 1 bfulgham 2015-01-09 11:59:08 -0800 <rdar://problem/19428865> 1060216 2 244359 bfulgham 2015-01-09 12:03:21 -0800 Created attachment 244359 Patch 1060234 3 bfulgham 2015-01-09 12:17:38 -0800 Committed r178186: <http://trac.webkit.org/changeset/178186> 1060327 4 cdumez 2015-01-09 16:18:01 -0800 May have caused 1 test failure on the bots (may be a simple rebaseline): https://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r178186%20(20724)/results.html 1060355 5 bfulgham 2015-01-09 17:29:45 -0800 (In reply to comment #4) > May have caused 1 test failure on the bots (may be a simple rebaseline): > https://build.webkit.org/results/ > Apple%20MountainLion%20Debug%20WK2%20(Tests)/r178186%20(20724)/results.html Interesting. Looking at the history for this test on our platform (<http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=css3%2Fbackground%2Fbackground-repeat-space-content.html>), it looks as if a change between r178181 and r178183 introduced the slight image difference. (See http://trac.webkit.org/log/?verbose=on&rev=178183&stop_rev=178181>) Looking at the whole set of bots, it looks like r178183 is the change that triggered the image difference. 1060358 6 bfulgham 2015-01-09 17:31:16 -0800 (In reply to comment #4) > May have caused 1 test failure on the bots (may be a simple rebaseline): > https://build.webkit.org/results/ > Apple%20MountainLion%20Debug%20WK2%20(Tests)/r178186%20(20724)/results.html I think it was Bug 140298 that introduced that small image difference. I've updated the bug with some notes. 244359 2015-01-09 12:03:21 -0800 2015-01-09 12:07:23 -0800 Patch bug-140303-20150109121024.patch text/plain 1609 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODE4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAxLTA5ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIExheW91dCBUZXN0 IGZhc3QvY2FudmFzL2NhbnZhcy1wYXRoLWFkZFBhdGguaHRtbCBpcyBmYWlsaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAzMDMKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzE5NDI4ODY1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFsdGhvdWdoIHRoZSBjb2RlIGNsZWFybHkgc3RhdGVzIHRoYXQg Q0cgZG9lc24ndCBhbGxvdyBhZGRpbmcgYSBwYXRoIHRvIGl0c2VsZiwKKyAgICAgICAgYW5kIGJy YW5jaGVzIHRvIGhhbmRsZSB0aGlzIGNhc2UsIGl0IHNpbXBseSB1c2VzIHRoZSBicmFuY2ggdG8g dHJ5IGFkZGluZyB0aGUKKyAgICAgICAgcGF0aCB0byBpdHNlbGYgKGlnbm9yaW5nIHRoZSBjb3B5 IGl0IGp1c3QgbWFkZSkhCisKKyAgICAgICAgRml4IHRoaXMgY29weS9wYXN0ZSBidWcgc28gdGhh dCB3ZSB1c2UgdGhlIGNvcHkgYW5kIGF2b2lkIHZpb2xhdGluZyB0aGUgQ0cgCisgICAgICAgIEFQ SSBjb250cmFjdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL1BhdGhDRy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjphZGRQYXRoKTogRml4IHBhdGggdXNlZC4KKwogMjAx NS0wMS0wOSAgR3dhbmcgWW9vbiBId2FuZyAgPHlvb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBS ZW5hbWUgR3JhcGhpY3NMYXllckFuaW1hdGlvbiB0byBUZXh0dXJlTWFwcGVyQW5pbWF0aW9uCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9QYXRoQ0cuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL1BhdGhDRy5jcHAJ KHJldmlzaW9uIDE3ODE3MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nn L1BhdGhDRy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyNSw3ICszMjUsNyBAQCB2b2lkIFBhdGg6 OmFkZFBhdGgoY29uc3QgUGF0aCYgcGF0aCwgY29uCiAgICAgICAgIHJldHVybjsKICAgICB9CiAg ICAgQ0dQYXRoUmVmIHBhdGhDb3B5ID0gQ0dQYXRoQ3JlYXRlQ29weShwYXRoLnBsYXRmb3JtUGF0 aCgpKTsKLSAgICBDR1BhdGhBZGRQYXRoKGVuc3VyZVBsYXRmb3JtUGF0aCgpLCAmdHJhbnNmb3Jt Q0csIHBhdGgucGxhdGZvcm1QYXRoKCkpOworICAgIENHUGF0aEFkZFBhdGgoZW5zdXJlUGxhdGZv cm1QYXRoKCksICZ0cmFuc2Zvcm1DRywgcGF0aENvcHkpOwogICAgIENHUGF0aFJlbGVhc2UocGF0 aENvcHkpOwogfQogCg==