140291 2015-01-09 08:10:23 -0800 Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Console view 2015-01-09 12:08:58 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1060135 0 timothy 2015-01-09 08:10:23 -0800 After http://trac.webkit.org/changeset/178155 I have sometimes seen the navigation sidebar appear on launch when restoring to the Console view. Not sure what the steps are, but I have a patch to avoid it. 1060136 1 webkit-bug-importer 2015-01-09 08:10:46 -0800 <rdar://problem/19426210> 1060137 2 244343 timothy 2015-01-09 08:14:54 -0800 Created attachment 244343 Patch 1060191 3 244343 joepeck 2015-01-09 11:17:10 -0800 Comment on attachment 244343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244343&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:975 > + this._ignoreNavigationSidebarPanelCollapsedEvent = true; > + this.navigationSidebar.collapsed = true; > + delete this._ignoreNavigationSidebarPanelCollapsedEvent; I wonder if we should just set _ignore to false instead of deleting it. That would mean that later, the property lookup doesn't need to walk the prototype chain, and should just find the property immediately. > Source/WebInspectorUI/UserInterface/Base/Main.js:979 > + // Restore the sidebar if was forced collapsed earlier because of no selectedSidebarPanel. Grammar: "if was forced" => "if it was forced" 1060226 4 244343 commit-queue 2015-01-09 12:08:54 -0800 Comment on attachment 244343 Patch Clearing flags on attachment: 244343 Committed r178184: <http://trac.webkit.org/changeset/178184> 1060227 5 commit-queue 2015-01-09 12:08:58 -0800 All reviewed patches have been landed. Closing bug. 244343 2015-01-09 08:14:54 -0800 2015-01-09 12:08:54 -0800 Patch bug-140291-20150109081459.patch text/plain 5536 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz MjgxNjM5ODkxZjg0ZTA5MDkyMWJiNzY1OTAzZjY3ZDZkMjE2MGU3Li45MTBiYTllNmMwMTExYjhj YWQ0MTJhZDA5NDVjYjY0MGYxNjYxM2E0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNS0wMS0wOSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTjogTmF2aWdhdGlvbiBzaWRl YmFyIGNhbiBzaG93IGJsYW5rIG5leHQgdG8gdGhlIENvbnNvbGUgdmlldworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMjkxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2Uv TWFpbi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVkKTogRG9uJ3QgcmVz dG9yZSBjb2xsYXBzZWQgZmFsc2UgaWYgc2VsZWN0ZWRTaWRlYmFyUGFuZWwgaXMgbnVsbC4KKyAg ICAgICAgKFdlYkluc3BlY3Rvci5fc2lkZWJhckNvbGxhcHNlZFN0YXRlRGlkQ2hhbmdlKTogU3Vw cG9ydCBhIF9pZ25vcmVOYXZpZ2F0aW9uU2lkZWJhclBhbmVsQ29sbGFwc2VkRXZlbnQgZmxhZwor ICAgICAgICB0byBhdm9pZCBzZXR0aW5nIF9uYXZpZ2F0aW9uU2lkZWJhckNvbGxhcHNlZFNldHRp bmcuCisgICAgICAgIChXZWJJbnNwZWN0b3IuX25hdmlnYXRpb25TaWRlYmFyUGFuZWxTZWxlY3Rl ZCk6IEZvcmNlIGNvbGxhcHNlZCBpZiBzZWxlY3RlZFNpZGViYXJQYW5lbCBpcyBudWxsLgorICAg ICAgICAoV2ViSW5zcGVjdG9yLl9jb250ZW50QnJvd3NlckN1cnJlbnRDb250ZW50Vmlld0RpZENo YW5nZSk6IFNldCBfaWdub3JlTmF2aWdhdGlvblNpZGViYXJQYW5lbENvbGxhcHNlZEV2ZW50Cisg ICAgICAgIHdoZW4gZm9yY2luZyB0aGUgY29sbGFwc2VkIHN0YXRlIHRvIGF2b2lkIHNldHRpbmcg X25hdmlnYXRpb25TaWRlYmFyQ29sbGFwc2VkU2V0dGluZyBhbmQgY2FsbGluZworICAgICAgICBf dXBkYXRlQ29udGVudFZpZXdGb3JDdXJyZW50TmF2aWdhdGlvblNpZGViYXIuCisKIDIwMTUtMDEt MDggIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogUkVHUkVTU0lPTiBTaG93aW5nIGRlYnVnZ2VyIHNpZGViYXIgc2hvdWxkbid0 IGNoYW5nZSBzZWxlY3RlZCBKUyBmaWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggOGRlMmQ3MWY5MTg5ZTU3YzhiNzliMzQ4NGFi Njc1ODhjMGRiYzg2OC4uOTBjNGE5MTIyNjBmYmRhMmI2YTJhZGUwMzQ3ZWM4ODZlNDFhMWZmNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWlu LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5q cwpAQCAtMzQxLDcgKzM0MSw3IEBAIFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVkID0gZnVuY3Rp b24oKQogCiAgICAgLy8gU2V0IGNvbGxhcHNlZCBhZnRlciBsb2FkaW5nIHRoZSBwZW5kaW5nIGZy b250ZW5kIGNvbW1hbmRzIGFyZSBkaXNwYXRjaGVkIHNvIG9ubHkgdGhlIGZpbmFsCiAgICAgLy8g c2VsZWN0ZWQgc2lkZWJhciBwYW5lbCBnZXRzIHNob3duIGFuZCBoYXMgYSBzYXkgaW4gd2hhdCBj b250ZW50IHZpZXcgZ2V0cyBzaG93bi4KLSAgICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyLmNvbGxh cHNlZCA9IHRoaXMuX25hdmlnYXRpb25TaWRlYmFyQ29sbGFwc2VkU2V0dGluZy52YWx1ZTsKKyAg ICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyLmNvbGxhcHNlZCA9IHRoaXMubmF2aWdhdGlvblNpZGVi YXIuc2VsZWN0ZWRTaWRlYmFyUGFuZWwgPyB0aGlzLl9uYXZpZ2F0aW9uU2lkZWJhckNvbGxhcHNl ZFNldHRpbmcudmFsdWUgOiB0cnVlOwogCiAgICAgLy8gSWYgSW5zcGVjdG9yRnJvbnRlbmRBUEkg ZGlkbid0IHNob3cgYSBjb250ZW50IHZpZXcsIHRoZW4gdHJ5IHRvIHJlc3RvcmUgdGhlIGxhc3Qg c2F2ZWQgdmlldyBzdGF0ZS4KICAgICBpZiAoIXRoaXMuY29udGVudEJyb3dzZXIuY3VycmVudENv bnRlbnRWaWV3ICYmICF0aGlzLmlnbm9yZUxhc3RDb250ZW50Q29va2llKQpAQCAtODg2LDggKzg4 NiwxMCBAQCBXZWJJbnNwZWN0b3IuX3VwZGF0ZURvY2tOYXZpZ2F0aW9uSXRlbXMgPSBmdW5jdGlv bigpCiBXZWJJbnNwZWN0b3IuX3NpZGViYXJDb2xsYXBzZWRTdGF0ZURpZENoYW5nZSA9IGZ1bmN0 aW9uKGV2ZW50KQogewogICAgIGlmIChldmVudC50YXJnZXQgPT09IHRoaXMubmF2aWdhdGlvblNp ZGViYXIpIHsKLSAgICAgICAgdGhpcy5fbmF2aWdhdGlvblNpZGViYXJDb2xsYXBzZWRTZXR0aW5n LnZhbHVlID0gdGhpcy5uYXZpZ2F0aW9uU2lkZWJhci5jb2xsYXBzZWQ7Ci0gICAgICAgIHRoaXMu X3VwZGF0ZUNvbnRlbnRWaWV3Rm9yQ3VycmVudE5hdmlnYXRpb25TaWRlYmFyKCk7CisgICAgICAg IGlmICghdGhpcy5faWdub3JlTmF2aWdhdGlvblNpZGViYXJQYW5lbENvbGxhcHNlZEV2ZW50KSB7 CisgICAgICAgICAgICB0aGlzLl9uYXZpZ2F0aW9uU2lkZWJhckNvbGxhcHNlZFNldHRpbmcudmFs dWUgPSB0aGlzLm5hdmlnYXRpb25TaWRlYmFyLmNvbGxhcHNlZDsKKyAgICAgICAgICAgIHRoaXMu X3VwZGF0ZUNvbnRlbnRWaWV3Rm9yQ3VycmVudE5hdmlnYXRpb25TaWRlYmFyKCk7CisgICAgICAg IH0KICAgICB9IGVsc2UgaWYgKGV2ZW50LnRhcmdldCA9PT0gdGhpcy5kZXRhaWxzU2lkZWJhcikg ewogICAgICAgICBpZiAoIXRoaXMuX2lnbm9yZURldGFpbHNTaWRlYmFyUGFuZWxDb2xsYXBzZWRF dmVudCkKICAgICAgICAgICAgIHRoaXMuX2RldGFpbHNTaWRlYmFyQ29sbGFwc2VkU2V0dGluZy52 YWx1ZSA9IHRoaXMuZGV0YWlsc1NpZGViYXIuY29sbGFwc2VkOwpAQCAtOTY0LDcgKzk2NiwyMCBA QCBXZWJJbnNwZWN0b3IuX3VwZGF0ZUNvbnRlbnRWaWV3Rm9yQ3VycmVudE5hdmlnYXRpb25TaWRl YmFyID0gZnVuY3Rpb24oKQogCiBXZWJJbnNwZWN0b3IuX25hdmlnYXRpb25TaWRlYmFyUGFuZWxT ZWxlY3RlZCA9IGZ1bmN0aW9uKGV2ZW50KQogewotICAgIGlmICghdGhpcy5uYXZpZ2F0aW9uU2lk ZWJhci5zZWxlY3RlZFNpZGViYXJQYW5lbCB8fCB0aGlzLl9pZ25vcmVOYXZpZ2F0aW9uU2lkZWJh clBhbmVsU2VsZWN0ZWRFdmVudCkKKyAgICBpZiAodGhpcy5faWdub3JlTmF2aWdhdGlvblNpZGVi YXJQYW5lbFNlbGVjdGVkRXZlbnQpCisgICAgICAgIHJldHVybjsKKworICAgIGlmICghdGhpcy5u YXZpZ2F0aW9uU2lkZWJhci5zZWxlY3RlZFNpZGViYXJQYW5lbCkgeworICAgICAgICB0aGlzLl9p Z25vcmVOYXZpZ2F0aW9uU2lkZWJhclBhbmVsQ29sbGFwc2VkRXZlbnQgPSB0cnVlOworICAgICAg ICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyLmNvbGxhcHNlZCA9IHRydWU7CisgICAgICAgIGRlbGV0 ZSB0aGlzLl9pZ25vcmVOYXZpZ2F0aW9uU2lkZWJhclBhbmVsQ29sbGFwc2VkRXZlbnQ7CisgICAg ICAgIHJldHVybjsKKyAgICB9CisKKyAgICAvLyBSZXN0b3JlIHRoZSBzaWRlYmFyIGlmIHdhcyBm b3JjZWQgY29sbGFwc2VkIGVhcmxpZXIgYmVjYXVzZSBvZiBubyBzZWxlY3RlZFNpZGViYXJQYW5l bC4KKyAgICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyLmNvbGxhcHNlZCA9IHRoaXMuX25hdmlnYXRp b25TaWRlYmFyQ29sbGFwc2VkU2V0dGluZy52YWx1ZTsKKworICAgIGlmICh0aGlzLm5hdmlnYXRp b25TaWRlYmFyLmNvbGxhcHNlZCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgdGhpcy5fdXBkYXRl Q29udGVudFZpZXdGb3JDdXJyZW50TmF2aWdhdGlvblNpZGViYXIoKTsKQEAgLTExMDEsMTUgKzEx MTYsMjIgQEAgV2ViSW5zcGVjdG9yLl9jb250ZW50QnJvd3NlckN1cnJlbnRDb250ZW50Vmlld0Rp ZENoYW5nZSA9IGZ1bmN0aW9uKGV2ZW50KQogICAgICAgICBpZiAoYWxsb3dlZE5hdmlnYXRpb25T aWRlYmFyUGFuZWxzLmxlbmd0aCAmJiAhYWxsb3dlZE5hdmlnYXRpb25TaWRlYmFyUGFuZWxzLmNv bnRhaW5zKHNlbGVjdGVkU2lkZWJhclBhbmVsSWRlbnRpZmllcikpIHsKICAgICAgICAgICAgIGNv bnNvbGUuYXNzZXJ0KCFjdXJyZW50Q29udGVudFZpZXcuX19sYXN0TmF2aWdhdGlvblNpZGViYXJQ YW5lbElkZW50aWZpZXIgfHwgYWxsb3dlZE5hdmlnYXRpb25TaWRlYmFyUGFuZWxzLmNvbnRhaW5z KGN1cnJlbnRDb250ZW50Vmlldy5fX2xhc3ROYXZpZ2F0aW9uU2lkZWJhclBhbmVsSWRlbnRpZmll cikpOwogICAgICAgICAgICAgdGhpcy5uYXZpZ2F0aW9uU2lkZWJhci5zZWxlY3RlZFNpZGViYXJQ YW5lbCA9IGN1cnJlbnRDb250ZW50Vmlldy5fX2xhc3ROYXZpZ2F0aW9uU2lkZWJhclBhbmVsSWRl bnRpZmllciB8fCBhbGxvd2VkTmF2aWdhdGlvblNpZGViYXJQYW5lbHNbMF07CisgICAgICAgICAg ICBjb25zb2xlLmFzc2VydCh0aGlzLm5hdmlnYXRpb25TaWRlYmFyLnNlbGVjdGVkU2lkZWJhclBh bmVsKTsKICAgICAgICAgfQogCiAgICAgICAgIGlmICh0aGlzLl93YXNTaG93aW5nTmF2aWdhdGlv blNpZGViYXJCZWZvcmVGb3JjZWRDb2xsYXBzZWQpIHsKKyAgICAgICAgICAgIHRoaXMuX2lnbm9y ZU5hdmlnYXRpb25TaWRlYmFyUGFuZWxDb2xsYXBzZWRFdmVudCA9IHRydWU7CiAgICAgICAgICAg ICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyLmNvbGxhcHNlZCA9IGZhbHNlOworICAgICAgICAgICAg ZGVsZXRlIHRoaXMuX2lnbm9yZU5hdmlnYXRpb25TaWRlYmFyUGFuZWxDb2xsYXBzZWRFdmVudDsK KwogICAgICAgICAgICAgZGVsZXRlIHRoaXMuX3dhc1Nob3dpbmdOYXZpZ2F0aW9uU2lkZWJhckJl Zm9yZUZvcmNlZENvbGxhcHNlZDsKICAgICAgICAgfQogICAgIH0gZWxzZSBpZiAoIWFsbG93ZWRO YXZpZ2F0aW9uU2lkZWJhclBhbmVscyAmJiAhdGhpcy5uYXZpZ2F0aW9uU2lkZWJhci5jb2xsYXBz ZWQpIHsKICAgICAgICAgdGhpcy5fd2FzU2hvd2luZ05hdmlnYXRpb25TaWRlYmFyQmVmb3JlRm9y Y2VkQ29sbGFwc2VkID0gdHJ1ZTsKKworICAgICAgICB0aGlzLl9pZ25vcmVOYXZpZ2F0aW9uU2lk ZWJhclBhbmVsQ29sbGFwc2VkRXZlbnQgPSB0cnVlOwogICAgICAgICB0aGlzLm5hdmlnYXRpb25T aWRlYmFyLmNvbGxhcHNlZCA9IHRydWU7CisgICAgICAgIGRlbGV0ZSB0aGlzLl9pZ25vcmVOYXZp Z2F0aW9uU2lkZWJhclBhbmVsQ29sbGFwc2VkRXZlbnQ7CiAgICAgfQogCiAgICAgaWYgKGFsbG93 ZWROYXZpZ2F0aW9uU2lkZWJhclBhbmVscyAmJiAhdGhpcy5uYXZpZ2F0aW9uU2lkZWJhci5jb2xs YXBzZWQpCg==