140289 2015-01-09 03:04:45 -0800 [EFL] REGRESSION(r178029): It made compositing tests crash 2015-01-09 10:58:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 138551 1 ossy webkit-unassigned commit-queue esprehn+autocc glenn gyuyoung.kim kondapallykalyan ossy simon.fraser sun.shin oldest_to_newest 1060112 0 ossy 2015-01-09 03:04:45 -0800 https://trac.webkit.org/changeset/178029 made compositing tests crash on EFL which made the EFL bot early exit and unable to catch any new regression. Unfortunately the EFL bot was out of order r178020-r178142, but I bisected manually and confirm that r178029 caused this serious regression. Crash logs can be found here: (at least for a month, will be deleted automatically) https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/18835 1060119 1 sun.shin 2015-01-09 03:37:13 -0800 I have found the call stack of crash from your link <https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/18835 >. 18:59:49.163 21071 worker/3 compositing/backing/no-backing-for-clip-overlap.html crashed, (stderr lines): 18:59:49.163 21071 1 0x7ffb1cebf8c0 18:59:49.163 21071 2 0x7ffb1d080c30 18:59:49.163 21071 3 0x7ffb1ed33c85 WebCore::CoordinatedGraphicsLayer::notifyFlushRequired() 18:59:49.163 21071 4 0x7ffb1ed37b45 WebCore::CoordinatedGraphicsLayer::removeFromParent() 18:59:49.164 21071 5 0x7ffb1ed361b2 WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer() 18:59:49.164 21071 6 0x7ffb1ed36791 WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer() 18:59:49.164 21071 7 0x7ffb1ead6ecc WebCore::RenderLayerBacking::updateChildClippingStrategy(bool) 18:59:49.164 21071 8 0x7ffb1ead7131 WebCore::RenderLayerBacking::~RenderLayerBacking() 18:59:49.164 21071 9 0x7ffb1ead72a1 WebCore::RenderLayerBacking::~RenderLayerBacking() 18:59:49.164 21071 10 0x7ffb1eacacf2 WebCore::RenderLayer::clearBacking(bool) 18:59:49.164 21071 11 0x7ffb1eacae4d WebCore::RenderLayer::~RenderLayer() 18:59:49.164 21071 12 0x7ffb1eacb0f1 WebCore::RenderLayer::~RenderLayer() 18:59:49.164 21071 13 0x7ffb1eb1095f WebCore::RenderObject::willBeDestroyed() 18:59:49.164 21071 14 0x7ffb1eb133f9 WebCore::RenderObject::destroy() I can confirm that crash happens when clearing childClippingMaskLayer of CoordinatedGraphics Layer as in the following code. 1433 void RenderLayerBacking::updateChildClippingStrategy(bool needsDescendentsClippingLayer) 1434 { ................ 1453 } else { 1454 if (m_childClippingMaskLayer) { 1455 m_childClippingMaskLayer = nullptr; I am investigating the reason why it makes crash on EFL port. 1060133 2 244342 sun.shin 2015-01-09 07:56:51 -0800 Created attachment 244342 Patch 1060151 3 ossy 2015-01-09 09:41:20 -0800 (In reply to comment #2) > Created attachment 244342 [details] > Patch I checked this patch locally, it fixes the EFL issue for me. 1060180 4 244342 commit-queue 2015-01-09 10:58:29 -0800 Comment on attachment 244342 Patch Clearing flags on attachment: 244342 Committed r178176: <http://trac.webkit.org/changeset/178176> 1060181 5 commit-queue 2015-01-09 10:58:33 -0800 All reviewed patches have been landed. Closing bug. 244342 2015-01-09 07:56:51 -0800 2015-01-09 10:58:29 -0800 Patch bug-140289-20150109075657.patch text/plain 1753 sun.shin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQ1MTNjYTg3YjRjYWVl YWQ1MTc0MWRjMGUyYjg1YTk4NTBiMDJlZC4uYjZkZmFkZmYzOTdmNGY5YjhiNzBlZGM2OTE5YmQ5 MmNjMGEyMmI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAxLTA5ICBCeXVu Z3Nlb24gU2hpbiAgPHN1bi5zaGluQGxnZS5jb20+CisKKyAgICAgICAgW0VGTF0gRml4IGNyYXNo IGludHJvZHVjZWQgaW4gcjE3ODAyOQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQwMjg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ2xlYXJpbmcgY2hpbGRDbGlwcGluZ01hc2tMYXllciBvZiBDb29yZGlu YXRlZEdyYXBoaWNzIHNob3VsZCBiZSBjYWxsZWQKKyAgICAgICAgYmVmb3JlIGNsZWFyaW5nIGNo aWxkQ2xpcHBpbmdMYXllci4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6flJlbmRlckxheWVyQmFj a2luZyk6CisKIDIwMTUtMDEtMDkgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNv bT4KIAogICAgICAgICBBWDogQ3Jhc2ggYXQgLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckJhc2UgYWNjZXNzaWJpbGl0eVRpdGxlXSArIDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IDE3MTA5MDNiNzViOTFmYmU2ZGMyODYz YTNlYTEwYjYyZjM4M2U2N2QuLjExY2UwNDU2ZmE0NTQ0OTBjYzhhYjQzZDI1NjhlZmMyNzc4OGQ1 YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tp bmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcu Y3BwCkBAIC0xNDIsMTIgKzE0MiwxMiBAQCBSZW5kZXJMYXllckJhY2tpbmc6OlJlbmRlckxheWVy QmFja2luZyhSZW5kZXJMYXllciYgbGF5ZXIpCiBSZW5kZXJMYXllckJhY2tpbmc6On5SZW5kZXJM YXllckJhY2tpbmcoKQogewogICAgIHVwZGF0ZUFuY2VzdG9yQ2xpcHBpbmdMYXllcihmYWxzZSk7 CisgICAgdXBkYXRlQ2hpbGRDbGlwcGluZ1N0cmF0ZWd5KGZhbHNlKTsKICAgICB1cGRhdGVEZXNj ZW5kYW50Q2xpcHBpbmdMYXllcihmYWxzZSk7CiAgICAgdXBkYXRlT3ZlcmZsb3dDb250cm9sc0xh eWVycyhmYWxzZSwgZmFsc2UsIGZhbHNlKTsKICAgICB1cGRhdGVGb3JlZ3JvdW5kTGF5ZXIoZmFs c2UpOwogICAgIHVwZGF0ZUJhY2tncm91bmRMYXllcihmYWxzZSk7CiAgICAgdXBkYXRlTWFza0xh eWVyKGZhbHNlKTsKLSAgICB1cGRhdGVDaGlsZENsaXBwaW5nU3RyYXRlZ3koZmFsc2UpOwogICAg IHVwZGF0ZVNjcm9sbGluZ0xheWVycyhmYWxzZSk7CiAgICAgZGV0YWNoRnJvbVNjcm9sbGluZ0Nv b3JkaW5hdG9yKCk7CiAgICAgZGVzdHJveUdyYXBoaWNzTGF5ZXJzKCk7Cg==