140285 2015-01-08 21:14:21 -0800 [CoordinatedGraphics] Suspend or resume when visibility is changed 2015-01-11 18:47:09 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue lucas.de.marchi oldest_to_newest 1060071 0 ryuan.choi 2015-01-08 21:14:21 -0800 When webview became hidden, I think that we don't need to draw something like TiledCoreAnimationDrawingArea in mac/ 1060083 1 244326 ryuan.choi 2015-01-08 21:45:02 -0800 Created attachment 244326 Patch 1060084 2 244326 gyuyoung.kim 2015-01-08 21:49:27 -0800 Comment on attachment 244326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244326&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:613 > + if (changed && ViewState::IsVisible) { Is changed flag ? So don't we use below condition ? if (changed & ViewState::IsVisible) { } 1060089 3 244330 ryuan.choi 2015-01-08 22:24:16 -0800 Created attachment 244330 Patch 1060090 4 ryuan.choi 2015-01-08 22:30:09 -0800 (In reply to comment #2) > Comment on attachment 244326 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244326&action=review > > > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:613 > > + if (changed && ViewState::IsVisible) { > > Is changed flag ? So don't we use below condition ? > > if (changed & ViewState::IsVisible) { > > } Oops, mistake. Thanks for the review, I fixed. 1060504 5 244330 commit-queue 2015-01-11 18:47:05 -0800 Comment on attachment 244330 Patch Clearing flags on attachment: 244330 Committed r178252: <http://trac.webkit.org/changeset/178252> 1060505 6 commit-queue 2015-01-11 18:47:09 -0800 All reviewed patches have been landed. Closing bug. 244326 2015-01-08 21:45:02 -0800 2015-01-08 22:24:06 -0800 Patch bug-140285-20150109144501.patch text/plain 2733 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjZhODNkMGM2MjY4YmUz N2U2YTRmNmJjZWVhM2U2NzZkMTU0ZTViNy4uOTU1NGU2MmU0MGMzNjhlN2I4MTFmY2Q1OGNmMTMx OTM5NjZjZDI5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAxLTA4ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtDb29yZGluYXRl ZEdyYXBoaWNzXSBTdXNwZW5kIG9yIHJlc3VtZSB3aGVuIHZpc2liaWxpdHkgaXMgY2hhbmdlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMjg1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmNw cDogQ29waWVkIHRoZSBsb2dpYyBmcm9tIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLgor ICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZERyYXdpbmdBcmVhOjp2aWV3U3RhdGVEaWRDaGFu Z2UpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nv b3JkaW5hdGVkRHJhd2luZ0FyZWEuaDoKKwogMjAxNS0wMS0wOCAgU2FtIFdlaW5pZyAgPHNhbUB3 ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgV0tOYXZpZ2F0aW9uIGJyaWRnZWQgdG8gQVBJOjpO YXZpZ2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv Q29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVk RHJhd2luZ0FyZWEuY3BwCmluZGV4IDhiOTJmMzlkOTg1NDc5MmM3NWJjOWE3ZTdhYTdmY2FkYjk2 NGEzMmIuLjYxNjhlMWJjNTcxZDU2OGZlM2U5M2JjNzIyNmJkZTUxZDRkZjJiOWMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWEuY3Bw CkBAIC02MDgsNiArNjA4LDE2IEBAIHZvaWQgQ29vcmRpbmF0ZWREcmF3aW5nQXJlYTo6ZGlkUmVj ZWl2ZUNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdE1lc3NhZ2UoSVBDOjpDb25uCiB9CiAjZW5kaWYK IAordm9pZCBDb29yZGluYXRlZERyYXdpbmdBcmVhOjp2aWV3U3RhdGVEaWRDaGFuZ2UoVmlld1N0 YXRlOjpGbGFncyBjaGFuZ2VkLCBib29sLCBjb25zdCBWZWN0b3I8dWludDY0X3Q+JikKK3sKKyAg ICBpZiAoY2hhbmdlZCAmJiBWaWV3U3RhdGU6OklzVmlzaWJsZSkgeworICAgICAgICBpZiAobV93 ZWJQYWdlLmlzVmlzaWJsZSgpKQorICAgICAgICAgICAgcmVzdW1lUGFpbnRpbmcoKTsKKyAgICAg ICAgZWxzZQorICAgICAgICAgICAgc3VzcGVuZFBhaW50aW5nKCk7CisgICAgfQorfQorCiB2b2lk IENvb3JkaW5hdGVkRHJhd2luZ0FyZWE6OmF0dGFjaFZpZXdPdmVybGF5R3JhcGhpY3NMYXllcihX ZWJDb3JlOjpGcmFtZSogZnJhbWUsIFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqIHZpZXdPdmVybGF5 Um9vdExheWVyKQogewogICAgIGlmICghZnJhbWUtPmlzTWFpbkZyYW1lKCkpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZERyYXdpbmdBcmVhLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmgKaW5kZXggMTRk MmI1NmQ1MjQ1NDdiN2FlMjdlNzFjOTIwNDQ0Zjc2NGMyZGE5YS4uZDcwNTM0NjAyMzAxNGE1ZGEz NThmOWRhOTU4ZDljYWFjZDZkMzJiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJlYS5o CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBo aWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWEuaApAQCAtNjgsNiArNjgsNyBAQCBwcml2YXRlOgog ICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0TWVzc2Fn ZShJUEM6OkNvbm5lY3Rpb24mLCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJik7CiAjZW5kaWYKIAorICAg IHZpcnR1YWwgdm9pZCB2aWV3U3RhdGVEaWRDaGFuZ2UoV2ViQ29yZTo6Vmlld1N0YXRlOjpGbGFn cywgYm9vbCAvKiB3YW50c0RpZFVwZGF0ZVZpZXdTdGF0ZSAqLywgY29uc3QgVmVjdG9yPHVpbnQ2 NF90PiYgLyogY2FsbGJhY2tJRHMgKi8pIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBhdHRh Y2hWaWV3T3ZlcmxheUdyYXBoaWNzTGF5ZXIoV2ViQ29yZTo6RnJhbWUqLCBXZWJDb3JlOjpHcmFw aGljc0xheWVyKikgb3ZlcnJpZGU7CiAKICAgICAvLyBJUEMgbWVzc2FnZSBoYW5kbGVycy4K 244330 2015-01-08 22:24:16 -0800 2015-01-11 18:47:05 -0800 Patch bug-140285-20150109152418.patch text/plain 2732 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjZhODNkMGM2MjY4YmUz N2U2YTRmNmJjZWVhM2U2NzZkMTU0ZTViNy4uOTU1NGU2MmU0MGMzNjhlN2I4MTFmY2Q1OGNmMTMx OTM5NjZjZDI5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAxLTA4ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtDb29yZGluYXRl ZEdyYXBoaWNzXSBTdXNwZW5kIG9yIHJlc3VtZSB3aGVuIHZpc2liaWxpdHkgaXMgY2hhbmdlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMjg1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmNw cDogQ29waWVkIHRoZSBsb2dpYyBmcm9tIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLgor ICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZERyYXdpbmdBcmVhOjp2aWV3U3RhdGVEaWRDaGFu Z2UpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nv b3JkaW5hdGVkRHJhd2luZ0FyZWEuaDoKKwogMjAxNS0wMS0wOCAgU2FtIFdlaW5pZyAgPHNhbUB3 ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgV0tOYXZpZ2F0aW9uIGJyaWRnZWQgdG8gQVBJOjpO YXZpZ2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv Q29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVk RHJhd2luZ0FyZWEuY3BwCmluZGV4IDhiOTJmMzlkOTg1NDc5MmM3NWJjOWE3ZTdhYTdmY2FkYjk2 NGEzMmIuLmFkMjU3OWRiZDc5MGQ4ZTNjYmNhNmQzMmQ1MDk4OWFlM2U3ZThkZjMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWEuY3Bw CkBAIC02MDgsNiArNjA4LDE2IEBAIHZvaWQgQ29vcmRpbmF0ZWREcmF3aW5nQXJlYTo6ZGlkUmVj ZWl2ZUNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdE1lc3NhZ2UoSVBDOjpDb25uCiB9CiAjZW5kaWYK IAordm9pZCBDb29yZGluYXRlZERyYXdpbmdBcmVhOjp2aWV3U3RhdGVEaWRDaGFuZ2UoVmlld1N0 YXRlOjpGbGFncyBjaGFuZ2VkLCBib29sLCBjb25zdCBWZWN0b3I8dWludDY0X3Q+JikKK3sKKyAg ICBpZiAoY2hhbmdlZCAmIFZpZXdTdGF0ZTo6SXNWaXNpYmxlKSB7CisgICAgICAgIGlmIChtX3dl YlBhZ2UuaXNWaXNpYmxlKCkpCisgICAgICAgICAgICByZXN1bWVQYWludGluZygpOworICAgICAg ICBlbHNlCisgICAgICAgICAgICBzdXNwZW5kUGFpbnRpbmcoKTsKKyAgICB9Cit9CisKIHZvaWQg Q29vcmRpbmF0ZWREcmF3aW5nQXJlYTo6YXR0YWNoVmlld092ZXJsYXlHcmFwaGljc0xheWVyKFdl YkNvcmU6OkZyYW1lKiBmcmFtZSwgV2ViQ29yZTo6R3JhcGhpY3NMYXllciogdmlld092ZXJsYXlS b290TGF5ZXIpCiB7CiAgICAgaWYgKCFmcmFtZS0+aXNNYWluRnJhbWUoKSkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nv b3JkaW5hdGVkRHJhd2luZ0FyZWEuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWEuaAppbmRleCAxNGQy YjU2ZDUyNDU0N2I3YWUyN2U3MWM5MjA0NDRmNzY0YzJkYTlhLi5kNzA1MzQ2MDIzMDE0YTVkYTM1 OGY5ZGE5NThkOWNhYWNkNmQzMmJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmgK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJlYS5oCkBAIC02OCw2ICs2OCw3IEBAIHByaXZhdGU6CiAg ICAgdmlydHVhbCB2b2lkIGRpZFJlY2VpdmVDb29yZGluYXRlZExheWVyVHJlZUhvc3RNZXNzYWdl KElQQzo6Q29ubmVjdGlvbiYsIElQQzo6TWVzc2FnZURlY29kZXImKTsKICNlbmRpZgogCisgICAg dmlydHVhbCB2b2lkIHZpZXdTdGF0ZURpZENoYW5nZShXZWJDb3JlOjpWaWV3U3RhdGU6OkZsYWdz LCBib29sIC8qIHdhbnRzRGlkVXBkYXRlVmlld1N0YXRlICovLCBjb25zdCBWZWN0b3I8dWludDY0 X3Q+JiAvKiBjYWxsYmFja0lEcyAqLykgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2b2lkIGF0dGFj aFZpZXdPdmVybGF5R3JhcGhpY3NMYXllcihXZWJDb3JlOjpGcmFtZSosIFdlYkNvcmU6OkdyYXBo aWNzTGF5ZXIqKSBvdmVycmlkZTsKIAogICAgIC8vIElQQyBtZXNzYWdlIGhhbmRsZXJzLgo=