140263 2015-01-08 12:54:50 -0800 Can't use DataDetectors after immediate action preparation 2015-01-08 12:59:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca bdakin oldest_to_newest 1059916 0 thorton 2015-01-08 12:54:50 -0800 Can't use DataDetectors after immediate action preparation 1059918 1 244286 thorton 2015-01-08 12:55:16 -0800 Created attachment 244286 Patch 1059920 2 244286 thorton 2015-01-08 12:56:24 -0800 Comment on attachment 244286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244286&action=review > Source/WebKit/mac/WebView/WebImmediateActionController.mm:137 > return; Should drop this return, too. 1059922 3 thorton 2015-01-08 12:59:46 -0800 http://trac.webkit.org/changeset/178126 244286 2015-01-08 12:55:16 -0800 2015-01-08 12:57:39 -0800 Patch bug-140263-20150108125522.patch text/plain 2500 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggN2RlYzU1NWZl MWExMWUzM2RmNzcxMThkMzRjNzA4NmJjNGM3MDAzMC4uMmJkZjUzOTI5MWI2OTcxMjlhODU1YWJk MjY4YWQ0MmJhMzUyMGQ0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1 LTAxLTA4ICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAg ICAgICBDYW4ndCB1c2UgRGF0YURldGVjdG9ycyBhZnRlciBpbW1lZGlhdGUgYWN0aW9uIHByZXBh cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDAyNjMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE5NDEyNzA1PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy9XZWJJbW1lZGlhdGVB Y3Rpb25Db250cm9sbGVyLm1tOgorICAgICAgICAoLVtXZWJJbW1lZGlhdGVBY3Rpb25Db250cm9s bGVyIGltbWVkaWF0ZUFjdGlvblJlY29nbml6ZXJXaWxsUHJlcGFyZTpdKToKKyAgICAgICAgKC1b V2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlciBpbW1lZGlhdGVBY3Rpb25SZWNvZ25pemVyV2ls bEJlZ2luQW5pbWF0aW9uOl0pOgorICAgICAgICBUbyBtYXRjaCBXZWJLaXQyLCBvbmx5IGNhbGwg c2hvdWxkVXNlQWN0aW9ucyBpZiB0aGUgYW5pbWF0aW9uIGlzIGFjdHVhbGx5CisgICAgICAgIGdv aW5nIHRvIGJlZ2luLCBub3Qgd2hlbiBwcmVwYXJpbmcgZm9yIGl0LiBUaGlzIHdheSwgd2UncmUg Z3VhcmFudGVlZAorICAgICAgICB0byBnZXQgYSBkaWRDYW5jZWwgb3IgZGlkQ29tcGxldGUuCisK IDIwMTUtMDEtMDcgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAg IFtpT1NdIE1ha2UgV2ViS2l0MiBidWlsZCB3aXRoIHB1YmxpYyBpT1MgU0RLIGFuZCBtb3JlIGJ1 aWxkIGZpeGVzIGZvciBEUlQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcv V2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZp ZXcvV2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbQppbmRleCBjZDU1NDczZTg1YWNhNmU0 ZTAwYjA5NGE2NTBmNTY3NzE4MTNiMzc2Li4xZGUzNjY0ZWM1NDdkOGJiMzY5NGViYTA3ZTJhNjYz NWZiZDg2OTIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkltbWVk aWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9X ZWJJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyLm1tCkBAIC0xMzYsMTIgKzEzNiw2IEBAIHVzaW5n IG5hbWVzcGFjZSBXZWJDb3JlOwogICAgICAgICBbc2VsZiBfY2FuY2VsSW1tZWRpYXRlQWN0aW9u XTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLQotICAgIGlmIChfY3VycmVudEFjdGlvbkNvbnRl eHQpIHsKLSAgICAgICAgX2hhc0FjdGl2YXRlZEFjdGlvbkNvbnRleHQgPSBZRVM7Ci0gICAgICAg IGlmICghW2dldEREQWN0aW9uc01hbmFnZXJDbGFzcygpIHNob3VsZFVzZUFjdGlvbnNXaXRoQ29u dGV4dDpfY3VycmVudEFjdGlvbkNvbnRleHQuZ2V0KCldKQotICAgICAgICAgICAgW3NlbGYgX2Nh bmNlbEltbWVkaWF0ZUFjdGlvbl07Ci0gICAgfQogfQogCiAtICh2b2lkKWltbWVkaWF0ZUFjdGlv blJlY29nbml6ZXJXaWxsQmVnaW5BbmltYXRpb246KE5TSW1tZWRpYXRlQWN0aW9uR2VzdHVyZVJl Y29nbml6ZXIgKilpbW1lZGlhdGVBY3Rpb25SZWNvZ25pemVyCkBAIC0xNDksNyArMTQzLDExIEBA IHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogICAgIGlmIChpbW1lZGlhdGVBY3Rpb25SZWNvZ25p emVyICE9IF9pbW1lZGlhdGVBY3Rpb25SZWNvZ25pemVyKQogICAgICAgICByZXR1cm47CiAKLSAg ICAvLyBGSVhNRTogQWRkIHN1cHBvcnQgZm9yIHRoZSB0eXBlcyBvZiBmdW5jdGlvbmFsaXR5IHBy b3ZpZGVkIGluIEFjdGlvbiBtZW51J3MgbWVudU5lZWRzVXBkYXRlLgorICAgIGlmIChfY3VycmVu dEFjdGlvbkNvbnRleHQpIHsKKyAgICAgICAgX2hhc0FjdGl2YXRlZEFjdGlvbkNvbnRleHQgPSBZ RVM7CisgICAgICAgIGlmICghW2dldEREQWN0aW9uc01hbmFnZXJDbGFzcygpIHNob3VsZFVzZUFj dGlvbnNXaXRoQ29udGV4dDpfY3VycmVudEFjdGlvbkNvbnRleHQuZ2V0KCldKQorICAgICAgICAg ICAgW3NlbGYgX2NhbmNlbEltbWVkaWF0ZUFjdGlvbl07CisgICAgfQogfQogCiAtICh2b2lkKWlt bWVkaWF0ZUFjdGlvblJlY29nbml6ZXJEaWRVcGRhdGVBbmltYXRpb246KE5TSW1tZWRpYXRlQWN0 aW9uR2VzdHVyZVJlY29nbml6ZXIgKilpbW1lZGlhdGVBY3Rpb25SZWNvZ25pemVyCg==