140253 2015-01-08 10:12:57 -0800 http/tests/misc/acid3.html is flakey on Mavericks 2015-01-15 09:22:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139968 1 mmaxfield mmaxfield ap dino jonlee simon.fraser thorton oldest_to_newest 1059866 0 mmaxfield 2015-01-08 10:12:57 -0800 [1/2] editing/selection/move-by-character-brute-force.html passed [2/2] http/tests/misc/acid3.html failed unexpectedly (text diff) 1060336 1 mmaxfield 2015-01-09 16:39:35 -0800 This is caused by <rdar://problem/19433490> 1060366 2 244397 mmaxfield 2015-01-09 18:10:30 -0800 Created attachment 244397 Patch 1060435 3 244397 ap 2015-01-10 11:07:02 -0800 Comment on attachment 244397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244397&action=review Nice detective work! > Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:169 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1090 Is this 10.9 only? My guess is that we need the workaround on 10.9 and later now. > Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:170 > + // Workaround <rdar://problem/19433490> "Work around" is two words when one of them is a verb, and also please add a period at the end. > LayoutTests/platform/mac/TestExpectations:-1492 > -webkit.org/b/139968 [ Mavericks+ ] http/tests/misc/acid3.html [ Pass Failure ] Here's hoping that this fixes more tests, but that can be cleaned up later. 1060473 4 244397 mmaxfield 2015-01-11 09:27:34 -0800 Comment on attachment 244397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244397&action=review >> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:169 >> +#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1090 > > Is this 10.9 only? My guess is that we need the workaround on 10.9 and later now. I tried in 10.10 and the bug did not present itself. >> LayoutTests/platform/mac/TestExpectations:-1492 >> -webkit.org/b/139968 [ Mavericks+ ] http/tests/misc/acid3.html [ Pass Failure ] > > Here's hoping that this fixes more tests, but that can be cleaned up later. Yeah, I need to figure that out and (hopefully) unskip more tests 1060474 5 ap 2015-01-11 09:55:01 -0800 Hmm. But the test is also flaky on Yosemite, so we can't unmark it if the workaround is 10.9 only. http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmisc%2Facid3.html 1060650 6 244397 darin 2015-01-12 13:18:06 -0800 Comment on attachment 244397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244397&action=review >>> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:169 >>> +#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1090 >> >> Is this 10.9 only? My guess is that we need the workaround on 10.9 and later now. > > I tried in 10.10 and the bug did not present itself. That’s strange, given that the Apple team responsible does not claim the bug is fixed in 10.10 and is working on a fix for a future release. 1061560 7 mmaxfield 2015-01-15 09:22:16 -0800 Committed r178513: <http://trac.webkit.org/changeset/178513> 244397 2015-01-09 18:10:30 -0800 2015-01-10 11:07:02 -0800 Patch bug-140253-20150109181035.patch text/plain 3780 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmQ2MWM2OGQ1NmYxYzgw ODNhNTcwOTE4YWUxMTE5MDE5YmNhYTA4YS4uY2MyYzU4N2FlM2U1NWI4N2VhMWUxNWQwNzk4Yjg3 NGM0ODk0MjVjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAxLTA5ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cC90ZXN0 cy9taXNjL2FjaWQzLmh0bWwgaXMgZmxha2V5IG9uIE1hdmVyaWNrcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMjUzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29yZVRleHQgaGFzIGEgYnVnIDxyZGFy Oi8vcHJvYmxlbS8xOTQzMzQ5MD4gaW4gd2hpY2gga2VybmluZyBpcyBub3QgYXBwbGllZCBmb3Ig YSBmb250CisgICAgICAgIGlmIGEgQ1RUeXBlc2V0dGVyIGlzIGNyZWF0ZWQgdXNpbmcgdGhhdCBm b250IGJlZm9yZSBhIGNhbGwgdG8gQ1RGb250VHJhbnNmb3JtR2x5cGhzLiBXZQorICAgICAgICBv ZnRlbiBjcmVhdGUgdHlwZXNldHRlcnMgaW4gdGhlIGNvbXBsZXggY29kZSBwYXRoLCBzbyBpdCdz IG5vdCBvYnZpb3VzIHdoZW4gdGhpcyBidWcKKyAgICAgICAgbWlnaHQgcHJlc2VudCBpdHNlbGYu IFRoaXMgcGF0Y2ggc2ltcGx5IG1ha2VzIGEgZHVtbXkgaW52b2NhdGlvbiBvZgorICAgICAgICBD VEZvbnRUcmFuc2Zvcm1HbHlwaHMoKSB3aGVuIGNyZWF0aW5nIGEgU2ltcGxlRm9udERhdGEuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhpcyBpcyBjb3ZlcmVkIGJ5IGh0dHAvdGVz dHMvbWlzYy9hY2lkMy5odG1sLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1Np bXBsZUZvbnREYXRhTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxlRm9udERhdGE6OnBs YXRmb3JtSW5pdCk6CisKIDIwMTUtMDEtMDcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgQWJzdHJhY3RTUUxTdGF0ZW1lbnRCYWNrZW5kCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9u dERhdGFNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxl Rm9udERhdGFNYWMubW0KaW5kZXggOTQ3MzllYmNhNjJkNjZhYmY5MWM0ZDJhMjZjNmI5MjMzZmE0 MzVmYS4uY2YxYWUxODFjOTg2MzBhY2EzMTcxYjZkOWViMWM3MTM3MTQ4NzJlYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1NpbXBsZUZvbnREYXRhTWFj Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9TaW1wbGVGb250 RGF0YU1hYy5tbQpAQCAtMTY1LDYgKzE2NSwxMyBAQCB2b2lkIFNpbXBsZUZvbnREYXRhOjpwbGF0 Zm9ybUluaXQoKQogICAgICAgICBMT0dfRVJST1IoImZhaWxlZCB0byBzZXQgdXAgZm9udCwgdXNp bmcgc3lzdGVtIGZvbnQgJXMiLCBtX3BsYXRmb3JtRGF0YS5mb250KCkpOwogICAgICAgICBpbml0 Rm9udERhdGEodGhpcyk7CiAgICAgfQorCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA9PSAxMDkwCisgICAgLy8gV29ya2Fyb3VuZCA8cmRhcjovL3Byb2JsZW0vMTk0MzM0OTA+ CisgICAgQ0dHbHlwaCBkdW1teUdseXBoc1tdID0gezAsIDB9OworICAgIENHU2l6ZSBkdW1teVNp emVbXSA9IHtDR1NpemVNYWtlKDAsIDApLCBDR1NpemVNYWtlKDAsIDApfTsKKyAgICBDVEZvbnRU cmFuc2Zvcm1HbHlwaHMobV9wbGF0Zm9ybURhdGEuY3RGb250KCksIGR1bW15R2x5cGhzLCBkdW1t eVNpemUsIDIsIGtDVEZvbnRUcmFuc2Zvcm1BcHBseVBvc2l0aW9uaW5nIHwga0NURm9udFRyYW5z Zm9ybUFwcGx5U2hhcGluZyk7CisjZW5kaWYKICAgICAKICAgICBpbnQgaUFzY2VudDsKICAgICBp bnQgaURlc2NlbnQ7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmQ3YzEzZGZkNjcyMThjYTM0MGYwOGEwODRlNjcxMTM3Njgw Yjg4Yy4uMzU0YjI0ZDgzNTZkYWNiMGRlMzUzZWNlMmFjZTAxOTQ3YmMxZTNkOCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDE1LTAxLTA5ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBh cHBsZS5jb20+CisKKyAgICAgICAgaHR0cC90ZXN0cy9taXNjL2FjaWQzLmh0bWwgaXMgZmxha2V5 IG9uIE1hdmVyaWNrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQwMjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVtb3ZlIGZsYWtleSBtYXJrLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RF eHBlY3RhdGlvbnM6CisKIDIwMTUtMDEtMDcgIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9i ZS5jb20+CiAKICAgICAgICAgW0NTUyBTaGFwZXNdIEFkZCBhIHZlcnRpY2FsLXJsIHRlc3QgZm9y IHNoYXBlcyBhZmZlY3RpbmcgYSBib3ggdGhhdCBzaHJpbmtzIHRvIGF2b2lkIHRoZSBmbG9hdApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA1NDFmN2I4MDNm ZTZlM2E0NTM3ODAyY2M5ODRiOWExNjkxOTcxOWQ0Li42YjdhNTY0MzIwZmY0YzY1M2RmZTUxZTZj YWQ0OTIxODk4MjdiZTFhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVz dEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0 aW9ucwpAQCAtMTQ4OSw3ICsxNDg5LDYgQEAgd2Via2l0Lm9yZy9iLzEzOTk2OCBbIE1vdW50YWlu TGlvbiBdIGZhc3QvcmVwYWludC9pbnZpc2libGUtb2JqZWN0cy5odG1sIFsgRmFpbHUKIHdlYmtp dC5vcmcvYi8xMzk5NjggWyBNb3VudGFpbkxpb24gXSBmYXN0L3RleHQvd2hpdGVzcGFjZS8wMjgu aHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzEzOTk2OCBbIE1vdW50YWluTGlvbiBdIHBs YXRmb3JtL21hYy9lZGl0aW5nL3NwZWxsaW5nL2F1dG9jb3JyZWN0aW9uLWNvbnRyYWN0aW9uLmh0 bWwgWyBGYWlsdXJlIF0KICMgVGhlc2UgdGVzdHMgYmVjYW1lIGZsYWt5LCB0ZXh0IHdpZHRoIGdl dHMgc2xpZ2h0bHkgb2ZmLgotd2Via2l0Lm9yZy9iLzEzOTk2OCBbIE1hdmVyaWNrcysgXSBodHRw L3Rlc3RzL21pc2MvYWNpZDMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTM5 OTY4IFsgTWF2ZXJpY2tzKyBdIHRhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnMTA2MzMuaHRtbCBbIFBh c3MgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTM5OTY4IFsgTWF2ZXJpY2tzKyBdIHRhYmxlcy9t b3ppbGxhL2J1Z3MvYnVnMTEzMjM1LTEuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJraXQub3Jn L2IvMTM5OTY4IFsgTWF2ZXJpY2tzKyBdIHRhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnODg1OC5odG1s IFsgUGFzcyBGYWlsdXJlIF0K