140243 2015-01-08 06:18:15 -0800 [CoordinatedGraphics] Non-overlay scrollbar is not rendered 2016-09-14 09:01:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 147725 1 yoon yoon commit-queue esprehn+autocc glenn gyuyoung.kim kondapallykalyan mcatanzaro mrobinson ryuan.choi simon.fraser oldest_to_newest 1059798 0 yoon 2015-01-08 06:18:15 -0800 [CoordinatedGraphics] Non-overlay scrollbar is not rendered 1059800 1 244256 yoon 2015-01-08 06:21:21 -0800 Created attachment 244256 Patch 1059801 2 yoon 2015-01-08 06:26:54 -0800 RenderLayerCompositor::mainFrameBackingIsTiled is checking the RenderLayerBacking uses tiledbacking dynamically. In the Coordinated Graphics, the main frame backing is always uses tiled backing store. So it should return true. I think we should refactor TILED_BACKING_STORE to match with Apple's tiledBacking at some point, and remove the TILED_BACKING_STORE guard in separated task. 1094301 3 ryuan.choi 2015-05-12 15:53:30 -0700 I added gyuyoung to take a look. Informally looks good to me. 1094329 4 244256 ryuan.choi 2015-05-12 17:45:16 -0700 Comment on attachment 244256 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244256&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:2927 > +#if USE(TILED_BACKING_STORE) I removed WTF_USE_TILED_BACKING_STORE since r183529 Please change this to USE(COORDINATED_GRAPHICS) 1094332 5 244256 gyuyoung.kim 2015-05-12 18:02:07 -0700 Comment on attachment 244256 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244256&action=review >> Source/WebCore/rendering/RenderLayerCompositor.cpp:2927 >> +#if USE(TILED_BACKING_STORE) > > I removed WTF_USE_TILED_BACKING_STORE since r183529 > > Please change this to USE(COORDINATED_GRAPHICS) The mainFrameBackingIsTiled() was changed to documentUsesTiledBacking() in r183943. This patch needs to be updated. 1094338 6 244256 simon.fraser 2015-05-12 18:21:59 -0700 Comment on attachment 244256 Patch r- since the patch is old. But are you sure the callers of documentUsesTiledBacking() are expecting this to return true for coordinated graphics? 1107645 7 256346 yoon 2015-07-07 19:30:22 -0700 Created attachment 256346 Patch 1107646 8 256347 yoon 2015-07-07 19:33:57 -0700 Created attachment 256347 Patch 1107647 9 yoon 2015-07-07 19:37:34 -0700 ryuan, gyuyoung thanks for pointing out. I just updated to match current codebase. 1107648 10 yoon 2015-07-07 19:39:14 -0700 (In reply to comment #6) > Comment on attachment 244256 [details] > Patch > > r- since the patch is old. But are you sure the callers of > documentUsesTiledBacking() are expecting this to return true for coordinated > graphics? Patch is updated. In Coordinated Graphics, we are just support overlay scrollbar at this point. To support non-overlay scrollbar, Coordinated Graphics should get true from documentUsesTiledBacking. And I'm pretty sure about it. :) 1107649 11 256347 gyuyoung.kim 2015-07-07 19:40:43 -0700 Comment on attachment 256347 Patch LGTM for EFL port which uses the coordinated graphics. However I would delegate this review to Simon. 1108165 12 256347 thorton 2015-07-09 01:21:13 -0700 Comment on attachment 256347 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256347&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:2948 > + return true; This is pretty weird. Why does backing->usingTiledBacking() not return true? Why would you want this and that to return different things? Seems wrong. 1109505 13 yoon 2015-07-14 15:57:46 -0700 (In reply to comment #12) > Comment on attachment 256347 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256347&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.cpp:2948 > > + return true; > > This is pretty weird. Why does backing->usingTiledBacking() not return true? > Why would you want this and that to return different things? Seems wrong. Thanks for review. First of all, it is because CoordinatedGraphics uses TiledBackingStore, not a TiledBacking. Coordinated Graphics manages tiles in GraphicsLayer, but TiledBacking is used in RenderLayer. There are several logics in RenderLayerBacking and RenderLayerCompositor which are specific TiledBacking implementation. So if we just return true in RenderLayerBacking::usingTiledBacking, it will introduce undesirable behavior in CoordinatedGraphics. That's why I want to add it this way. In a long-term, it is desirable to merge TiledBackingStore in to TiledBacking. It is weird that we have two similar implementation with similar name. And it will solve these weird stuffs. I'll do this work after turning threaded-compositor on in GTK+ port. 1229573 14 mcatanzaro 2016-09-14 09:01:13 -0700 Pretty sure this bug is obsolete now! 244256 2015-01-08 06:21:21 -0800 2015-07-07 19:30:15 -0700 Patch bug-140243-20150108232124.patch text/plain 1980 yoon U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWFlMGMxM2VjNTIzZjUw NmEwNzk3MTg3NDFkZGUzMWYwNTAzNzM3Yy4uZGViMzM4N2I3OTRjZWZkOTNhNmJmZmE1YWEzZjg0 NDA0NmI0ZjUwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE1LTAxLTA4ICBHd2Fu ZyBZb29uIEh3YW5nICA8eW9vbkBpZ2FsaWEuY29tPgogCisgICAgICAgIFtDb29yZGluYXRlZEdy YXBoaWNzXSBOb24tb3ZlcmxheSBzY3JvbGxiYXIgaXMgbm90IHJlbmRlcmVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAyNDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50IENvb3JkaW5hdGVk IEdyYXBoaWNzLCBkb2Vzbid0IHN1cHBvcnQgbm9uLW92ZXJsYXkgc2Nyb2xsYmFycyBwcm9wZXJs eS4KKyAgICAgICAgQmVjYXVzZSBDb29yZGluYXRlZCBHcmFwaGljcyB1c2VzIFRJTEVEX0JBQ0tJ TkdfU1RPUkUsIGFsbCBvZiBzY3JvbGxiYXJzCisgICAgICAgIHNob3VsZCBiZSBjb21wb3NpdGVk LCBidXQgaXQgb25seSBjb21wb3NpdGUgb3ZlcmxheSBzY3JvbGxiYXJzLgorCisgICAgICAgIFJl bmRlckxheWVyQ29tcG9zaXRvcjo6bWFpbkZyYW1lQmFja2luZ0lzVGlsZWQgaXMgY2hlY2tpbmcg dGhlCisgICAgICAgIFJlbmRlckxheWVyQmFja2luZyB1c2VzIHRpbGVkYmFja2luZyBkeW5hbWlj YWxseS4gIEluIHRoZSBDb29yZGluYXRlZAorICAgICAgICBHcmFwaGljcywgdGhlIG1haW4gZnJh bWUgYmFja2luZyBpcyBhbHdheXMgdXNlcyB0aWxlZCBiYWNraW5nIHN0b3JlLiBTbworICAgICAg ICBpdCBzaG91bGQgcmV0dXJuIHRydWUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFu Z2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpt YWluRnJhbWVCYWNraW5nSXNUaWxlZCk6CisKKzIwMTUtMDEtMDggIEd3YW5nIFlvb24gSHdhbmcg IDx5b29uQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gU2VwZXJhdGUgdXBkYXRlQmFja2lu Z1N0b3JlIGZyb20gZmx1c2hDb21wb3NpdGluZ1N0YXRlLgogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2ODg3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggZTkxYzY4Y2VmMTBl ZTFhZjIzZDgyNDU1ZTQ1MWYzNDFiNmFiNmJlYi4uMmUxNWU4NWU1MGEzMGY0ZjU3YWVmM2YwMjIy OTlmYzExZGU5NGUzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTI5MjQsNyArMjkyNCwxMSBAQCBib29sIFJlbmRlckxh eWVyQ29tcG9zaXRvcjo6bWFpbkZyYW1lQmFja2luZ0lzVGlsZWQoKSBjb25zdAogICAgIGlmICgh YmFja2luZykKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisjaWYgVVNFKFRJTEVEX0JBQ0tJTkdf U1RPUkUpCisgICAgcmV0dXJuIHRydWU7CisjZWxzZQogICAgIHJldHVybiBiYWNraW5nLT51c2lu Z1RpbGVkQmFja2luZygpOworI2VuZGlmCiB9CiAKIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9y OjpzaG91bGRDb21wb3NpdGVPdmVyZmxvd0NvbnRyb2xzKCkgY29uc3QK 256346 2015-07-07 19:30:22 -0700 2015-07-07 19:31:18 -0700 Patch bug-140243-20150708112923.patch text/plain 1936 yoon U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDIyNDQwYWU5ZTQzNmFl MzQ1NzUxNWQ2MTU5ZDVlN2Y1MzM0NWQ0Zi4uODNmNjRjNDRiNmE5YTI5ODE4ZTU1ZjA4NDhhNTBh ZmM4NWU1ODM3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTAxLTA4ICBHd2Fu ZyBZb29uIEh3YW5nICA8eW9vbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDb29yZGluYXRlZEdy YXBoaWNzXSBOb24tb3ZlcmxheSBzY3JvbGxiYXIgaXMgbm90IHJlbmRlcmVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAyNDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50IENvb3JkaW5hdGVk IEdyYXBoaWNzLCBkb2Vzbid0IHN1cHBvcnQgbm9uLW92ZXJsYXkgc2Nyb2xsYmFycyBwcm9wZXJs eS4KKyAgICAgICAgQmVjYXVzZSBDb29yZGluYXRlZCBHcmFwaGljcyB1c2VzIFRpbGVkQmFja2lu Z1N0b3JlLCBhbGwgb2Ygc2Nyb2xsYmFycworICAgICAgICBzaG91bGQgYmUgY29tcG9zaXRlZCwg YnV0IGl0IG9ubHkgY29tcG9zaXRlIG92ZXJsYXkgc2Nyb2xsYmFycy4KKworICAgICAgICBSZW5k ZXJMYXllckNvbXBvc2l0b3I6Om1haW5GcmFtZUJhY2tpbmdJc1RpbGVkIGlzIGNoZWNraW5nIHRo ZQorICAgICAgICBSZW5kZXJMYXllckJhY2tpbmcgdXNlcyB0aWxlZGJhY2tpbmcgZHluYW1pY2Fs bHkuICBJbiB0aGUgQ29vcmRpbmF0ZWQKKyAgICAgICAgR3JhcGhpY3MsIHRoZSBtYWluIGZyYW1l IGJhY2tpbmcgaXMgYWx3YXlzIHVzZXMgdGlsZWQgYmFja2luZyBzdG9yZS4gU28KKyAgICAgICAg aXQgc2hvdWxkIHJldHVybiB0cnVlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdl IGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6bWFp bkZyYW1lQmFja2luZ0lzVGlsZWQpOgorCiAyMDE1LTA3LTA3ICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxODMxMzMtcjE4MzEzOCk6 IFNlY29uZGFyeSBjbGlja2luZyBpbiB3aGl0ZXNwYWNlIHNlbGVjdHMgcHJlY2VkaW5nIHdvcmQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0 b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5j cHAKaW5kZXggYjllMDYyYWYzZmYxODE4YmJhYTFiNzQyOTg1ODAyZjdkNjUxNTNlYS4uYzI0MTc4 NTJjNzZkODhiZWFmMDRkMTViYThkYjQ3OWI5ZjA3MDI5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTI5NDQsNyArMjk0 NCwxMSBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZG9jdW1lbnRVc2VzVGlsZWRCYWNr aW5nKCkgY29uc3QKICAgICBpZiAoIWJhY2tpbmcpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAor I2lmIFVTRShDT09SRElOQVRFRF9HUkFQSElDUykKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbHNlCiAg ICAgcmV0dXJuIGJhY2tpbmctPnVzaW5nVGlsZWRCYWNraW5nKCk7CisjZW5kaWYKIH0KIAogYm9v bCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmlzTWFpbkZyYW1lQ29tcG9zaXRvcigpIGNvbnN0Cg== 256347 2015-07-07 19:33:57 -0700 2015-07-09 01:21:13 -0700 Patch bug-140243-20150708113258.patch text/plain 1938 yoon U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDIyNDQwYWU5ZTQzNmFl MzQ1NzUxNWQ2MTU5ZDVlN2Y1MzM0NWQ0Zi4uYTZiZTdmODcyNDZiNDRkYTAzMTBkZWQ5OTNjZGUw NDZmMTkwNjE5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTAxLTA4ICBHd2Fu ZyBZb29uIEh3YW5nICA8eW9vbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDb29yZGluYXRlZEdy YXBoaWNzXSBOb24tb3ZlcmxheSBzY3JvbGxiYXIgaXMgbm90IHJlbmRlcmVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAyNDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50IENvb3JkaW5hdGVk IEdyYXBoaWNzLCBkb2Vzbid0IHN1cHBvcnQgbm9uLW92ZXJsYXkgc2Nyb2xsYmFycyBwcm9wZXJs eS4KKyAgICAgICAgQmVjYXVzZSBDb29yZGluYXRlZCBHcmFwaGljcyB1c2VzIFRpbGVkQmFja2lu Z1N0b3JlLCBhbGwgb2Ygc2Nyb2xsYmFycworICAgICAgICBzaG91bGQgYmUgY29tcG9zaXRlZCwg YnV0IGl0IG9ubHkgY29tcG9zaXRlIG92ZXJsYXkgc2Nyb2xsYmFycy4KKworICAgICAgICBSZW5k ZXJMYXllckNvbXBvc2l0b3I6OmRvY3VtZW50VXNlc1RpbGVkQmFja2luZyBpcyBjaGVja2luZyB0 aGUKKyAgICAgICAgUmVuZGVyTGF5ZXJCYWNraW5nIHVzZXMgdGlsZWRiYWNraW5nIGR5bmFtaWNh bGx5LiAgSW4gdGhlIENvb3JkaW5hdGVkCisgICAgICAgIEdyYXBoaWNzLCB0aGUgbWFpbiBmcmFt ZSBiYWNraW5nIGlzIGFsd2F5cyB1c2VzIHRpbGVkIGJhY2tpbmcgc3RvcmUuIFNvCisgICAgICAg IGl0IHNob3VsZCByZXR1cm4gdHJ1ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNoYW5n ZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmRv Y3VtZW50VXNlc1RpbGVkQmFja2luZyk6CisKIDIwMTUtMDctMDcgIEJyZW50IEZ1bGdoYW0gIDxi ZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE4MzEzMy1yMTgzMTM4 KTogU2Vjb25kYXJ5IGNsaWNraW5nIGluIHdoaXRlc3BhY2Ugc2VsZWN0cyBwcmVjZWRpbmcgd29y ZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmNwcAppbmRleCBiOWUwNjJhZjNmZjE4MThiYmFhMWI3NDI5ODU4MDJmN2Q2NTE1M2VhLi5jMjQx Nzg1MmM3NmQ4OGJlYWYwNGQxNWJhOGRiNDc5YjlmMDcwMjk4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMjk0NCw3ICsy OTQ0LDExIEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpkb2N1bWVudFVzZXNUaWxlZEJh Y2tpbmcoKSBjb25zdAogICAgIGlmICghYmFja2luZykKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CisjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKQorICAgIHJldHVybiB0cnVlOworI2Vsc2UK ICAgICByZXR1cm4gYmFja2luZy0+dXNpbmdUaWxlZEJhY2tpbmcoKTsKKyNlbmRpZgogfQogCiBi b29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6aXNNYWluRnJhbWVDb21wb3NpdG9yKCkgY29uc3QK