140239 2015-01-07 20:37:25 -0800 Web Inspector: Editing Inline Styles Not Working 2015-01-07 22:19:43 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck burg burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1059708 0 joepeck 2015-01-07 20:37:25 -0800 * SUMMARY Editing Inline Styles Not Working. * TEST <style>body { background-color: red; }</style> <body bgColor="blue" style="background-color:green"></body> * STEPS TO REPRODUCE 1. Inspect <body> of test case 2. Disable inline "green" style. 3. Attempt to change "red" style to "purple". Or try to disable. => Does not work. 1059709 1 webkit-bug-importer 2015-01-07 20:37:34 -0800 <rdar://problem/19408438> 1059711 2 joepeck 2015-01-07 20:42:45 -0800 Regression caused by "purge PassRefPtr from Inspector code and use Ref for typed and untyped protocol objects": http://trac.webkit.org/changeset/178060 Doh. 1059722 3 joepeck 2015-01-07 21:18:19 -0800 Looks like this was due to an InspectorStyleSheet change: - RefPtr<Inspector::InspectorValue> ordinalValue = value->get("ordinal"); - if (!ordinalValue || !ordinalValue->asInteger(m_ordinal)) + int ordinalValue; + if (!value->getInteger("ordinal", ordinalValue)) m_ordinal used to be getting set, but now it isn't, causing it to have a garbage value. 1059727 4 244240 burg 2015-01-07 21:29:48 -0800 Created attachment 244240 Patch 1059735 5 244240 joepeck 2015-01-07 21:51:56 -0800 Comment on attachment 244240 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244240&action=review Thanks! > Source/WebCore/inspector/InspectorStyleSheet.h:69 > - if (!value->getString("styleSheetId", m_styleSheetId)) > + if (!value->getString(ASCIILiteral("styleSheetId"), m_styleSheetId)) > return; > > - int ordinalValue; > - if (!value->getInteger("ordinal", ordinalValue)) > - m_styleSheetId = ""; > + if (!value->getInteger(ASCIILiteral("ordinal"), m_ordinal)) > + m_styleSheetId = String(); We could swap the order of these and avoid this awkward cleanup. 1059736 6 joepeck 2015-01-07 21:55:44 -0800 (In reply to comment #5) > Comment on attachment 244240 [details] > Patch > > We could swap the order of these and avoid this awkward cleanup. Bah, then we'd need to clean up ordinal. I guess we do need awkwardness. 1059744 7 244240 commit-queue 2015-01-07 22:19:39 -0800 Comment on attachment 244240 Patch Clearing flags on attachment: 244240 Committed r178105: <http://trac.webkit.org/changeset/178105> 1059745 8 commit-queue 2015-01-07 22:19:43 -0800 All reviewed patches have been landed. Closing bug. 244240 2015-01-07 21:29:48 -0800 2015-01-07 22:19:39 -0800 Patch bug-140239-20150107212945.patch text/plain 2121 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Y2MWY1ODNmM2VlNzYz ZTRlMGVhY2VkYTRkMDFiM2VmYTE0MzAzYS4uMzBjMjczMTEzYzQwMTY5ZmMzY2YwZGIzM2Q0NGNj ZjYxM2Y5NmU3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAxLTA3ICBCcmlh biBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBFZGl0aW5nIElubGluZSBTdHlsZXMgTm90IFdvcmtpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDIzOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIHJlZ3Jlc3Npb24gaW50cm9kdWNl ZCBpbiByMTc4MDYwLCB3aGVyZSB3ZSBubyBsb25nZXIgc2V0CisgICAgICAgIG1fb3JkaW5hbCBp biBJbnNwZWN0b3JDU1NJZC4gVGhlIG9yaWdpbmFsIHJlZmFjdG9yaW5nIHNob3VsZCBoYXZlCisg ICAgICAgIHBhc3NlZCBtX29yZGluYWwuIEZpeCB0aGlzIGFuZCBpbnRyb2R1Y2UgYSBzZW5zaWJs ZSBkZWZhdWx0IHZhbHVlLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hl ZXQuaDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNTU0lkOjpJbnNwZWN0b3JDU1NJZCk6 CisKIDIwMTUtMDEtMDcgIEd3YW5nIFlvb24gSHdhbmcgIDx5b29uQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS11bVGhyZWFkZWRDb21wb3NpdG9yXSBBZGQgc3VwcG9ydCBmb3IgdGhyZWFkZWQg Y29tcG9zaXRvci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JTdHlsZVNoZWV0LmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVT aGVldC5oCmluZGV4IGRlY2QzMTliNjUzNTZhNDIyZDE4MTFkZWFmMzFhM2E2MGU2ZGZiMmQuLjI3 Mzg0Y2UwOTQ4OWI3NTJmZTlkZjBiMTkyNTY2NDdmNmUzZTgzNWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmgKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuaApAQCAtNTgsMTkgKzU4LDE1IEBA IHR5cGVkZWYgU3RyaW5nIEVycm9yU3RyaW5nOwogCiBjbGFzcyBJbnNwZWN0b3JDU1NJZCB7CiBw dWJsaWM6Ci0gICAgSW5zcGVjdG9yQ1NTSWQoKQotICAgICAgICA6IG1fb3JkaW5hbCgwKQotICAg IHsKLSAgICB9CisgICAgSW5zcGVjdG9yQ1NTSWQoKSB7IH0KIAogICAgIGV4cGxpY2l0IEluc3Bl Y3RvckNTU0lkKGNvbnN0IFJlZlB0cjxJbnNwZWN0b3I6Okluc3BlY3Rvck9iamVjdD4mJiB2YWx1 ZSkKICAgICB7Ci0gICAgICAgIGlmICghdmFsdWUtPmdldFN0cmluZygic3R5bGVTaGVldElkIiwg bV9zdHlsZVNoZWV0SWQpKQorICAgICAgICBpZiAoIXZhbHVlLT5nZXRTdHJpbmcoQVNDSUlMaXRl cmFsKCJzdHlsZVNoZWV0SWQiKSwgbV9zdHlsZVNoZWV0SWQpKQogICAgICAgICAgICAgcmV0dXJu OwogCi0gICAgICAgIGludCBvcmRpbmFsVmFsdWU7Ci0gICAgICAgIGlmICghdmFsdWUtPmdldElu dGVnZXIoIm9yZGluYWwiLCBvcmRpbmFsVmFsdWUpKQotICAgICAgICAgICAgbV9zdHlsZVNoZWV0 SWQgPSAiIjsKKyAgICAgICAgaWYgKCF2YWx1ZS0+Z2V0SW50ZWdlcihBU0NJSUxpdGVyYWwoIm9y ZGluYWwiKSwgbV9vcmRpbmFsKSkKKyAgICAgICAgICAgIG1fc3R5bGVTaGVldElkID0gU3RyaW5n KCk7CiAgICAgfQogCiAgICAgSW5zcGVjdG9yQ1NTSWQoY29uc3QgU3RyaW5nJiBzdHlsZVNoZWV0 SWQsIHVuc2lnbmVkIG9yZGluYWwpCkBAIC05OSw3ICs5NSw3IEBAIHB1YmxpYzoKIAogcHJpdmF0 ZToKICAgICBTdHJpbmcgbV9zdHlsZVNoZWV0SWQ7Ci0gICAgdW5zaWduZWQgbV9vcmRpbmFsOwor ICAgIHVuc2lnbmVkIG1fb3JkaW5hbCA9IHswfTsKIH07CiAKIHN0cnVjdCBJbnNwZWN0b3JTdHls ZVByb3BlcnR5IHsK