140237 2015-01-07 19:32:01 -0800 Web Inspector: Do not create rulesMap entries for rules without identifiers 2015-01-07 20:37:22 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1059687 0 joepeck 2015-01-07 19:32:01 -0800 * SUMMARY We are accidentally creating rulesMap entries for rules without identifiers. This was causing a bogus entry in the rulesMap which could cause problems later on. We started with a null mapKey, which accidentally turns into a string with: > mapKey += ":" + occurrence; 1059688 1 webkit-bug-importer 2015-01-07 19:32:25 -0800 <rdar://problem/19408185> 1059693 2 244236 joepeck 2015-01-07 19:47:25 -0800 Created attachment 244236 [PATCH] Proposed Fix 1059706 3 244236 commit-queue 2015-01-07 20:37:19 -0800 Comment on attachment 244236 [PATCH] Proposed Fix Clearing flags on attachment: 244236 Committed r178096: <http://trac.webkit.org/changeset/178096> 1059707 4 commit-queue 2015-01-07 20:37:22 -0800 All reviewed patches have been landed. Closing bug. 244236 2015-01-07 19:47:25 -0800 2015-01-07 20:37:19 -0800 [PATCH] Proposed Fix mapKey.patch text/plain 1678 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJkYTVkNDcuLjZiYTdjYjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAxLTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90 IGNyZWF0ZSBydWxlc01hcCBlbnRyaWVzIGZvciBydWxlcyB3aXRob3V0IGlkZW50aWZpZXJzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAyMzcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9N Tm9kZVN0eWxlcy5wcm90b3R5cGUuX3BhcnNlUnVsZVBheWxvYWQpOgorICAgICAgICBXZSB3ZXJl IGFjY2lkZW50YWxseSBjb252ZXJ0aW5nIGEgbnVsbCBpbnRvIGEgc3RyaW5nIHdpdGggYSBsb29z ZSBzdHJpbmcKKyAgICAgICAgY29uY2F0ZW5hdGlvbi4gT25seSBkbyB0aGlzIGlmIHRoZSBtYXBL ZXkgaXMgbm90LW51bGwuCisKIDIwMTUtMDEtMDcgIFNhYW0gQmFyYXRpICA8c2FhbWJhcmF0aTFA Z21haWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFic3RyYWN0IGNvbW1vbiBmdW5j dGlvbnMgZnJvbSBUeXBlVG9rZW5Bbm5vdGF0b3IgaW50byBhIHBhcmVudCBjbGFzcyBhbmQgaW50 cm9kdWNlIGFuIEFubm90YXRvck1hbmFnZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlU3R5bGVzLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanMKaW5kZXggZTNj NzY5Ni4uYzc2NTY1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanMKQEAgLTc5MSwxMCArNzkxLDEw IEBAIFdlYkluc3BlY3Rvci5ET01Ob2RlU3R5bGVzLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg ICAgICBvY2N1cnJlbmNlID0gKytydWxlT2NjdXJyZW5jZXNbbWFwS2V5XTsKICAgICAgICAgICAg IGVsc2UKICAgICAgICAgICAgICAgICBydWxlT2NjdXJyZW5jZXNbbWFwS2V5XSA9IG9jY3VycmVu Y2U7Ci0gICAgICAgIH0KIAotICAgICAgICAvLyBBcHBlbmQgdGhlIG9jY3VycmVuY2UgbnVtYmVy IHRvIHRoZSBtYXAga2V5IGZvciBsb29rdXAgaW4gdGhlIHJ1bGVzIG1hcC4KLSAgICAgICAgbWFw S2V5ICs9ICI6IiArIG9jY3VycmVuY2U7CisgICAgICAgICAgICAvLyBBcHBlbmQgdGhlIG9jY3Vy cmVuY2UgbnVtYmVyIHRvIHRoZSBtYXAga2V5IGZvciBsb29rdXAgaW4gdGhlIHJ1bGVzIG1hcC4K KyAgICAgICAgICAgIG1hcEtleSArPSAiOiIgKyBvY2N1cnJlbmNlOworICAgICAgICB9CiAKICAg ICAgICAgdmFyIHJ1bGUgPSBudWxsOwogCg==