140228 2015-01-07 16:38:44 -0800 Web Inspector: Remove unnecessary copyRef for paramsObject in generated dispatchers 2015-01-07 17:49:10 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1059635 0 joepeck 2015-01-07 16:38:44 -0800 * SUMMARY Remove unnecessary copyRef for paramsObject in generated dispatchers. The object is not used after, so it can be moved. 1059636 1 webkit-bug-importer 2015-01-07 16:39:02 -0800 <rdar://problem/19406466> 1059637 2 244222 joepeck 2015-01-07 16:39:31 -0800 Created attachment 244222 [PATCH] Proposed Fix 1059639 3 commit-queue 2015-01-07 16:42:29 -0800 This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) 1059665 4 244222 commit-queue 2015-01-07 17:49:07 -0800 Comment on attachment 244222 [PATCH] Proposed Fix Clearing flags on attachment: 244222 Committed r178074: <http://trac.webkit.org/changeset/178074> 1059666 5 commit-queue 2015-01-07 17:49:10 -0800 All reviewed patches have been landed. Closing bug. 244222 2015-01-07 16:39:31 -0800 2015-01-07 17:49:07 -0800 [PATCH] Proposed Fix move.patch text/plain 7262 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDU2MmI3NTcuLjIzNDIwOTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAxLTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHVubmVjZXNzYXJ5IGNvcHlSZWYgZm9yIHBhcmFtc09iamVjdCBpbiBnZW5lcmF0ZWQgZGlzcGF0 Y2hlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MDIyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL3NjcmlwdHMvY29kZWdlbi9nZW5lcmF0ZV9jcHBfZnJvbnRlbmRfZGlzcGF0Y2hl cl9pbXBsZW1lbnRhdGlvbi5weToKKyAgICAgICAgKENwcEZyb250ZW5kRGlzcGF0Y2hlckltcGxl bWVudGF0aW9uR2VuZXJhdG9yLl9nZW5lcmF0ZV9kaXNwYXRjaGVyX2ltcGxlbWVudGF0aW9uX2Zv cl9ldmVudCk6CisgICAgICAgICogaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdlbi9nZW5lcmF0ZV9v YmpjX2Zyb250ZW5kX2Rpc3BhdGNoZXJfaW1wbGVtZW50YXRpb24ucHk6CisgICAgICAgIChPYmpD RnJvbnRlbmREaXNwYXRjaGVySW1wbGVtZW50YXRpb25HZW5lcmF0b3IuX2dlbmVyYXRlX2V2ZW50 X291dF9wYXJhbWV0ZXJzKToKKyAgICAgICAgKiBpbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9leHBl Y3RlZC9lbnVtLXZhbHVlcy5qc29uLXJlc3VsdDoKKyAgICAgICAgKiBpbnNwZWN0b3Ivc2NyaXB0 cy90ZXN0cy9leHBlY3RlZC9ldmVudHMtd2l0aC1vcHRpb25hbC1wYXJhbWV0ZXJzLmpzb24tcmVz dWx0OgorCiAyMDE1LTAxLTA3ICBCcmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVk dT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBwdXJnZSBQYXNzUmVmUHRyIGZyb20gSW5zcGVj dG9yIGNvZGUgYW5kIHVzZSBSZWYgZm9yIHR5cGVkIGFuZCB1bnR5cGVkIHByb3RvY29sIG9iamVj dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9j b2RlZ2VuL2dlbmVyYXRlX2NwcF9mcm9udGVuZF9kaXNwYXRjaGVyX2ltcGxlbWVudGF0aW9uLnB5 IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vZ2VuZXJh dGVfY3BwX2Zyb250ZW5kX2Rpc3BhdGNoZXJfaW1wbGVtZW50YXRpb24ucHkKaW5kZXggODhmNThm NC4uYmRiOGRiYyAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9z Y3JpcHRzL2NvZGVnZW4vZ2VuZXJhdGVfY3BwX2Zyb250ZW5kX2Rpc3BhdGNoZXJfaW1wbGVtZW50 YXRpb24ucHkKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2Nv ZGVnZW4vZ2VuZXJhdGVfY3BwX2Zyb250ZW5kX2Rpc3BhdGNoZXJfaW1wbGVtZW50YXRpb24ucHkK QEAgLTExMyw3ICsxMTMsNyBAQCBjbGFzcyBDcHBGcm9udGVuZERpc3BhdGNoZXJJbXBsZW1lbnRh dGlvbkdlbmVyYXRvcihHZW5lcmF0b3IpOgogICAgICAgICBpZiBsZW4ocGFyYW1ldGVyX2Fzc2ln bm1lbnRzKSA+IDA6CiAgICAgICAgICAgICBsaW5lcy5hcHBlbmQoJyAgICBSZWY8SW5zcGVjdG9y T2JqZWN0PiBwYXJhbXNPYmplY3QgPSBJbnNwZWN0b3JPYmplY3Q6OmNyZWF0ZSgpOycpCiAgICAg ICAgICAgICBsaW5lcy5leHRlbmQocGFyYW1ldGVyX2Fzc2lnbm1lbnRzKQotICAgICAgICAgICAg bGluZXMuYXBwZW5kKCcgICAganNvbk1lc3NhZ2UtPnNldE9iamVjdChBU0NJSUxpdGVyYWwoInBh cmFtcyIpLCBwYXJhbXNPYmplY3QuY29weVJlZigpKTsnKQorICAgICAgICAgICAgbGluZXMuYXBw ZW5kKCcgICAganNvbk1lc3NhZ2UtPnNldE9iamVjdChBU0NJSUxpdGVyYWwoInBhcmFtcyIpLCBX VEY6Om1vdmUocGFyYW1zT2JqZWN0KSk7JykKIAogICAgICAgICBsaW5lcy5hcHBlbmQoJycpCiAg ICAgICAgIGxpbmVzLmFwcGVuZCgnICAgIG1faW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsLT5zZW5k TWVzc2FnZVRvRnJvbnRlbmQoanNvbk1lc3NhZ2UtPnRvSlNPTlN0cmluZygpKTsnKQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vZ2Vu ZXJhdGVfb2JqY19mcm9udGVuZF9kaXNwYXRjaGVyX2ltcGxlbWVudGF0aW9uLnB5IGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vZ2VuZXJhdGVfb2JqY19m cm9udGVuZF9kaXNwYXRjaGVyX2ltcGxlbWVudGF0aW9uLnB5CmluZGV4IDczMTM2MDYuLmUwZGRh MWQgMTAwNzU1Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9j b2RlZ2VuL2dlbmVyYXRlX29iamNfZnJvbnRlbmRfZGlzcGF0Y2hlcl9pbXBsZW1lbnRhdGlvbi5w eQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdlbi9n ZW5lcmF0ZV9vYmpjX2Zyb250ZW5kX2Rpc3BhdGNoZXJfaW1wbGVtZW50YXRpb24ucHkKQEAgLTE0 Nyw1ICsxNDcsNSBAQCBjbGFzcyBPYmpDRnJvbnRlbmREaXNwYXRjaGVySW1wbGVtZW50YXRpb25H ZW5lcmF0b3IoR2VuZXJhdG9yKToKICAgICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAgICAg bGluZXMuYXBwZW5kKCcgICAgaWYgKCVzKScgJSAocGFyYW1ldGVyLnBhcmFtZXRlcl9uYW1lKSkK ICAgICAgICAgICAgICAgICBsaW5lcy5hcHBlbmQoJyAgICAgICAgcGFyYW1zT2JqZWN0LT4lcyhB U0NJSUxpdGVyYWwoIiVzIiksICVzKTsnICUgKGtleWVkX3NldF9tZXRob2QsIHBhcmFtZXRlci5w YXJhbWV0ZXJfbmFtZSwgZXhwb3J0X2V4cHJlc3Npb24pKQotICAgICAgICBsaW5lcy5hcHBlbmQo JyAgICBqc29uTWVzc2FnZS0+c2V0T2JqZWN0KEFTQ0lJTGl0ZXJhbCgicGFyYW1zIiksIHBhcmFt c09iamVjdC5jb3B5UmVmKCkpOycpCisgICAgICAgIGxpbmVzLmFwcGVuZCgnICAgIGpzb25NZXNz YWdlLT5zZXRPYmplY3QoQVNDSUlMaXRlcmFsKCJwYXJhbXMiKSwgV1RGOjptb3ZlKHBhcmFtc09i amVjdCkpOycpCiAgICAgICAgIHJldHVybiBsaW5lcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4cGVjdGVkL2VudW0tdmFsdWVzLmpz b24tcmVzdWx0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL3Rlc3Rz L2V4cGVjdGVkL2VudW0tdmFsdWVzLmpzb24tcmVzdWx0CmluZGV4IGZhZTkxODYuLmE5NzJiNTMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90ZXN0 cy9leHBlY3RlZC9lbnVtLXZhbHVlcy5qc29uLXJlc3VsdAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZW51bS12YWx1ZXMuanNvbi1y ZXN1bHQKQEAgLTQwMyw3ICs0MDMsNyBAQCB2b2lkIEluc3BlY3RvckV2ZW50RG9tYWluRnJvbnRl bmREaXNwYXRjaGVyOjpldmVudFdpdGhFbnVtUGFyYW1ldGVyKFBhcmFtZXRlciBwYQogICAgIGpz b25NZXNzYWdlLT5zZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJtZXRob2QiKSwgQVNDSUlMaXRlcmFs KCJFdmVudERvbWFpbi5ldmVudFdpdGhFbnVtUGFyYW1ldGVyIikpOwogICAgIFJlZjxJbnNwZWN0 b3JPYmplY3Q+IHBhcmFtc09iamVjdCA9IEluc3BlY3Rvck9iamVjdDo6Y3JlYXRlKCk7CiAgICAg cGFyYW1zT2JqZWN0LT5zZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJwYXJhbWV0ZXIiKSwgSW5zcGVj dG9yOjpQcm90b2NvbDo6Z2V0RW51bUNvbnN0YW50VmFsdWUocGFyYW1ldGVyKSk7Ci0gICAganNv bk1lc3NhZ2UtPnNldE9iamVjdChBU0NJSUxpdGVyYWwoInBhcmFtcyIpLCBwYXJhbXNPYmplY3Qu Y29weVJlZigpKTsKKyAgICBqc29uTWVzc2FnZS0+c2V0T2JqZWN0KEFTQ0lJTGl0ZXJhbCgicGFy YW1zIiksIFdURjo6bW92ZShwYXJhbXNPYmplY3QpKTsKIAogICAgIG1faW5zcGVjdG9yRnJvbnRl bmRDaGFubmVsLT5zZW5kTWVzc2FnZVRvRnJvbnRlbmQoanNvbk1lc3NhZ2UtPnRvSlNPTlN0cmlu ZygpKTsKIH0KQEAgLTEwMjIsNyArMTAyMiw3IEBAIHVzaW5nIG5hbWVzcGFjZSBJbnNwZWN0b3I7 CiAgICAganNvbk1lc3NhZ2UtPnNldFN0cmluZyhBU0NJSUxpdGVyYWwoIm1ldGhvZCIpLCBBU0NJ SUxpdGVyYWwoIkV2ZW50RG9tYWluLmV2ZW50V2l0aEVudW1QYXJhbWV0ZXIiKSk7CiAgICAgUmVm PEluc3BlY3Rvck9iamVjdD4gcGFyYW1zT2JqZWN0ID0gSW5zcGVjdG9yT2JqZWN0OjpjcmVhdGUo KTsKICAgICBwYXJhbXNPYmplY3QtPnNldFN0cmluZyhBU0NJSUxpdGVyYWwoInBhcmFtZXRlciIp LCB0b1Byb3RvY29sU3RyaW5nKHBhcmFtZXRlcikpOwotICAgIGpzb25NZXNzYWdlLT5zZXRPYmpl Y3QoQVNDSUlMaXRlcmFsKCJwYXJhbXMiKSwgcGFyYW1zT2JqZWN0LmNvcHlSZWYoKSk7CisgICAg anNvbk1lc3NhZ2UtPnNldE9iamVjdChBU0NJSUxpdGVyYWwoInBhcmFtcyIpLCBXVEY6Om1vdmUo cGFyYW1zT2JqZWN0KSk7CiAgICAgZnJvbnRlbmRDaGFubmVsLT5zZW5kTWVzc2FnZVRvRnJvbnRl bmQoanNvbk1lc3NhZ2UtPnRvSlNPTlN0cmluZygpKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4cGVjdGVkL2V2ZW50cy13 aXRoLW9wdGlvbmFsLXBhcmFtZXRlcnMuanNvbi1yZXN1bHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZXZlbnRzLXdpdGgtb3B0aW9uYWwt cGFyYW1ldGVycy5qc29uLXJlc3VsdAppbmRleCA2ODZiMmI0Li4xNjBiOTE3IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQv ZXZlbnRzLXdpdGgtb3B0aW9uYWwtcGFyYW1ldGVycy5qc29uLXJlc3VsdAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZXZlbnRzLXdp dGgtb3B0aW9uYWwtcGFyYW1ldGVycy5qc29uLXJlc3VsdApAQCAtMzI0LDcgKzMyNCw3IEBAIHZv aWQgSW5zcGVjdG9yRGF0YWJhc2VGcm9udGVuZERpc3BhdGNoZXI6OmRpZEV4ZWN1dGVPcHRpb25h bFBhcmFtZXRlcnMoUmVmUHRyPEluCiAgICAgICAgIHBhcmFtc09iamVjdC0+c2V0U3RyaW5nKEFT Q0lJTGl0ZXJhbCgic2NyZWVuQ29sb3IiKSwgKnNjcmVlbkNvbG9yKTsKICAgICBpZiAocHJpbnRD b2xvcikKICAgICAgICAgcGFyYW1zT2JqZWN0LT5zZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJwcmlu dENvbG9yIiksICpwcmludENvbG9yKTsKLSAgICBqc29uTWVzc2FnZS0+c2V0T2JqZWN0KEFTQ0lJ TGl0ZXJhbCgicGFyYW1zIiksIHBhcmFtc09iamVjdC5jb3B5UmVmKCkpOworICAgIGpzb25NZXNz YWdlLT5zZXRPYmplY3QoQVNDSUlMaXRlcmFsKCJwYXJhbXMiKSwgV1RGOjptb3ZlKHBhcmFtc09i amVjdCkpOwogCiAgICAgbV9pbnNwZWN0b3JGcm9udGVuZENoYW5uZWwtPnNlbmRNZXNzYWdlVG9G cm9udGVuZChqc29uTWVzc2FnZS0+dG9KU09OU3RyaW5nKCkpOwogfQpAQCAtMzQyLDcgKzM0Miw3 IEBAIHZvaWQgSW5zcGVjdG9yRGF0YWJhc2VGcm9udGVuZERpc3BhdGNoZXI6OmRpZEV4ZWN1dGVO b09wdGlvbmFsUGFyYW1ldGVycyhSZWZQdHI8CiAgICAgcGFyYW1zT2JqZWN0LT5zZXRPYmplY3Qo QVNDSUlMaXRlcmFsKCJzcWxFcnJvciIpLCBzcWxFcnJvcik7CiAgICAgcGFyYW1zT2JqZWN0LT5z ZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJzY3JlZW5Db2xvciIpLCBzY3JlZW5Db2xvcik7CiAgICAg cGFyYW1zT2JqZWN0LT5zZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJwcmludENvbG9yIiksIHByaW50 Q29sb3IpOwotICAgIGpzb25NZXNzYWdlLT5zZXRPYmplY3QoQVNDSUlMaXRlcmFsKCJwYXJhbXMi KSwgcGFyYW1zT2JqZWN0LmNvcHlSZWYoKSk7CisgICAganNvbk1lc3NhZ2UtPnNldE9iamVjdChB U0NJSUxpdGVyYWwoInBhcmFtcyIpLCBXVEY6Om1vdmUocGFyYW1zT2JqZWN0KSk7CiAKICAgICBt X2luc3BlY3RvckZyb250ZW5kQ2hhbm5lbC0+c2VuZE1lc3NhZ2VUb0Zyb250ZW5kKGpzb25NZXNz YWdlLT50b0pTT05TdHJpbmcoKSk7CiB9CkBAIC05MDEsNyArOTAxLDcgQEAgdXNpbmcgbmFtZXNw YWNlIEluc3BlY3RvcjsKICAgICAgICAgcGFyYW1zT2JqZWN0LT5zZXRTdHJpbmcoQVNDSUlMaXRl cmFsKCJzY3JlZW5Db2xvciIpLCAoKnNjcmVlbkNvbG9yKSk7CiAgICAgaWYgKHByaW50Q29sb3Ip CiAgICAgICAgIHBhcmFtc09iamVjdC0+c2V0U3RyaW5nKEFTQ0lJTGl0ZXJhbCgicHJpbnRDb2xv ciIpLCAoKnByaW50Q29sb3IpKTsKLSAgICBqc29uTWVzc2FnZS0+c2V0T2JqZWN0KEFTQ0lJTGl0 ZXJhbCgicGFyYW1zIiksIHBhcmFtc09iamVjdC5jb3B5UmVmKCkpOworICAgIGpzb25NZXNzYWdl LT5zZXRPYmplY3QoQVNDSUlMaXRlcmFsKCJwYXJhbXMiKSwgV1RGOjptb3ZlKHBhcmFtc09iamVj dCkpOwogICAgIGZyb250ZW5kQ2hhbm5lbC0+c2VuZE1lc3NhZ2VUb0Zyb250ZW5kKGpzb25NZXNz YWdlLT50b0pTT05TdHJpbmcoKSk7CiB9CiAKQEAgLTkzMCw3ICs5MzAsNyBAQCB1c2luZyBuYW1l c3BhY2UgSW5zcGVjdG9yOwogICAgIHBhcmFtc09iamVjdC0+c2V0T2JqZWN0KEFTQ0lJTGl0ZXJh bCgic3FsRXJyb3IiKSwgW3NxbEVycm9yIHRvSW5zcGVjdG9yT2JqZWN0XSk7CiAgICAgcGFyYW1z T2JqZWN0LT5zZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJzY3JlZW5Db2xvciIpLCBzY3JlZW5Db2xv cik7CiAgICAgcGFyYW1zT2JqZWN0LT5zZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJwcmludENvbG9y IiksIHByaW50Q29sb3IpOwotICAgIGpzb25NZXNzYWdlLT5zZXRPYmplY3QoQVNDSUlMaXRlcmFs KCJwYXJhbXMiKSwgcGFyYW1zT2JqZWN0LmNvcHlSZWYoKSk7CisgICAganNvbk1lc3NhZ2UtPnNl dE9iamVjdChBU0NJSUxpdGVyYWwoInBhcmFtcyIpLCBXVEY6Om1vdmUocGFyYW1zT2JqZWN0KSk7 CiAgICAgZnJvbnRlbmRDaGFubmVsLT5zZW5kTWVzc2FnZVRvRnJvbnRlbmQoanNvbk1lc3NhZ2Ut PnRvSlNPTlN0cmluZygpKTsKIH0KIAo=