140215 2015-01-07 14:46:08 -0800 Annotate properties that start with "new" so they'll work under ARC 2015-01-07 20:45:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca ggaren oldest_to_newest 1059547 0 andersca 2015-01-07 14:46:08 -0800 Annotate properties that start with "new" so they'll work under ARC 1059549 1 244206 andersca 2015-01-07 14:47:53 -0800 Created attachment 244206 Patch 1059555 2 244206 ggaren 2015-01-07 14:58:17 -0800 Comment on attachment 244206 Patch r=me 1059556 3 ggaren 2015-01-07 14:58:35 -0800 Does this require an update to some bindings test expectations or a new bindings test? 1059559 4 andersca 2015-01-07 14:59:42 -0800 Committed r178057: <http://trac.webkit.org/changeset/178057> 1059713 5 244206 darin 2015-01-07 20:45:56 -0800 Comment on attachment 244206 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244206&action=review > Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm:899 > + my $needsReturnsRetainedAnnotation = $attributeName =~ /new([A-Z].*)?/; http://clang.llvm.org/docs/AutomaticReferenceCounting.html#method-families says that we also need to check for alloc, copy, mutableCopy, and new. And maybe even init. I also was considering whether __attribute__((objc_method_family(none))) might not be better than NS_RETURNS_NOT_RETAINED, but I guess not. Given that documentation, I’m thinking this regular expression should be: /_*(alloc|copy|mutableCopy|new)([^a-z].*)?/ That wouldn’t address the init family, but it would cover the copy cases, which I think could easily happen in practice. 244206 2015-01-07 14:47:53 -0800 2015-01-07 14:58:17 -0800 Patch bug-140215-20150107144758.patch text/plain 2434 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTMwNDYwNTM1OWJkMzMx YTkyNzFmMTVjYWU4NmYyZDcxMDJjNzFhMi4uYTMzMjZiYTEzNWQ0NzU3ZjBiOTA4Y2QzZWE3NDlk NDExZDhkNDA1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAxLTA3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgQW5ub3RhdGUgcHJv cGVydGllcyB0aGF0IHN0YXJ0IHdpdGggIm5ldyIgc28gdGhleSdsbCB3b3JrIHVuZGVyIEFSQwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMjE1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBlbmNv dW50ZXJpbmcgYXR0cmlidXRlcyB0aGF0IHN0YXJ0IHdpdGggIm5ldyIsIGFsc28gZ2VuZXJhdGUg YW4gYWRkaXRpb25hbCBnZXR0ZXIgbWV0aG9kIGRlY2xhcmF0aW9uIHRoYXQKKyAgICAgICAgaGFz IGFuIE5TX1JFVFVSTlNfTk9UX1JFVEFJTkVEIGFubm90YXRpb24gc28gQVJDIHdpbGwga25vdyBu b3QgdG8gb3ZlcnJlbGVhc2UgdGhlIHByb3BlcnR5IHZhbHVlLgorCisgICAgICAgICogYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbToKKyAgICAgICAgKEdlbmVyYXRlSGVhZGVy KToKKwogMjAxNS0wMS0wNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04gKHIxNzgwMjgpOiBpT1MgYnVpbGQgYnJva2VuIGR1ZSB0byB1bnVz ZWQgcGFyYW1ldGVycyBpbiBHbHlwaFBhZ2U6Om1heVVzZU1peGVkRm9udERhdGFXaGVuRmlsbGlu ZygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JPYmpDLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yT2JqQy5wbQppbmRleCBhYWZlMGJhM2UyY2E5OWIyNTFiMTNkMDdmNDM1ZmUzZWM1MGY1MWUw Li43MDQzNDNiN2E3ZWZmN2RiNGJhYmUwNTNjZTA0YmMxNjE2MGY0N2M2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBtCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0KQEAg LTg5NSw5ICs4OTUsMTkgQEAgc3ViIEdlbmVyYXRlSGVhZGVyCiAgICAgICAgICAgICB9CiAKICAg ICAgICAgICAgIGlmICghSXNDb3JlRm91bmRhdGlvblR5cGUoJGF0dHJpYnV0ZVR5cGUpKSB7Cisg ICAgICAgICAgICAgICAgIyBGSVhNRTogV2Ugc2hvdWxkIHByb2JhYmx5IGFsc28gY2hlY2sgdGhh dCB0aGUgcHJvcGVydHkgdHlwZSBpcyBhbiBPYmplY3RpdmUtQyB0eXBlLgorICAgICAgICAgICAg ICAgIG15ICRuZWVkc1JldHVybnNSZXRhaW5lZEFubm90YXRpb24gPSAkYXR0cmlidXRlTmFtZSA9 fiAvbmV3KFtBLVpdLiopPy87CisKICAgICAgICAgICAgICAgICAkcHJvcGVydHkgLj0gJGRlY2xh cmF0aW9uU3VmZml4OwogICAgICAgICAgICAgICAgIHB1c2goQGhlYWRlckF0dHJpYnV0ZXMsICRw cm9wZXJ0eSkgaWYgJHB1YmxpYzsKICAgICAgICAgICAgICAgICBwdXNoKEBwcml2YXRlSGVhZGVy QXR0cmlidXRlcywgJHByb3BlcnR5KSB1bmxlc3MgJHB1YmxpYzsKKyAgICAgICAgICAgICAgICBp ZiAoJG5lZWRzUmV0dXJuc1JldGFpbmVkQW5ub3RhdGlvbikgeworICAgICAgICAgICAgICAgICAg ICAjIC0gR0VUVEVSCisgICAgICAgICAgICAgICAgICAgIG15ICRnZXR0ZXIgPSAiLSAoIiAuICRh dHRyaWJ1dGVUeXBlIC4gIikiIC4gJGF0dHJpYnV0ZU5hbWUgLiAiIE5TX1JFVFVSTlNfTk9UX1JF VEFJTkVEIiAuICRkZWNsYXJhdGlvblN1ZmZpeDsKKyAgICAgICAgICAgICAgICAgICAgcHVzaChA aGVhZGVyQXR0cmlidXRlcywgJGdldHRlcikgaWYgJHB1YmxpYzsKKyAgICAgICAgICAgICAgICAg ICAgcHVzaChAcHJpdmF0ZUhlYWRlckF0dHJpYnV0ZXMsICRnZXR0ZXIpIHVubGVzcyAkcHVibGlj OworICAgICAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgfSBlbHNpZiAoQ29uZGl0aW9uYWxJ c0VuYWJsZWQoJWRlZmluZXNSZWYsICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRy aWJ1dGVzLT57IkNvbmRpdGlvbmFsIn0pKSB7CiAgICAgICAgICAgICAgICAgIyAtIEdFVFRFUgog ICAgICAgICAgICAgICAgIG15ICRnZXR0ZXIgPSAiLSAoIiAuICRhdHRyaWJ1dGVUeXBlIC4gIiki IC4gJGF0dHJpYnV0ZU5hbWUgLiAkZGVjbGFyYXRpb25TdWZmaXg7Cg==