140206 2015-01-07 14:06:20 -0800 Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the link 2015-01-07 14:48:40 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue eric.carlson glenn jer.noble philipj sergio thorton oldest_to_newest 1059524 0 bdakin 2015-01-07 14:06:20 -0800 Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the link rdar://problem/19300492 1059538 1 244203 bdakin 2015-01-07 14:29:42 -0800 Created attachment 244203 Patch 1059550 2 bdakin 2015-01-07 14:48:40 -0800 Thanks! http://trac.webkit.org/changeset/178056 244203 2015-01-07 14:29:42 -0800 2015-01-07 14:45:34 -0800 Patch for-review.txt text/plain 6797 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODA1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAxLTA3ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBZG9wdCBkZWxlZ2F0ZSBjYWxsYmFj a3Mgc28gdGhhdCBzdGFuZGFyZFF1aWNrTG9va01lbnVJdGVtIGRvZXMgbm90IG9ic2N1cmUgdGhl IAorICAgICAgICBsaW5rCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDAyMDYKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFy Oi8vcHJvYmxlbS8xOTMwMDQ5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1vcmUgZGVsZWdhdGUgbWV0aG9kcy4KKyAgICAgICAgKiBwbGF0Zm9ybS9z cGkvbWFjL1F1aWNrTG9va01hY1NQSS5oOgorCiAyMDE1LTAxLTA2ICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW9kZXJuaXplIHRoZSBTVkdFbGVtZW50IGFuZCBNYXRo TUxFbGVtZW50IGZhY3RvcmllcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL21h Yy9RdWlja0xvb2tNYWNTUEkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9zcGkvbWFjL1F1aWNrTG9va01hY1NQSS5oCShyZXZpc2lvbiAxNzgwNTApCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9zcGkvbWFjL1F1aWNrTG9va01hY1NQSS5oCSh3b3JraW5nIGNvcHkp CkBAIC0zMiw2ICszMiw4IEBACiAtIChpZDxRTFByZXZpZXdJdGVtPiltZW51SXRlbTooTlNNZW51 SXRlbSAqKW1lbnVJdGVtIHByZXZpZXdJdGVtQXRQb2ludDooTlNQb2ludClwb2ludDsKIC0gKE5T UmVjdEVkZ2UpbWVudUl0ZW06KE5TTWVudUl0ZW0gKiltZW51SXRlbSBwcmVmZXJyZWRFZGdlRm9y UG9pbnQ6KE5TUG9pbnQpcG9pbnQ7CiAtICh2b2lkKW1lbnVJdGVtRGlkQ2xvc2U6KE5TTWVudUl0 ZW0gKiltZW51SXRlbTsKKy0gKE5TUmVjdCltZW51SXRlbTooTlNNZW51SXRlbSAqKW1lbnVJdGVt IGl0ZW1GcmFtZUZvclBvaW50OihOU1BvaW50KXBvaW50OworLSAoTlNTaXplKW1lbnVJdGVtOihO U01lbnVJdGVtICopbWVudUl0ZW0gbWF4U2l6ZUZvclBvaW50OihOU1BvaW50KXBvaW50OwogCiBA ZW5kCiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODA1MykKKysrIFNvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAxLTA3ICBC ZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBZG9wdCBkZWxlZ2F0ZSBj YWxsYmFja3Mgc28gdGhhdCBzdGFuZGFyZFF1aWNrTG9va01lbnVJdGVtIGRvZXMgbm90IG9ic2N1 cmUgdGhlIAorICAgICAgICBsaW5rCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDAyMDYKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAg ICByZGFyOi8vcHJvYmxlbS8xOTMwMDQ5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFByb3ZpZGluZyBhbmQgaXRlbSBmcmFtZSB3aWxsIGVuc3VyZSB0 aGF0IHRoZSBvcmlnaW5hbCBsaW5rIGlzIG5vdCBvYnNjdXJlZC4KKyAgICAgICAgKiBVSVByb2Nl c3MvbWFjL1dLSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tJbW1l ZGlhdGVBY3Rpb25Db250cm9sbGVyIG1lbnVJdGVtOml0ZW1GcmFtZUZvclBvaW50Ol0pOgorCisg ICAgICAgIEZvciBub3cgdXNlIGEgbWF4IHNpemUgdGhhdCBpcyBzbWFsbGVyIHRoYW4gdGhlIFdL Vmlldywgd2l0aCB0aGUgc2NyZWVu4oCZcyBhc3BlY3QgCisgICAgICAgIHJhdGlvLCBhbmQgc2Nh bGVkIGRvd24uCisgICAgICAgICgtW1dLSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlciBtZW51SXRl bTptYXhTaXplRm9yUG9pbnQ6XSk6CisKIDIwMTUtMDEtMDcgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVsZWFzZSBidWlsZCBmaXguCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLSW1tZWRpYXRlQWN0 aW9uQ29udHJvbGxlci5tbQkocmV2aXNpb24gMTc4MDUwKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29weSkK QEAgLTM1LDYgKzM1LDcgQEAKICNpbXBvcnQgIldlYlBhZ2VQcm94eU1lc3NhZ2VzLmgiCiAjaW1w b3J0ICJXZWJQcm9jZXNzUHJveHkuaCIKICNpbXBvcnQgPFdlYkNvcmUvRGF0YURldGVjdG9yc1NQ SS5oPgorI2ltcG9ydCA8V2ViQ29yZS9HZW9tZXRyeVV0aWxpdGllcy5oPgogI2ltcG9ydCA8V2Vi Q29yZS9Mb29rdXBTUEkuaD4KICNpbXBvcnQgPFdlYkNvcmUvTlNNZW51U1BJLmg+CiAjaW1wb3J0 IDxXZWJDb3JlL05TUG9wb3ZlclNQSS5oPgpAQCAtMjg3LDYgKzI4OCwyNSBAQCAtICh2b2lkKW1l bnVJdGVtRGlkQ2xvc2U6KE5TTWVudUl0ZW0gKiltCiAgICAgW3NlbGYgX2NsZWFySW1tZWRpYXRl QWN0aW9uU3RhdGVdOwogfQogCistIChOU1JlY3QpbWVudUl0ZW06KE5TTWVudUl0ZW0gKiltZW51 SXRlbSBpdGVtRnJhbWVGb3JQb2ludDooTlNQb2ludClwb2ludAoreworICAgIGlmICghX3drVmll dykKKyAgICAgICAgcmV0dXJuIE5TWmVyb1JlY3Q7CisKKyAgICBSZWZQdHI8V2ViSGl0VGVzdFJl c3VsdD4gaGl0VGVzdFJlc3VsdCA9IFtzZWxmIF93ZWJIaXRUZXN0UmVzdWx0XTsKKyAgICByZXR1 cm4gW193a1ZpZXcgY29udmVydFJlY3Q6aGl0VGVzdFJlc3VsdC0+ZWxlbWVudEJvdW5kaW5nQm94 KCkgdG9WaWV3Om5pbF07Cit9CisKKy0gKE5TU2l6ZSltZW51SXRlbTooTlNNZW51SXRlbSAqKW1l bnVJdGVtIG1heFNpemVGb3JQb2ludDooTlNQb2ludClwb2ludAoreworICAgIGlmICghX3drVmll dykKKyAgICAgICAgcmV0dXJuIE5TWmVyb1NpemU7CisKKyAgICBOU1NpemUgc2NyZWVuU2l6ZSA9 IF93a1ZpZXcud2luZG93LnNjcmVlbi5mcmFtZS5zaXplOworICAgIEZsb2F0UmVjdCBsYXJnZXN0 UmVjdCA9IGxhcmdlc3RSZWN0V2l0aEFzcGVjdFJhdGlvSW5zaWRlUmVjdChzY3JlZW5TaXplLndp ZHRoIC8gc2NyZWVuU2l6ZS5oZWlnaHQsIF93a1ZpZXcuYm91bmRzKTsKKyAgICByZXR1cm4gTlNN YWtlU2l6ZShsYXJnZXN0UmVjdC53aWR0aCgpICogMC43NSwgbGFyZ2VzdFJlY3QuaGVpZ2h0KCkg KiAwLjc1KTsKK30KKwogI3ByYWdtYSBtYXJrIERhdGEgRGV0ZWN0b3JzIGFjdGlvbnMKIAogLSAo TlNNZW51SXRlbSAqKV9tZW51SXRlbUZvckRhdGFEZXRlY3RlZFRleHQKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9DaGFu Z2VMb2cJKHJldmlzaW9uIDE3ODA1MykKKysrIFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTAxLTA3ICBCZXRoIERha2luICA8 YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBZG9wdCBkZWxlZ2F0ZSBjYWxsYmFja3Mgc28g dGhhdCBzdGFuZGFyZFF1aWNrTG9va01lbnVJdGVtIGRvZXMgbm90IG9ic2N1cmUgdGhlIAorICAg ICAgICBsaW5rCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDAyMDYKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJv YmxlbS8xOTMwMDQ5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFByb3ZpZGluZyBhbmQgaXRlbSBmcmFtZSB3aWxsIGVuc3VyZSB0aGF0IHRoZSBvcmln aW5hbCBsaW5rIGlzIG5vdCBvYnNjdXJlZC4KKyAgICAgICAgKiBXZWJWaWV3L1dlYkltbWVkaWF0 ZUFjdGlvbkNvbnRyb2xsZXIubW06CisgICAgICAgIChlbGVtZW50Qm91bmRpbmdCb3hJbldpbmRv d0Nvb3JkaW5hdGVzRnJvbU5vZGUpOgorICAgICAgICAoLVtXZWJJbW1lZGlhdGVBY3Rpb25Db250 cm9sbGVyIG1lbnVJdGVtOml0ZW1GcmFtZUZvclBvaW50Ol0pOgorCisgICAgICAgIEZvciBub3cg dXNlIGEgbWF4IHNpemUgdGhhdCBpcyBzbWFsbGVyIHRoYW4gdGhlIFdlYlZpZXcsIHdpdGggdGhl IHNjcmVlbuKAmXMgYXNwZWN0IAorICAgICAgICByYXRpbywgYW5kIHNjYWxlZCBkb3duLgorICAg ICAgICAoLVtXZWJJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyIG1lbnVJdGVtOm1heFNpemVGb3JQ b2ludDpdKToKKwogMjAxNS0wMS0wNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIEdpdmUgc2ltcGxlIEhUTUwgZG9jdW1lbnRzIGEgZGF0YWJhc2UgcHJv dmlkZXIKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSW1tZWRpYXRlQWN0aW9u Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dl YkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE3ODA1MCkKKysrIFNvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbQkod29y a2luZyBjb3B5KQpAQCAtNDQsNiArNDQsNyBAQAogI2ltcG9ydCA8V2ViQ29yZS9Gb2N1c0NvbnRy b2xsZXIuaD4KICNpbXBvcnQgPFdlYkNvcmUvRnJhbWUuaD4KICNpbXBvcnQgPFdlYkNvcmUvRnJh bWVWaWV3Lmg+CisjaW1wb3J0IDxXZWJDb3JlL0dlb21ldHJ5VXRpbGl0aWVzLmg+CiAjaW1wb3J0 IDxXZWJDb3JlL0hUTUxDb252ZXJ0ZXIuaD4KICNpbXBvcnQgPFdlYkNvcmUvTG9va3VwU1BJLmg+ CiAjaW1wb3J0IDxXZWJDb3JlL05TTWVudVNQSS5oPgpAQCAtMjYxLDYgKzI2Miw0OCBAQCAtICh2 b2lkKW1lbnVJdGVtRGlkQ2xvc2U6KE5TTWVudUl0ZW0gKiltCiAgICAgW3NlbGYgX2NsZWFySW1t ZWRpYXRlQWN0aW9uU3RhdGVdOwogfQogCitzdGF0aWMgSW50UmVjdCBlbGVtZW50Qm91bmRpbmdC b3hJbldpbmRvd0Nvb3JkaW5hdGVzRnJvbU5vZGUoTm9kZSogbm9kZSkKK3sKKyAgICBpZiAoIW5v ZGUpCisgICAgICAgIHJldHVybiBJbnRSZWN0KCk7CisKKyAgICBGcmFtZSogZnJhbWUgPSBub2Rl LT5kb2N1bWVudCgpLmZyYW1lKCk7CisgICAgaWYgKCFmcmFtZSkKKyAgICAgICAgcmV0dXJuIElu dFJlY3QoKTsKKworICAgIEZyYW1lVmlldyogdmlldyA9IGZyYW1lLT52aWV3KCk7CisgICAgaWYg KCF2aWV3KQorICAgICAgICByZXR1cm4gSW50UmVjdCgpOworCisgICAgUmVuZGVyT2JqZWN0KiBy ZW5kZXJlciA9IG5vZGUtPnJlbmRlcmVyKCk7CisgICAgaWYgKCFyZW5kZXJlcikKKyAgICAgICAg cmV0dXJuIEludFJlY3QoKTsKKworICAgIHJldHVybiB2aWV3LT5jb250ZW50c1RvV2luZG93KHJl bmRlcmVyLT5hYnNvbHV0ZUJvdW5kaW5nQm94UmVjdCgpKTsKK30KKworLSAoTlNSZWN0KW1lbnVJ dGVtOihOU01lbnVJdGVtICopbWVudUl0ZW0gaXRlbUZyYW1lRm9yUG9pbnQ6KE5TUG9pbnQpcG9p bnQKK3sKKyAgICBpZiAoIV93ZWJWaWV3KQorICAgICAgICByZXR1cm4gTlNaZXJvUmVjdDsKKwor ICAgIE5vZGUqIG5vZGUgPSBfaGl0VGVzdFJlc3VsdC5pbm5lck5vZGUoKTsKKyAgICBpZiAoIW5v ZGUpCisgICAgICAgIHJldHVybiBOU1plcm9SZWN0OworCisgICAgcmV0dXJuIGVsZW1lbnRCb3Vu ZGluZ0JveEluV2luZG93Q29vcmRpbmF0ZXNGcm9tTm9kZShub2RlKTsKK30KKworLSAoTlNTaXpl KW1lbnVJdGVtOihOU01lbnVJdGVtICopbWVudUl0ZW0gbWF4U2l6ZUZvclBvaW50OihOU1BvaW50 KXBvaW50Cit7CisgICAgaWYgKCFfd2ViVmlldykKKyAgICAgICAgcmV0dXJuIE5TWmVyb1NpemU7 CisKKyAgICBOU1NpemUgc2NyZWVuU2l6ZSA9IF93ZWJWaWV3LndpbmRvdy5zY3JlZW4uZnJhbWUu c2l6ZTsKKyAgICBGbG9hdFJlY3QgbGFyZ2VzdFJlY3QgPSBsYXJnZXN0UmVjdFdpdGhBc3BlY3RS YXRpb0luc2lkZVJlY3Qoc2NyZWVuU2l6ZS53aWR0aCAvIHNjcmVlblNpemUuaGVpZ2h0LCBfd2Vi Vmlldy5ib3VuZHMpOworICAgIHJldHVybiBOU01ha2VTaXplKGxhcmdlc3RSZWN0LndpZHRoKCkg KiAwLjc1LCBsYXJnZXN0UmVjdC5oZWlnaHQoKSAqIDAuNzUpOworfQorCiAjcHJhZ21hIG1hcmsg RGF0YSBEZXRlY3RvcnMgYWN0aW9ucwogCiAtIChOU01lbnVJdGVtICopX21lbnVJdGVtRm9yRGF0 YURldGVjdGVkVGV4dAo=