140170 2015-01-06 20:22:51 -0800 Make webkit-patch try harder to find keychain credentials 2015-01-07 13:20:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield commit-queue darin dbates glenn rniwa oldest_to_newest 1059308 0 mmaxfield 2015-01-06 20:22:51 -0800 Make webkit-patch try harder to find keychain credentials 1059310 1 244133 mmaxfield 2015-01-06 20:26:21 -0800 Created attachment 244133 Patch 1059323 2 244133 rniwa 2015-01-06 22:05:36 -0800 Comment on attachment 244133 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244133&action=review > Tools/Scripts/webkitpy/common/net/credentials.py:121 > + if parsed_output[0] or parsed_output[1]: Why not any(parsed_output)? 1059493 3 mmaxfield 2015-01-07 13:20:58 -0800 Committed r178049: <http://trac.webkit.org/changeset/178049> 244133 2015-01-06 20:26:21 -0800 2015-01-06 22:05:36 -0800 Patch bug-140170-20150106202625.patch text/plain 4134 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MDE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzY2MDdjNDFjYTYwNDQzNjRhMTllMzVlYTY4NTNjNTQz ZThlODE2ZC4uMTZmODI3NjVjNzRmY2NhNjg1ZDdmNDFhOTEzZDk5YjNiMmM0OWU4ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE1LTAxLTA2ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgTWFrZSB3ZWJraXQtcGF0Y2ggdHJ5IGhhcmRlciB0byBmaW5kIGtleWNoYWlu IGNyZWRlbnRpYWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDAxNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXaGVuIHRoZSB1c2VyIG1hbnVhbGx5IGVudGVycyBhIHBhc3N3b3JkIGludG8gd2Via2l0 LXBhdGNoLCB3ZSBoYW5kIHRoYXQgb2ZmIHRvIHRoZQorICAgICAgICBLZXlyaW5nIFB5dGhvbiBt b2R1bGUuIEhvd2V2ZXIsIHRoYXQgbW9kdWxlIGNyZWF0ZXMgYSBnZW5lcmljIHBhc3N3b3JkIGVu dHJ5IGluc3RlYWQKKyAgICAgICAgb2YgYW4gaW50ZXJuZXQgcGFzc3dvcmQgZW50cnkuIFdlIHNo b3VsZCBsb29rIGZvciBib3RoIGtpbmRzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9j b21tb24vbmV0L2NyZWRlbnRpYWxzLnB5OgorICAgICAgICAoQ3JlZGVudGlhbHMuX3J1bl9zZWN1 cml0eV90b29sKToKKyAgICAgICAgKENyZWRlbnRpYWxzLl9jcmVkZW50aWFsc19mcm9tX2tleWNo YWluKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvY3JlZGVudGlhbHNf dW5pdHRlc3QucHk6CisgICAgICAgICh0ZXN0X3NlY3VyaXR5X291dHB1dF9wYXJzZV9lbnRyeV9u b3RfZm91bmQpOgorICAgICAgICAoX2Fzc2VydF9zZWN1cml0eV9jYWxsKToKKwogMjAxNS0wMS0w NiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFRyeSB0 byBmaXggdGhlIE1vdW50YWluIExpb24gYnVpbGQuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9uZXQvY3JlZGVudGlhbHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9uZXQvY3JlZGVudGlhbHMucHkKaW5kZXggNzAzOGI3ZTNjZGJmNjgzYzhhOTg4 NzQ2MDc4Mjc4NGQzZGNhODBiMi4uZDllZjNkMWNhMDE2YmNkYWQ3ZTQ5MGI1YjViNDMzZmQzZTRl YjdkNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2NyZWRl bnRpYWxzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9jcmVkZW50 aWFscy5weQpAQCAtODksMTAgKzg5LDEwIEBAIGNsYXNzIENyZWRlbnRpYWxzKG9iamVjdCk6CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWN1cml0 eV9vdXRwdXQpCiAgICAgICAgIHJldHVybiBbdXNlcm5hbWUsIHBhc3N3b3JkXQogCi0gICAgZGVm IF9ydW5fc2VjdXJpdHlfdG9vbChzZWxmLCB1c2VybmFtZT1Ob25lKToKKyAgICBkZWYgX3J1bl9z ZWN1cml0eV90b29sKHNlbGYsIGNvbW1hbmQsIHVzZXJuYW1lPU5vbmUpOgogICAgICAgICBzZWN1 cml0eV9jb21tYW5kID0gWwogICAgICAgICAgICAgIi91c3IvYmluL3NlY3VyaXR5IiwKLSAgICAg ICAgICAgICJmaW5kLWludGVybmV0LXBhc3N3b3JkIiwKKyAgICAgICAgICAgIGNvbW1hbmQsCiAg ICAgICAgICAgICAiLWciLAogICAgICAgICAgICAgIi1zIiwKICAgICAgICAgICAgIHNlbGYuaG9z dCwKQEAgLTExNSwxMSArMTE1LDE1IEBAIGNsYXNzIENyZWRlbnRpYWxzKG9iamVjdCk6CiAgICAg ICAgIGlmIG5vdCBzZWxmLl9pc19tYWNfb3NfeCgpOgogICAgICAgICAgICAgcmV0dXJuIFt1c2Vy bmFtZSwgTm9uZV0KIAotICAgICAgICBzZWN1cml0eV9vdXRwdXQgPSBzZWxmLl9ydW5fc2VjdXJp dHlfdG9vbCh1c2VybmFtZSkKKyAgICAgICAgc2VjdXJpdHlfb3V0cHV0ID0gc2VsZi5fcnVuX3Nl Y3VyaXR5X3Rvb2woImZpbmQtaW50ZXJuZXQtcGFzc3dvcmQiLCB1c2VybmFtZSkKKyAgICAgICAg aWYgc2VjdXJpdHlfb3V0cHV0OgorICAgICAgICAgICAgcGFyc2VkX291dHB1dCA9IHNlbGYuX3Bh cnNlX3NlY3VyaXR5X3Rvb2xfb3V0cHV0KHNlY3VyaXR5X291dHB1dCkKKyAgICAgICAgICAgIGlm IHBhcnNlZF9vdXRwdXRbMF0gb3IgcGFyc2VkX291dHB1dFsxXToKKyAgICAgICAgICAgICAgICBy ZXR1cm4gcGFyc2VkX291dHB1dAorICAgICAgICBzZWN1cml0eV9vdXRwdXQgPSBzZWxmLl9ydW5f c2VjdXJpdHlfdG9vbCgiZmluZC1nZW5lcmljLXBhc3N3b3JkIiwgdXNlcm5hbWUpCiAgICAgICAg IGlmIHNlY3VyaXR5X291dHB1dDoKICAgICAgICAgICAgIHJldHVybiBzZWxmLl9wYXJzZV9zZWN1 cml0eV90b29sX291dHB1dChzZWN1cml0eV9vdXRwdXQpCi0gICAgICAgIGVsc2U6Ci0gICAgICAg ICAgICByZXR1cm4gW05vbmUsIE5vbmVdCisgICAgICAgIHJldHVybiBbTm9uZSwgTm9uZV0KIAog ICAgIGRlZiBfcmVhZF9lbnZpcm9uKHNlbGYsIGtleSk6CiAgICAgICAgIGVudmlyb25fa2V5ID0g c2VsZi5fZW52aXJvbl9wcmVmaXggKyBrZXkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL25ldC9jcmVkZW50aWFsc191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL25ldC9jcmVkZW50aWFsc191bml0dGVzdC5weQppbmRleCA4MThiM2Q3 MTI3NzZmNTg3OTkzNDRlNTc0Y2UzODc5ZDRjYWY4NWM1Li4xYjRmZDdlYWU5ZmEwNDUxNDUxN2Y5 YjMyMTU3ZGI2ZWNkMTY0YmFmIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9uZXQvY3JlZGVudGlhbHNfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vbmV0L2NyZWRlbnRpYWxzX3VuaXR0ZXN0LnB5CkBAIC0xMTAsNyArMTEwLDcg QEAgcGFzc3dvcmQ6ICJTRUNSRVRTQVVDRSIKICAgICAgICAgIyBieSB0aGUgdGVzdCBjYXNlIENy ZWRlbnRpYWxzVGVzdC5fYXNzZXJ0X3NlY3VyaXR5X2NhbGwgKGJlbG93KS4KICAgICAgICAgb3V0 cHV0Q2FwdHVyZSA9IE91dHB1dENhcHR1cmUoKQogICAgICAgICBvdXRwdXRDYXB0dXJlLmNhcHR1 cmVfb3V0cHV0KCkKLSAgICAgICAgc2VsZi5hc3NlcnRJc05vbmUoY3JlZGVudGlhbHMuX3J1bl9z ZWN1cml0eV90b29sKCkpCisgICAgICAgIHNlbGYuYXNzZXJ0SXNOb25lKGNyZWRlbnRpYWxzLl9y dW5fc2VjdXJpdHlfdG9vbCgiZmluZC1pbnRlcm5ldC1wYXNzd29yZCIpKQogICAgICAgICBvdXRw dXRDYXB0dXJlLnJlc3RvcmVfb3V0cHV0KCkKIAogICAgIGRlZiBfYXNzZXJ0X3NlY3VyaXR5X2Nh bGwoc2VsZiwgdXNlcm5hbWU9Tm9uZSk6CkBAIC0xMTgsNyArMTE4LDcgQEAgcGFzc3dvcmQ6ICJT RUNSRVRTQVVDRSIKICAgICAgICAgY3JlZGVudGlhbHMgPSBNb2NrZWRDcmVkZW50aWFscygiZXhh bXBsZS5jb20iLCBleGVjdXRpdmU9ZXhlY3V0aXZlX21vY2spCiAKICAgICAgICAgZXhwZWN0ZWRf bG9ncyA9ICJSZWFkaW5nIEtleWNoYWluIGZvciBleGFtcGxlLmNvbSBhY2NvdW50IGFuZCBwYXNz d29yZC4gIENsaWNrIFwiQWxsb3dcIiB0byBjb250aW51ZS4uLlxuIgotICAgICAgICBPdXRwdXRD YXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgY3JlZGVudGlhbHMuX3J1bl9zZWN1cml0eV90 b29sLCBbdXNlcm5hbWVdLCBleHBlY3RlZF9sb2dzPWV4cGVjdGVkX2xvZ3MpCisgICAgICAgIE91 dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBjcmVkZW50aWFscy5fcnVuX3NlY3Vy aXR5X3Rvb2wsIFsiZmluZC1pbnRlcm5ldC1wYXNzd29yZCIsIHVzZXJuYW1lXSwgZXhwZWN0ZWRf bG9ncz1leHBlY3RlZF9sb2dzKQogCiAgICAgICAgIHNlY3VyaXR5X2FyZ3MgPSBbIi91c3IvYmlu L3NlY3VyaXR5IiwgImZpbmQtaW50ZXJuZXQtcGFzc3dvcmQiLCAiLWciLCAiLXMiLCAiZXhhbXBs ZS5jb20iXQogICAgICAgICBpZiB1c2VybmFtZToK