140154 2015-01-06 16:01:54 -0800 Web Inspector: Expected UserAgent styles to be crossed-out if overridden 2015-01-08 03:43:03 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1059200 0 joepeck 2015-01-06 16:01:54 -0800 * SUMMARY In the styles sidebar I expect User Agent styles are never crossed out, even if they are overridden. I would expect them to be crossed out. * TEST <style> textarea { background-color: red; } textarea { background-color: green; } </style> <textarea></textarea> * STEPS TO REPRODUCE 1. Inspect the <textarea> for its background-color => style sidebar shows, "green", "red", "white", expected red and white to be crossed out, but "white" was not. * NOTES - This is because the UserAgent CSS.CSSProperties are not sent with a "status" field, and are assumed to be anonymous styles that are never treated as overridden. Maybe we should treat them as overridable here. 1059201 1 webkit-bug-importer 2015-01-06 16:02:33 -0800 <rdar://problem/19392325> 1059748 2 joepeck 2015-01-07 22:29:38 -0800 Another test case, for HTML Attributes, which were also getting this treatment: * TEST 2 <style>body { background-color: red; }</style> <body bgColor="blue" style="background-color:green"></body> * STEPS TO REPRODUCE 1. Inspect <body> for its background-color => "blue" from HTML Attribute should be crossed-out (currently it is not) 2. Disable "green" from inline style. 3. Disable "red" from stylesheet. => "blue" from HTML Attribute should be enabled 1059749 3 244242 joepeck 2015-01-07 22:32:16 -0800 Created attachment 244242 [PATCH] Proposed Fix 1059770 4 244242 timothy 2015-01-08 03:02:49 -0800 Comment on attachment 244242 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=244242&action=review > Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:600 > + // FIXME: Is this still needed? This includes UserAgent styles and HTML attribute styles. > anonymous = true; We can remove it. I don't remember why I thought it was needed. 1059779 5 244242 commit-queue 2015-01-08 03:43:00 -0800 Comment on attachment 244242 [PATCH] Proposed Fix Clearing flags on attachment: 244242 Committed r178110: <http://trac.webkit.org/changeset/178110> 1059780 6 commit-queue 2015-01-08 03:43:03 -0800 All reviewed patches have been landed. Closing bug. 244242 2015-01-07 22:32:16 -0800 2015-01-08 03:43:00 -0800 [PATCH] Proposed Fix override.patch text/plain 2742 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZiYTdjYjYuLmRjMWEwOGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE1LTAxLTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRXhwZWN0 ZWQgVXNlckFnZW50IHN0eWxlcyB0byBiZSBjcm9zc2VkLW91dCBpZiBvdmVycmlkZGVuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAxNTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NTm9k ZVN0eWxlcy5wcm90b3R5cGUuX3BhcnNlU3R5bGVQcm9wZXJ0eVBheWxvYWQpOgorICAgICAgICBB ZGQgYSBjb21tZW50IGFib3V0IGFub255bW91cyBzdHlsZXMuIFRoZSBnZXR0ZXIgaXMgbm8gbG9u Z2VyIHVzZWQsIGFuZCBpdCBpcyBub3QKKyAgICAgICAgY2xlYXIgaWYgd2UgcmVhbGx5IGNhcmUg YWJvdXQgdGhpcyBzdGF0ZSwgb3IgaWYgImFub255bW91cyIgaXMgYW4gYXBwcm9wcmlhdGUgbmFt ZS4KKworICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTU5vZGVTdHlsZXMucHJvdG90eXBlLl9tYXJr T3ZlcnJpZGRlblByb3BlcnRpZXMpOgorICAgICAgICBBbGxvdyBicm93c2VyIHN0eWxlcyAodXNl ciBhZ2VudCAvIGh0bWwgYXR0cmlidXRlcykgdG8gYmUgb3ZlcnJpZGRlbi4KKworICAgICAgICAo V2ViSW5zcGVjdG9yLkRPTU5vZGVTdHlsZXMucHJvdG90eXBlLl9wYXJzZVN0eWxlRGVjbGFyYXRp b25QYXlsb2FkKToKKyAgICAgICAgV2hlbiByZWZyZXNoaW5nIHN0eWxlcyBhZnRlciBjaGFuZ2Vz LCB0aGUgU3R5bGUgb2JqZWN0IGJhY2tpbmcgSFRNTCBhdHRyaWJ1dGVzCisgICAgICAgIHdhcyBi ZWluZyBjb21wbGV0ZWx5IHJlcGxhY2VkLiBBbGxvdyBpdCB0byBiZSByZW1lbWJlcmVkIGJ5IGEg dW5pcXVlIGtleS4KKworMjAxNS0wMS0wNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERvIG5vdCBjcmVhdGUgcnVsZXNNYXAg ZW50cmllcyBmb3IgcnVsZXMgd2l0aG91dCBpZGVudGlmaWVycwogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMjM3CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlU3R5bGVzLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMu anMKaW5kZXggYzc2NTY1Yy4uNDU0ZjcyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanMKQEAgLTU5 Niw2ICs1OTYsNyBAQCBXZWJJbnNwZWN0b3IuRE9NTm9kZVN0eWxlcy5wcm90b3R5cGUgPSB7CiAg ICAgICAgICAgICBlbmFibGVkID0gZmFsc2U7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg Y2FzZSAic3R5bGUiOgorICAgICAgICAgICAgLy8gRklYTUU6IElzIHRoaXMgc3RpbGwgbmVlZGVk PyBUaGlzIGluY2x1ZGVzIFVzZXJBZ2VudCBzdHlsZXMgYW5kIEhUTUwgYXR0cmlidXRlIHN0eWxl cy4KICAgICAgICAgICAgIGFub255bW91cyA9IHRydWU7CiAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgfQpAQCAtNjUxLDYgKzY1Miw5IEBAIFdlYkluc3BlY3Rvci5ET01Ob2RlU3R5bGVzLnBy b3RvdHlwZSA9IHsKICAgICAgICAgdmFyIGlkID0gcGF5bG9hZC5zdHlsZUlkOwogICAgICAgICB2 YXIgbWFwS2V5ID0gaWQgPyBpZC5zdHlsZVNoZWV0SWQgKyAiOiIgKyBpZC5vcmRpbmFsIDogbnVs bDsKIAorICAgICAgICBpZiAodHlwZSA9PSBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlv bi5UeXBlLkF0dHJpYnV0ZSkKKyAgICAgICAgICAgIG1hcEtleSA9IG5vZGUuaWQgKyAiOmF0dHJp YnV0ZSI7CisKICAgICAgICAgdmFyIHN0eWxlRGVjbGFyYXRpb24gPSBydWxlID8gcnVsZS5zdHls ZSA6IG51bGw7CiAgICAgICAgIHZhciBzdHlsZURlY2xhcmF0aW9ucyA9IFtdOwogCkBAIC05ODAs NyArOTg0LDcgQEAgV2ViSW5zcGVjdG9yLkRPTU5vZGVTdHlsZXMucHJvdG90eXBlID0gewogCiAg ICAgICAgICAgICBmb3IgKHZhciBqID0gMDsgaiA8IHByb3BlcnRpZXMubGVuZ3RoOyArK2opIHsK ICAgICAgICAgICAgICAgICB2YXIgcHJvcGVydHkgPSBwcm9wZXJ0aWVzW2pdOwotICAgICAgICAg ICAgICAgIGlmICghcHJvcGVydHkuZW5hYmxlZCB8fCBwcm9wZXJ0eS5hbm9ueW1vdXMgfHwgIXBy b3BlcnR5LnZhbGlkKSB7CisgICAgICAgICAgICAgICAgaWYgKCFwcm9wZXJ0eS5lbmFibGVkIHx8 ICFwcm9wZXJ0eS52YWxpZCkgewogICAgICAgICAgICAgICAgICAgICBwcm9wZXJ0eS5vdmVycmlk ZGVuID0gZmFsc2U7CiAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAg ICAgIH0K