140148 2015-01-06 15:03:49 -0800 Add the lexicalEnvironment as an operand to op_create_arguments 2015-01-07 17:48:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140097 140233 1 mark.lam mark.lam commit-queue fpizlo ggaren mmirman msaboff oldest_to_newest 1059180 0 mark.lam 2015-01-06 15:03:49 -0800 This is the 1st step towards having the DFG CreateArguments node take the lexicalEnvironment as a parameter. 1059209 1 244107 mark.lam 2015-01-06 16:12:23 -0800 Created attachment 244107 the patch. 1059219 2 244107 ggaren 2015-01-06 16:22:49 -0800 Comment on attachment 244107 the patch. r=me 1059232 3 244107 commit-queue 2015-01-06 17:03:27 -0800 Comment on attachment 244107 the patch. Clearing flags on attachment: 244107 Committed r178008: <http://trac.webkit.org/changeset/178008> 1059233 4 commit-queue 2015-01-06 17:03:37 -0800 All reviewed patches have been landed. Closing bug. 244107 2015-01-06 16:12:23 -0800 2015-01-06 17:03:27 -0800 the patch. bug-140148.patch text/plain 6331 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc4MDAxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE1LTAxLTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgdGhlIGxleGljYWxFbnZpcm9ubWVudCBhcyBhbiBvcGVyYW5kIHRvIG9wX2NyZWF0ZV9hcmd1 bWVudHMuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDAxNDg+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBvbmx5IGFk ZHMgdGhlIG9wZXJhbmQgdG8gdGhlIGJ5dGVjb2RlLiAgSXQgaXMgbm90IGluIHVzZSB5ZXQuCisK KyAgICAgICAgKiBieXRlY29kZS9CeXRlY29kZUxpc3QuanNvbjoKKyAgICAgICAgKiBieXRlY29k ZS9CeXRlY29kZVVzZURlZi5oOgorICAgICAgICAoSlNDOjpjb21wdXRlVXNlc0ZvckJ5dGVjb2Rl T2Zmc2V0KToKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAoSlND OjpDb2RlQmxvY2s6OmR1bXBCeXRlY29kZSk6CisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVj b2RlR2VuZXJhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OkJ5dGVj b2RlR2VuZXJhdG9yKToKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmNyZWF0ZUFy Z3VtZW50c0lmTmVjZXNzYXJ5KToKKyAgICAgICAgLSBBZGRzIHRoZSBsZXhpY2FsRW52aXJvbm1l bnQgcmVnaXN0ZXIgKGlmIHByZXNlbnQpIGFzIGFuIG9wZXJhbmQgdG8KKyAgICAgICAgICBvcF9j cmVhdGVfYXJndW1lbnRzLiAgRWxzZSwgYWRkcyBhIGNvbnN0YW50IGVtcHR5IEpTVmFsdWUuCisg ICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbToKKyAgICAgICAgKiBs bGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtOgorCiAyMDE1LTAxLTA2ICBBbGV4ZXkgUHJv c2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIEFERFJFU1NfU0FOSVRJWkVSIG1h Y3JvIGlzIG92ZXJsb2FkZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9C eXRlY29kZUxpc3QuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvQnl0ZWNvZGVMaXN0Lmpzb24JKHJldmlzaW9uIDE3Nzk5OSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9CeXRlY29kZUxpc3QuanNvbgkod29ya2luZyBjb3B5KQpAQCAt OCw3ICs4LDcgQEAKICAgICAgICAgICAgIHsgIm5hbWUiIDogIm9wX2dldF9zY29wZSIsICJsZW5n dGgiIDogMiB9LAogICAgICAgICAgICAgeyAibmFtZSIgOiAib3BfdG91Y2hfZW50cnkiLCAibGVu Z3RoIiA6IDEgfSwKICAgICAgICAgICAgIHsgIm5hbWUiIDogIm9wX2luaXRfbGF6eV9yZWciLCAi bGVuZ3RoIiA6IDIgfSwKLSAgICAgICAgICAgIHsgIm5hbWUiIDogIm9wX2NyZWF0ZV9hcmd1bWVu dHMiLCAibGVuZ3RoIiA6IDIgfSwKKyAgICAgICAgICAgIHsgIm5hbWUiIDogIm9wX2NyZWF0ZV9h cmd1bWVudHMiLCAibGVuZ3RoIiA6IDMgfSwKICAgICAgICAgICAgIHsgIm5hbWUiIDogIm9wX2Ny ZWF0ZV90aGlzIiwgImxlbmd0aCIgOiA0IH0sCiAgICAgICAgICAgICB7ICJuYW1lIiA6ICJvcF9n ZXRfY2FsbGVlIiwgImxlbmd0aCIgOiAzIH0sCiAgICAgICAgICAgICB7ICJuYW1lIiA6ICJvcF90 b190aGlzIiwgImxlbmd0aCIgOiA0IH0sCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvQnl0ZWNvZGVVc2VEZWYuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvZGUvQnl0ZWNvZGVVc2VEZWYuaAkocmV2aXNpb24gMTc3OTk5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0J5dGVjb2RlVXNlRGVmLmgJKHdvcmtpbmcgY29weSkK QEAgLTU2LDcgKzU2LDYgQEAgdm9pZCBjb21wdXRlVXNlc0ZvckJ5dGVjb2RlT2Zmc2V0KAogICAg IGNhc2Ugb3BfcHJvZmlsZV9jb250cm9sX2Zsb3c6CiAgICAgICAgIHJldHVybjsKICAgICBjYXNl IG9wX2dldF9zY29wZToKLSAgICBjYXNlIG9wX2NyZWF0ZV9hcmd1bWVudHM6CiAgICAgY2FzZSBv cF90b190aGlzOgogICAgIGNhc2Ugb3BfcG9wX3Njb3BlOgogICAgIGNhc2Ugb3BfcHJvZmlsZV93 aWxsX2NhbGw6CkBAIC03NCw2ICs3Myw3IEBAIHZvaWQgY29tcHV0ZVVzZXNGb3JCeXRlY29kZU9m ZnNldCgKICAgICAgICAgZnVuY3Rvcihjb2RlQmxvY2ssIGluc3RydWN0aW9uLCBvcGNvZGVJRCwg aW5zdHJ1Y3Rpb25bMV0udS5vcGVyYW5kKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KKyAgICBj YXNlIG9wX2NyZWF0ZV9hcmd1bWVudHM6CiAgICAgY2FzZSBvcF9uZXdfZnVuYzoKICAgICBjYXNl IG9wX3JldF9vYmplY3Rfb3JfdGhpczoKICAgICBjYXNlIG9wX2psZXNzZXE6CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkocmV2aXNpb24gMTc3 OTk5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTc1OCw3ICs3NTgsOSBAQCB2b2lkIENvZGVCbG9jazo6ZHVtcEJ5dGVj b2RlKAogICAgICAgICB9CiAgICAgICAgIGNhc2Ugb3BfY3JlYXRlX2FyZ3VtZW50czogewogICAg ICAgICAgICAgaW50IHIwID0gKCsraXQpLT51Lm9wZXJhbmQ7Ci0gICAgICAgICAgICBwcmludExv Y2F0aW9uT3BBbmRSZWdpc3Rlck9wZXJhbmQob3V0LCBleGVjLCBsb2NhdGlvbiwgaXQsICJjcmVh dGVfYXJndW1lbnRzIiwgcjApOworICAgICAgICAgICAgaW50IHIxID0gKCsraXQpLT51Lm9wZXJh bmQ7CisgICAgICAgICAgICBwcmludExvY2F0aW9uQW5kT3Aob3V0LCBleGVjLCBsb2NhdGlvbiwg aXQsICJjcmVhdGVfYXJndW1lbnRzIik7CisgICAgICAgICAgICBvdXQucHJpbnRmKCIlcyAlcyIs IHJlZ2lzdGVyTmFtZShyMCkuZGF0YSgpLCByZWdpc3Rlck5hbWUocjEpLmRhdGEoKSk7CiAgICAg ICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICBjYXNlIG9wX2luaXRfbGF6eV9yZWc6 IHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5l cmF0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGls ZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCShyZXZpc2lvbiAxNzc5OTkpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjgyLDYgKzI4Miw5IEBAIEJ5dGVjb2RlR2VuZXJhdG9yOjpCeXRlY29kZUdlbmVy YXRvcihWTSYKICAgICAgICAgaWYgKHNob3VsZENyZWF0ZUFyZ3VtZW50c0VhZ2VybHkoKSB8fCBz aG91bGRUZWFyT2ZmQXJndW1lbnRzRWFnZXJseSgpKSB7CiAgICAgICAgICAgICBlbWl0T3Bjb2Rl KG9wX2NyZWF0ZV9hcmd1bWVudHMpOwogICAgICAgICAgICAgaW5zdHJ1Y3Rpb25zKCkuYXBwZW5k KGFyZ3VtZW50c1JlZ2lzdGVyLT5pbmRleCgpKTsKKyAgICAgICAgICAgIEFTU0VSVCghbV9jb2Rl QmxvY2stPmhhc0FjdGl2YXRpb25SZWdpc3RlcigpIHx8IG1fY29kZUJsb2NrLT5hY3RpdmF0aW9u UmVnaXN0ZXIoKS5pc1ZhbGlkKCkpOworICAgICAgICAgICAgaW5zdHJ1Y3Rpb25zKCkuYXBwZW5k KG1fY29kZUJsb2NrLT5oYXNBY3RpdmF0aW9uUmVnaXN0ZXIoKSA/IG1fY29kZUJsb2NrLT5hY3Rp dmF0aW9uUmVnaXN0ZXIoKS5vZmZzZXQoKSA6IGFkZENvbnN0YW50VmFsdWUoSlNWYWx1ZSgpKS0+ aW5kZXgoKSk7CisKICAgICAgICAgICAgIGlmIChtX2NvZGVCbG9jay0+aGFzQWN0aXZhdGlvblJl Z2lzdGVyKCkpIHsKICAgICAgICAgICAgICAgICBSZWdpc3RlcklEKiBhcmd1bWVudHNSZWdpc3Rl ciA9ICZyZWdpc3RlckZvcihtX2NvZGVCbG9jay0+YXJndW1lbnRzUmVnaXN0ZXIoKS5vZmZzZXQo KSk7CiAgICAgICAgICAgICAgICAgaW5pdGlhbGl6ZUNhcHR1cmVkVmFyaWFibGUoYXJndW1lbnRz UmVnaXN0ZXIsIHByb3BlcnR5TmFtZXMoKS5hcmd1bWVudHMsIGFyZ3VtZW50c1JlZ2lzdGVyKTsK QEAgLTE3NzIsNiArMTc3NSw4IEBAIHZvaWQgQnl0ZWNvZGVHZW5lcmF0b3I6OmNyZWF0ZUFyZ3Vt ZW50c0kKICAgICBlbWl0T3Bjb2RlKG9wX2NyZWF0ZV9hcmd1bWVudHMpOwogICAgIGluc3RydWN0 aW9ucygpLmFwcGVuZChtX2NvZGVCbG9jay0+YXJndW1lbnRzUmVnaXN0ZXIoKS5vZmZzZXQoKSk7 CiAgICAgQVNTRVJUKCFoYXNXYXRjaGFibGVWYXJpYWJsZShtX2NvZGVCbG9jay0+YXJndW1lbnRz UmVnaXN0ZXIoKS5vZmZzZXQoKSkpOworICAgIEFTU0VSVCghbV9jb2RlQmxvY2stPmhhc0FjdGl2 YXRpb25SZWdpc3RlcigpIHx8IG1fY29kZUJsb2NrLT5hY3RpdmF0aW9uUmVnaXN0ZXIoKS5pc1Zh bGlkKCkpOworICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChtX2NvZGVCbG9jay0+aGFzQWN0aXZh dGlvblJlZ2lzdGVyKCkgPyBtX2NvZGVCbG9jay0+YWN0aXZhdGlvblJlZ2lzdGVyKCkub2Zmc2V0 KCkgOiBhZGRDb25zdGFudFZhbHVlKEpTVmFsdWUoKSktPmluZGV4KCkpOwogfQogCiBSZWdpc3Rl cklEKiBCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdENhbGxFdmFsKFJlZ2lzdGVySUQqIGRzdCwgUmVn aXN0ZXJJRCogZnVuYywgQ2FsbEFyZ3VtZW50cyYgY2FsbEFyZ3VtZW50cywgY29uc3QgSlNUZXh0 UG9zaXRpb24mIGRpdm90LCBjb25zdCBKU1RleHRQb3NpdGlvbiYgZGl2b3RTdGFydCwgY29uc3Qg SlNUZXh0UG9zaXRpb24mIGRpdm90RW5kKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHJldmlzaW9u IDE3Nzk5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJl dGVyMzJfNjQuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC03NTAsNyArNzUwLDcgQEAgX2xsaW50X29w X2NyZWF0ZV9hcmd1bWVudHM6CiAgICAgYmluZXEgVGFnT2Zmc2V0W2NmciwgdDAsIDhdLCBFbXB0 eVZhbHVlVGFnLCAub3BDcmVhdGVBcmd1bWVudHNEb25lCiAgICAgY2FsbFNsb3dQYXRoKF9zbG93 X3BhdGhfY3JlYXRlX2FyZ3VtZW50cykKIC5vcENyZWF0ZUFyZ3VtZW50c0RvbmU6Ci0gICAgZGlz cGF0Y2goMikKKyAgICBkaXNwYXRjaCgzKQogCiAKIF9sbGludF9vcF9jcmVhdGVfdGhpczoKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNt Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy cHJldGVyNjQuYXNtCShyZXZpc2lvbiAxNzc5OTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQkod29ya2luZyBjb3B5KQpAQCAtNjM2LDcg KzYzNiw3IEBAIF9sbGludF9vcF9jcmVhdGVfYXJndW1lbnRzOgogICAgIGJxbmVxIFtjZnIsIHQw LCA4XSwgVmFsdWVFbXB0eSwgLm9wQ3JlYXRlQXJndW1lbnRzRG9uZQogICAgIGNhbGxTbG93UGF0 aChfc2xvd19wYXRoX2NyZWF0ZV9hcmd1bWVudHMpCiAub3BDcmVhdGVBcmd1bWVudHNEb25lOgot ICAgIGRpc3BhdGNoKDIpCisgICAgZGlzcGF0Y2goMykKIAogCiBfbGxpbnRfb3BfY3JlYXRlX3Ro aXM6Cg==