140143 2015-01-06 13:27:03 -0800 Source/WTF/wtf/OSAllocatorPosix.cpp fails to build on OS X Leopard due to madvise() extensions not being available 2015-01-08 12:55:23 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 jeremyhu webkit-unassigned cgarcia mrobinson ossy oldest_to_newest 1059136 0 jeremyhu 2015-01-06 13:27:03 -0800 Compilation of webkit-gtk-2.4.7 fails on OS X Leopard: :info:build Source/WTF/wtf/OSAllocatorPosix.cpp:54:35: error: use of undeclared identifier 'MADV_FREE_REUSABLE' :info:build while (madvise(result, bytes, MADV_FREE_REUSABLE) == -1 && errno == EAGAIN) { } :info:build ^ :info:build Source/WTF/wtf/OSAllocatorPosix.cpp:139:36: error: use of undeclared identifier 'MADV_FREE_REUSE' :info:build while (madvise(address, bytes, MADV_FREE_REUSE) == -1 && errno == EAGAIN) { } :info:build ^ :info:build Source/WTF/wtf/OSAllocatorPosix.cpp:156:36: error: use of undeclared identifier 'MADV_FREE_REUSABLE' :info:build while (madvise(address, bytes, MADV_FREE_REUSABLE) == -1 && errno == EAGAIN) { } :info:build ^ :info:build 3 errors generated. :info:build GNUmakefile:52455: recipe for target 'Source/WTF/wtf/libWTF_la-OSAllocatorPosix.lo' failed :info:build gmake: *** [Source/WTF/wtf/libWTF_la-OSAllocatorPosix.lo] Error 1 This happens because Leopard does not support: #define MADV_ZERO_WIRED_PAGES 6 /* zero the wired pages that have not been unwired before the entry is deleted */ #define MADV_FREE_REUSABLE 7 /* pages can be reused (by anyone) */ #define MADV_FREE_REUSE 8 /* caller wants to reuse those pages */ #define MADV_CAN_REUSE 9 1059139 1 jeremyhu 2015-01-06 13:29:57 -0800 It looks like the code is guarded: #elif HAVE(MADV_FREE_REUSE) while (madvise(address, bytes, MADV_FREE_REUSABLE) == -1 && errno == EAGAIN) { } so the issue is that HAVE(MADV_FREE_REUSE) is not working right. 1059145 2 jeremyhu 2015-01-06 13:44:36 -0800 I'm testing a patch of Platform.h for Leopard now. 1059915 3 244284 jeremyhu 2015-01-08 12:54:34 -0800 Created attachment 244284 Fix Platform.h for Leopard 1059917 4 244285 jeremyhu 2015-01-08 12:55:03 -0800 Created attachment 244285 Fix malloc struct for Leopard 1059919 5 jeremyhu 2015-01-08 12:55:23 -0800 With these two patches, webkit-gtk builds correctly against the Leopard SDK. 244284 2015-01-08 12:54:34 -0800 2015-01-08 12:54:34 -0800 Fix Platform.h for Leopard leopard-platform.patch text/plain 532 jeremyhu LS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgub3JpZwkyMDE1LTAxLTA2IDEzOjMwOjUyLjAw MDAwMDAwMCAtMDgwMAorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkyMDE1LTAxLTA2IDEz OjQyOjE1LjAwMDAwMDAwMCAtMDgwMApAQCAtNTg3LDExICs1ODcsMTQgQEAKIAogI2lmIE9TKERB UldJTikKIAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA2MCB8fCBQ TEFURk9STShJT1MpCiAjZGVmaW5lIEhBVkVfRElTUEFUQ0hfSCAxCi0jZGVmaW5lIEhBVkVfTUFE Vl9GUkVFIDEKICNkZWZpbmUgSEFWRV9NQURWX0ZSRUVfUkVVU0UgMQotI2RlZmluZSBIQVZFX01F UkdFU09SVCAxCiAjZGVmaW5lIEhBVkVfUFRIUkVBRF9TRVROQU1FX05QIDEKKyNlbmRpZgorCisj ZGVmaW5lIEhBVkVfTUFEVl9GUkVFIDEKKyNkZWZpbmUgSEFWRV9NRVJHRVNPUlQgMQogI2RlZmlu ZSBIQVZFX1JFQURMSU5FIDEKICNkZWZpbmUgSEFWRV9TWVNfVElNRUJfSCAxCiAjZGVmaW5lIFdU Rl9VU0VfQUNDRUxFUkFURSAxCg== 244285 2015-01-08 12:55:03 -0800 2015-01-08 12:55:03 -0800 Fix malloc struct for Leopard leopard-malloc.patch text/plain 864 jeremyhu LS0tIFNvdXJjZS9XVEYvd3RmL0Zhc3RNYWxsb2MuY3BwLm9yaWcJMjAxNS0wMS0wNyAxNjowNDoz MS4wMDAwMDAwMDAgLTA4MDAKKysrIFNvdXJjZS9XVEYvd3RmL0Zhc3RNYWxsb2MuY3BwCTIwMTUt MDEtMDcgMTY6MDY6MDUuMDAwMDAwMDAwIC0wODAwCkBAIC01MDk1LDggKzUwOTUsMTMgQEAgdm9p ZCogRmFzdE1hbGxvY1pvbmU6OnpvbmVSZWFsbG9jKG1hbGxvYwogZXh0ZXJuICJDIiB7CiBtYWxs b2NfaW50cm9zcGVjdGlvbl90IGpzY29yZV9mYXN0bWFsbG9jX2ludHJvc3BlY3Rpb24gPSB7ICZG YXN0TWFsbG9jWm9uZTo6ZW51bWVyYXRlLCAmRmFzdE1hbGxvY1pvbmU6Omdvb2RTaXplLCAmRmFz dE1hbGxvY1pvbmU6OmNoZWNrLCAmRmFzdE1hbGxvY1pvbmU6OnByaW50LAogICAgICZGYXN0TWFs bG9jWm9uZTo6bG9nLCAmRmFzdE1hbGxvY1pvbmU6OmZvcmNlTG9jaywgJkZhc3RNYWxsb2Nab25l Ojpmb3JjZVVubG9jaywgJkZhc3RNYWxsb2Nab25lOjpzdGF0aXN0aWNzCisKKyNpZiBPUyhJT1Mp IHx8IF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA+PSAxMDYwCiAgICAgLCAwIC8vIHpv bmVfbG9ja2VkIHdpbGwgbm90IGJlIGNhbGxlZCBvbiB0aGUgem9uZSB1bmxlc3MgaXQgYWR2ZXJ0 aXNlcyBpdHNlbGYgYXMgdmVyc2lvbiBmaXZlIG9yIGhpZ2hlci4KKyNlbmRpZgorI2lmIE9TKElP UykgfHwgX19NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEID49IDEwNzAKICAgICAsIDAsIDAs IDAsIDAgLy8gVGhlc2UgbWVtYmVycyB3aWxsIG5vdCBiZSB1c2VkIHVubGVzcyB0aGUgem9uZSBh ZHZlcnRpc2VzIGl0c2VsZiBhcyB2ZXJzaW9uIHNldmVuIG9yIGhpZ2hlci4KKyNlbmRpZgogCiAg ICAgfTsKIH0K