140140 2015-01-06 12:21:09 -0800 Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler 2015-01-06 14:26:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1059114 0 andersca 2015-01-06 12:21:09 -0800 Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler 1059116 1 244089 andersca 2015-01-06 12:22:49 -0800 Created attachment 244089 Patch 1059122 2 244089 kling 2015-01-06 12:42:42 -0800 Comment on attachment 244089 Patch r=me 1059123 3 andersca 2015-01-06 12:43:24 -0800 Committed r177986: <http://trac.webkit.org/changeset/177986> 1059162 4 244089 darin 2015-01-06 14:26:48 -0800 Comment on attachment 244089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244089&action=review > Source/WebKit/mac/Plugins/npapi.mm:184 > + dispatch_async(dispatch_get_main_queue(), ^{ > + if (!pluginView || !pluginView->plugin) { > + // The plug-in has already been destroyed. > + return; > + } > + > + func(userData); > + }); Whether pluginView is null or not is already known before calling dispatch_async so that check seems like it should be outside the block. 244089 2015-01-06 12:22:49 -0800 2015-01-06 12:42:42 -0800 Patch bug-140140-20150106122253.patch text/plain 4208 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3OTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNzliOTdhOGM2 OGNmZGM4YjUyYjY1ZGI0YTcwNmYxMjNmY2QxMTNjMS4uMjNjZDdhMmMyMGJhZTdhMmJjNThlMzE0 OTA1NGU0MTQ5OWNlOTY1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE1 LTAxLTA2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAg UmVpbXBsZW1lbnQgTlBOX1BsdWdpblRocmVhZEFzeW5jQ2FsbCB3aXRob3V0IHVzaW5nIFBsdWdp bk1haW5UaHJlYWRTY2hlZHVsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MDE0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEp1c3QgdXNlIGEgZGlzcGF0Y2hfYXN5bmMgY2FsbCB0byB0aGUgbWFpbiBx dWV1ZS4gVGhpcyB3aWxsIGxldCB1cyBtb3ZlIFBsdWdpbk1haW5UaHJlYWRTY2hlZHVsZXIKKyAg ICAgICAgb3V0IG9mIFdlYkNvcmUgc2luY2Ugbm9ib2R5IGVsc2UgaXMgdXNpbmcgaXQuCisKKyAg ICAgICAgKiBQbHVnaW5zL1dlYk5ldHNjYXBlUGx1Z2luVmlldy5oOgorICAgICAgICAqIFBsdWdp bnMvV2ViTmV0c2NhcGVQbHVnaW5WaWV3Lm1tOgorICAgICAgICAoLVtXZWJOZXRzY2FwZVBsdWdp blZpZXcgX2NyZWF0ZVBsdWdpbl0pOgorICAgICAgICAoLVtXZWJOZXRzY2FwZVBsdWdpblZpZXcg X2Rlc3Ryb3lQbHVnaW5dKToKKyAgICAgICAgKiBQbHVnaW5zL25wYXBpLm1tOgorICAgICAgICAo TlBOX1BsdWdpblRocmVhZEFzeW5jQ2FsbCk6CisKKzIwMTUtMDEtMDYgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBBZGQgYSBXZWJLaXQxIGRhdGFiYXNl IHByb3ZpZGVyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDAxMjYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJOZXRz Y2FwZVBsdWdpblZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvbWFjL1BsdWdpbnMvV2ViTmV0c2NhcGVQ bHVnaW5WaWV3LmgKaW5kZXggZDdiOWRiNzY0MTQ5OGYxMDQ2ZDNjYTg1MzRhNmQ2MTYzY2E5ZGM1 Yy4uYTE0YTNmZjU2MWExZGQ3Y2FiMmI2NzJiMmJiYjhiN2E2NWNkODA3NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblZpZXcuaAorKysgYi9T b3VyY2UvV2ViS2l0L21hYy9QbHVnaW5zL1dlYk5ldHNjYXBlUGx1Z2luVmlldy5oCkBAIC02MCw2 ICs2MCw3IEBAIHR5cGVkZWYgdW5pb24gUGx1Z2luUG9ydCB7CiAKIEBpbnRlcmZhY2UgV2ViTmV0 c2NhcGVQbHVnaW5WaWV3IDogV2ViQmFzZU5ldHNjYXBlUGx1Z2luVmlldzxXZWJQbHVnaW5NYW51 YWxMb2FkZXIsIFdlYlBsdWdpbkNvbnRhaW5lckNoZWNrQ29udHJvbGxlcj4KIHsKK0BwYWNrYWdl CiAgICAgUmVmUHRyPFdlYk5ldHNjYXBlUGx1Z2luU3RyZWFtPiBfbWFudWFsU3RyZWFtOwogICAg IFJldGFpblB0cjxDQUxheWVyPiBfcGx1Z2luTGF5ZXI7CiAgICAgdW5zaWduZWQgX2RhdGFMZW5n dGhSZWNlaXZlZDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1BsdWdpbnMvV2ViTmV0 c2NhcGVQbHVnaW5WaWV3Lm1tIGIvU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJOZXRzY2Fw ZVBsdWdpblZpZXcubW0KaW5kZXggMGMxYjk5YzQ2MjNmYTFlYWIyOGZlZWFlODI0ZjBjODc4ZWU0 MmFkZC4uMzkxMTgwMDIwMjE2ZTJhZGRmODIwNzI4MDIyZmZmMjU2ZThlYmJhZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblZpZXcubW0KKysr IGIvU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblZpZXcubW0KQEAg LTY1LDcgKzY1LDYgQEAKICNpbXBvcnQgPFdlYkNvcmUvRnJhbWVWaWV3Lmg+CiAjaW1wb3J0IDxX ZWJDb3JlL0hUTUxQbHVnSW5FbGVtZW50Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL1BhZ2UuaD4gCi0j aW1wb3J0IDxXZWJDb3JlL1BsdWdpbk1haW5UaHJlYWRTY2hlZHVsZXIuaD4KICNpbXBvcnQgPFdl YkNvcmUvUHJveHlTZXJ2ZXIuaD4KICNpbXBvcnQgPFdlYkNvcmUvU2NyaXB0Q29udHJvbGxlci5o PgogI2ltcG9ydCA8V2ViQ29yZS9TZWN1cml0eU9yaWdpbi5oPgpAQCAtMjM1OCw4ICsyMzU3LDYg QEAgc3RhdGljIGlubGluZSB2b2lkIGdldE5QUmVjdChjb25zdCBOU1JlY3QmIG5yLCBOUFJlY3Qm IG5wcikKICAgICAvLyBOUE5fTmV3KCksIHdoaWNoIGNyZWF0ZXMgdGhlIHBsdWctaW4gaW5zdGFu Y2UsIHNob3VsZCBuZXZlciBiZSBjYWxsZWQgd2hpbGUgY2FsbGluZyBhIHBsdWctaW4gZnVuY3Rp b24gZm9yIHRoYXQgaW5zdGFuY2UuCiAgICAgQVNTRVJUKHBsdWdpbkZ1bmN0aW9uQ2FsbERlcHRo ID09IDApOwogCi0gICAgUGx1Z2luTWFpblRocmVhZFNjaGVkdWxlcjo6c2NoZWR1bGVyKCkucmVn aXN0ZXJQbHVnaW4ocGx1Z2luKTsKLQogICAgIF9pc0ZsYXNoID0gW19wbHVnaW5QYWNrYWdlLmdl dCgpIGJ1bmRsZUlkZW50aWZpZXJdID09ICJjb20ubWFjcm9tZWRpYS5GbGFzaCBQbGF5ZXIucGx1 Z2luIjsKICAgICBfaXNTaWx2ZXJsaWdodCA9IFtfcGx1Z2luUGFja2FnZS5nZXQoKSBidW5kbGVJ ZGVudGlmaWVyXSA9PSAiY29tLm1pY3Jvc29mdC5TaWx2ZXJsaWdodFBsdWdpbiI7CiAKQEAgLTIz NzQsOCArMjM3MSw2IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBnZXROUFJlY3QoY29uc3QgTlNSZWN0 JiBuciwgTlBSZWN0JiBucHIpCiAKIC0gKHZvaWQpX2Rlc3Ryb3lQbHVnaW4KIHsKLSAgICBQbHVn aW5NYWluVGhyZWFkU2NoZWR1bGVyOjpzY2hlZHVsZXIoKS51bnJlZ2lzdGVyUGx1Z2luKHBsdWdp bik7Ci0gICAgCiAgICAgaWYgKF9pc1NpbHZlcmxpZ2h0KQogICAgICAgICBbc2VsZiBfd29ya2Fy b3VuZFNpbHZlcmxpZ2h0RnVsbHNjcmVlbkJ1ZzpOT107CiAgICAgCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L21hYy9QbHVnaW5zL25wYXBpLm1tIGIvU291cmNlL1dlYktpdC9tYWMvUGx1Z2lu cy9ucGFwaS5tbQppbmRleCBmYzNkOGU4NzY3MjhhMzEyYTQ4Mjc2M2ZiYzljYzA1YTY0ODcyMWM2 Li41NmE3YzI5NDdmNDRkYmExODEyNDA4ZDhmYjBkY2M2MjA1MWZhNzU3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L21hYy9QbHVnaW5zL25wYXBpLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFj L1BsdWdpbnMvbnBhcGkubW0KQEAgLTMxLDcgKzMxLDYgQEAKIAogI2ltcG9ydCAiV2ViTmV0c2Nh cGVQbHVnaW5WaWV3LmgiCiAjaW1wb3J0ICJXZWJLaXRMb2dnaW5nLmgiCi0jaW1wb3J0IDxXZWJD b3JlL1BsdWdpbk1haW5UaHJlYWRTY2hlZHVsZXIuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNv cmU7CiAKQEAgLTE3Myw3ICsxNzIsMTYgQEAgdm9pZCBOUE5fUG9wUG9wdXBzRW5hYmxlZFN0YXRl KE5QUCBpbnN0YW5jZSkKIAogdm9pZCBOUE5fUGx1Z2luVGhyZWFkQXN5bmNDYWxsKE5QUCBpbnN0 YW5jZSwgdm9pZCAoKmZ1bmMpICh2b2lkICopLCB2b2lkICp1c2VyRGF0YSkKIHsKLSAgICBQbHVn aW5NYWluVGhyZWFkU2NoZWR1bGVyOjpzY2hlZHVsZXIoKS5zY2hlZHVsZUNhbGwoaW5zdGFuY2Us IGZ1bmMsIHVzZXJEYXRhKTsKKyAgICBXZWJOZXRzY2FwZVBsdWdpblZpZXcgKnBsdWdpblZpZXcg PSBwbHVnaW5WaWV3Rm9ySW5zdGFuY2UoaW5zdGFuY2UpOworCisgICAgZGlzcGF0Y2hfYXN5bmMo ZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXnsKKyAgICAgICAgaWYgKCFwbHVnaW5WaWV3IHx8 ICFwbHVnaW5WaWV3LT5wbHVnaW4pIHsKKyAgICAgICAgICAgIC8vIFRoZSBwbHVnLWluIGhhcyBh bHJlYWR5IGJlZW4gZGVzdHJveWVkLgorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisK KyAgICAgICAgZnVuYyh1c2VyRGF0YSk7CisgICAgfSk7CiB9CiAKIHVpbnQzMl90IE5QTl9TY2hl ZHVsZVRpbWVyKE5QUCBpbnN0YW5jZSwgdWludDMyX3QgaW50ZXJ2YWwsIE5QQm9vbCByZXBlYXQs IHZvaWQgKCp0aW1lckZ1bmMpKE5QUCBucHAsIHVpbnQzMl90IHRpbWVySUQpKQo=