140130 2015-01-06 10:48:06 -0800 ADDRESS_SANITIZER macro is overloaded 2015-01-06 14:24:46 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=128819 P2 Normal --- 1 ap ap andersca ayao benjamin cmarcelo commit-queue ddkilzer oldest_to_newest 1059055 0 ap 2015-01-06 10:48:06 -0800 ADDRESS_SANITIZER macro is used for two purposes: - conditional compilation of code when ASan is enabled; - enabling security checks, whether ASan is enabled or not. 1059058 1 244074 ap 2015-01-06 10:53:23 -0800 Created attachment 244074 proposed fix 1059143 2 244074 andersca 2015-01-06 13:36:24 -0800 Comment on attachment 244074 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=244074&action=review > Source/WTF/wtf/Compiler.h:143 > +#if defined(__has_feature) > +#define ASAN_ENABLED __has_feature(address_sanitizer) > +#else > +#define ASAN_ENABLED false > +#endif Maybe this should be #define ENABLE_ASAN? so #if ENABLE(ASAN) could be used? 1059155 3 ap 2015-01-06 14:13:13 -0800 ENABLE() macros are for things that can be enabled by defining the macro, which is why I intentionally stayed away from using this form - ASan won't appear if you pass -DENABLE_ASAN. 1059161 4 ap 2015-01-06 14:24:46 -0800 Committed <http://trac.webkit.org/r177995>. 244074 2015-01-06 10:53:23 -0800 2015-01-06 14:13:01 -0800 proposed fix ASAN-macro.txt text/plain 7319 ap SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc3OTY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTAxLTA2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIEFERFJFU1NfU0FOSVRJWkVSIG1hY3JvIGlzIG92ZXJsb2FkZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDEzMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvSlNTdGFjay5j cHA6IChKU0M6OkpTU3RhY2s6OnNhbml0aXplU3RhY2spOiBVc2UgdGhlIG5ldyBtYWNyby4KKyAg ICAgICAgVGhpcyBjb2RlIGlzIG5lYXJseSB1bnVzZWQgKG9ubHkgY29tcGlsZWQgaW4gd2hlbiBK SVQgaXMgZGlzYWJsZWQgYXQgYnVpbGQgdGltZSksCisgICAgICAgIGhvd2V2ZXIgSSd2ZSBiZWVu IHRvbGQgdGhhdCBpdCdzIGJlc3QgdG8ga2VlcCBpdC4KKwogMjAxNS0wMS0wMyAgTWljaGFlbCBT YWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBvcGVyYXRpb25O ZXdGdW5jdGlvbiB3aGVuIHNjcm9sbGluZyBvbiBHb29nbGUrCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaW50ZXJwcmV0ZXIvSlNTdGFjay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suY3BwCShyZXZpc2lvbiAxNzc5MjIpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSlNTdGFjay5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTExOCw3ICsxMTgsNyBAQCB2b2lkIEpTU3RhY2s6OmdhdGhlckNvbnNlcnZhdGl2 ZVJvb3RzKENvCiAKIHZvaWQgSlNTdGFjazo6c2FuaXRpemVTdGFjaygpCiB7Ci0jaWYgIWRlZmlu ZWQoQUREUkVTU19TQU5JVElaRVIpCisjaWYgIUFTQU5fRU5BQkxFRAogICAgIEFTU0VSVCh0b3BP ZlN0YWNrKCkgPD0gYmFzZU9mU3RhY2soKSk7CiAgICAgCiAgICAgaWYgKG1fbGFzdFN0YWNrVG9w IDwgdG9wT2ZTdGFjaygpKSB7CkluZGV4OiBTb3VyY2UvV1RGL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNpb24gMTc3OTY3KQorKysgU291cmNlL1dU Ri9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxNS0wMS0wNiAg QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBBRERSRVNTX1NB TklUSVpFUiBtYWNybyBpcyBvdmVybG9hZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAxMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Db21waWxlci5oOiBBZGRlZCBhbiBBU0FOX0VOQUJM RUQgbWFjcm8uIFRoZSBhYmJyZXZpYXRpb24gc2hvdWxkIGJlY29tZSB3ZWxsCisgICAgICAgIGtu b3duIC0gd2UgYWxyZWFkeSB1c2UgaXQgaW4gdG9vbHMuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0 aW9ucy5oOgorICAgICAgICAqIHd0Zi9SZWZDb3VudGVkLmg6CisgICAgICAgICogd3RmL1NpemVM aW1pdHMuY3BwOgorICAgICAgICBDaGFuZ2UgdGhlIGNvbmRpdGlvbmFsIHRvIEVOQUJMRShTRUNV UklUWV9BU1NFUlRJT05TKS4gVGhlc2UgY2hlY2tzIHdpbGwgYmUgdXNlZAorICAgICAgICBpbiBk ZWJ1ZyBidWlsZHMsIGFuZCBhbHNvIHdoZW4gb25lIGV4cGxpY2l0bHkgcGFzc2VzIC1ERU5BQkxF X1NFQ1VSSVRZX0FTU0VSVElPTlMuCisKIDIwMTUtMDEtMDUgIEFuZHJlYXMgS2xpbmcgIDxha2xp bmdAYXBwbGUuY29tPgogCiAgICAgICAgIFB1cmdlIFBhc3NSZWZQdHIgZnJvbSBQYWdlLgpJbmRl eDogU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYv d3RmL0Fzc2VydGlvbnMuaAkocmV2aXNpb24gMTc3OTIyKQorKysgU291cmNlL1dURi93dGYvQXNz ZXJ0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMTMsNyArMjEzLDcgQEAgZXh0ZXJuICJDIiB7 CiAKICNkZWZpbmUgQVNTRVJUX1VOVVNFRCh2YXJpYWJsZSwgYXNzZXJ0aW9uKSAoKHZvaWQpdmFy aWFibGUpCiAKLSNpZmRlZiBBRERSRVNTX1NBTklUSVpFUgorI2lmIEVOQUJMRShTRUNVUklUWV9B U1NFUlRJT05TKQogI2RlZmluZSBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihhc3Nl cnRpb24pIFwKICAgICAoIShhc3NlcnRpb24pID8gXAogICAgICAgICAoV1RGUmVwb3J0QXNzZXJ0 aW9uRmFpbHVyZShfX0ZJTEVfXywgX19MSU5FX18sIFdURl9QUkVUVFlfRlVOQ1RJT04sICNhc3Nl cnRpb24pLCBcCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgJKHJldmlzaW9uIDE3NzkyMikKKysrIFNvdXJjZS9X VEYvd3RmL0NvbXBpbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEzNiw2ICsxMzYsMTIgQEAKICNk ZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0VBQkkgMQogI2VuZGlmCiAKKyNpZiBkZWZpbmVk KF9faGFzX2ZlYXR1cmUpCisjZGVmaW5lIEFTQU5fRU5BQkxFRCBfX2hhc19mZWF0dXJlKGFkZHJl c3Nfc2FuaXRpemVyKQorI2Vsc2UKKyNkZWZpbmUgQVNBTl9FTkFCTEVEIGZhbHNlCisjZW5kaWYK KwogLyogPT09PSBDb21waWxlci1pbmRlcGVuZGVudCBtYWNyb3MgZm9yIHZhcmlvdXMgY29tcGls ZXIgZmVhdHVyZXMsIGluIGFscGhhYmV0aWNhbCBvcmRlciA9PT09ICovCiAKIC8qIEFMV0FZU19J TkxJTkUgKi8KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1JlZkNvdW50ZWQuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV1RGL3d0Zi9SZWZDb3VudGVkLmgJKHJldmlzaW9uIDE3NzkyMikKKysrIFNvdXJj ZS9XVEYvd3RmL1JlZkNvdW50ZWQuaAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsNyBAQAog CiBuYW1lc3BhY2UgV1RGIHsKIAotI2lmIGRlZmluZWQoTkRFQlVHKSAmJiAhZGVmaW5lZChBRERS RVNTX1NBTklUSVpFUikKKyNpZiBkZWZpbmVkKE5ERUJVRykgJiYgIUVOQUJMRShTRUNVUklUWV9B U1NFUlRJT05TKQogI2RlZmluZSBDSEVDS19SRUZfQ09VTlRFRF9MSUZFQ1lDTEUgMAogI2Vsc2UK ICNkZWZpbmUgQ0hFQ0tfUkVGX0NPVU5URURfTElGRUNZQ0xFIDEKSW5kZXg6IFNvdXJjZS9XVEYv d3RmL1NpemVMaW1pdHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1NpemVMaW1p dHMuY3BwCShyZXZpc2lvbiAxNzc5MjIpCisrKyBTb3VyY2UvV1RGL3d0Zi9TaXplTGltaXRzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDEsNyArNDEsNyBAQAogCiBuYW1lc3BhY2UgV1RGIHsKIAot I2lmICFkZWZpbmVkKE5ERUJVRykgfHwgZGVmaW5lZChBRERSRVNTX1NBTklUSVpFUikKKyNpZiAh ZGVmaW5lZChOREVCVUcpIHx8IEVOQUJMRShTRUNVUklUWV9BU1NFUlRJT05TKQogc3RydWN0IFNh bWVTaXplQXNSZWZDb3VudGVkIHsKICAgICBpbnQgYTsKICAgICBib29sIGI7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiAxNzc5NjcpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wMS0wNiAgQWxleGV5IFByb3NrdXJ5YWtv diAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBBRERSRVNTX1NBTklUSVpFUiBtYWNybyBpcyBv dmVybG9hZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDAxMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL1JlZkNvdW50ZWRTdXBwbGVtZW50Lmg6CisgICAgICAgICogcGxhdGZvcm0v U3VwcGxlbWVudGFibGUuaDoKKyAgICAgICAgQ2hhbmdlIHRoZSBjb25kaXRpb25hbCB0byBFTkFC TEUoU0VDVVJJVFlfQVNTRVJUSU9OUykuIFRoZXNlIGNoZWNrcyB3aWxsIGJlIHVzZWQKKyAgICAg ICAgaW4gZGVidWcgYnVpbGRzLCBhbmQgYWxzbyB3aGVuIG9uZSBleHBsaWNpdGx5IHBhc3NlcyAt REVOQUJMRV9TRUNVUklUWV9BU1NFUlRJT05TLgorCiAyMDE1LTAxLTA2ICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIG5vdyB1bnVzZWQgSW5k ZXhlZERCIGNvZGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1JlZkNvdW50ZWRTdXBw bGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUmVmQ291bnRl ZFN1cHBsZW1lbnQuaAkocmV2aXNpb24gMTc3OTIyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vUmVmQ291bnRlZFN1cHBsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDQsNyArNDQsNyBA QCBwdWJsaWM6CiAgICAgcHVibGljOgogICAgICAgICBleHBsaWNpdCBXcmFwcGVyKFBhc3NSZWZQ dHI8VGhpc1R5cGU+IHdyYXBwZWQpIDogbV93cmFwcGVkKHdyYXBwZWQpIHsgfQogICAgICAgICB2 aXJ0dWFsIH5XcmFwcGVyKCkgeyBtX3dyYXBwZWQtPmhvc3REZXN0cm95ZWQoKTsgIH0KLSNpZiAh QVNTRVJUX0RJU0FCTEVEIHx8IGRlZmluZWQoQUREUkVTU19TQU5JVElaRVIpCisjaWYgIUFTU0VS VF9ESVNBQkxFRCB8fCBFTkFCTEUoU0VDVVJJVFlfQVNTRVJUSU9OUykKICAgICAgICAgdmlydHVh bCBib29sIGlzUmVmQ291bnRlZFdyYXBwZXIoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVl OyB9CiAjZW5kaWYKICAgICAgICAgVGhpc1R5cGUqIHdyYXBwZWQoKSBjb25zdCB7IHJldHVybiBt X3dyYXBwZWQuZ2V0KCk7IH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1N1cHBsZW1l bnRhYmxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU3VwcGxlbWVu dGFibGUuaAkocmV2aXNpb24gMTc3OTIyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU3Vw cGxlbWVudGFibGUuaAkod29ya2luZyBjb3B5KQpAQCAtNzksNyArNzksNyBAQCB0ZW1wbGF0ZTx0 eXBlbmFtZSBUPgogY2xhc3MgU3VwcGxlbWVudCB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB+U3Vw cGxlbWVudCgpIHsgfQotI2lmICFBU1NFUlRfRElTQUJMRUQgfHwgZGVmaW5lZChBRERSRVNTX1NB TklUSVpFUikKKyNpZiAhQVNTRVJUX0RJU0FCTEVEIHx8IEVOQUJMRShTRUNVUklUWV9BU1NFUlRJ T05TKQogICAgIHZpcnR1YWwgYm9vbCBpc1JlZkNvdW50ZWRXcmFwcGVyKCkgY29uc3QgeyByZXR1 cm4gZmFsc2U7IH0KICNlbmRpZgogCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzc5NjcpCisrKyBUb29scy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxNS0wMS0wNiAgQWxleGV5IFByb3Nr dXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBBRERSRVNTX1NBTklUSVpFUiBtYWNy byBpcyBvdmVybG9hZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDAxMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwOiBVc2UgdGhlIG5l dyBtYWNyby4KKwogMjAxNS0wMS0wNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSBzb21lIHN0YWxlIGNsYXNzIG5hbWVzIGluIGNoZWNrLWZv ci1pbmFwcHJvcHJpYXRlLW9iamMtY2xhc3MtbmFtZXMKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxNzc5MjIpCisrKyBUb29scy9XZWJL aXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzAsMTUg KzcwLDExIEBAIGNvbnN0IHVuc2lnbmVkIFRlc3RDb250cm9sbGVyOjp2aWV3SGVpZ2gKIGNvbnN0 IHVuc2lnbmVkIFRlc3RDb250cm9sbGVyOjp3M2NTVkdWaWV3V2lkdGggPSA0ODA7CiBjb25zdCB1 bnNpZ25lZCBUZXN0Q29udHJvbGxlcjo6dzNjU1ZHVmlld0hlaWdodCA9IDM2MDsKIAotI2lmIGRl ZmluZWQoX19oYXNfZmVhdHVyZSkKLSNpZiBfX2hhc19mZWF0dXJlKGFkZHJlc3Nfc2FuaXRpemVy KQorI2lmIEFTQU5fRU5BQkxFRAogY29uc3QgZG91YmxlIFRlc3RDb250cm9sbGVyOjpzaG9ydFRp bWVvdXQgPSAxMC4wOwogI2Vsc2UKIGNvbnN0IGRvdWJsZSBUZXN0Q29udHJvbGxlcjo6c2hvcnRU aW1lb3V0ID0gNS4wOwogI2VuZGlmCi0jZWxzZQotY29uc3QgZG91YmxlIFRlc3RDb250cm9sbGVy OjpzaG9ydFRpbWVvdXQgPSA1LjA7Ci0jZW5kaWYKIAogY29uc3QgZG91YmxlIFRlc3RDb250cm9s bGVyOjpub1RpbWVvdXQgPSAtMTsKIAo=