140118 2015-01-06 02:15:25 -0800 Fix Unused parameter warning in Webcore bindings 2015-01-06 03:59:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140105 1 shiva.jm webkit-unassigned ap commit-queue darin gyuyoung.kim kling ossy oldest_to_newest 1058943 0 shiva.jm 2015-01-06 02:15:25 -0800 Got build warning error for efl port. might caused by issue: https://bugs.webkit.org/show_bug.cgi?id=140105 ../../Source/WebCore/bindings/js/ScriptController.cpp:408:37: warning: unused parameter ‘widget’ [-Wunused-parameter] PassRefPtr<JSC::Bindings::Instance> ScriptController::createScriptInstanceForWidget(Widget* widget) ^ 1058944 1 244042 shiva.jm 2015-01-06 02:21:13 -0800 Created attachment 244042 Patch remove the Unused parameter from createScriptInstanceForWidget() function. 1058949 2 244042 gyuyoung.kim 2015-01-06 02:30:09 -0800 Comment on attachment 244042 Patch LGTM 1058957 3 244042 commit-queue 2015-01-06 03:10:07 -0800 Comment on attachment 244042 Patch Clearing flags on attachment: 244042 Committed r177954: <http://trac.webkit.org/changeset/177954> 1058958 4 commit-queue 2015-01-06 03:10:12 -0800 All reviewed patches have been landed. Closing bug. 1058959 5 244042 pnormand 2015-01-06 03:21:10 -0800 Comment on attachment 244042 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244042&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=140046 Wrong bug ID... 1058965 6 ossy 2015-01-06 03:30:04 -0800 *** Bug 140120 has been marked as a duplicate of this bug. *** 1058968 7 ossy 2015-01-06 03:34:39 -0800 (In reply to comment #5) > Comment on attachment 244042 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244042&action=review > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=140046 > > Wrong bug ID... I filed a new bug report to fix the CQ not to land patches with this kind of problems: bug140122 1058973 8 shiva.jm 2015-01-06 03:46:34 -0800 Update the changelog in patch: https://bugs.webkit.org/show_bug.cgi?id=140121 1058982 9 gyuyoung.kim 2015-01-06 03:59:53 -0800 Committed r177956: <http://trac.webkit.org/changeset/177956> 244042 2015-01-06 02:21:13 -0800 2015-01-06 03:10:07 -0800 Patch bug-140118.patch text/plain 1349 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Nzk1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAxLTA2ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IFVudXNlZCBwYXJh bWV0ZXIgd2FybmluZyBpbiBXZWJjb3JlIGJpbmRpbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcmVtb3ZlIHRoZSBVbnVzZWQgcGFyYW1ldGVyIGZy b20gY3JlYXRlU2NyaXB0SW5zdGFuY2VGb3JXaWRnZXQoKSBmdW5jdGlvbgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlZC4KKworICAgICAgICAqIGJpbmRpbmdzL2pz L1NjcmlwdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0Q29udHJvbGxl cjo6Y3JlYXRlU2NyaXB0SW5zdGFuY2VGb3JXaWRnZXQpOgorCiAyMDE1LTAxLTA1ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBNb2Rlcm5pemUgYW5kIHN0cmVhbWxp bmUgSFRNTFRva2VuIGFuZCBBdG9taWNIVE1MVG9rZW4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxNzc5NDUpCisr KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDA1LDcgKzQwNSw3IEBAIE5QT2JqZWN0KiBTY3JpcHRDb250cm9sbGVyOjpj cmVhdGVTY3JpcHQKICNlbmRpZgogCiAjaWYgIVBMQVRGT1JNKENPQ09BKQotUGFzc1JlZlB0cjxK U0M6OkJpbmRpbmdzOjpJbnN0YW5jZT4gU2NyaXB0Q29udHJvbGxlcjo6Y3JlYXRlU2NyaXB0SW5z dGFuY2VGb3JXaWRnZXQoV2lkZ2V0KiB3aWRnZXQpCitQYXNzUmVmUHRyPEpTQzo6QmluZGluZ3M6 Okluc3RhbmNlPiBTY3JpcHRDb250cm9sbGVyOjpjcmVhdGVTY3JpcHRJbnN0YW5jZUZvcldpZGdl dChXaWRnZXQqKQogewogICAgIHJldHVybiBudWxscHRyOwogfQo=