140117 2015-01-06 02:13:40 -0800 [GStreamer][MSE] wrong duration computing 2015-12-09 00:12:51 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED LATER P2 Normal --- 1 pnormand webkit-unassigned cgarcia pnormand slomo zan oldest_to_newest 1058942 0 pnormand 2015-01-06 02:13:40 -0800 MediaSourceClientGStreamer::durationChanged() should use MediaTime::toFloat() 1058952 1 244044 pnormand 2015-01-06 02:52:43 -0800 Created attachment 244044 patch 1058979 2 244044 slomo 2015-01-06 03:56:41 -0800 Comment on attachment 244044 patch View in context: https://bugs.webkit.org/attachment.cgi?id=244044&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:357 > + GstClockTime gstDuration = duration.toFloat() * GST_SECOND; Why? What is the timeValue and timeScale for the durations here? By going through floats you'll lose some precision here 1058983 3 pnormand 2015-01-06 04:03:13 -0800 timeValue: 4645885228097732608 scale: 10000000 1058984 4 pnormand 2015-01-06 04:04:14 -0800 Duration calculated for the same video with the patch: 0:06:48.999985152 1059393 5 slomo 2015-01-07 08:17:26 -0800 That seems like a bug elsewhere then, or I misunderstand the API of MediaTime :) 1059856 6 244269 pnormand 2015-01-08 09:58:48 -0800 Created attachment 244269 patch 1147612 7 pnormand 2015-12-09 00:12:51 -0800 This isn't going to apply to the reworked MSE backend. 244044 2015-01-06 02:52:43 -0800 2015-01-08 09:58:48 -0800 patch patch.patch text/plain 2176 pnormand RnJvbSBlMTE3YjhiZjZhOTNhY2RjMDJmYzIwMmU2NjM3ODU5M2I2NDMyMjdjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDYgSmFuIDIwMTUgMTE6NDc6MzkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw YXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgMTQgKysrKysrKysrKysrKysKIC4uLi9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwICAgICAgfCAgNSArKysrLQogMiBmaWxlcyBj aGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDIz NzgxOTEuLjYwMzY2MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNS0wMS0wNiAg UGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJl YW1lcl1bTVNFXSB3cm9uZyBkdXJhdGlvbiBjb21wdXRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDExNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIFlvdXR1YmUgVFYgYXQgbGVhc3QgdGhlIGN1 cnJlbnQgYXBwcm9hY2ggb2Ygc2NhbGluZyB0aGUKKyAgICAgICAgZHVyYXRpb24gdmFsdWUgbGVh ZHMgdG8gYW4gaW52YWxpZCBkdXJhdGlvbi4gQ29udmVydGluZyB0byBhIGZsb2F0CisgICAgICAg IHZhbHVlIHdvcmtzIHRob3VnaC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRNZWRpYVNvdXJjZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpN ZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lcjo6ZHVyYXRpb25DaGFuZ2VkKToKKwogMjAxNS0wMS0w NSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9kZXJuaXplIGFu ZCBzdHJlYW1saW5lIEhUTUxUb2tlbiBhbmQgQXRvbWljSFRNTFRva2VuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0TWVkaWFTb3Vy Y2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL1dlYktpdE1lZGlhU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCA3NGE3MDc2Li5mZDUzZjY0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRNZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAKQEAg LTM1MCw4ICszNTAsMTEgQEAgTWVkaWFTb3VyY2VQcml2YXRlOjpBZGRTdGF0dXMgTWVkaWFTb3Vy Y2VDbGllbnRHU3RyZWFtZXI6OmFkZFNvdXJjZUJ1ZmZlcihQYXNzUmUKIAogdm9pZCBNZWRpYVNv dXJjZUNsaWVudEdTdHJlYW1lcjo6ZHVyYXRpb25DaGFuZ2VkKGNvbnN0IE1lZGlhVGltZSYgZHVy YXRpb24pCiB7CisgICAgaWYgKCFkdXJhdGlvbi5pc1ZhbGlkKCkgfHwgZHVyYXRpb24uaXNQb3Np dGl2ZUluZmluaXRlKCkgfHwgZHVyYXRpb24uaXNOZWdhdGl2ZUluZmluaXRlKCkpCisgICAgICAg IHJldHVybjsKKwogICAgIFdlYktpdE1lZGlhU3JjUHJpdmF0ZSogcHJpdiA9IG1fc3JjLT5wcml2 OwotICAgIEdzdENsb2NrVGltZSBnc3REdXJhdGlvbiA9IGdzdF91dGlsX3VpbnQ2NF9zY2FsZShk dXJhdGlvbi50aW1lVmFsdWUoKSwgR1NUX1NFQ09ORCwgZHVyYXRpb24udGltZVNjYWxlKCkpOwor ICAgIEdzdENsb2NrVGltZSBnc3REdXJhdGlvbiA9IGR1cmF0aW9uLnRvRmxvYXQoKSAqIEdTVF9T RUNPTkQ7CiAKICAgICBHU1RfREVCVUdfT0JKRUNUKG1fc3JjLmdldCgpLCAiUmVjZWl2ZWQgZHVy YXRpb246ICUiIEdTVF9USU1FX0ZPUk1BVCwgR1NUX1RJTUVfQVJHUyhnc3REdXJhdGlvbikpOwog Ci0tIAoyLjEuMw== 244269 2015-01-08 09:58:48 -0800 2015-12-09 00:12:02 -0800 patch patch.patch text/plain 2362 pnormand RnJvbSBkMmMzYjdiY2E1MWQ3MGI4YmVmMGRjODhhODk4YWYwMzcwZmQ1ZmNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDYgSmFuIDIwMTUgMTE6NDc6MzkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw YXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgMTQgKysrKysrKysrKysrKysKIC4uLi9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwICAgICAgfCAgOSArKysrKysrKy0KIDIgZmls ZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBhYWUwYzEzLi44MTZhZWEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUtMDEt MDYgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtH U3RyZWFtZXJdW01TRV0gd3JvbmcgZHVyYXRpb24gY29tcHV0aW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAxMTcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbiBZb3V0dWJlIFRWIGF0IGxlYXN0IHRo ZSBjdXJyZW50IGFwcHJvYWNoIG9mIHNjYWxpbmcgdGhlCisgICAgICAgIGR1cmF0aW9uIHZhbHVl IGxlYWRzIHRvIGFuIGludmFsaWQgZHVyYXRpb24uIENvbnZlcnRpbmcgdG8gYSBmbG9hdAorICAg ICAgICB2YWx1ZSB3b3JrcyB0aG91Z2guCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXI6OmR1cmF0aW9uQ2hhbmdlZCk6CisKIDIwMTUt MDEtMDggIEd3YW5nIFlvb24gSHdhbmcgIDx5b29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S10gU2VwZXJhdGUgdXBkYXRlQmFja2luZ1N0b3JlIGZyb20gZmx1c2hDb21wb3NpdGluZ1N0YXRl LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L1dlYktpdE1lZGlhU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRNZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXgg NzRhNzA3Ni4uZGNkMjQ2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL1dlYktpdE1lZGlhU291cmNlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0TWVkaWFTb3VyY2VH U3RyZWFtZXIuY3BwCkBAIC0zNTAsOCArMzUwLDE1IEBAIE1lZGlhU291cmNlUHJpdmF0ZTo6QWRk U3RhdHVzIE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyOjphZGRTb3VyY2VCdWZmZXIoUGFzc1Jl CiAKIHZvaWQgTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXI6OmR1cmF0aW9uQ2hhbmdlZChjb25z dCBNZWRpYVRpbWUmIGR1cmF0aW9uKQogeworICAgIGlmICghZHVyYXRpb24uaXNWYWxpZCgpIHx8 IGR1cmF0aW9uLmlzUG9zaXRpdmVJbmZpbml0ZSgpIHx8IGR1cmF0aW9uLmlzTmVnYXRpdmVJbmZp bml0ZSgpKQorICAgICAgICByZXR1cm47CisKICAgICBXZWJLaXRNZWRpYVNyY1ByaXZhdGUqIHBy aXYgPSBtX3NyYy0+cHJpdjsKLSAgICBHc3RDbG9ja1RpbWUgZ3N0RHVyYXRpb24gPSBnc3RfdXRp bF91aW50NjRfc2NhbGUoZHVyYXRpb24udGltZVZhbHVlKCksIEdTVF9TRUNPTkQsIGR1cmF0aW9u LnRpbWVTY2FsZSgpKTsKKyAgICBHc3RDbG9ja1RpbWUgZ3N0RHVyYXRpb247CisgICAgaWYgKGR1 cmF0aW9uLmhhc0RvdWJsZVZhbHVlKCkpCisgICAgICAgIGdzdER1cmF0aW9uID0gZHVyYXRpb24u dG9GbG9hdCgpICogR1NUX1NFQ09ORDsKKyAgICBlbHNlCisgICAgICAgIGdzdER1cmF0aW9uID0g Z3N0X3V0aWxfdWludDY0X3NjYWxlKGR1cmF0aW9uLnRpbWVWYWx1ZSgpLCBHU1RfU0VDT05ELCBk dXJhdGlvbi50aW1lU2NhbGUoKSk7CiAKICAgICBHU1RfREVCVUdfT0JKRUNUKG1fc3JjLmdldCgp LCAiUmVjZWl2ZWQgZHVyYXRpb246ICUiIEdTVF9USU1FX0ZPUk1BVCwgR1NUX1RJTUVfQVJHUyhn c3REdXJhdGlvbikpOwogCi0tIAoyLjEuMw==