140113 2015-01-05 23:14:03 -0800 Make explicit which TextIndicator animations are driven manually, and which run automatically 2015-01-06 11:10:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca bdakin webkit-bug-importer oldest_to_newest 1058919 0 thorton 2015-01-05 23:14:03 -0800 Make explicit which TextIndicator animations are driven manually, and which run automatically 1058920 1 webkit-bug-importer 2015-01-05 23:14:43 -0800 <rdar://problem/19383425> 1058921 2 webkit-bug-importer 2015-01-05 23:14:47 -0800 <rdar://problem/19383427> 1058922 3 244035 thorton 2015-01-05 23:16:09 -0800 Created attachment 244035 Patch 1058938 4 244035 darin 2015-01-06 01:45:03 -0800 Comment on attachment 244035 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244035&action=review > Source/WebCore/page/TextIndicator.cpp:262 > + return false; I think we should have ASSERT_NOT_REACHED here. 1059068 5 thorton 2015-01-06 11:10:27 -0800 http://trac.webkit.org/changeset/177970 244035 2015-01-05 23:16:09 -0800 2015-01-06 01:45:03 -0800 Patch bug-140113-20150105231612.patch text/plain 5960 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3OTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjczM2U3NjhkZjcxMDM1 ZDk4YzkxYjE2ZjkzZDdmNGRmNDExM2QzYy4uZTI1NWM1NTE4YzE1MWM4OWRhOGFkZjEwMTFmOWNl MmU4OGVhZTYyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTAxLTA1ICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIGV4 cGxpY2l0IHdoaWNoIFRleHRJbmRpY2F0b3IgYW5pbWF0aW9ucyBhcmUgZHJpdmVuIG1hbnVhbGx5 LCBhbmQgd2hpY2ggcnVuIGF1dG9tYXRpY2FsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDExMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTkz ODM0MjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwYWdlL1RleHRJbmRpY2F0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dEluZGljYXRv cjo6d2FudHNNYW51YWxBbmltYXRpb24pOgorICAgICAgICBBZGQgd2FudHNNYW51YWxBbmltYXRp b24oKS4gVGhlIG9sZCB0cmFuc2l0aW9ucyAoQm91bmNlIGFuZCBCb3VuY2VBbmRDcm9zc2ZhZGUp CisgICAgICAgIHJ1biBhdXRvbWF0aWNhbGx5LCBhbmQgdGhlIG5ldyBvbmVzIChGYWRlSW4gYW5k IENyb3NzZmFkZSkgYXJlIGRyaXZlbiBtYW51YWxseS4KKworICAgICAgICAqIHBhZ2UvVGV4dElu ZGljYXRvci5oOgorICAgICAgICBBZGQgYSBjb21tZW50IGV4cGxhaW5pbmcgd2hpY2ggYW5pbWF0 aW9ucyBhcmUgbWFudWFsIGFuZCB3aGljaCBhcmUgbm90LgorCisgICAgICAgICogcGFnZS9tYWMv VGV4dEluZGljYXRvcldpbmRvdy5tbToKKyAgICAgICAgKC1bV2ViVGV4dEluZGljYXRvclZpZXcg cHJlc2VudF0pOgorICAgICAgICBNYWtlIHVzZSBvZiB3YW50c01hbnVhbEFuaW1hdGlvbigpLiBU aGUgcHJldmlvdXMgKHdhbnRzRmFkZUluIHx8IHdhbnRzQ3Jvc3NmYWRlKQorICAgICAgICB3YXMg d3JvbmcsIGJlY2F1c2UgaXQgd2FzIHRydWUgZm9yIEJvdW5jZUFuZENyb3NzZmFkZSwgYW5kIHdv dWxkIGNhdXNlCisgICAgICAgIEJvdW5jZUFuZENyb3NzZmFkZSBhbmltYXRpb25zICh3aGljaCBh cmVuJ3QgZHJpdmVuIG1hbnVhbGx5KSB0byBzdGFsbCBhdCBwcm9ncmVzcz0wLgorCiAyMDE1LTAx LTA1ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBQdXJnZSBQ YXNzUmVmUHRyIGZyb20gUGFnZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBkOWYzYTgwODQ1ZDViZTFlMjZkNzA1 MGIzYTg3MzQwNTQ1MzFiMjRlLi5kMzE5NzU5ZWFhY2U5Y2JiYzhkMzg4NTgxODZhMTNhZGQ0NzQz MWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTUtMDEtMDUgIFRpbW90aHkgSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCisgICAgICAgIE1ha2UgZXhwbGljaXQg d2hpY2ggVGV4dEluZGljYXRvciBhbmltYXRpb25zIGFyZSBkcml2ZW4gbWFudWFsbHksIGFuZCB3 aGljaCBydW4gYXV0b21hdGljYWxseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQwMTEzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xOTM4MzQyNT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9tYWMvUGFnZUNsaWVudEltcGwubW06CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJ bXBsOjpkaWRQZXJmb3JtRGljdGlvbmFyeUxvb2t1cCk6CisgICAgICAgIERlbGV0ZSBhbiBpbmFj Y3VyYXRlIGNvbW1lbnQuCisKKzIwMTUtMDEtMDUgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9o b3J0b25AYXBwbGUuY29tPgorCiAgICAgICAgIEltcGxpY2l0bHkgZGlzbWlzc2VkIEREIHBvcG92 ZXJzIGRvbid0IGNsZWFyIGltbWVkaWF0ZSBhY3Rpb24gc3RhdGUsIHByZW1hdHVyZWx5IGRpc21p c3NpbmcgdGhlIG5leHQgREQgaGlnaGxpZ2h0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAwODgKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE5Mjk4 MzkxPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9UZXh0SW5kaWNhdG9yLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvVGV4dEluZGljYXRvci5jcHAKaW5kZXggMzYyYjljNDQzYTFh ODYxNDY0ZjZkMmE1YTk3ZDM2MGExMDk0ZjRjMC4uNDVkMDhhNGE1Y2MzOGQ5NGFkZGQ1NzU2ZjBi OWRlMGNiZTk0YjkwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9UZXh0SW5kaWNh dG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1RleHRJbmRpY2F0b3IuY3BwCkBAIC0y NDYsNCArMjQ2LDIwIEBAIGJvb2wgVGV4dEluZGljYXRvcjo6d2FudHNGYWRlSW4oKSBjb25zdAog ICAgIHJldHVybiBmYWxzZTsKIH0KIAorYm9vbCBUZXh0SW5kaWNhdG9yOjp3YW50c01hbnVhbEFu aW1hdGlvbigpIGNvbnN0Cit7CisgICAgc3dpdGNoIChtX2RhdGEucHJlc2VudGF0aW9uVHJhbnNp dGlvbikgeworICAgIGNhc2UgVGV4dEluZGljYXRvclByZXNlbnRhdGlvblRyYW5zaXRpb246OkZh ZGVJbjoKKyAgICBjYXNlIFRleHRJbmRpY2F0b3JQcmVzZW50YXRpb25UcmFuc2l0aW9uOjpDcm9z c2ZhZGU6CisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgY2FzZSBUZXh0SW5kaWNhdG9yUHJl c2VudGF0aW9uVHJhbnNpdGlvbjo6Qm91bmNlOgorICAgIGNhc2UgVGV4dEluZGljYXRvclByZXNl bnRhdGlvblRyYW5zaXRpb246OkJvdW5jZUFuZENyb3NzZmFkZToKKyAgICBjYXNlIFRleHRJbmRp Y2F0b3JQcmVzZW50YXRpb25UcmFuc2l0aW9uOjpOb25lOgorICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgfQorCisgICAgcmV0dXJuIGZhbHNlOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1RleHRJbmRpY2F0b3IuaCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvVGV4dEluZGljYXRvci5oCmluZGV4IDA4NDRiZDU1MWI1ZWRhNmU4ODU3 ZWE2OGUwMTcxZjEwMmY3ODFkZDkuLjRlYTE5N2RiYWEzZmM5ZTI2Y2MzM2JmYTUyMDMxMDM5Njg1 YWEwNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVGV4dEluZGljYXRvci5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVGV4dEluZGljYXRvci5oCkBAIC00Niw4ICs0NiwxMiBA QCBjbGFzcyBSYW5nZTsKIAogZW51bSBjbGFzcyBUZXh0SW5kaWNhdG9yUHJlc2VudGF0aW9uVHJh bnNpdGlvbiB7CiAgICAgTm9uZSwKKworICAgIC8vIFRoZXNlIGFuaW1hdGlvbnMgZHJpdmUgdGhl bXNlbHZlcy4KICAgICBCb3VuY2UsCiAgICAgQm91bmNlQW5kQ3Jvc3NmYWRlLAorCisgICAgLy8g VGhlc2UgYW5pbWF0aW9ucyBuZWVkIHRvIGJlIGRyaXZlbiBtYW51YWxseSB2aWEgVGV4dEluZGlj YXRvcldpbmRvdzo6c2V0QW5pbWF0aW9uUHJvZ3Jlc3MuCiAgICAgRmFkZUluLAogICAgIENyb3Nz ZmFkZQogfTsKQEAgLTg1LDYgKzg5LDcgQEAgcHVibGljOgogICAgIGJvb2wgd2FudHNCb3VuY2Uo KSBjb25zdDsKICAgICBib29sIHdhbnRzQ29udGVudENyb3NzZmFkZSgpIGNvbnN0OwogICAgIGJv b2wgd2FudHNGYWRlSW4oKSBjb25zdDsKKyAgICBib29sIHdhbnRzTWFudWFsQW5pbWF0aW9uKCkg Y29uc3Q7CiAKIHByaXZhdGU6CiAgICAgVGV4dEluZGljYXRvcihjb25zdCBUZXh0SW5kaWNhdG9y RGF0YSYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9tYWMvVGV4dEluZGljYXRv cldpbmRvdy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL1RleHRJbmRpY2F0b3JXaW5kb3cu bW0KaW5kZXggNDc4YWI0ZGNmOTM4MWQ4N2ZjMDljM2U0ZGE1YTU3Nzg1ZTE3OGU3Ni4uYjRhNzc4 NGM3MzdmODI5Njc2ZWJhNzZiNWUxODY5ZTlmYmE5M2Y5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9tYWMvVGV4dEluZGljYXRvcldpbmRvdy5tbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL21hYy9UZXh0SW5kaWNhdG9yV2luZG93Lm1tCkBAIC0yNzUsNyArMjc1LDcgQEAgc3Rh dGljIFJldGFpblB0cjxDQUJhc2ljQW5pbWF0aW9uPiBjcmVhdGVGYWRlSW5BbmltYXRpb24oQ0ZU aW1lSW50ZXJ2YWwgZHVyYXRpb24KIAogICAgIFtDQVRyYW5zYWN0aW9uIGJlZ2luXTsKICAgICBm b3IgKENBTGF5ZXIgKmJvdW5jZUxheWVyIGluIF9ib3VuY2VMYXllcnMuZ2V0KCkpIHsKLSAgICAg ICAgaWYgKHdhbnRzRmFkZUluIHx8IHdhbnRzQ3Jvc3NmYWRlKQorICAgICAgICBpZiAoX3RleHRJ bmRpY2F0b3ItPndhbnRzTWFudWFsQW5pbWF0aW9uKCkpCiAgICAgICAgICAgICBib3VuY2VMYXll ci5zcGVlZCA9IDA7CiAKICAgICAgICAgaWYgKCF3YW50c0ZhZGVJbikKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGwubW0gYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCmluZGV4IGVmOWU4YjMwZTQ1Yjc4 MzllMjRmMjk1NzMyZDdlMDg5NDRiNWY4YzMuLjg4YWJkNGY0OTRkMzRhNjQyMjIyYjdjN2NmNjll MTEyMzkzNjZlMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUGFn ZUNsaWVudEltcGwubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9QYWdlQ2xp ZW50SW1wbC5tbQpAQCAtNTY5LDkgKzU2OSw2IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OmRpZFBl cmZvcm1EaWN0aW9uYXJ5TG9va3VwKGNvbnN0IERpY3Rpb25hcnlQb3B1cEluZm8mIGRpY3RpCiAg ICAgUmV0YWluUHRyPE5TTXV0YWJsZURpY3Rpb25hcnk+IG11dGFibGVPcHRpb25zID0gYWRvcHRO UyhbKE5TRGljdGlvbmFyeSAqKWRpY3Rpb25hcnlQb3B1cEluZm8ub3B0aW9ucy5nZXQoKSBtdXRh YmxlQ29weV0pOwogCiAgICAgaWYgKGNhbkxvYWRMVVRlcm1PcHRpb25EaXNhYmxlU2VhcmNoVGVy bUluZGljYXRvcigpICYmIGRpY3Rpb25hcnlQb3B1cEluZm8udGV4dEluZGljYXRvci5jb250ZW50 SW1hZ2UpIHsKLSAgICAgICAgLy8gUnVuIHRoZSBhbmltYXRpb25zIHNlcmlhbGx5IGJlY2F1c2Ug YXR0YWNoaW5nIGFub3RoZXIgc3Vid2luZG93IGJyZWFrcyB0aGUgYm91bmNlIGFuaW1hdGlvbi4K LSAgICAgICAgLy8gV2UgY291bGQgY29uc2lkZXIgbWFraW5nIHRoZSBib3VuY2UgTlNBbmltYXRp b25Ob25ibG9ja2luZ1RocmVhZGVkIGluc3RlYWQsIHdoaWNoIHNlZW1zCi0gICAgICAgIC8vIHRv IHdvcmssIGJ1dCBuZWVkIHRvIGNvbnNpZGVyIGFsbCBvZiB0aGUgaW1wbGljYXRpb25zLgogICAg ICAgICBbbV93a1ZpZXcgX3NldFRleHRJbmRpY2F0b3I6VGV4dEluZGljYXRvcjo6Y3JlYXRlKGRp Y3Rpb25hcnlQb3B1cEluZm8udGV4dEluZGljYXRvcikgZmFkZU91dDpOT107CiAgICAgICAgIFtt dXRhYmxlT3B0aW9ucyBzZXRPYmplY3Q6QFlFUyBmb3JLZXk6Z2V0TFVUZXJtT3B0aW9uRGlzYWJs ZVNlYXJjaFRlcm1JbmRpY2F0b3IoKV07CiAgICAgICAgIFtnZXRMVUxvb2t1cERlZmluaXRpb25N b2R1bGVDbGFzcygpIHNob3dEZWZpbml0aW9uRm9yVGVybTpkaWN0aW9uYXJ5UG9wdXBJbmZvLmF0 dHJpYnV0ZWRTdHJpbmcuc3RyaW5nLmdldCgpIGF0TG9jYXRpb246dGV4dEJhc2VsaW5lT3JpZ2lu IG9wdGlvbnM6bXV0YWJsZU9wdGlvbnMuZ2V0KCldOwo=