<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>140109</bug_id>
          
          <creation_ts>2015-01-05 18:05:45 -0800</creation_ts>
          <short_desc>Pack WebCore::RuleData better.</short_desc>
          <delta_ts>2015-01-06 17:39:11 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>REOPENED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>140159</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="Andreas Kling">kling</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1058879</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-01-05 18:05:45 -0800</bug_when>
    <thetext>We can save some memory by packing the members of RuleData better.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058881</commentid>
    <comment_count>1</comment_count>
      <attachid>244026</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-01-05 18:06:25 -0800</bug_when>
    <thetext>Created attachment 244026
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058882</commentid>
    <comment_count>2</comment_count>
      <attachid>244026</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2015-01-05 18:09:12 -0800</bug_when>
    <thetext>Comment on attachment 244026
Patch

It would be good to have a static_assert checking RuleData does not grow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1059134</commentid>
    <comment_count>3</comment_count>
      <attachid>244026</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-01-06 13:20:40 -0800</bug_when>
    <thetext>Comment on attachment 244026
Patch

Clearing flags on attachment: 244026

Committed r177988: &lt;http://trac.webkit.org/changeset/177988&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1059135</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-01-06 13:20:45 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1059240</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-01-06 17:39:11 -0800</bug_when>
    <thetext>Re-opened since this is blocked by bug 140159</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>244026</attachid>
            <date>2015-01-05 18:06:25 -0800</date>
            <delta_ts>2015-01-06 13:20:40 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-140109.diff</filename>
            <type>text/plain</type>
            <size>3155</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBmMjQ4N2ZhLi5hMDI4YTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg
QEAKIDIwMTUtMDEtMDUgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg
ICAgIFBhY2sgV2ViQ29yZTo6UnVsZURhdGEgYmV0dGVyLgorICAgICAgICA8aHR0cHM6Ly93ZWJr
aXQub3JnL2IvMTQwMTA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFNocmluayBSdWxlRGF0YSBieSA4IGJ5dGVzIHBlciBpbnN0YW5jZSBieSByZW9y
ZGVyaW5nIG1lbWJlcnMgc28gdGhhdAorICAgICAgICB0aGUgQ1NTIEpJVCBjb21waWxhdGlvbiBz
dGF0dXMgZml0cyBpbnRvIHRoZSBiaXRmaWVsZC4KKworICAgICAgICAqIGNzcy9SdWxlU2V0Lmg6
CisgICAgICAgIChXZWJDb3JlOjpSdWxlRGF0YTo6Y29tcGlsYXRpb25TdGF0dXMpOgorICAgICAg
ICAqIGNzc2ppdC9TZWxlY3RvckNvbXBpbGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3Rv
ckNvbXBpbGF0aW9uU3RhdHVzOjpTZWxlY3RvckNvbXBpbGF0aW9uU3RhdHVzKToKKworMjAxNS0w
MS0wNSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKICAgICAgICAgUHVyZ2Ug
UGFzc1JlZlB0ciBmcm9tIFNoYXJlZEJ1ZmZlci4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y
Zy9iLzE0MDA5OT4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVTZXQuaCBi
L1NvdXJjZS9XZWJDb3JlL2Nzcy9SdWxlU2V0LmgKaW5kZXggZTdkOGEwYi4uNTIzMjM0MSAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVTZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9jc3MvUnVsZVNldC5oCkBAIC04NCw3ICs4NCw3IEBAIHB1YmxpYzoKICAgICBjb25zdCB1bnNp
Z25lZCogZGVzY2VuZGFudFNlbGVjdG9ySWRlbnRpZmllckhhc2hlcygpIGNvbnN0IHsgcmV0dXJu
IG1fZGVzY2VuZGFudFNlbGVjdG9ySWRlbnRpZmllckhhc2hlczsgfQogCiAjaWYgRU5BQkxFKENT
U19TRUxFQ1RPUl9KSVQpCi0gICAgU2VsZWN0b3JDb21waWxhdGlvblN0YXR1cyBjb21waWxhdGlv
blN0YXR1cygpIGNvbnN0IHsgcmV0dXJuIG1fY29tcGlsYXRpb25TdGF0dXM7IH0KKyAgICBTZWxl
Y3RvckNvbXBpbGF0aW9uU3RhdHVzIGNvbXBpbGF0aW9uU3RhdHVzKCkgY29uc3QgeyByZXR1cm4g
U2VsZWN0b3JDb21waWxhdGlvblN0YXR1cyhtX2NvbXBpbGF0aW9uU3RhdHVzKTsgfQogICAgIEpT
Qzo6TWFjcm9Bc3NlbWJsZXJDb2RlUmVmIGNvbXBpbGVkU2VsZWN0b3JDb2RlUmVmKCkgY29uc3Qg
eyByZXR1cm4gbV9jb21waWxlZFNlbGVjdG9yQ29kZVJlZjsgfQogICAgIHZvaWQgc2V0Q29tcGls
ZWRTZWxlY3RvcihTZWxlY3RvckNvbXBpbGF0aW9uU3RhdHVzIHN0YXR1cywgSlNDOjpNYWNyb0Fz
c2VtYmxlckNvZGVSZWYgY29kZVJlZikgY29uc3QKICAgICB7CkBAIC0xMTMsMjAgKzExMywyMCBA
QCBwcml2YXRlOgogICAgIHVuc2lnbmVkIG1fY29udGFpbnNVbmNvbW1vbkF0dHJpYnV0ZVNlbGVj
dG9yIDogMTsKICAgICB1bnNpZ25lZCBtX2xpbmtNYXRjaFR5cGUgOiAyOyAvLyAgU2VsZWN0b3JD
aGVja2VyOjpMaW5rTWF0Y2hNYXNrCiAgICAgdW5zaWduZWQgbV9wcm9wZXJ0eVdoaXRlbGlzdFR5
cGUgOiAyOwotICAgIC8vIFVzZSBwbGFpbiBhcnJheSBpbnN0ZWFkIG9mIGEgVmVjdG9yIHRvIG1p
bmltaXplIG1lbW9yeSBvdmVyaGVhZC4KLSAgICB1bnNpZ25lZCBtX2Rlc2NlbmRhbnRTZWxlY3Rv
cklkZW50aWZpZXJIYXNoZXNbbWF4aW11bUlkZW50aWZpZXJDb3VudF07CiAjaWYgRU5BQkxFKENT
U19TRUxFQ1RPUl9KSVQpCi0gICAgbXV0YWJsZSBTZWxlY3RvckNvbXBpbGF0aW9uU3RhdHVzIG1f
Y29tcGlsYXRpb25TdGF0dXM7CisgICAgbXV0YWJsZSB1bnNpZ25lZCBtX2NvbXBpbGF0aW9uU3Rh
dHVzIDogMjsgLy8gU2VsZWN0b3JDb21waWxhdGlvblN0YXR1cwogICAgIG11dGFibGUgSlNDOjpN
YWNyb0Fzc2VtYmxlckNvZGVSZWYgbV9jb21waWxlZFNlbGVjdG9yQ29kZVJlZjsKICNpZiBDU1Nf
U0VMRUNUT1JfSklUX1BST0ZJTElORwogICAgIG11dGFibGUgdW5zaWduZWQgbV9jb21waWxlZFNl
bGVjdG9yVXNlQ291bnQ7CiAjZW5kaWYKICNlbmRpZiAvLyBFTkFCTEUoQ1NTX1NFTEVDVE9SX0pJ
VCkKKyAgICAvLyBVc2UgcGxhaW4gYXJyYXkgaW5zdGVhZCBvZiBhIFZlY3RvciB0byBtaW5pbWl6
ZSBtZW1vcnkgb3ZlcmhlYWQuCisgICAgdW5zaWduZWQgbV9kZXNjZW5kYW50U2VsZWN0b3JJZGVu
dGlmaWVySGFzaGVzW21heGltdW1JZGVudGlmaWVyQ291bnRdOwogfTsKICAgICAKIHN0cnVjdCBT
YW1lU2l6ZUFzUnVsZURhdGEgewogI2lmIEVOQUJMRShDU1NfU0VMRUNUT1JfSklUKQotICAgIHVu
c2lnbmVkIGNvbXBpbGF0aW9uU3RhdHVzOworICAgIC8vIE5PVEU6IFRoZSBjb21waWxhdGlvblN0
YXR1cyBmaWVsZCBmaXRzIGluIHRoZSBiaXRmaWVsZC4KICAgICB2b2lkKiBjb21waWxlZFNlbGVj
dG9yUG9pbnRlcjsKICAgICB2b2lkKiBjb2RlUmVmUHRyOwogI2lmIENTU19TRUxFQ1RPUl9KSVRf
UFJPRklMSU5HCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21w
aWxlci5oIGIvU291cmNlL1dlYkNvcmUvY3Nzaml0L1NlbGVjdG9yQ29tcGlsZXIuaAppbmRleCAy
Y2I2NGE4Li40NDVmZmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0
b3JDb21waWxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzc2ppdC9TZWxlY3RvckNvbXBpbGVy
LmgKQEAgLTYxLDYgKzYxLDEwIEBAIHB1YmxpYzoKICAgICAgICAgOiBtX3N0YXR1cyhzdGF0dXMp
CiAgICAgeyB9CiAKKyAgICBleHBsaWNpdCBTZWxlY3RvckNvbXBpbGF0aW9uU3RhdHVzKHVuc2ln
bmVkIHN0YXR1cykKKyAgICAgICAgOiBtX3N0YXR1cyhzdGF0aWNfY2FzdDxTdGF0dXM+KHN0YXR1
cykpCisgICAgeyB9CisKICAgICBvcGVyYXRvciBTdGF0dXMoKSBjb25zdCB7IHJldHVybiBtX3N0
YXR1czsgfQogCiBwcml2YXRlOgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>