<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>140103</bug_id>
          
          <creation_ts>2015-01-05 15:51:25 -0800</creation_ts>
          <short_desc>Add copies of NPN_Evaluate and NPN_Invoke on Windows</short_desc>
          <delta_ts>2015-01-06 08:52:57 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Anders Carlsson">andersca</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1058843</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2015-01-05 15:51:25 -0800</bug_when>
    <thetext>Add a copy of NPN_Evaluate and NPN_Invoke on Windows</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058844</commentid>
    <comment_count>1</comment_count>
      <attachid>244014</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2015-01-05 15:55:35 -0800</bug_when>
    <thetext>Created attachment 244014
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058848</commentid>
    <comment_count>2</comment_count>
      <attachid>244014</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-01-05 16:08:53 -0800</bug_when>
    <thetext>Comment on attachment 244014
Patch

Gross. Fine, whatever. rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058851</commentid>
    <comment_count>3</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2015-01-05 16:10:54 -0800</bug_when>
    <thetext>Committed r177937: &lt;http://trac.webkit.org/changeset/177937&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058878</commentid>
    <comment_count>4</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-01-05 18:02:24 -0800</bug_when>
    <thetext>Some build fixes were needed:

http://trac.webkit.org/changeset/177943.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058885</commentid>
    <comment_count>5</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-01-05 18:46:39 -0800</bug_when>
    <thetext>Attempted to fix in:

&lt;http://trac.webkit.org/changeset/177943&gt;.

But finally got it right in: 

&lt;http://trac.webkit.org/changeset/177945&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058925</commentid>
    <comment_count>6</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-01-05 23:53:47 -0800</bug_when>
    <thetext>The Windows build is still broken.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1059016</commentid>
    <comment_count>7</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-01-06 08:52:57 -0800</bug_when>
    <thetext>One more change was needed:

&lt;http://trac.webkit.org/changeset/177959&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>244014</attachid>
            <date>2015-01-05 15:55:35 -0800</date>
            <delta_ts>2015-01-05 16:08:53 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-140103-20150105155539.patch</filename>
            <type>text/plain</type>
            <size>5255</size>
            <attacher name="Anders Carlsson">andersca</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjczM2U3NjhkZjcxMDM1
ZDk4YzkxYjE2ZjkzZDdmNGRmNDExM2QzYy4uMWYzMjBhNGE2MDczOTQ3YTFlM2ExNTdhODBhNTBi
MTUzM2QxM2EwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAxLTA1ICBBbmRl
cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgY29weSBv
ZiBOUE5fRXZhbHVhdGUgYW5kIE5QTl9JbnZva2Ugb24gV2luZG93cworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMTAzCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hpbGUgdGhpcyBpcyB1bmZvcnR1bmF0
ZSwgaXQgd2lsbCBhbGxvdyB1cyB0byBnZXQgcmlkIG9mIFBsdWdpblZpZXcuaCBhbmQgUGx1Z2lu
Vmlld05vbmUuY3BwCisgICAgICAgIGZyb20gdGhlIGNyb3NzIHBsYXRmb3JtIFdlYkNvcmUgY29k
ZSBhbmQgdGhlbiBtb3ZlIHRoZSBwbHVnLWluIGNvZGUgdG8gV2ViS2l0L3dpbiAod2hpY2ggaXMg
dGhlIG9ubHkgY2xpZW50IG9mIHRoaXMgcGx1Zy1pbiBpbXBsZW1lbnRhdGlvbikuCisKKyAgICAg
ICAgKiBwbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TlBOX0lu
dm9rZSk6CisgICAgICAgIChXZWJDb3JlOjpOUE5fRXZhbHVhdGUpOgorICAgICAgICAoV2ViQ29y
ZTo6UGx1Z2luUGFja2FnZTo6aW5pdGlhbGl6ZUJyb3dzZXJGdW5jcyk6CisKIDIwMTUtMDEtMDUg
IEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFB1cmdlIFBhc3NS
ZWZQdHIgZnJvbSBQYWdlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVn
aW5QYWNrYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAK
aW5kZXggMjBhMjM0ZmE4ODBlNWU1YjQzYjAyNGJhYzE2NWU2YTVmNzg0ZWFjYi4uNjVjNTg4YTI0
NWNhNTYxNmRlYzM5ZDFmZTRjMWJlMDkzNGVlZGU1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5z
L1BsdWdpblBhY2thZ2UuY3BwCkBAIC0yOSw4ICsyOSwxMCBAQAogI2luY2x1ZGUgIlBsdWdpblBh
Y2thZ2UuaCIKIAogI2luY2x1ZGUgIk1JTUVUeXBlUmVnaXN0cnkuaCIKKyNpbmNsdWRlICJOUF9q
c29iamVjdC5oIgogI2luY2x1ZGUgIlBsdWdpbkRhdGFiYXNlLmgiCiAjaW5jbHVkZSAiUGx1Z2lu
RGVidWcuaCIKKyNpbmNsdWRlICJQbHVnaW5WaWV3LmgiCiAjaW5jbHVkZSAiVGltZXIuaCIKICNp
bmNsdWRlICJucHJ1bnRpbWVfaW1wbC5oIgogI2luY2x1ZGUgPHN0cmluZy5oPgpAQCAtMjY3LDYg
KzI2OSw4MiBAQCB2b2lkIFBsdWdpblBhY2thZ2U6OmRldGVybWluZU1vZHVsZVZlcnNpb25Gcm9t
RGVzY3JpcHRpb24oKQogI2VuZGlmCiAKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkK
K3N0YXRpYyBib29sIE5QTl9JbnZva2UoTlBQIG5wcCwgTlBPYmplY3QqIG8sIE5QSWRlbnRpZmll
ciBtZXRob2ROYW1lLCBjb25zdCBOUFZhcmlhbnQqIGFyZ3MsIHVpbnQzMl90IGFyZ0NvdW50LCBO
UFZhcmlhbnQqIHJlc3VsdCkKK3sKKyAgICBpZiAoby0+X2NsYXNzID09IE5QU2NyaXB0T2JqZWN0
Q2xhc3MpIHsKKyAgICAgICAgSmF2YVNjcmlwdE9iamVjdCogb2JqID0gcmVpbnRlcnByZXRfY2Fz
dDxKYXZhU2NyaXB0T2JqZWN0Kj4obyk7CisKKyAgICAgICAgSWRlbnRpZmllclJlcCogaSA9IHN0
YXRpY19jYXN0PElkZW50aWZpZXJSZXAqPihtZXRob2ROYW1lKTsKKyAgICAgICAgaWYgKCFpLT5p
c1N0cmluZygpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgICAgIC8vIFNwZWNp
YWwgY2FzZSB0aGUgImV2YWwiIG1ldGhvZC4KKyAgICAgICAgaWYgKG1ldGhvZE5hbWUgPT0gX05Q
Tl9HZXRTdHJpbmdJZGVudGlmaWVyKCJldmFsIikpIHsKKyAgICAgICAgICAgIGlmIChhcmdDb3Vu
dCAhPSAxKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgIGlmIChh
cmdzWzBdLnR5cGUgIT0gTlBWYXJpYW50VHlwZV9TdHJpbmcpCisgICAgICAgICAgICAgICAgcmV0
dXJuIGZhbHNlOworICAgICAgICAgICAgcmV0dXJuIE5QTl9FdmFsdWF0ZShucHAsIG8sIGNvbnN0
X2Nhc3Q8TlBTdHJpbmcqPigmYXJnc1swXS52YWx1ZS5zdHJpbmdWYWx1ZSksIHJlc3VsdCk7Cisg
ICAgICAgIH0KKworICAgICAgICAvLyBMb29rIHVwIHRoZSBmdW5jdGlvbiBvYmplY3QuCisgICAg
ICAgIFJvb3RPYmplY3QqIHJvb3RPYmplY3QgPSBvYmotPnJvb3RPYmplY3Q7CisgICAgICAgIGlm
ICghcm9vdE9iamVjdCB8fCAhcm9vdE9iamVjdC0+aXNWYWxpZCgpKQorICAgICAgICAgICAgcmV0
dXJuIGZhbHNlOworICAgICAgICBFeGVjU3RhdGUqIGV4ZWMgPSByb290T2JqZWN0LT5nbG9iYWxP
YmplY3QoKS0+Z2xvYmFsRXhlYygpOworICAgICAgICBKU0xvY2tIb2xkZXIgbG9jayhleGVjKTsK
KyAgICAgICAgSlNWYWx1ZSBmdW5jdGlvbiA9IG9iai0+aW1wLT5nZXQoZXhlYywgaWRlbnRpZmll
ckZyb21OUElkZW50aWZpZXIoZXhlYywgaS0+c3RyaW5nKCkpKTsKKyAgICAgICAgQ2FsbERhdGEg
Y2FsbERhdGE7CisgICAgICAgIENhbGxUeXBlIGNhbGxUeXBlID0gZ2V0Q2FsbERhdGEoZnVuY3Rp
b24sIGNhbGxEYXRhKTsKKyAgICAgICAgaWYgKGNhbGxUeXBlID09IENhbGxUeXBlTm9uZSkKKyAg
ICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAgICAvLyBDYWxsIHRoZSBmdW5jdGlvbiBv
YmplY3QuCisgICAgICAgIE1hcmtlZEFyZ3VtZW50QnVmZmVyIGFyZ0xpc3Q7CisgICAgICAgIGdl
dExpc3RGcm9tVmFyaWFudEFyZ3MoZXhlYywgYXJncywgYXJnQ291bnQsIHJvb3RPYmplY3QsIGFy
Z0xpc3QpOworICAgICAgICBKU1ZhbHVlIHJlc3VsdFYgPSBKU0M6OmNhbGwoZXhlYywgZnVuY3Rp
b24sIGNhbGxUeXBlLCBjYWxsRGF0YSwgb2JqLT5pbXAsIGFyZ0xpc3QpOworCisgICAgICAgIC8v
IENvbnZlcnQgYW5kIHJldHVybiB0aGUgcmVzdWx0IG9mIHRoZSBmdW5jdGlvbiBjYWxsLgorICAg
ICAgICBjb252ZXJ0VmFsdWVUb05QVmFyaWFudChleGVjLCByZXN1bHRWLCByZXN1bHQpOworICAg
ICAgICBleGVjLT5jbGVhckV4Y2VwdGlvbigpOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9
CisKKyAgICBpZiAoby0+X2NsYXNzLT5pbnZva2UpCisgICAgICAgIHJldHVybiBvLT5fY2xhc3Mt
Pmludm9rZShvLCBtZXRob2ROYW1lLCBhcmdzLCBhcmdDb3VudCwgcmVzdWx0KTsKKworICAgIFZP
SURfVE9fTlBWQVJJQU5UKCpyZXN1bHQpOworICAgIHJldHVybiB0cnVlOworfQorCitzdGF0aWMg
Ym9vbCBOUE5fRXZhbHVhdGUoTlBQIGluc3RhbmNlLCBOUE9iamVjdCogbywgTlBTdHJpbmcqIHMs
IE5QVmFyaWFudCogdmFyaWFudCkKK3sKKyAgICBpZiAoby0+X2NsYXNzID09IE5QU2NyaXB0T2Jq
ZWN0Q2xhc3MpIHsKKyAgICAgICAgSmF2YVNjcmlwdE9iamVjdCogb2JqID0gcmVpbnRlcnByZXRf
Y2FzdDxKYXZhU2NyaXB0T2JqZWN0Kj4obyk7CisKKyAgICAgICAgUm9vdE9iamVjdCogcm9vdE9i
amVjdCA9IG9iai0+cm9vdE9iamVjdDsKKyAgICAgICAgaWYgKCFyb290T2JqZWN0IHx8ICFyb290
T2JqZWN0LT5pc1ZhbGlkKCkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAg
Ly8gVGhlcmUgaXMgYSBjcmFzaCBpbiBGbGFzaCB3aGVuIGV2YWx1YXRpbmcgYSBzY3JpcHQgdGhh
dCBkZXN0cm95cyB0aGUKKyAgICAgICAgLy8gUGx1Z2luVmlldywgc28gd2UgZGVzdHJveSBpdCBh
c3luY2hyb25vdXNseS4KKyAgICAgICAgUGx1Z2luVmlldzo6a2VlcEFsaXZlKGluc3RhbmNlKTsK
KworICAgICAgICBFeGVjU3RhdGUqIGV4ZWMgPSByb290T2JqZWN0LT5nbG9iYWxPYmplY3QoKS0+
Z2xvYmFsRXhlYygpOworICAgICAgICBKU0xvY2tIb2xkZXIgbG9jayhleGVjKTsKKyAgICAgICAg
U3RyaW5nIHNjcmlwdFN0cmluZyA9IGNvbnZlcnROUFN0cmluZ1RvVVRGMTYocyk7CisKKyAgICAg
ICAgSlNWYWx1ZSByZXR1cm5WYWx1ZSA9IEpTQzo6ZXZhbHVhdGUocm9vdE9iamVjdC0+Z2xvYmFs
T2JqZWN0KCktPmdsb2JhbEV4ZWMoKSwgbWFrZVNvdXJjZShzY3JpcHRTdHJpbmcpLCBKU0M6OkpT
VmFsdWUoKSk7CisKKyAgICAgICAgY29udmVydFZhbHVlVG9OUFZhcmlhbnQoZXhlYywgcmV0dXJu
VmFsdWUsIHZhcmlhbnQpOworICAgICAgICBleGVjLT5jbGVhckV4Y2VwdGlvbigpOworICAgICAg
ICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKKyAgICBWT0lEX1RPX05QVkFSSUFOVCgqdmFyaWFudCk7
CisgICAgcmV0dXJuIGZhbHNlOworfQorCiB2b2lkIFBsdWdpblBhY2thZ2U6OmluaXRpYWxpemVC
cm93c2VyRnVuY3MoKQogewogICAgIG1lbXNldCgmbV9icm93c2VyRnVuY3MsIDAsIHNpemVvZiht
X2Jyb3dzZXJGdW5jcykpOwpAQCAtMzA4LDkgKzM4Niw5IEBAIHZvaWQgUGx1Z2luUGFja2FnZTo6
aW5pdGlhbGl6ZUJyb3dzZXJGdW5jcygpCiAgICAgbV9icm93c2VyRnVuY3MuY3JlYXRlb2JqZWN0
ID0gX05QTl9DcmVhdGVPYmplY3Q7CiAgICAgbV9icm93c2VyRnVuY3MucmV0YWlub2JqZWN0ID0g
X05QTl9SZXRhaW5PYmplY3Q7CiAgICAgbV9icm93c2VyRnVuY3MucmVsZWFzZW9iamVjdCA9IF9O
UE5fUmVsZWFzZU9iamVjdDsKLSAgICBtX2Jyb3dzZXJGdW5jcy5pbnZva2UgPSBfTlBOX0ludm9r
ZTsKKyAgICBtX2Jyb3dzZXJGdW5jcy5pbnZva2UgPSBOUE5fSW52b2tlOwogICAgIG1fYnJvd3Nl
ckZ1bmNzLmludm9rZURlZmF1bHQgPSBfTlBOX0ludm9rZURlZmF1bHQ7Ci0gICAgbV9icm93c2Vy
RnVuY3MuZXZhbHVhdGUgPSBfTlBOX0V2YWx1YXRlOworICAgIG1fYnJvd3NlckZ1bmNzLmV2YWx1
YXRlID0gTlBOX0V2YWx1YXRlOwogICAgIG1fYnJvd3NlckZ1bmNzLmdldHByb3BlcnR5ID0gX05Q
Tl9HZXRQcm9wZXJ0eTsKICAgICBtX2Jyb3dzZXJGdW5jcy5zZXRwcm9wZXJ0eSA9IF9OUE5fU2V0
UHJvcGVydHk7CiAgICAgbV9icm93c2VyRnVuY3MucmVtb3ZlcHJvcGVydHkgPSBfTlBOX1JlbW92
ZVByb3BlcnR5Owo=
</data>
<flag name="review"
          id="268930"
          type_id="1"
          status="+"
          setter="kling"
    />
          </attachment>
      

    </bug>

</bugzilla>