140101 2015-01-05 15:13:09 -0800 [TexMap]TextureMapperLayer - avoiding multiple regions in paintUsingOverlapRegions 2022-06-14 15:23:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 abaldeva fujii cmarcelo don.olmstead ews-watchlist fujii kondapallykalyan luiz magomez webkit-bug-importer zdobersek oldest_to_newest 1058830 0 244009 abaldeva 2015-01-05 15:13:09 -0800 Created attachment 244009 1 pixel offset overlapping region Hi, In TextureMapperLayer::paintUsingOverlapRegions, there is a check to avoid dividing the area between overlapping and nonoverlapping. The current check is if (overlapRegion.bounds().size().area() > nonOverlapRegion.bounds().size().area()) However, I think it is incorrect. If the overlap region is just 1 pixel small from all the 4 side, this check would not catch that. Attached an html that reproduces the issue. Seems to me that the correct check should be if (overlapRegion.totalArea() > nonOverlapRegion.totalArea) Thoughts? Arpit 1697035 1 fujii 2020-10-12 14:36:02 -0700 The code was added by r149369 (Bug 115226). 1875154 2 fujii 2022-06-09 19:05:19 -0700 (In reply to abaldeva from comment #0) > Seems to me that the correct check should be > if (overlapRegion.totalArea() > nonOverlapRegion.totalArea) > > Thoughts? It sounds like a good idea to me. Will prepare a patch. 1875157 3 460152 fujii 2022-06-09 19:23:01 -0700 Created attachment 460152 Patch 1875611 4 fujii 2022-06-13 14:18:17 -0700 gtk-wk2 EWS reports a test failure. imported/w3c/web-platform-tests/css/css-transforms/transform3d-rotatex-perspective-003.html [ ImageOnlyFailure ] This is a true-positive. Created bug#241568 for it. 1875615 5 460215 fujii 2022-06-13 14:30:59 -0700 Created attachment 460215 Patch 1875889 6 ews-feeder 2022-06-14 15:22:49 -0700 Committed r295542 (251547@main): <https://commits.webkit.org/251547@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460215. 1875890 7 webkit-bug-importer 2022-06-14 15:23:13 -0700 <rdar://problem/95148331> 244009 2015-01-05 15:13:09 -0800 2015-01-05 15:13:09 -0800 1 pixel offset overlapping region simplePage.html text/html 351 abaldeva DQo8IURPQ1RZUEUgSFRNTD4NCjxodG1sPg0KPGhlYWQ+DQo8L2hlYWQ+DQo8Ym9keT4NCiAgICA8 ZGl2IHN0eWxlPSJwb3NpdGlvbjphYnNvbHV0ZTtsZWZ0OjEwMHB4O3RvcDoxMDBweDt3aWR0aDoy MDBweDtoZWlnaHQ6MjAwcHg7YmFja2dyb3VuZC1jb2xvcjpncmF5O29wYWNpdHk6MC43NTsiPg0K ICAgICAgICA8ZGl2IHN0eWxlPSJwb3NpdGlvbjphYnNvbHV0ZTtsZWZ0OjFweDt0b3A6MXB4O3dp ZHRoOjE5OHB4O2hlaWdodDoxOThweDtiYWNrZ3JvdW5kLWNvbG9yOmJsdWU7LXdlYmtpdC10cmFu c2Zvcm06dHJhbnNsYXRlWigwKTsiPjwvZGl2Pg0KICAgIDwvZGl2Pg0KDQo8L2JvZHk+DQo8L2h0 bWw+DQoNCg0K 460152 2022-06-09 19:23:01 -0700 2022-06-13 14:30:56 -0700 Patch bug-140101-20220610112300.patch text/plain 1736 fujii RnJvbSA4MWQzYTBjZTc2M2U3YjgxYmNlMTk5MzFlY2E1YjkxNDYxYzg0YTg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IEZyaSwgMTAgSnVuIDIwMjIgMTE6MDg6MjcgKzA5MDAKU3ViamVjdDogW1BBVENI XSBbVGV4TWFwXSBUZXh0dXJlTWFwcGVyTGF5ZXIgLSBhdm9pZGluZyBtdWx0aXBsZSByZWdpb25z IGluCiBwYWludFVzaW5nT3ZlcmxhcFJlZ2lvbnMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MDEwMQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpwYWludFVz aW5nT3ZlcmxhcFJlZ2lvbnMgaGFzIGEgY29kZSB0byBtZXJnZSBub25PdmVybGFwUmVnaW9uIGlu dG8Kb3ZlcmxhcFJlZ2lvbiB0byBhdm9pZCBkaXZpZGluZyBpbnRvIG11bHRpcGxlIHNtYWxsIGFy ZWFzIGlmCm92ZXJsYXBSZWdpb24gaXMgYmlnZ2VyIHRoYW4gbm9uT3ZlcmxhcFJlZ2lvbi4KCkhv d2V2ZXIsIGlmIHRoZSBvdmVybGFwIHJlZ2lvbiBpcyBqdXN0IDEgcGl4ZWwgc21hbGwgZnJvbSBh bGwgdGhlIDQKc2lkZSwgdGhpcyBjaGVjayB3b3VsZCBub3QgY2F0Y2ggdGhhdC4KCiogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHA6 CihXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50VXNpbmdPdmVybGFwUmVnaW9ucyk6 CkNvbXBhcmUgdG90YWxBcmVhIG9mIG92ZXJsYXBSZWdpb24gYW5kIG5vbk92ZXJsYXBSZWdpb24u Ci0tLQogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBw ZXJMYXllci5jcHAgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCmluZGV4IDA3N2ZiYWJjZTk3OC4u OGVhZTgzMTVkZGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcApAQCAtNDAyLDcgKzQw Miw3IEBAIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpwYWludFVzaW5nT3ZlcmxhcFJlZ2lvbnMo VGV4dHVyZU1hcHBlclBhaW50T3B0aW9ucyYgb3B0CiAKICAgICAvLyBIYXZpbmcgYm90aCBvdmVy bGFwIGFuZCBub24tb3ZlcmxhcCByZWdpb25zIGNhcnJpZXMgc29tZSBvdmVyaGVhZC4gQXZvaWQg aXQgaWYgdGhlIG92ZXJsYXAgYXJlYQogICAgIC8vIGlzIGJpZyBhbnl3YXkuCi0gICAgaWYgKG92 ZXJsYXBSZWdpb24uYm91bmRzKCkuc2l6ZSgpLmFyZWEoKSA+IG5vbk92ZXJsYXBSZWdpb24uYm91 bmRzKCkuc2l6ZSgpLmFyZWEoKSkgeworICAgIGlmIChvdmVybGFwUmVnaW9uLnRvdGFsQXJlYSgp ID4gbm9uT3ZlcmxhcFJlZ2lvbi50b3RhbEFyZWEoKSkgewogICAgICAgICBvdmVybGFwUmVnaW9u LnVuaXRlKG5vbk92ZXJsYXBSZWdpb24pOwogICAgICAgICBub25PdmVybGFwUmVnaW9uID0gUmVn aW9uKCk7CiAgICAgfQotLSAKMi4yNS4xCgo= 460215 2022-06-13 14:30:59 -0700 2022-06-14 15:22:50 -0700 Patch bug-140101-20220614063058.patch text/plain 2598 fujii RnJvbSBhY2Y4MzFmZDQ5NmQ4MWUwMjZhMWIzODU5MzIyOGFkZDNkYjMyZDJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFR1ZSwgMTQgSnVuIDIwMjIgMDY6Mjg6MjIgKzA5MDAKU3ViamVjdDogW1BBVENI XSBbVGV4TWFwXSBUZXh0dXJlTWFwcGVyTGF5ZXIgLSBhdm9pZGluZyBtdWx0aXBsZSByZWdpb25z IGluCiBwYWludFVzaW5nT3ZlcmxhcFJlZ2lvbnMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MDEwMQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpwYWludFVz aW5nT3ZlcmxhcFJlZ2lvbnMgaGFzIGEgY29kZSB0byBtZXJnZSBub25PdmVybGFwUmVnaW9uIGlu dG8Kb3ZlcmxhcFJlZ2lvbiB0byBhdm9pZCBkaXZpZGluZyBpbnRvIG11bHRpcGxlIHNtYWxsIGFy ZWFzIGlmCm92ZXJsYXBSZWdpb24gaXMgYmlnZ2VyIHRoYW4gbm9uT3ZlcmxhcFJlZ2lvbi4KCkhv d2V2ZXIsIGlmIHRoZSBvdmVybGFwIHJlZ2lvbiBpcyBqdXN0IDEgcGl4ZWwgc21hbGwgZnJvbSBh bGwgdGhlIDQKc2lkZSwgdGhpcyBjaGVjayB3b3VsZCBub3QgY2F0Y2ggdGhhdC4KCiogTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zOgoqIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwOgooV2ViQ29yZTo6 VGV4dHVyZU1hcHBlckxheWVyOjpwYWludFVzaW5nT3ZlcmxhcFJlZ2lvbnMpOgpDb21wYXJlIHRv dGFsQXJlYSBvZiBvdmVybGFwUmVnaW9uIGFuZCBub25PdmVybGFwUmVnaW9uLgotLS0KIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3Bw IHwgMiArLQogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zICAgICAg ICAgICAgICAgICAgICAgfCAxICsKIDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAx IGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcAppbmRleCAwNzdmYmFiY2U5 NzguLjhlYWU4MzE1ZGRkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKQEAgLTQwMiw3 ICs0MDIsNyBAQCB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRVc2luZ092ZXJsYXBSZWdp b25zKFRleHR1cmVNYXBwZXJQYWludE9wdGlvbnMmIG9wdAogCiAgICAgLy8gSGF2aW5nIGJvdGgg b3ZlcmxhcCBhbmQgbm9uLW92ZXJsYXAgcmVnaW9ucyBjYXJyaWVzIHNvbWUgb3ZlcmhlYWQuIEF2 b2lkIGl0IGlmIHRoZSBvdmVybGFwIGFyZWEKICAgICAvLyBpcyBiaWcgYW55d2F5LgotICAgIGlm IChvdmVybGFwUmVnaW9uLmJvdW5kcygpLnNpemUoKS5hcmVhKCkgPiBub25PdmVybGFwUmVnaW9u LmJvdW5kcygpLnNpemUoKS5hcmVhKCkpIHsKKyAgICBpZiAob3ZlcmxhcFJlZ2lvbi50b3RhbEFy ZWEoKSA+IG5vbk92ZXJsYXBSZWdpb24udG90YWxBcmVhKCkpIHsKICAgICAgICAgb3ZlcmxhcFJl Z2lvbi51bml0ZShub25PdmVybGFwUmVnaW9uKTsKICAgICAgICAgbm9uT3ZlcmxhcFJlZ2lvbiA9 IFJlZ2lvbigpOwogICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIv VGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCA2ZTViMzdiNTQ4M2QuLmNjM2RhYTNmNGE2MSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNjkyLDYgKzY5Miw3IEBAIGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10cmFuc2Zvcm1zL3RyYW5zZm9ybTNkLXNv cnRpbmctMDAzLmh0bWwKIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10 cmFuc2Zvcm1zL3RyYW5zZm9ybTNkLXRyYW5zbGF0ZTNkLTAwMS5odG1sIFsgUGFzcyBdCiBpbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtdHJhbnNmb3Jtcy90dHdmLWNzcy0z ZC1wb2x5Z29uLWN5Y2xlLmh0bWwgWyBQYXNzIF0KIAord2Via2l0Lm9yZy9iLzI0MTU2OCBpbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtdHJhbnNmb3Jtcy90cmFuc2Zvcm0z ZC1yb3RhdGV4LXBlcnNwZWN0aXZlLTAwMy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKIAog Iy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8K