140095 2015-01-05 13:50:48 -0800 Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry 2015-01-06 16:26:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap fpizlo ggaren mrowe oldest_to_newest 1058801 0 ap 2015-01-05 13:50:48 -0800 In release builds, Register::jsValue is inlined into DFG::prepareOSREntry, so a blacklist line we have in webkit-asan-ignore.txt is sufficient. But in debug builds, it is not inlined, so we crash in this function. Adding Register::jsValue to the blacklist is not the best fix, because this function is used elsewhere. The better fix is to blacklist the whole file. 1058841 1 244013 ap 2015-01-05 15:50:25 -0800 Created attachment 244013 proposed fix Actually, blacklisting the file doesn't work - if we do that, we get a non-ASan version of the inline function in DFGOSREntry.o, but it is later eliminated by the linker in favor of an ASanified copy from another file. So I only see two options: 1. Blacklist Register::jsValue(), and ask for a better solution (which I propose here). 2. Make a copy of Register::jsValue() function with a different name, just for the purpose of using it in prepareOSREntry() in a blacklist. 1059221 2 ap 2015-01-06 16:26:11 -0800 Committed <http://trac.webkit.org/r178005>. 244013 2015-01-05 15:50:25 -0800 2015-01-05 15:55:07 -0800 proposed fix DebugASan.txt text/plain 1226 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NzkzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTAxLTA1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIERlYnVnIEFTYW4gYnVpbGRzIGZyZXF1ZW50bHkgY3Jhc2ggaW4gUmVnaXN0 ZXI6OmpzVmFsdWUgdW5kZXIgREZHOjpwcmVwYXJlT1NSRW50cnkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDA5NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNhbi93ZWJraXQtYXNhbi1pZ25vcmUu dHh0OiBCbGFja2xpc3QgYSBmdW5jdGlvbiB0aGF0IGdldHMgaW5saW5lZCBpbiByZWxlYXNlCisg ICAgICAgIGJ1aWxkcywgYnV0IG5vdCBpbiBkZWJ1ZyBvbmVzLgorCiAyMDE1LTAxLTA1ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgaGVhcC1idWZmZXIt b3ZlcmZsb3cgb24gZmFzdC9sb2FkZXIvcmVsb2FkLXplcm8tYnl0ZS1wbHVnaW4uaHRtbApJbmRl eDogVG9vbHMvYXNhbi93ZWJraXQtYXNhbi1pZ25vcmUudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L2FzYW4vd2Via2l0LWFzYW4taWdub3JlLnR4dAkocmV2aXNpb24gMTc3OTIyKQorKysgVG9vbHMv YXNhbi93ZWJraXQtYXNhbi1pZ25vcmUudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsNiBA QAogZnVuOipnZW5lcmljQWRkU3BhbioKIGZ1bjoqZ2F0aGVyRnJvbUN1cnJlbnRUaHJlYWQqQ29u c2VydmF0aXZlUm9vdHMqCiBmdW46KkRGRypwcmVwYXJlT1NSRW50cnkqCisjIEZJWE1FIChyZGFy Oi8vcHJvYmxlbS8xOTM3OTIxNCk6IFJlZ2lzdGVyOjpqc1ZhbHVlKCkgb25seSBuZWVkcyB0byBi ZSBibGFja2xpc3RlZCB3aGVuCisjIGNhbGxlZCBmcm9tIHByZXBhcmVPU1JFbnRyeSgpLCBidXQg dGhlcmUgaXMgY3VycmVudGx5IG5vIHdheSB0byBleHByZXNzIHRoaXMgaW4gYSBibGFja2xpc3Qu CitmdW46KkpTQypSZWdpc3Rlcipqc1ZhbHVlKgo=