14008 2007-06-05 19:47:55 -0700 RenderTextControl.cpp hard-codes scrollbar size to 15 pixels 2007-06-05 21:28:26 -0700 1 1 1 Unclassified WebKit Platform 523.x (Safari 3) All All RESOLVED FIXED P3 Minor --- 1 fishd fishd oldest_to_newest 8313 0 fishd 2007-06-05 19:47:55 -0700 RenderTextControl.cpp hard-codes scrollbar size to 15 pixels the comments say that this should use RenderTheme instead. after discussing with maciej on #webkit, it seems like the best solution is a method on RenderTheme that takes a RenderObject parameter so that the scrollbar size can vary (e.g., on OS X, mini controls have a smaller scrollbar). 8315 1 14874 fishd 2007-06-05 20:42:23 -0700 Created attachment 14874 simple patch I went with the simpler version of the patch since other code in rendering/ invokes PlatformScrollbar::horizontalScrollbarHeight()/verticalScrollbarWidth() Moreover, this ends up not being a real code change since it's just replacing a hard-coded 15 with a static function that returns 15 (on Mac). 8318 2 14874 hyatt 2007-06-05 20:59:41 -0700 Comment on attachment 14874 simple patch r=me 8319 3 mrowe 2007-06-05 21:28:26 -0700 Landed in r22017. 14874 2007-06-05 20:42:23 -0700 2007-06-05 20:59:41 -0700 simple patch no_hardcoded_sizes.diff text/plain 2484 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDE2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDYt MDUgIE1vcmdhbkwgIDxtb3JnYW5sLndlYmtpdEB5YWhvby5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMDgKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU ZXh0Q29udHJvbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUZXh0Q29udHJvbDo6Y2Fs Y0hlaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUZXh0Q29udHJvbDo6Y2FsY1ByZWZX aWR0aHMpOgorCiAyMDA3LTA2LTA1ICBLZXZpbiBNY0N1bGxvdWdoICA8a21jY3VsbG91Z2hAYXBw bGUuY29tPgogICAgICAgICBSZXZpZXdlZCBieS4KIApJbmRleDogcmVuZGVyaW5nL1JlbmRlclRl eHRDb250cm9sLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wu Y3BwCShyZXZpc2lvbiAyMjAxMSkKKysrIHJlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKICNpbmNsdWRlICJIaXRUZXN0UmVzdWx0 LmgiCiAjaW5jbHVkZSAiTG9jYWxpemVkU3RyaW5ncy5oIgogI2luY2x1ZGUgIk1vdXNlRXZlbnQu aCIKKyNpbmNsdWRlICJQbGF0Zm9ybVNjcm9sbGJhci5oIgogI2luY2x1ZGUgIlJlbmRlclRoZW1l LmgiCiAjaW5jbHVkZSAiU2VhcmNoUG9wdXBNZW51LmgiCiAjaW5jbHVkZSAiU2VsZWN0aW9uQ29u dHJvbGxlci5oIgpAQCAtNTk4LDExICs1OTksMTEgQEAgdm9pZCBSZW5kZXJUZXh0Q29udHJvbDo6 Y2FsY0hlaWdodCgpCiAgICAgfQogICAgIHRvQWRkICs9IGlubmVyVG9BZGQ7CiAKLSAgICAvLyBG SVhNRTogV2Ugc2hvdWxkIGdldCB0aGUgc2l6ZSBvZiB0aGUgc2Nyb2xsYmFyIGZyb20gdGhlIFJl bmRlclRoZW1lIGluc3RlYWQgb2YgaGFyZCBjb2RpbmcgaXQgaGVyZS4KKyAgICAvLyBGSVhNRTog V2Ugc2hvdWxkIGdldCB0aGUgc2l6ZSBvZiB0aGUgc2Nyb2xsYmFyIGZyb20gdGhlIFJlbmRlclRo ZW1lIGluc3RlYWQuCiAgICAgaW50IHNjcm9sbGJhclNpemUgPSAwOwogICAgIC8vIFdlIGFyZSBh YmxlIHRvIGhhdmUgYSBob3Jpem9udGFsIHNjcm9sbGJhciBpZiB0aGUgb3ZlcmZsb3cgc3R5bGUg aXMgc2Nyb2xsLCBvciBpZiBpdHMgYXV0byBhbmQgdGhlcmUncyBubyB3b3JkIHdyYXAuCiAgICAg aWYgKG1faW5uZXJUZXh0LT5yZW5kZXJlcigpLT5zdHlsZSgpLT5vdmVyZmxvd1goKSA9PSBPU0NS T0xMIHx8ICAobV9pbm5lclRleHQtPnJlbmRlcmVyKCktPnN0eWxlKCktPm92ZXJmbG93WCgpID09 IE9BVVRPICYmIG1faW5uZXJUZXh0LT5yZW5kZXJlcigpLT5zdHlsZSgpLT53b3JkV3JhcCgpID09 IE5vcm1hbFdvcmRXcmFwKSkKLSAgICAgICAgc2Nyb2xsYmFyU2l6ZSA9IDE1OworICAgICAgICBz Y3JvbGxiYXJTaXplID0gUGxhdGZvcm1TY3JvbGxiYXI6Omhvcml6b250YWxTY3JvbGxiYXJIZWln aHQoKTsKIAogICAgIG1faGVpZ2h0ID0gbGluZSAqIHJvd3MgKyB0b0FkZCArIHNjcm9sbGJhclNp emU7CiAKQEAgLTcyMCw5ICs3MjEsOSBAQCB2b2lkIFJlbmRlclRleHRDb250cm9sOjpjYWxjUHJl ZldpZHRocygpCiAgICAgICAgIGludCBzY3JvbGxiYXJTaXplID0gMDsKICAgICAgICAgaWYgKG1f bXVsdGlMaW5lKSB7CiAgICAgICAgICAgICBmYWN0b3IgPSBzdGF0aWNfY2FzdDxIVE1MVGV4dEFy ZWFFbGVtZW50Kj4obm9kZSgpKS0+Y29scygpOwotICAgICAgICAgICAgLy8gRklYTUU6IFdlIHNo b3VsZCBnZXQgdGhlIHNpemUgb2YgdGhlIHNjcm9sbGJhciBmcm9tIHRoZSBSZW5kZXJUaGVtZSBp bnN0ZWFkIG9mIGhhcmQgY29kaW5nIGl0IGhlcmUuCisgICAgICAgICAgICAvLyBGSVhNRTogV2Ug c2hvdWxkIGdldCB0aGUgc2l6ZSBvZiB0aGUgc2Nyb2xsYmFyIGZyb20gdGhlIFJlbmRlclRoZW1l IGluc3RlYWQuCiAgICAgICAgICAgICBpZiAobV9pbm5lclRleHQtPnJlbmRlcmVyKCktPnN0eWxl KCktPm92ZXJmbG93WSgpICE9IE9ISURERU4pCi0gICAgICAgICAgICAgICAgc2Nyb2xsYmFyU2l6 ZSA9IDE1OworICAgICAgICAgICAgICAgIHNjcm9sbGJhclNpemUgPSBQbGF0Zm9ybVNjcm9sbGJh cjo6dmVydGljYWxTY3JvbGxiYXJXaWR0aCgpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAg ICAgZmFjdG9yID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KG5vZGUoKSktPnNpemUo KTsKICAgICAgICAgICAgIGlmIChmYWN0b3IgPD0gMCkK