140030 2015-01-01 13:29:30 -0800 ASSERT that a null key is never used with FeatureCounter 2015-01-01 15:53:25 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue ddkilzer kling koivisto oldest_to_newest 1058348 0 cdumez 2015-01-01 13:29:30 -0800 ASSERT that a null key is never used with FeatureCounter 1058349 1 243869 cdumez 2015-01-01 13:31:34 -0800 Created attachment 243869 Patch 1058352 2 243871 cdumez 2015-01-01 14:09:10 -0800 Created attachment 243871 Patch 1058358 3 243871 darin 2015-01-01 15:07:01 -0800 Comment on attachment 243871 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243871&action=review > Source/WebCore/platform/FeatureCounter.cpp:55 > + ASSERT_ARG(key, key); Release builds will give a warning unless you use ASSERT_UNUSED here. > Source/WebCore/platform/FeatureCounter.cpp:61 > + ASSERT_ARG(key, key); Release builds will give a warning unless you use ASSERT_UNUSED here. 1058359 4 243873 cdumez 2015-01-01 15:12:00 -0800 Created attachment 243873 Patch 1058361 5 243873 commit-queue 2015-01-01 15:53:20 -0800 Comment on attachment 243873 Patch Clearing flags on attachment: 243873 Committed r177851: <http://trac.webkit.org/changeset/177851> 1058362 6 commit-queue 2015-01-01 15:53:25 -0800 All reviewed patches have been landed. Closing bug. 243869 2015-01-01 13:31:34 -0800 2015-01-01 14:09:06 -0800 Patch bug-140030-20150101133136.patch text/plain 2379 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3ODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzg0ZGE0NGMxZmI3YWFl ZTg5MGU2OGI0NzNhMzYwNjY0M2VlOTIwNC4uZmQ1ZjM2YTc3NzM1NTU4Yjc0NjM2NzNiYWUxNjU1 YWIxNTE4NzAzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTAxLTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQVNTRVJUIHRoYXQgYSBudWxs IGtleSBpcyBuZXZlciB1c2VkIHdpdGggRmVhdHVyZUNvdW50ZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDAzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vRmVhdHVyZUNvdW50ZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RmVhdHVyZUNvdW50ZXI6OmluY3JlbWVudEtleSk6Cisg ICAgICAgIChXZWJDb3JlOjpGZWF0dXJlQ291bnRlcjo6c2V0S2V5KToKKyAgICAgICAgKiBwbGF0 Zm9ybS9pb3MvRmVhdHVyZUNvdW50ZXIubW06CisgICAgICAgIChXZWJDb3JlOjpGZWF0dXJlQ291 bnRlcjo6aW5jcmVtZW50S2V5KToKKyAgICAgICAgKFdlYkNvcmU6OkZlYXR1cmVDb3VudGVyOjpz ZXRLZXkpOgorCisyMDE1LTAxLTAxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisK ICAgICAgICAgW2lPU10gRml4IG1lbW9yeSBsZWFrIGluIEZlYXR1cmVDb3VudGVyCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAwMjkKICAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzE5MjU1NjkwPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vRmVhdHVyZUNvdW50ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmVhdHVy ZUNvdW50ZXIuY3BwCmluZGV4IDhjMzdkMjgzNWJkOWZjYzIyZjRkMDlkNmQwOGMyYzAwMWFhOTQ0 MWIuLjI0MzQwMTQ1MDQ4YTU3MGQwNjQxNDQ1ZjI1MjI5ZDc3NDY2MmQ3ZmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZlYXR1cmVDb3VudGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9GZWF0dXJlQ291bnRlci5jcHAKQEAgLTUyLDEzICs1MiwxMyBAQCBi b29sIEZlYXR1cmVDb3VudGVyOjpzaG91bGRVc2VGb3JQYWdlKFBhZ2UqIHBhZ2UpCiB2b2lkIEZl YXR1cmVDb3VudGVyOjppbmNyZW1lbnRLZXkoUGFnZSogcGFnZSwgY29uc3QgY2hhciogY29uc3Qg a2V5KQogewogICAgIFVOVVNFRF9QQVJBTShwYWdlKTsKLSAgICBVTlVTRURfUEFSQU0oa2V5KTsK KyAgICBBU1NFUlRfQVJHKGtleSwga2V5KTsKIH0KIAogdm9pZCBGZWF0dXJlQ291bnRlcjo6c2V0 S2V5KFBhZ2UqIHBhZ2UsIGNvbnN0IGNoYXIqIGNvbnN0IGtleSwgaW50NjRfdCB2YWx1ZSkKIHsK ICAgICBVTlVTRURfUEFSQU0ocGFnZSk7Ci0gICAgVU5VU0VEX1BBUkFNKGtleSk7CisgICAgQVNT RVJUX0FSRyhrZXksIGtleSk7CiAgICAgVU5VU0VEX1BBUkFNKHZhbHVlKTsKIH0KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0ZlYXR1cmVDb3VudGVyLm1tIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0ZlYXR1cmVDb3VudGVyLm1tCmluZGV4IDdiMjY5ZDI0 MzU0MTkwMjgyMDQ5MDk1NTFmNGY4ZTYxNTE4N2U3MGYuLjNkNjFmMzQ4NTc0N2IwZTc4NjMxNGM0 OWI0ZTZmNjQ1ZGFiYzZkODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lv cy9GZWF0dXJlQ291bnRlci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvRmVh dHVyZUNvdW50ZXIubW0KQEAgLTM0LDYgKzM0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB2 b2lkIEZlYXR1cmVDb3VudGVyOjppbmNyZW1lbnRLZXkoUGFnZSogcGFnZSwgY29uc3QgY2hhciog Y29uc3Qga2V5KQogeworICAgIEFTU0VSVChrZXkpOwogICAgIGlmICghc2hvdWxkVXNlRm9yUGFn ZShwYWdlKSkKICAgICAgICAgcmV0dXJuOwogCkBAIC00Myw2ICs0NCw3IEBAIHZvaWQgRmVhdHVy ZUNvdW50ZXI6OmluY3JlbWVudEtleShQYWdlKiBwYWdlLCBjb25zdCBjaGFyKiBjb25zdCBrZXkp CiAKIHZvaWQgRmVhdHVyZUNvdW50ZXI6OnNldEtleShQYWdlKiBwYWdlLCBjb25zdCBjaGFyKiBj b25zdCBrZXksIGludDY0X3QgdmFsdWUpCiB7CisgICAgQVNTRVJUKGtleSk7CiAgICAgaWYgKCFz aG91bGRVc2VGb3JQYWdlKHBhZ2UpKQogICAgICAgICByZXR1cm47CiAK 243871 2015-01-01 14:09:10 -0800 2015-01-01 15:11:57 -0800 Patch bug-140030-20150101140912.patch text/plain 2282 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3ODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2I2NzAwYWNmZTkxYWE3 MWE5MTc2N2JmODA5NjBhZjYyMGI5MWQ3MS4uMWRmMjU3OTRkNjY5YmI1OTYyOWVlNGE4ODQ2MDRj ODU3YjBmNjYwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAxLTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUIHRoYXQgYSBudWxs IGtleSBpcyBuZXZlciB1c2VkIHdpdGggRmVhdHVyZUNvdW50ZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDAzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vRmVhdHVyZUNvdW50ZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RmVhdHVyZUNvdW50ZXI6OmluY3JlbWVudEtleSk6Cisg ICAgICAgIChXZWJDb3JlOjpGZWF0dXJlQ291bnRlcjo6c2V0S2V5KToKKyAgICAgICAgKiBwbGF0 Zm9ybS9pb3MvRmVhdHVyZUNvdW50ZXIubW06CisgICAgICAgIChXZWJDb3JlOjpGZWF0dXJlQ291 bnRlcjo6aW5jcmVtZW50S2V5KToKKyAgICAgICAgKFdlYkNvcmU6OkZlYXR1cmVDb3VudGVyOjpz ZXRLZXkpOgorCiAyMDE0LTEyLTMxICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgTW92ZSBzY3JvbGxpbmcgY29kZSBvZmYgb2YgV1RGOjpiaW5kCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GZWF0dXJlQ291bnRlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9GZWF0dXJlQ291bnRlci5jcHAKaW5kZXggOGMzN2QyODM1YmQ5ZmNjMjJmNGQw OWQ2ZDA4YzJjMDAxYWE5NDQxYi4uMjQzNDAxNDUwNDhhNTcwZDA2NDE0NDVmMjUyMjlkNzc0NjYy ZDdmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmVhdHVyZUNvdW50ZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZlYXR1cmVDb3VudGVyLmNwcApAQCAt NTIsMTMgKzUyLDEzIEBAIGJvb2wgRmVhdHVyZUNvdW50ZXI6OnNob3VsZFVzZUZvclBhZ2UoUGFn ZSogcGFnZSkKIHZvaWQgRmVhdHVyZUNvdW50ZXI6OmluY3JlbWVudEtleShQYWdlKiBwYWdlLCBj b25zdCBjaGFyKiBjb25zdCBrZXkpCiB7CiAgICAgVU5VU0VEX1BBUkFNKHBhZ2UpOwotICAgIFVO VVNFRF9QQVJBTShrZXkpOworICAgIEFTU0VSVF9BUkcoa2V5LCBrZXkpOwogfQogCiB2b2lkIEZl YXR1cmVDb3VudGVyOjpzZXRLZXkoUGFnZSogcGFnZSwgY29uc3QgY2hhciogY29uc3Qga2V5LCBp bnQ2NF90IHZhbHVlKQogewogICAgIFVOVVNFRF9QQVJBTShwYWdlKTsKLSAgICBVTlVTRURfUEFS QU0oa2V5KTsKKyAgICBBU1NFUlRfQVJHKGtleSwga2V5KTsKICAgICBVTlVTRURfUEFSQU0odmFs dWUpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvRmVhdHVy ZUNvdW50ZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvRmVhdHVyZUNvdW50ZXIu bW0KaW5kZXggMjUxZGZmYjU0OWZmMjQ5MWMwODhlOWVhN2IwNDcyNDA1ODRjMzk1MC4uNjEyOThk ZWUxMDJhOWJjYTYyNTAyNzEwYTdlNmQwODg2Nzc0ZTk0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW9zL0ZlYXR1cmVDb3VudGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2lvcy9GZWF0dXJlQ291bnRlci5tbQpAQCAtMzMsNiArMzMsNyBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIHZvaWQgRmVhdHVyZUNvdW50ZXI6OmluY3JlbWVudEtleShQYWdlKiBw YWdlLCBjb25zdCBjaGFyKiBjb25zdCBrZXkpCiB7CisgICAgQVNTRVJUKGtleSk7CiAgICAgaWYg KCFzaG91bGRVc2VGb3JQYWdlKHBhZ2UpKQogICAgICAgICByZXR1cm47CiAKQEAgLTQyLDYgKzQz LDcgQEAgdm9pZCBGZWF0dXJlQ291bnRlcjo6aW5jcmVtZW50S2V5KFBhZ2UqIHBhZ2UsIGNvbnN0 IGNoYXIqIGNvbnN0IGtleSkKIAogdm9pZCBGZWF0dXJlQ291bnRlcjo6c2V0S2V5KFBhZ2UqIHBh Z2UsIGNvbnN0IGNoYXIqIGNvbnN0IGtleSwgaW50NjRfdCB2YWx1ZSkKIHsKKyAgICBBU1NFUlQo a2V5KTsKICAgICBpZiAoIXNob3VsZFVzZUZvclBhZ2UocGFnZSkpCiAgICAgICAgIHJldHVybjsK IAo= 243873 2015-01-01 15:12:00 -0800 2015-01-01 15:53:20 -0800 Patch bug-140030-20150101151203.patch text/plain 2382 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3ODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWNiNzQ3MjZjNDI3MmMw MjczM2FlYzQyNzVmYzYyYTRmMjgyNDUzNS4uMzUwYjRjMDM2YzJmOTJiNjM0YjMzOGM0YTYwZTFk MTMwOTI1Y2YyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTAxLTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQVNTRVJUIHRoYXQgYSBudWxs IGtleSBpcyBuZXZlciB1c2VkIHdpdGggRmVhdHVyZUNvdW50ZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDAzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgICogcGxhdGZvcm0vRmVhdHVyZUNvdW50ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RmVhdHVyZUNvdW50ZXI6OmluY3JlbWVudEtleSk6CisgICAg ICAgIChXZWJDb3JlOjpGZWF0dXJlQ291bnRlcjo6c2V0S2V5KToKKyAgICAgICAgKiBwbGF0Zm9y bS9pb3MvRmVhdHVyZUNvdW50ZXIubW06CisgICAgICAgIChXZWJDb3JlOjpGZWF0dXJlQ291bnRl cjo6aW5jcmVtZW50S2V5KToKKyAgICAgICAgKFdlYkNvcmU6OkZlYXR1cmVDb3VudGVyOjpzZXRL ZXkpOgorCisyMDE1LTAxLTAxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAg ICAgICAgW2lPU10gRml4IG1lbW9yeSBsZWFrIGluIEZlYXR1cmVDb3VudGVyCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAwMjkKICAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzE5MjU1NjkwPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vRmVhdHVyZUNvdW50ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmVhdHVyZUNv dW50ZXIuY3BwCmluZGV4IDhjMzdkMjgzNWJkOWZjYzIyZjRkMDlkNmQwOGMyYzAwMWFhOTQ0MWIu LjIxMmQwNmQ0ZTc3ODY3Y2ZjMDRmYjg2NjdmZDgwNTFkYzFhZjA5NWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZlYXR1cmVDb3VudGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9GZWF0dXJlQ291bnRlci5jcHAKQEAgLTUyLDEzICs1MiwxMyBAQCBib29s IEZlYXR1cmVDb3VudGVyOjpzaG91bGRVc2VGb3JQYWdlKFBhZ2UqIHBhZ2UpCiB2b2lkIEZlYXR1 cmVDb3VudGVyOjppbmNyZW1lbnRLZXkoUGFnZSogcGFnZSwgY29uc3QgY2hhciogY29uc3Qga2V5 KQogewogICAgIFVOVVNFRF9QQVJBTShwYWdlKTsKLSAgICBVTlVTRURfUEFSQU0oa2V5KTsKKyAg ICBBU1NFUlRfVU5VU0VEKGtleSwga2V5KTsKIH0KIAogdm9pZCBGZWF0dXJlQ291bnRlcjo6c2V0 S2V5KFBhZ2UqIHBhZ2UsIGNvbnN0IGNoYXIqIGNvbnN0IGtleSwgaW50NjRfdCB2YWx1ZSkKIHsK ICAgICBVTlVTRURfUEFSQU0ocGFnZSk7Ci0gICAgVU5VU0VEX1BBUkFNKGtleSk7CisgICAgQVNT RVJUX1VOVVNFRChrZXksIGtleSk7CiAgICAgVU5VU0VEX1BBUkFNKHZhbHVlKTsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0ZlYXR1cmVDb3VudGVyLm1tIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0ZlYXR1cmVDb3VudGVyLm1tCmluZGV4IDdiMjY5 ZDI0MzU0MTkwMjgyMDQ5MDk1NTFmNGY4ZTYxNTE4N2U3MGYuLjNkNjFmMzQ4NTc0N2IwZTc4NjMx NGM0OWI0ZTZmNjQ1ZGFiYzZkODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy9GZWF0dXJlQ291bnRlci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mv RmVhdHVyZUNvdW50ZXIubW0KQEAgLTM0LDYgKzM0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiB2b2lkIEZlYXR1cmVDb3VudGVyOjppbmNyZW1lbnRLZXkoUGFnZSogcGFnZSwgY29uc3QgY2hh ciogY29uc3Qga2V5KQogeworICAgIEFTU0VSVChrZXkpOwogICAgIGlmICghc2hvdWxkVXNlRm9y UGFnZShwYWdlKSkKICAgICAgICAgcmV0dXJuOwogCkBAIC00Myw2ICs0NCw3IEBAIHZvaWQgRmVh dHVyZUNvdW50ZXI6OmluY3JlbWVudEtleShQYWdlKiBwYWdlLCBjb25zdCBjaGFyKiBjb25zdCBr ZXkpCiAKIHZvaWQgRmVhdHVyZUNvdW50ZXI6OnNldEtleShQYWdlKiBwYWdlLCBjb25zdCBjaGFy KiBjb25zdCBrZXksIGludDY0X3QgdmFsdWUpCiB7CisgICAgQVNTRVJUKGtleSk7CiAgICAgaWYg KCFzaG91bGRVc2VGb3JQYWdlKHBhZ2UpKQogICAgICAgICByZXR1cm47CiAK