140029 2015-01-01 13:04:17 -0800 [iOS] Fix memory leak in FeatureCounter 2015-01-01 14:36:02 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 139652 1 cdumez cdumez commit-queue darin ddkilzer kling koivisto oldest_to_newest 1058345 0 cdumez 2015-01-01 13:04:17 -0800 Fix memory leak in FeatureCounter, the NSString for the counter key is never released. Radar: <rdar://problem/19255690> 1058346 1 243868 cdumez 2015-01-01 13:06:46 -0800 Created attachment 243868 Patch 1058355 2 243868 commit-queue 2015-01-01 14:35:58 -0800 Comment on attachment 243868 Patch Clearing flags on attachment: 243868 Committed r177850: <http://trac.webkit.org/changeset/177850> 1058356 3 commit-queue 2015-01-01 14:36:02 -0800 All reviewed patches have been landed. Closing bug. 243868 2015-01-01 13:06:46 -0800 2015-01-01 14:35:58 -0800 Patch bug-140029-20150101130648.patch text/plain 2839 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3ODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTEzM2VkYTQ0NGY5N2Jj ZjVjZThkYmFmNjBiNzE1ZTI1MzBjMjIxZC4uNzg0ZGE0NGMxZmI3YWFlZTg5MGU2OGI0NzNhMzYw NjY0M2VlOTIwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAxLTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gRml4IG1lbW9yeSBs ZWFrIGluIEZlYXR1cmVDb3VudGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDAwMjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE5MjU1NjkwPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBtZW1v cnkgbGVhayBpbiBGZWF0dXJlQ291bnRlci4gVGhlIE5TU3RyaW5nIGZvciB0aGUgY291bnRlciBr ZXkKKyAgICAgICAgd2FzIGFsbG9jYXRlZCBidXQgbmV2ZXIgcmVsZWFzZWQuIFRoZSBwYXRjaCBz d2l0Y2hlcyB0byB1c2luZyBhCisgICAgICAgIFJldGFpblB0ciBpbnN0ZWFkIG9mIGEgcmF3IHBv aW50ZXIgdG8gYXZvaWQgdGhlIGlzc3VlLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL0ZlYXR1 cmVDb3VudGVyLm1tOgorICAgICAgICAoV2ViQ29yZTo6RmVhdHVyZUNvdW50ZXI6OmluY3JlbWVu dEtleSk6CisgICAgICAgIChXZWJDb3JlOjpGZWF0dXJlQ291bnRlcjo6c2V0S2V5KToKKwogMjAx NC0xMi0zMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUg J2ZvbnQtc2l6ZScgQ1NTIHByb3BlcnR5IHRvIHRoZSBuZXcgU3R5bGVCdWlsZGVyCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvRmVhdHVyZUNvdW50ZXIubW0gYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvRmVhdHVyZUNvdW50ZXIubW0KaW5kZXggMjUxZGZmYjU0 OWZmMjQ5MWMwODhlOWVhN2IwNDcyNDA1ODRjMzk1MC4uN2IyNjlkMjQzNTQxOTAyODIwNDkwOTU1 MWY0ZjhlNjE1MTg3ZTcwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9z L0ZlYXR1cmVDb3VudGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9GZWF0 dXJlQ291bnRlci5tbQpAQCAtMjgsNiArMjgsNyBAQAogCiAjaWYgUExBVEZPUk0oSU9TKSAmJiBV U0UoQVBQTEVfSU5URVJOQUxfU0RLKQogI2ltcG9ydCA8QXBwU3VwcG9ydC9DUEFnZ3JlZ2F0ZURp Y3Rpb25hcnkuaD4KKyNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIApAQCAtMzYsOCArMzcsOCBAQCB2b2lkIEZlYXR1cmVDb3VudGVyOjppbmNyZW1lbnRL ZXkoUGFnZSogcGFnZSwgY29uc3QgY2hhciogY29uc3Qga2V5KQogICAgIGlmICghc2hvdWxkVXNl Rm9yUGFnZShwYWdlKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgTlNTdHJpbmcgKm5zS2V5ID0g W1tOU1N0cmluZyBhbGxvY10gaW5pdFdpdGhDaGFyYWN0ZXJzTm9Db3B5OnJlaW50ZXJwcmV0X2Nh c3Q8dW5pY2hhcio+KGNvbnN0X2Nhc3Q8Y2hhcio+KGtleSkpIGxlbmd0aDpzdHJsZW4oa2V5KSBm cmVlV2hlbkRvbmU6Tk9dOwotICAgIFtbQ1BBZ2dyZWdhdGVEaWN0aW9uYXJ5IHNoYXJlZEFnZ3Jl Z2F0ZURpY3Rpb25hcnldIGluY3JlbWVudEtleTpuc0tleV07CisgICAgUmV0YWluUHRyPE5TU3Ry aW5nPiBuc0tleSA9IGFkb3B0TlMoW1tOU1N0cmluZyBhbGxvY10gaW5pdFdpdGhDaGFyYWN0ZXJz Tm9Db3B5OnJlaW50ZXJwcmV0X2Nhc3Q8dW5pY2hhcio+KGNvbnN0X2Nhc3Q8Y2hhcio+KGtleSkp IGxlbmd0aDpzdHJsZW4oa2V5KSBmcmVlV2hlbkRvbmU6Tk9dKTsKKyAgICBbW0NQQWdncmVnYXRl RGljdGlvbmFyeSBzaGFyZWRBZ2dyZWdhdGVEaWN0aW9uYXJ5XSBpbmNyZW1lbnRLZXk6bnNLZXku Z2V0KCldOwogfQogCiB2b2lkIEZlYXR1cmVDb3VudGVyOjpzZXRLZXkoUGFnZSogcGFnZSwgY29u c3QgY2hhciogY29uc3Qga2V5LCBpbnQ2NF90IHZhbHVlKQpAQCAtNDUsOCArNDYsOCBAQCB2b2lk IEZlYXR1cmVDb3VudGVyOjpzZXRLZXkoUGFnZSogcGFnZSwgY29uc3QgY2hhciogY29uc3Qga2V5 LCBpbnQ2NF90IHZhbHVlKQogICAgIGlmICghc2hvdWxkVXNlRm9yUGFnZShwYWdlKSkKICAgICAg ICAgcmV0dXJuOwogCi0gICAgTlNTdHJpbmcgKm5zS2V5ID0gW1tOU1N0cmluZyBhbGxvY10gaW5p dFdpdGhDaGFyYWN0ZXJzTm9Db3B5OnJlaW50ZXJwcmV0X2Nhc3Q8dW5pY2hhcio+KGNvbnN0X2Nh c3Q8Y2hhcio+KGtleSkpIGxlbmd0aDpzdHJsZW4oa2V5KSBmcmVlV2hlbkRvbmU6Tk9dOwotICAg IFtbQ1BBZ2dyZWdhdGVEaWN0aW9uYXJ5IHNoYXJlZEFnZ3JlZ2F0ZURpY3Rpb25hcnldIHNldFZh bHVlOnZhbHVlIGZvclNjYWxhcktleTpuc0tleV07CisgICAgUmV0YWluUHRyPE5TU3RyaW5nPiBu c0tleSA9IGFkb3B0TlMoW1tOU1N0cmluZyBhbGxvY10gaW5pdFdpdGhDaGFyYWN0ZXJzTm9Db3B5 OnJlaW50ZXJwcmV0X2Nhc3Q8dW5pY2hhcio+KGNvbnN0X2Nhc3Q8Y2hhcio+KGtleSkpIGxlbmd0 aDpzdHJsZW4oa2V5KSBmcmVlV2hlbkRvbmU6Tk9dKTsKKyAgICBbW0NQQWdncmVnYXRlRGljdGlv bmFyeSBzaGFyZWRBZ2dyZWdhdGVEaWN0aW9uYXJ5XSBzZXRWYWx1ZTp2YWx1ZSBmb3JTY2FsYXJL ZXk6bnNLZXkuZ2V0KCldOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==