140005 2014-12-30 04:19:26 -0800 Fix build warnings after r177792 2014-12-31 09:17:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139978 1 b.gajda webkit-unassigned andersca commit-queue ossy sam oldest_to_newest 1058174 0 b.gajda 2014-12-30 04:19:26 -0800 After that revision following errors appeared: DerivedSources/WebKit2/NetworkResourceLoaderMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/PluginProcessMessageReceiver.cpp:41:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/NetworkProcessMessageReceiver.cpp:50:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/NetworkConnectionToWebProcessMessageReceiver.cpp:80:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebProcessConnectionMessageReceiver.cpp:87:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/PluginControllerProxyMessageReceiver.cpp:74:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebFullScreenManagerMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebProcessProxyMessageReceiver.cpp:132:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/NetworkProcessConnectionMessageReceiver.cpp:49:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/PluginProcessConnectionMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebProcessMessageReceiver.cpp:51:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebResourceLoaderMessageReceiver.cpp:48:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/PluginProxyMessageReceiver.cpp:45:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/CoordinatedLayerTreeHostMessageReceiver.cpp:41:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebPageMessageReceiver.cpp:128:6: warning: unused parameter ‘connection’ [-Wunused-parameter] 1058175 1 243821 b.gajda 2014-12-30 04:23:25 -0800 Created attachment 243821 patch v1 The most important part is to add UNUSED_PARAM even if it's LegacyReceiver, but I also refactored a bit code around, so there are no unneccessary ifs. 1058255 2 243821 commit-queue 2014-12-31 09:17:00 -0800 Comment on attachment 243821 patch v1 Clearing flags on attachment: 243821 Committed r177833: <http://trac.webkit.org/changeset/177833> 1058256 3 commit-queue 2014-12-31 09:17:04 -0800 All reviewed patches have been landed. Closing bug. 243821 2014-12-30 04:23:25 -0800 2014-12-31 09:17:00 -0800 patch v1 patch_warnings.txt text/plain 3438 b.gajda ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZWJlYzhhLi4wNzI1MzgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMTItMzAgIEJhcnRsb21pZWogR2FqZGEgIDxiLmdhamRhQHNhbXN1bmcuY29tPgor CisgICAgICAgIEZpeCBidWlsZCB3YXJuaW5ncyBhZnRlciByMTc3NzkyLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMDA1LgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBVTlVTRURfUEFSQU0oY29u bmVjdGlvbikgZm9yIGFzeW5jIG1lc3NhZ2VzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXQv bWVzc2FnZXMucHk6CisgICAgICAgIChnZW5lcmF0ZV9tZXNzYWdlX2hhbmRsZXIpOgorCiAyMDE0 LTEyLTI5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAg UmVtb3ZlIHVubmVlZGVkIFN0b3JhZ2VOYW1lc3BhY2UgZnVuY3Rpb25zCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdC9tZXNzYWdlcy5weSBiL1NvdXJjZS9XZWJLaXQy L1NjcmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5CmluZGV4IDlmNzg4MzMuLjk3N2YxNGQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5CisrKyBiL1Nv dXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5CkBAIC01MjAsMzMgKzUyMCwy MyBAQCBkZWYgZ2VuZXJhdGVfbWVzc2FnZV9oYW5kbGVyKGZpbGUpOgogICAgICAgICAgICAgYXN5 bmNfbWVzc2FnZXMuYXBwZW5kKG1lc3NhZ2UpCiAKICAgICBpZiBhc3luY19tZXNzYWdlczoKLSAg ICAgICAgaWYgcmVjZWl2ZXIuaGFzX2F0dHJpYnV0ZShMRUdBQ1lfUkVDRUlWRVJfQVRUUklCVVRF KToKLSAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoJ3ZvaWQgJXM6OmRpZFJlY2VpdmUlc01lc3Nh Z2UoSVBDOjpDb25uZWN0aW9uKiBjb25uZWN0aW9uLCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJiBkZWNv ZGVyKVxuJyAlIChyZWNlaXZlci5uYW1lLCByZWNlaXZlci5uYW1lKSkKLSAgICAgICAgZWxzZToK LSAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoJ3ZvaWQgJXM6OmRpZFJlY2VpdmVNZXNzYWdlKElQ Qzo6Q29ubmVjdGlvbiogY29ubmVjdGlvbiwgSVBDOjpNZXNzYWdlRGVjb2RlciYgZGVjb2Rlcilc bicgJSAocmVjZWl2ZXIubmFtZSkpCi0KKyAgICAgICAgcmVzdWx0LmFwcGVuZCgndm9pZCAlczo6 ZGlkUmVjZWl2ZSVzTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24sIElQQzo6TWVz c2FnZURlY29kZXImIGRlY29kZXIpXG4nICUgKHJlY2VpdmVyLm5hbWUsIHJlY2VpdmVyLm5hbWUg aWYgcmVjZWl2ZXIuaGFzX2F0dHJpYnV0ZShMRUdBQ1lfUkVDRUlWRVJfQVRUUklCVVRFKSBlbHNl ICcnKSkKICAgICAgICAgcmVzdWx0LmFwcGVuZCgne1xuJykKICAgICAgICAgcmVzdWx0ICs9IFth c3luY19tZXNzYWdlX3N0YXRlbWVudChyZWNlaXZlciwgbWVzc2FnZSkgZm9yIG1lc3NhZ2UgaW4g YXN5bmNfbWVzc2FnZXNdCiAgICAgICAgIGlmIChyZWNlaXZlci5zdXBlcmNsYXNzKToKICAgICAg ICAgICAgIHJlc3VsdC5hcHBlbmQoJyAgICAlczo6ZGlkUmVjZWl2ZU1lc3NhZ2UoY29ubmVjdGlv biwgZGVjb2Rlcik7XG4nICUgKHJlY2VpdmVyLnN1cGVyY2xhc3MpKQogICAgICAgICBlbHNlOgot ICAgICAgICAgICAgaWYgbm90IHJlY2VpdmVyLmhhc19hdHRyaWJ1dGUoTEVHQUNZX1JFQ0VJVkVS X0FUVFJJQlVURSk6Ci0gICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgnICAgIFVOVVNFRF9Q QVJBTShjb25uZWN0aW9uKTtcbicpCisgICAgICAgICAgICByZXN1bHQuYXBwZW5kKCcgICAgVU5V U0VEX1BBUkFNKGNvbm5lY3Rpb24pO1xuJykKICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoJyAg ICBVTlVTRURfUEFSQU0oZGVjb2Rlcik7XG4nKQogICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgn ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpO1xuJykKICAgICAgICAgcmVzdWx0LmFwcGVuZCgnfVxu JykKIAogICAgIGlmIHN5bmNfbWVzc2FnZXM6CiAgICAgICAgIHJlc3VsdC5hcHBlbmQoJ1xuJykK LSAgICAgICAgdXNlX2Nvbm5lY3Rpb24gPSBUcnVlCi0gICAgICAgIGlmIHJlY2VpdmVyLmhhc19h dHRyaWJ1dGUoTEVHQUNZX1JFQ0VJVkVSX0FUVFJJQlVURSk6Ci0gICAgICAgICAgICByZXN1bHQu YXBwZW5kKCd2b2lkICVzOjpkaWRSZWNlaXZlU3luYyVzTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24q IGNvbm5lY3Rpb24sIElQQzo6TWVzc2FnZURlY29kZXImIGRlY29kZXIsIHN0ZDo6dW5pcXVlX3B0 cjxJUEM6Ok1lc3NhZ2VFbmNvZGVyPiYgcmVwbHlFbmNvZGVyKVxuJyAlIChyZWNlaXZlci5uYW1l LCByZWNlaXZlci5uYW1lKSkKLSAgICAgICAgZWxzZToKLSAgICAgICAgICAgIHJlc3VsdC5hcHBl bmQoJ3ZvaWQgJXM6OmRpZFJlY2VpdmVTeW5jTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24qIGNvbm5l Y3Rpb24sIElQQzo6TWVzc2FnZURlY29kZXImIGRlY29kZXIsIHN0ZDo6dW5pcXVlX3B0cjxJUEM6 Ok1lc3NhZ2VFbmNvZGVyPiYgcmVwbHlFbmNvZGVyKVxuJyAlIChyZWNlaXZlci5uYW1lKSkKKyAg ICAgICAgcmVzdWx0LmFwcGVuZCgndm9pZCAlczo6ZGlkUmVjZWl2ZVN5bmMlc01lc3NhZ2UoSVBD OjpDb25uZWN0aW9uKiBjb25uZWN0aW9uLCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJiBkZWNvZGVyLCBz dGQ6OnVuaXF1ZV9wdHI8SVBDOjpNZXNzYWdlRW5jb2Rlcj4mIHJlcGx5RW5jb2RlcilcbicgJSAo cmVjZWl2ZXIubmFtZSwgcmVjZWl2ZXIubmFtZSBpZiByZWNlaXZlci5oYXNfYXR0cmlidXRlKExF R0FDWV9SRUNFSVZFUl9BVFRSSUJVVEUpIGVsc2UgJycpKQogICAgICAgICByZXN1bHQuYXBwZW5k KCd7XG4nKQogICAgICAgICByZXN1bHQgKz0gW3N5bmNfbWVzc2FnZV9zdGF0ZW1lbnQocmVjZWl2 ZXIsIG1lc3NhZ2UpIGZvciBtZXNzYWdlIGluIHN5bmNfbWVzc2FnZXNdCi0gICAgICAgIGlmIHVz ZV9jb25uZWN0aW9uOgotICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgnICAgIFVOVVNFRF9QQVJB TShjb25uZWN0aW9uKTtcbicpCisgICAgICAgIHJlc3VsdC5hcHBlbmQoJyAgICBVTlVTRURfUEFS QU0oY29ubmVjdGlvbik7XG4nKQogICAgICAgICByZXN1bHQuYXBwZW5kKCcgICAgVU5VU0VEX1BB UkFNKGRlY29kZXIpO1xuJykKICAgICAgICAgcmVzdWx0LmFwcGVuZCgnICAgIFVOVVNFRF9QQVJB TShyZXBseUVuY29kZXIpO1xuJykKICAgICAgICAgcmVzdWx0LmFwcGVuZCgnICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpO1xuJykK