140000 2014-12-29 16:24:29 -0800 REGRESSION(r177795): [GTK] Build broken 2014-12-31 03:36:01 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139990 1 clopez zan andersca cgarcia ossy sam zan oldest_to_newest 1058150 0 clopez 2014-12-29 16:24:29 -0800 Revision r177795 <http://trac.webkit.org/r177795> has broken the GTK build: Build log: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/54028/steps/compile-webkit/logs/stdio 1058180 1 243823 zan 2014-12-30 07:26:20 -0800 Created attachment 243823 Patch 1058181 2 243823 zan 2014-12-30 07:39:53 -0800 Comment on attachment 243823 Patch I'm not exactly sure why and how the build error popped up now, but the GTK-specific argument coders were simply not included (anymore?) in the WebPageProxyMessageReceiver.cpp file. This should fix it for good, but I want a review to asses whether it might not be an appropriate approach. 1058189 3 243823 darin 2014-12-30 10:03:17 -0800 Comment on attachment 243823 Patch Seems probably not the right approach. ArgumentCodersCF.h and ArgumentCodersMac.h don’t work this way. 1058226 4 243823 ossy 2014-12-31 00:37:38 -0800 Comment on attachment 243823 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243823&action=review Why not simply including ArgumentCodersGtk.h from the sources which need it? Or including it from only ArgumentCoders.h and adding a guard to avoid including it from anywhere else. > Source/WebKit2/Platform/IPC/ArgumentCoders.h:305 > +#if PLATFORM(GTK) > +#include "ArgumentCodersGtk.h" > +#endif ArgumentCoders.h is included in ArgumentCodersGtk.h too. 1058238 5 ossy 2014-12-31 02:10:43 -0800 (In reply to comment #4) > Why not simply including ArgumentCodersGtk.h from the sources which need it? Ah, WebPageProxyMessageReceiver.cpp is a generated source, so it isn't so easy to fix the generator properly. 1058239 6 ossy 2014-12-31 02:22:10 -0800 (In reply to comment #2) > Comment on attachment 243823 [details] > Patch > > I'm not exactly sure why and how the build error popped up now, but the > GTK-specific argument coders were simply not included (anymore?) in the > WebPageProxyMessageReceiver.cpp file. This should fix it for good, but I > want a review to asses whether it might not be an appropriate approach. I found the root of the problem. Before r177795 ArgumentCodersGtk.h was included indirectly: InjectedBundleUserMessageCoders.h -> WebPage.h -> ArgumentCodersGtk.h. But now InjectedBundleUserMessageCoders.h isn't included anymore. 1058244 7 zan 2014-12-31 03:35:28 -0800 Committed a fix in r177832. http://trac.webkit.org/changeset/177832 I just moved the ArgumentCodersGtk.h inclusion from WebPageProxy.cpp to WebPageProxy.h, which makes ArgumentCoder<WebCore::DragData> available in WebPageProxyMessageReceiver.cpp. 243823 2014-12-30 07:26:20 -0800 2014-12-31 03:36:01 -0800 Patch bug-140000-20141230072807.patch text/plain 3020 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3ODIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWViZWM4YTYxZGI0ZDg5 MTBmOWYzYjhlOTFmZDQzZTZlMWVhMWRjMi4uNWQ0YzgxMGRiYTJlZDIxZmE1OGY3MWI1NWJhYWEw MDQ3ZWE3MGJiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEyLTMwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIx Nzc3OTUpOiBbR1RLXSBCdWlsZCBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MDAwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluY2x1ZGUgQXJndW1lbnRDb2RlcnNHdGsuaCBhdCB0aGUgZW5k IG9mIEFyZ3VtZW50Q29kZXJzLmggZm9yIHRoZSBHVEsKKyAgICAgICAgcG9ydC4gVGhpcyBpbW1l ZGlhdGVseSBpbnRyb2R1Y2VzIGFsbCB0aGUgcmVxdWlyZWQgSVBDIGNvZGVycyB0aGF0IGFyZQor ICAgICAgICB1dGlsaXplZCBpbiBhdXRvbWF0aWNhbGx5IGdlbmVyYXRlZCBJUEMgbWVzc2FnZSBy ZWNlaXZlciBjb2RlLgorCisgICAgICAgIEFyZ3VtZW50Q29kZXJzR3RrLmggaW5jbHVzaW9ucyBh cmUgYWxzbyByZW1vdmVkIHdoZXJlIHBvc3NpYmxlLgorCisgICAgICAgICogUGxhdGZvcm0vSVBD L0FyZ3VtZW50Q29kZXJzLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6 CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9ndGsvV2ViRHJhZ0NsaWVudEd0 ay5jcHA6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoKKwogMjAxNC0x Mi0yOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJl bW92ZSB1bm5lZWRlZCBTdG9yYWdlTmFtZXNwYWNlIGZ1bmN0aW9ucwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL0FyZ3VtZW50Q29kZXJzLmggYi9Tb3VyY2UvV2ViS2l0 Mi9QbGF0Zm9ybS9JUEMvQXJndW1lbnRDb2RlcnMuaAppbmRleCA0NjJjZTM3NmRlYmQ2Y2QyMTcw YTE4YjE4MzQyYjBjY2Y1YTViNjg4Li5iNjgxNDlmYTQwYzFhOTM1NjVkNjAzMjQ1ZTQxMjJkZDFi OTM0ZGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQXJndW1lbnRD b2RlcnMuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQXJndW1lbnRDb2RlcnMu aApAQCAtMzAwLDQgKzMwMCw4IEBAIHRlbXBsYXRlPD4gc3RydWN0IEFyZ3VtZW50Q29kZXI8U3Ry aW5nPiB7CiAKIH0gLy8gbmFtZXNwYWNlIElQQwogCisjaWYgUExBVEZPUk0oR1RLKQorI2luY2x1 ZGUgIkFyZ3VtZW50Q29kZXJzR3RrLmgiCisjZW5kaWYKKwogI2VuZGlmIC8vIEFyZ3VtZW50Q29k ZXJzX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggMmMy NDViNDE1M2E2N2MzNTZkNmQwNzhkODBkYWEyZjc2NmQxOGVjYS4uMDI4MmU5NDI0OTRkNTY1ZTRh ODU3NDQ3MWM4NmUxMDIxYjEyYmEwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAKQEAgLTExMywxMCArMTEzLDYgQEAKICNpbmNsdWRlICJDb29yZGluYXRlZExh eWVyVHJlZUhvc3RQcm94eU1lc3NhZ2VzLmgiCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKEdUSykK LSNpbmNsdWRlICJBcmd1bWVudENvZGVyc0d0ay5oIgotI2VuZGlmCi0KICNpZiBFTkFCTEUoVklC UkFUSU9OKQogI2luY2x1ZGUgIldlYlZpYnJhdGlvblByb3h5LmgiCiAjZW5kaWYKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZ3RrL1dlYkRyYWdD bGllbnRHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9n dGsvV2ViRHJhZ0NsaWVudEd0ay5jcHAKaW5kZXggOWFjM2I2NzEyYWJlMzJkOTRlYWU1NGY4ZGIw MzM0NmNjNGM4YjlkYS4uNzJjOWFkZDg1MjEyMWM2ZDE0YWEyNDQ2YThiNDk4MzNlYmMyYTRhOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9ndGsv V2ViRHJhZ0NsaWVudEd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJD b3JlU3VwcG9ydC9ndGsvV2ViRHJhZ0NsaWVudEd0ay5jcHAKQEAgLTI4LDcgKzI4LDYgQEAKIAog I2lmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAKLSNpbmNsdWRlICJBcmd1bWVudENvZGVyc0d0ay5o IgogI2luY2x1ZGUgIlNoYXJlYWJsZUJpdG1hcC5oIgogI2luY2x1ZGUgIldlYlBhZ2UuaCIKICNp bmNsdWRlICJXZWJQYWdlUHJveHlNZXNzYWdlcy5oIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmgKaW5kZXggZDRhNTJjN2FlZTllMzM0YTFiNzcyMjY5MGViOWNm Yzc0YTQ1Mjg0ZC4uMDY5N2YxMDkzZjU3ZWNkYzk4ODNjODk5MmM5NzlmMGMxNTc3ZDg3YSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCkBAIC03Nyw3ICs3 Nyw2IEBACiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKEdUSykKLSNpbmNsdWRlICJBcmd1bWVudENv ZGVyc0d0ay5oIgogI2luY2x1ZGUgIldlYlByaW50T3BlcmF0aW9uR3RrLmgiCiAjZW5kaWYKIAo=