139984 2014-12-28 23:14:32 -0800 [EFL] The size of contents wasn't updated immediately after r176631 2017-03-11 10:36:30 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 hs85.jeong hs85.jeong gyuyoung.kim gyuyoung.kim lucas.de.marchi mcatanzaro oldest_to_newest 1058076 0 hs85.jeong 2014-12-28 23:14:32 -0800 You can watch this problem after clicking the button of maximize window in MiniBrowser. It looks like page has wrong scale factor. I added logs in PageViewportController::updateMinimumScaleToFit() to fix this issue. Logs are : (when click the maximize button) [PageViewportController::updateMinimumScaleToFit] m_viewportSize width:1920.000000 height:964.000000 [PageViewportController::updateMinimumScaleToFit] m_contentsSize width:800.000000 height:560.000000 [PageViewportController::updateMinimumScaleToFit] currentlyScaledToFit:1 [PageViewportController::updateMinimumScaleToFit] minimumScale:2.400000 [PageViewportController::updateMinimumScaleToFit] m_minimumScaleToFit:1.000000 [PageViewportController::applyScaleAfterRenderingContents] scale:2.400000 minimumScale updated the wrong value because the size of viewport was not the same with contents. 1058077 1 243791 hs85.jeong 2014-12-28 23:26:55 -0800 Created attachment 243791 Patch 1058078 2 hs85.jeong 2014-12-28 23:44:18 -0800 I try to update the size of contents immediately to fix this problem but it still occurred at www.naver.com. I will try to find the cause to fix this issue. 1058169 3 243818 hs85.jeong 2014-12-30 01:29:33 -0800 Created attachment 243818 Patch 1058171 4 hs85.jeong 2014-12-30 01:43:10 -0800 After attachment 243818, Page was scaled correctly when clicked the maxmize button in MiniBrowser. Gyuyoung, Could I ask why you removed m_hadUserInteraction in updateMinimumScaleToFit()? But api test still failed in EWK2ViewTest.ewk_view_scale_with_fixed_layout. ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:917: Failure Value of: ewk_view_scale_get(webView()) Actual: 0.81632656 Expected: 1 916: // Default scale value is 1.0. 917: ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())); 1058225 5 gyuyoung.kim 2014-12-30 23:38:37 -0800 (In reply to comment #4) > After attachment 243818 [details], Page was scaled correctly when clicked > the maxmize button in MiniBrowser. > > Gyuyoung, Could I ask why you removed m_hadUserInteraction in > updateMinimumScaleToFit()? IIRC, I removed it because it seems we don't need to use it. If we need to use it, we can revert it. > But api test still failed in EWK2ViewTest.ewk_view_scale_with_fixed_layout. > > ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:917: Failure > Value of: ewk_view_scale_get(webView()) > Actual: 0.81632656 > Expected: 1 > > 916: // Default scale value is 1.0. > 917: ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())); Hmm, this test was passed when I landed r176631. I guess following patch made this regression. 1060514 6 244432 hs85.jeong 2015-01-12 00:06:09 -0800 Created attachment 244432 Patch 1060517 7 244432 gyuyoung.kim 2015-01-12 00:29:10 -0800 Comment on attachment 244432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244432&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-914 > - ASSERT_TRUE(loadUrlSync(environment->defaultTestPageUrl())); If we don't load a test page, what is meaning to check if default scale value is 1.0 below ? ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())); > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-919 > - ASSERT_TRUE(ewk_view_scale_set(webView(), 1.2, 0, 0)); This is to test that webview can keep previous scale factor after reloading a page. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-924 > - ASSERT_TRUE(ewk_view_scale_set(webView(), 1.5, 0, 0)); ditto. 1060518 8 244432 hs85.jeong 2015-01-12 00:35:35 -0800 Comment on attachment 244432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244432&action=review >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-914 >> - ASSERT_TRUE(loadUrlSync(environment->defaultTestPageUrl())); > > If we don't load a test page, what is meaning to check if default scale value is 1.0 below ? > > ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())); If load the defaultTestPage, pageScaleFactor was changed from 1.0 to 0.81632656 because default contentSize(980x735) bigger then default viewSize(800x560). So I removed the "loadUrlSync(environment->defaultTestPageUrl())" to check the default value of pageScaleFactor whether it is 1.0. >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-919 >> - ASSERT_TRUE(ewk_view_scale_set(webView(), 1.2, 0, 0)); > > This is to test that webview can keep previous scale factor after reloading a page. If ewk_view_scale_set() was invoked before loadUrl(), it didn't set pageScaleFactor because syncVisibleContents() failed. If syncVisibleContents() failed, it recover the original pageScaleFactor that was old one. So I moved the ewk_view_scale_set() after invoking the loadUrlSync(). 1060523 9 244432 gyuyoung.kim 2015-01-12 01:34:11 -0800 Comment on attachment 244432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244432&action=review >>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-914 >>> - ASSERT_TRUE(loadUrlSync(environment->defaultTestPageUrl())); >> >> If we don't load a test page, what is meaning to check if default scale value is 1.0 below ? >> >> ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())); > > If load the defaultTestPage, pageScaleFactor was changed from 1.0 to 0.81632656 because default contentSize(980x735) bigger then default viewSize(800x560). > So I removed the "loadUrlSync(environment->defaultTestPageUrl())" to check the default value of pageScaleFactor whether it is 1.0. If so, we have to change the default content size with 800x560. I think you change test behavior without reasonable reason. >>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-919 >>> - ASSERT_TRUE(ewk_view_scale_set(webView(), 1.2, 0, 0)); >> >> This is to test that webview can keep previous scale factor after reloading a page. > > If ewk_view_scale_set() was invoked before loadUrl(), it didn't set pageScaleFactor because syncVisibleContents() failed. > If syncVisibleContents() failed, it recover the original pageScaleFactor that was old one. > So I moved the ewk_view_scale_set() after invoking the loadUrlSync(). I don't understand well. We already load a default test page in 914 line before you removed it. If so, ewk_view_scale_set(webView(), 1.2, 0, 0) should not be failed, isn't it ? 1060527 10 244432 hs85.jeong 2015-01-12 02:12:14 -0800 Comment on attachment 244432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244432&action=review >>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-914 >>>> - ASSERT_TRUE(loadUrlSync(environment->defaultTestPageUrl())); >>> >>> If we don't load a test page, what is meaning to check if default scale value is 1.0 below ? >>> >>> ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())); >> >> If load the defaultTestPage, pageScaleFactor was changed from 1.0 to 0.81632656 because default contentSize(980x735) bigger then default viewSize(800x560). >> So I removed the "loadUrlSync(environment->defaultTestPageUrl())" to check the default value of pageScaleFactor whether it is 1.0. > > If so, we have to change the default content size with 800x560. I think you change test behavior without reasonable reason. Yes, ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())) passed if I changed the default page width from 980 to 800 in ViewportConfiguration::webpageParameters(). Should I changed the value in EFL port? >>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-919 >>>> - ASSERT_TRUE(ewk_view_scale_set(webView(), 1.2, 0, 0)); >>> >>> This is to test that webview can keep previous scale factor after reloading a page. >> >> If ewk_view_scale_set() was invoked before loadUrl(), it didn't set pageScaleFactor because syncVisibleContents() failed. >> If syncVisibleContents() failed, it recover the original pageScaleFactor that was old one. >> So I moved the ewk_view_scale_set() after invoking the loadUrlSync(). > > I don't understand well. We already load a default test page in 914 line before you removed it. If so, ewk_view_scale_set(webView(), 1.2, 0, 0) should not be failed, isn't it ? Yes, it is. But it failed if I changed the default page width to 800. ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:922: Failure Value of: ewk_view_scale_get(webView()) Actual: 0.81632656 Expected: 1.2 I think ewk_view_scale_set(webView(), 1.2, 0, 0) didn'set the pageScaleFactor because syncVisibleContents() failed. So it recover the old pageScaleFactor but I don't know why actual value is 0.81632656. 1060742 11 244432 gyuyoung.kim 2015-01-12 18:24:57 -0800 Comment on attachment 244432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244432&action=review >>>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-914 >>>>> - ASSERT_TRUE(loadUrlSync(environment->defaultTestPageUrl())); >>>> >>>> If we don't load a test page, what is meaning to check if default scale value is 1.0 below ? >>>> >>>> ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())); >>> >>> If load the defaultTestPage, pageScaleFactor was changed from 1.0 to 0.81632656 because default contentSize(980x735) bigger then default viewSize(800x560). >>> So I removed the "loadUrlSync(environment->defaultTestPageUrl())" to check the default value of pageScaleFactor whether it is 1.0. >> >> If so, we have to change the default content size with 800x560. I think you change test behavior without reasonable reason. > > Yes, ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())) passed if I changed the default page width from 980 to 800 in ViewportConfiguration::webpageParameters(). > Should I changed the value in EFL port? When I landed r176631, this API test was passed. Could you check if content Size was also 980x735 at that time ? >>>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-919 >>>>> - ASSERT_TRUE(ewk_view_scale_set(webView(), 1.2, 0, 0)); >>>> >>>> This is to test that webview can keep previous scale factor after reloading a page. >>> >>> If ewk_view_scale_set() was invoked before loadUrl(), it didn't set pageScaleFactor because syncVisibleContents() failed. >>> If syncVisibleContents() failed, it recover the original pageScaleFactor that was old one. >>> So I moved the ewk_view_scale_set() after invoking the loadUrlSync(). >> >> I don't understand well. We already load a default test page in 914 line before you removed it. If so, ewk_view_scale_set(webView(), 1.2, 0, 0) should not be failed, isn't it ? > > Yes, it is. But it failed if I changed the default page width to 800. > > ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:922: Failure > Value of: ewk_view_scale_get(webView()) > Actual: 0.81632656 > Expected: 1.2 > > I think ewk_view_scale_set(webView(), 1.2, 0, 0) didn'set the pageScaleFactor because syncVisibleContents() failed. > So it recover the old pageScaleFactor but I don't know why actual value is 0.81632656. I made to restore previous scale factor if sysnVisibleContents() is failed. I think we should not keep the failing pageScaleFactor in PageViewportController though coordinatedGraphics fails to change scale. I think we should check why syncVisibleContents() is failed first. 1062575 12 244432 hs85.jeong 2015-01-19 17:48:54 -0800 Comment on attachment 244432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244432&action=review >>>>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-914 >>>>>> - ASSERT_TRUE(loadUrlSync(environment->defaultTestPageUrl())); >>>>> >>>>> If we don't load a test page, what is meaning to check if default scale value is 1.0 below ? >>>>> >>>>> ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())); >>>> >>>> If load the defaultTestPage, pageScaleFactor was changed from 1.0 to 0.81632656 because default contentSize(980x735) bigger then default viewSize(800x560). >>>> So I removed the "loadUrlSync(environment->defaultTestPageUrl())" to check the default value of pageScaleFactor whether it is 1.0. >>> >>> If so, we have to change the default content size with 800x560. I think you change test behavior without reasonable reason. >> >> Yes, ASSERT_FLOAT_EQ(1, ewk_view_scale_get(webView())) passed if I changed the default page width from 980 to 800 in ViewportConfiguration::webpageParameters(). >> Should I changed the value in EFL port? > > When I landed r176631, this API test was passed. Could you check if content Size was also 980x735 at that time ? I tried to test the ewk_view_scale_with_fixed_layout after reset r176631. Failed in 5 times among the 10 times. Maybe,,there are some timing issue. Value of: ewk_view_scale_get(webView()) Actual: 0.81632656 Expected: 1.5 Value of: ewk_view_scale_get(webView()) Actual: 0.81632656 Expected: 1.2 Result is different whenever I try to test. And I checked the content size in PageViewportController::updateMinimumScaleToFit(). contentSize width:980.000000 height:735.000000 m_viewportSize width:800.000000 height:600.000000 minimumScale:0.816327 >>>>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-919 >>>>>> - ASSERT_TRUE(ewk_view_scale_set(webView(), 1.2, 0, 0)); >>>>> >>>>> This is to test that webview can keep previous scale factor after reloading a page. >>>> >>>> If ewk_view_scale_set() was invoked before loadUrl(), it didn't set pageScaleFactor because syncVisibleContents() failed. >>>> If syncVisibleContents() failed, it recover the original pageScaleFactor that was old one. >>>> So I moved the ewk_view_scale_set() after invoking the loadUrlSync(). >>> >>> I don't understand well. We already load a default test page in 914 line before you removed it. If so, ewk_view_scale_set(webView(), 1.2, 0, 0) should not be failed, isn't it ? >> >> Yes, it is. But it failed if I changed the default page width to 800. >> >> ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:922: Failure >> Value of: ewk_view_scale_get(webView()) >> Actual: 0.81632656 >> Expected: 1.2 >> >> I think ewk_view_scale_set(webView(), 1.2, 0, 0) didn'set the pageScaleFactor because syncVisibleContents() failed. >> So it recover the old pageScaleFactor but I don't know why actual value is 0.81632656. > > I made to restore previous scale factor if sysnVisibleContents() is failed. I think we should not keep the failing pageScaleFactor in PageViewportController though coordinatedGraphics fails to change scale. I think we should check why syncVisibleContents() is failed first. I checked the syncVisiblieContents() whether is failed or not. It is not a problem of syncVisibleContent(),,, syncVisibleContents() isn't failed in test. I will find what is problem. 1286307 13 mcatanzaro 2017-03-11 10:36:30 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 243791 2014-12-28 23:26:55 -0800 2014-12-30 01:29:25 -0800 Patch bug-139984-20141229162658.patch text/plain 1645 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3Nzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzdjMDJkMzE3MTEwODIz NGVkZTQ4YzZiZmM0YjIyM2IxOTgwNzQxYy4uYTc1MDg0OTc2ZmIyNjNmYmE4MDIyMjhiMWM4ZmZi ZTFiZTRkMWZjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEyLTI4ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBUaGUg c2l6ZSBvZiBjb250ZW50cyB3YXNuJ3QgdXBkYXRlZCBpbW1lZGlhdGVseSBhZnRlciByMTc2NjMx CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk5ODQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnZva2Vk IHRoZSBkaWRDaGFuZ2VDb250ZW50c1NpemUoKSB0byB1cGRhdGUgdGhlIHNpemUgb2YgY29udGVu dHMgaW1tZWRpYXRlbHkgd2hlbgorICAgICAgICBjaGFuZ2VkIHRoZSBzaXplIG9mIEV3a1ZpZXcu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcDoKKyAgICAgICAgKEV3 a1ZpZXc6OmhhbmRsZUV2YXNPYmplY3RDYWxjdWxhdGUpOgorCiAyMDE0LTEyLTI4ICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgVHJhbnNmb3JtIG5lc3Rl ZCBvYmplY3RzIGluc2lkZSBhcnJheXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvRXdrVmlldy5jcHAKaW5kZXggMTg3MWYyNmI0NTU0OGUzMzIzOGZiYjliYTFiNGJhMzU2Yjk2 ZTU3MC4uNGUzMjIwYjg1NzZhNDA4NzZiM2U3YTgzZjA4NWE5OTBlNzExOTMyOCAxMDA3NTUKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKQEAgLTEyMjcsOCArMTIy NywxMCBAQCB2b2lkIEV3a1ZpZXc6OmhhbmRsZUV2YXNPYmplY3RDYWxjdWxhdGUoRXZhc19PYmpl Y3QqIGV2YXNPYmplY3QpCiAgICAgICAgIHNtYXJ0RGF0YS0+dmlldy5oID0gaGVpZ2h0OwogCiAg ICAgICAgIFdLVmlld1NldFNpemUoc2VsZi0+d2tWaWV3KCksIFdLU2l6ZU1ha2Uod2lkdGgsIGhl aWdodCkpOwotICAgICAgICBpZiAoV0tQYWdlVXNlRml4ZWRMYXlvdXQoc2VsZi0+d2tQYWdlKCkp KQorICAgICAgICBpZiAoV0tQYWdlVXNlRml4ZWRMYXlvdXQoc2VsZi0+d2tQYWdlKCkpKSB7CiAg ICAgICAgICAgICBzZWxmLT5wYWdlVmlld3BvcnRDb250cm9sbGVyKCkuZGlkQ2hhbmdlVmlld3Bv cnRTaXplKHNlbGYtPnNpemUoKSk7CisgICAgICAgICAgICBzZWxmLT5wYWdlVmlld3BvcnRDb250 cm9sbGVyKCkuZGlkQ2hhbmdlQ29udGVudHNTaXplKHNlbGYtPnNpemUoKSk7CisgICAgICAgIH0K IAogICAgICAgICBzZWxmLT5zZXROZWVkc1N1cmZhY2VSZXNpemUoKTsKICAgICB9Cg== 243818 2014-12-30 01:29:33 -0800 2015-01-12 00:06:01 -0800 Patch bug-139984-20141230182937.patch text/plain 1801 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3ODIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWViZWM4YTYxZGI0ZDg5 MTBmOWYzYjhlOTFmZDQzZTZlMWVhMWRjMi4uYjQzYTc4N2IwMjA0NzE5YWUxMmExMjNhYTcwYWM5 YzM2NDlmZWNmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEyLTMwICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBQYWdl U2NhbGVGYWN0b3Igd2Fzbid0IHVwZGF0ZWQgY29ycmVjdGx5IGFmdGVyIHIxNzY2MzEgCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk5ODQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtaW5pbXVtU2NhbGUg aGF2ZSB0byBiZSB1cGRhdGVkIHRvIGZpdCB0aGUgdmlld3BvcnQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6UGFnZVZpZXdwb3J0Q29udHJvbGxlcjo6dXBkYXRlTWluaW11bVNjYWxl VG9GaXQpOgorICAgICAgICBVcGRhdGUgc2NhbGUgd2hlbiBtX2hhZFVzZXJJbnRlcmFjdGlvbiBp cyB0cnVlLgorCiAyMDE0LTEyLTI5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIHVubmVlZGVkIFN0b3JhZ2VOYW1lc3BhY2UgZnVuY3Rpb25z CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGlj cy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9D b29yZGluYXRlZEdyYXBoaWNzL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXIuY3BwCmluZGV4IGM0ZTM2 Njk0MDE1MTM1MjU3NDM4MDhjOWE1Nzc5MjJkYmMzNzIwMzAuLjIwYTI1ZjYxZDJlZjY5ZmY5ZTY0 MzgxNWU3YzQ0ZWQ1MGZjNjc3YmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9Db29yZGluYXRlZEdyYXBoaWNzL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1BhZ2VWaWV3cG9ydENv bnRyb2xsZXIuY3BwCkBAIC0zNDcsNyArMzQ3LDcgQEAgYm9vbCBQYWdlVmlld3BvcnRDb250cm9s bGVyOjp1cGRhdGVNaW5pbXVtU2NhbGVUb0ZpdChib29sIHVzZXJJbml0aWF0ZWRVcGRhdGUpCiAg ICAgICAgIG1fbWluaW11bVNjYWxlVG9GaXQgPSBtaW5pbXVtU2NhbGU7CiAKICAgICAgICAgaWYg KCFtX3dlYlBhZ2VQcm94eS0+YXJlQWN0aXZlRE9NT2JqZWN0c0FuZEFuaW1hdGlvbnNTdXNwZW5k ZWQoKSkgewotICAgICAgICAgICAgaWYgKHVzZXJJbml0aWF0ZWRVcGRhdGUgJiYgY3VycmVudGx5 U2NhbGVkVG9GaXQpCisgICAgICAgICAgICBpZiAoIW1faGFkVXNlckludGVyYWN0aW9uIHx8ICh1 c2VySW5pdGlhdGVkVXBkYXRlICYmIGN1cnJlbnRseVNjYWxlZFRvRml0KSkKICAgICAgICAgICAg ICAgICBhcHBseVNjYWxlQWZ0ZXJSZW5kZXJpbmdDb250ZW50cyhtX21pbmltdW1TY2FsZVRvRml0 KTsKICAgICAgICAgICAgIGVsc2UgewogICAgICAgICAgICAgICAgIC8vIEVuc3VyZSB0aGUgZWZm ZWN0aXZlIHNjYWxlIHN0YXlzIHdpdGhpbiBib3VuZHMuCg== 244432 2015-01-12 00:06:09 -0800 2015-01-12 00:29:10 -0800 Patch bug-139984-20150112170612.patch text/plain 3432 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDQ5ODFlMmE1NjY5ZjVi OWUyODVmNzUwYTEwNTMxYjI3YmU4ZmJhNC4uNmUzMjFkZmEwN2M1YmE3MTk2NDJjZTFiMzc3MTY2 MjlkZThmMzZjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAxLTExICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBQYWdl U2NhbGVGYWN0b3Igd2Fzbid0IHVwZGF0ZWQgY29ycmVjdGx5IGFmdGVyIHIxNzY2MzEgCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk5ODQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtaW5pbXVtU2NhbGUg aGF2ZSB0byBiZSB1cGRhdGVkIHRvIGZpdCB0aGUgdmlld3BvcnQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6CisgICAgICAgIChURVNUX0Yp OiBDaGFuZ2VkIHRoZSBzZXF1ZW5jZSBvZiBUZXN0QVBJIAorICAgICAgICAqIFVJUHJvY2Vzcy9D b29yZGluYXRlZEdyYXBoaWNzL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXIuY3BwOiBSZXZlcnQgdGhl IG1faGFkVXNlckludGVyYWN0aW9uIHRvIHVzZSBpdC4KKyAgICAgICAgKFdlYktpdDo6UGFnZVZp ZXdwb3J0Q29udHJvbGxlcjo6dXBkYXRlTWluaW11bVNjYWxlVG9GaXQpOgorCiAyMDE1LTAxLTEx ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgogCiAgICAgICAgIFtDb29y ZGluYXRlZEdyYXBoaWNzXSBTdXNwZW5kIG9yIHJlc3VtZSB3aGVuIHZpc2liaWxpdHkgaXMgY2hh bmdlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMv dGVzdF9ld2syX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVz dHMvdGVzdF9ld2syX3ZpZXcuY3BwCmluZGV4IGYwYTA5Yjk3NmEwYmFjZGI2ODdjNmYwOTViMDdk N2M3NGE0NTUyMWQuLjJjOTg1ZThjYmYzNzY1NWI2NTJlZWE3YzcwZjgwMDY2MGUwMDhjYjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdr Ml92aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90 ZXN0X2V3azJfdmlldy5jcHAKQEAgLTkxMSwyMiArOTExLDIwIEBAIFRFU1RfRihFV0syVmlld1Rl c3QsIGV3a192aWV3X3NjYWxlX3dpdGhfZml4ZWRfbGF5b3V0KQogICAgIC8vIGV3a192aWV3X3Nj YWxlKCkgY2FuIHdvcmsgb25seSB3aGVuIGZpeGVkIGxheW91dCBpcyBlbmFibGVkLgogICAgIEVY UEVDVF9UUlVFKGV3a192aWV3X2xheW91dF9maXhlZF9zZXQod2ViVmlldygpLCB0cnVlKSk7CiAK LSAgICBBU1NFUlRfVFJVRShsb2FkVXJsU3luYyhlbnZpcm9ubWVudC0+ZGVmYXVsdFRlc3RQYWdl VXJsKCkpKTsKLQogICAgIC8vIERlZmF1bHQgc2NhbGUgdmFsdWUgaXMgMS4wLgogICAgIEFTU0VS VF9GTE9BVF9FUSgxLCBld2tfdmlld19zY2FsZV9nZXQod2ViVmlldygpKSk7CiAKLSAgICBBU1NF UlRfVFJVRShld2tfdmlld19zY2FsZV9zZXQod2ViVmlldygpLCAxLjIsIDAsIDApKTsKICAgICAv LyBSZWxvYWQgcGFnZSB0byBjaGVjayB0aGUgcGFnZSBzY2FsZSB2YWx1ZS4KICAgICBBU1NFUlRf VFJVRShsb2FkVXJsU3luYyhlbnZpcm9ubWVudC0+ZGVmYXVsdFRlc3RQYWdlVXJsKCkpKTsKKyAg ICBBU1NFUlRfVFJVRShld2tfdmlld19zY2FsZV9zZXQod2ViVmlldygpLCAxLjIsIDAsIDApKTsK ICAgICBBU1NFUlRfRkxPQVRfRVEoMS4yLCBld2tfdmlld19zY2FsZV9nZXQod2ViVmlldygpKSk7 CiAKLSAgICBBU1NFUlRfVFJVRShld2tfdmlld19zY2FsZV9zZXQod2ViVmlldygpLCAxLjUsIDAs IDApKTsKICAgICBBU1NFUlRfVFJVRShsb2FkVXJsU3luYyhlbnZpcm9ubWVudC0+ZGVmYXVsdFRl c3RQYWdlVXJsKCkpKTsKKyAgICBBU1NFUlRfVFJVRShld2tfdmlld19zY2FsZV9zZXQod2ViVmll dygpLCAxLjUsIDAsIDApKTsKICAgICBBU1NFUlRfRkxPQVRfRVEoMS41LCBld2tfdmlld19zY2Fs ZV9nZXQod2ViVmlldygpKSk7CiAKLSAgICBBU1NFUlRfVFJVRShld2tfdmlld19zY2FsZV9zZXQo d2ViVmlldygpLCAxLCAwLCAwKSk7CiAgICAgQVNTRVJUX1RSVUUobG9hZFVybFN5bmMoZW52aXJv bm1lbnQtPmRlZmF1bHRUZXN0UGFnZVVybCgpKSk7CisgICAgQVNTRVJUX1RSVUUoZXdrX3ZpZXdf c2NhbGVfc2V0KHdlYlZpZXcoKSwgMSwgMCwgMCkpOwogICAgIEFTU0VSVF9GTE9BVF9FUSgxLCBl d2tfdmlld19zY2FsZV9nZXQod2ViVmlldygpKSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1BhZ2VWaWV3cG9ydENvbnRyb2xs ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvUGFn ZVZpZXdwb3J0Q29udHJvbGxlci5jcHAKaW5kZXggYzRlMzY2OTQwMTUxMzUyNTc0MzgwOGM5YTU3 NzkyMmRiYzM3MjAzMC4uMjBhMjVmNjFkMmVmNjlmZjllNjQzODE1ZTdjNDRlZDUwZmM2NzdiYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv UGFnZVZpZXdwb3J0Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0Nvb3JkaW5hdGVkR3JhcGhpY3MvUGFnZVZpZXdwb3J0Q29udHJvbGxlci5jcHAKQEAgLTM0Nyw3 ICszNDcsNyBAQCBib29sIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXI6OnVwZGF0ZU1pbmltdW1TY2Fs ZVRvRml0KGJvb2wgdXNlckluaXRpYXRlZFVwZGF0ZSkKICAgICAgICAgbV9taW5pbXVtU2NhbGVU b0ZpdCA9IG1pbmltdW1TY2FsZTsKIAogICAgICAgICBpZiAoIW1fd2ViUGFnZVByb3h5LT5hcmVB Y3RpdmVET01PYmplY3RzQW5kQW5pbWF0aW9uc1N1c3BlbmRlZCgpKSB7Ci0gICAgICAgICAgICBp ZiAodXNlckluaXRpYXRlZFVwZGF0ZSAmJiBjdXJyZW50bHlTY2FsZWRUb0ZpdCkKKyAgICAgICAg ICAgIGlmICghbV9oYWRVc2VySW50ZXJhY3Rpb24gfHwgKHVzZXJJbml0aWF0ZWRVcGRhdGUgJiYg Y3VycmVudGx5U2NhbGVkVG9GaXQpKQogICAgICAgICAgICAgICAgIGFwcGx5U2NhbGVBZnRlclJl bmRlcmluZ0NvbnRlbnRzKG1fbWluaW11bVNjYWxlVG9GaXQpOwogICAgICAgICAgICAgZWxzZSB7 CiAgICAgICAgICAgICAgICAgLy8gRW5zdXJlIHRoZSBlZmZlY3RpdmUgc2NhbGUgc3RheXMgd2l0 aGluIGJvdW5kcy4K