139975 2014-12-28 10:32:01 -0800 Update css3/flexbox/auto-margins.html after r177774 2015-01-07 16:10:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139968 1 mmaxfield mmaxfield ap dino simon.fraser thorton zalan oldest_to_newest 1058029 0 mmaxfield 2014-12-28 10:32:01 -0800 Update css3/flexbox/auto-margins.html after r177774 1058030 1 243783 mmaxfield 2014-12-28 10:35:28 -0800 Created attachment 243783 Patch 1058041 2 243783 darin 2014-12-28 11:12:46 -0800 Comment on attachment 243783 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243783&action=review > LayoutTests/ChangeLog:12 > + This is a subpixel problem. Flexbox uses SimpleLineLayout for the entire > + box and therefore does all its math in floating point, while the > + -expected uses the regular renderer hierarchy and therefore fixed-point > + math. This patch updates the test to use Ahem so that the character > + widths divide the same way in both cases. Does that mean that I could see a difference if a page dynamically changed layout between these two techniques? That sounds like a bug! I understand the desire to not make this test sensitive to this bug, but what about fixing the bug? 1058045 3 243783 zalan 2014-12-28 11:45:14 -0800 Comment on attachment 243783 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243783&action=review > LayoutTests/ChangeLog:10 > + This is a subpixel problem. Flexbox uses SimpleLineLayout for the entire > + box and therefore does all its math in floating point, while the > + -expected uses the regular renderer hierarchy and therefore fixed-point Simple line layout snaps content to pixels at painting time the same way as any other InlineBox/RenderBox does. Whether it uses float or LayoutUnit while layouting shouldn't make any difference (other than in some edge cases caused by precession loss -where we might push content to the wrong position at halfway values). I think this is more about table layout vs. rest of the rendering layout, where table still uses integral positioning. 1059592 4 mmaxfield 2015-01-07 15:56:01 -0800 Committed r178063: <http://trac.webkit.org/changeset/178063> 1059593 5 mmaxfield 2015-01-07 15:56:32 -0800 Zalan says we already have a few bugs about subpixelifying tables, so I'm going to land this. 1059620 6 zalan 2015-01-07 16:10:22 -0800 (In reply to comment #5) > Zalan says we already have a few bugs about subpixelifying tables, so I'm > going to land this. bug 132010 243783 2014-12-28 10:35:28 -0800 2014-12-28 11:12:46 -0800 Patch bug-139975-20141228103530.patch text/plain 4407 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3Nzc5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjVmNzhmN2YxZjMwYzk1NDc5MmM2 OGEzYTBjNDc2ODBjY2MzZmIyNy4uYjg4N2NhYTc0MWFjMWU4ZjZjNjNiYjkyNDlhZjMzOWQ1YTA1 MDVkNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTEyLTI4ICBNeWxlcyBDLiBNYXhmaWVs ZCAgPGxpdGhlcnVtQGdtYWlsLmNvbT4KKworICAgICAgICBVcGRhdGUgY3NzMy9mbGV4Ym94L2F1 dG8tbWFyZ2lucy5odG1sIGFmdGVyIHIxNzc3NzQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTk3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSBzdWJwaXhlbCBwcm9ibGVtLiBGbGV4Ym94 IHVzZXMgU2ltcGxlTGluZUxheW91dCBmb3IgdGhlIGVudGlyZQorICAgICAgICBib3ggYW5kIHRo ZXJlZm9yZSBkb2VzIGFsbCBpdHMgbWF0aCBpbiBmbG9hdGluZyBwb2ludCwgd2hpbGUgdGhlCisg ICAgICAgIC1leHBlY3RlZCB1c2VzIHRoZSByZWd1bGFyIHJlbmRlcmVyIGhpZXJhcmNoeSBhbmQg dGhlcmVmb3JlIGZpeGVkLXBvaW50CisgICAgICAgIG1hdGguIFRoaXMgcGF0Y2ggdXBkYXRlcyB0 aGUgdGVzdCB0byB1c2UgQWhlbSBzbyB0aGF0IHRoZSBjaGFyYWN0ZXIKKyAgICAgICAgd2lkdGhz IGRpdmlkZSB0aGUgc2FtZSB3YXkgaW4gYm90aCBjYXNlcy4KKworICAgICAgICAqIGNzczMvZmxl eGJveC9hdXRvLW1hcmdpbnMtZXhwZWN0ZWQuaHRtbDoKKyAgICAgICAgKiBjc3MzL2ZsZXhib3gv YXV0by1tYXJnaW5zLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnM6CisKIDIwMTQtMTItMjggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4K IAogICAgICAgICBbV2luXSBVbnJldmlld2VkIGdhcmRlbmluZywgbWFyayBtb3JlIGZhaWxpbmcg dGVzdHMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvYXV0by1tYXJnaW5z LWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvYXV0by1tYXJnaW5zLWV4 cGVjdGVkLmh0bWwKaW5kZXggNjZkNTJjM2M1MTI3MGNiNWEwMjE0MjBkZDdmYzFjZDc2ZGQ4ZGIz Mi4uMGNjMzgyZWY0YmJlMWU0NDYxYTUzYjViNjYwZjFiYzRhYjU1ZGZlZCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2F1dG8tbWFyZ2lucy1leHBlY3RlZC5odG1sCisrKyBi L0xheW91dFRlc3RzL2NzczMvZmxleGJveC9hdXRvLW1hcmdpbnMtZXhwZWN0ZWQuaHRtbApAQCAt MTYsMTMgKzE2LDEzIEBACiA8Ym9keT4KIDxwPlRoZXNlIHRlc3RzIGFyZSBmcm9tIHRoZSBzcGVj OiA8YSBocmVmPSJodHRwOi8vZGV2LnczLm9yZy9jc3N3Zy9jc3MzLWZsZXhib3gvI2F1dG8tbWFy Z2lucyI+aHR0cDovL2Rldi53My5vcmcvY3Nzd2cvY3NzMy1mbGV4Ym94LyNhdXRvLW1hcmdpbnM8 L2E+LjwvcD4KIAotPHA+VGhlIHdvcmQgT0sgc2hvdWxkIGJlIGNlbnRlcmVkIHZlcnRpY2FsbHkg YW5kIGhvcml6b250YWxseS48L3A+Cis8cD5BIGJsYWNrIGJveCBzaG91bGQgYmUgY2VudGVyZWQg dmVydGljYWxseSBhbmQgaG9yaXpvbnRhbGx5LjwvcD4KIDxkaXYgc3R5bGU9IndpZHRoOiA0ZW07 IGhlaWdodDogNGVtOyBiYWNrZ3JvdW5kOiBzaWx2ZXIiPgotICA8dGFibGUgc3R5bGU9IndpZHRo OiAxMDAlOyBoZWlnaHQ6IDEwMCU7Ij48dHI+PHRkIHN0eWxlPSJ0ZXh0LWFsaWduOiBjZW50ZXIi Pk9LPC90ZD48L3RyPjwvdGFibGU+CisgIDx0YWJsZSBzdHlsZT0id2lkdGg6IDEwMCU7IGhlaWdo dDogMTAwJTsiPjx0cj48dGQgc3R5bGU9InRleHQtYWxpZ246IGNlbnRlcjsgZm9udC1mYW1pbHk6 IEFoZW07Ij5PSzwvdGQ+PC90cj48L3RhYmxlPgogPC9kaXY+CiAKIDxkaXYgc3R5bGU9IndpZHRo OiA0ZW07IGhlaWdodDogNGVtOyBtYXJnaW4tdG9wOiAxMHB4OyBiYWNrZ3JvdW5kOiBzaWx2ZXI7 IC13ZWJraXQtd3JpdGluZy1tb2RlOiB2ZXJ0aWNhbC1ybCI+Ci0gIDx0YWJsZSBzdHlsZT0id2lk dGg6IDEwMCU7IGhlaWdodDogMTAwJTsiPjx0cj48dGQgc3R5bGU9InRleHQtYWxpZ246IGNlbnRl ciI+T0s8L3RkPjwvdHI+PC90YWJsZT4KKyAgPHRhYmxlIHN0eWxlPSJ3aWR0aDogMTAwJTsgaGVp Z2h0OiAxMDAlOyI+PHRyPjx0ZCBzdHlsZT0idGV4dC1hbGlnbjogY2VudGVyOyBmb250LWZhbWls eTogQWhlbTsiPk9LPC90ZD48L3RyPjwvdGFibGU+CiA8L2Rpdj4KIAogPHA+WW91IHNob3VsZCBz ZWUgMyBibHVlIGNvbmNlbnRyaWMgY2lyY2xlcy48L3A+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9jc3MzL2ZsZXhib3gvYXV0by1tYXJnaW5zLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhi b3gvYXV0by1tYXJnaW5zLmh0bWwKaW5kZXggYjYzZTNjYTA1YzRkNGI2ODU5MThmNTFlZTA3ZTU2 ZTk4NjNkOGU3Yy4uZWRmNTgwZTllMWJiMmE4NDFkY2QxODExYzU4MDU1MWMzYzg5ZDc0NCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2F1dG8tbWFyZ2lucy5odG1sCisrKyBi L0xheW91dFRlc3RzL2NzczMvZmxleGJveC9hdXRvLW1hcmdpbnMuaHRtbApAQCAtMjMsMTMgKzIz LDEzIEBACiA8Ym9keT4KIDxwPlRoZXNlIHRlc3RzIGFyZSBmcm9tIHRoZSBzcGVjOiA8YSBocmVm PSJodHRwOi8vZGV2LnczLm9yZy9jc3N3Zy9jc3MzLWZsZXhib3gvI2F1dG8tbWFyZ2lucyI+aHR0 cDovL2Rldi53My5vcmcvY3Nzd2cvY3NzMy1mbGV4Ym94LyNhdXRvLW1hcmdpbnM8L2E+LjwvcD4K IAotPHA+VGhlIHdvcmQgT0sgc2hvdWxkIGJlIGNlbnRlcmVkIHZlcnRpY2FsbHkgYW5kIGhvcml6 b250YWxseS48L3A+Cis8cD5BIGJsYWNrIGJveCBzaG91bGQgYmUgY2VudGVyZWQgdmVydGljYWxs eSBhbmQgaG9yaXpvbnRhbGx5LjwvcD4KIDxkaXYgY2xhc3M9ImZsZXhib3giIHN0eWxlPSJ3aWR0 aDogNGVtOyBoZWlnaHQ6IDRlbTsgYmFja2dyb3VuZDogc2lsdmVyIj4KLSAgPHAgaWQ9Im9rIiBz dHlsZT0ibWFyZ2luOiBhdXRvOyI+T0s8L3A+CisgIDxwIGlkPSJvayIgc3R5bGU9Im1hcmdpbjog YXV0bzsgZm9udC1mYW1pbHk6IEFoZW07Ij5PSzwvcD4KIDwvZGl2PgogCiA8ZGl2IGNsYXNzPSJm bGV4Ym94IiBzdHlsZT0id2lkdGg6IDRlbTsgaGVpZ2h0OiA0ZW07IG1hcmdpbi10b3A6IDEwcHg7 IGJhY2tncm91bmQ6IHNpbHZlcjsgLXdlYmtpdC13cml0aW5nLW1vZGU6IHZlcnRpY2FsLXJsIj4K LSAgPHAgaWQ9Im9rVmVydGljYWwiIHN0eWxlPSJtYXJnaW46IGF1dG87Ij5PSzwvcD4KKyAgPHAg aWQ9Im9rVmVydGljYWwiIHN0eWxlPSJtYXJnaW46IGF1dG87IGZvbnQtZmFtaWx5OiBBaGVtOyI+ T0s8L3A+CiA8L2Rpdj4KIAogPHA+WW91IHNob3VsZCBzZWUgMyBibHVlIGNvbmNlbnRyaWMgY2ly Y2xlcy48L3A+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4 IDE2ZjRkMWMzMjhhMzA2ZWIyZDMyN2RhNDgxNWQ3ODA5ZWQ0ZWM2NTMuLjU4MGNkODJkMzVlYzZm YmE1YWRkZWE2NmI2NjkxNmMzOTM1NTYxNWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCkBAIC0xMzQ4LDcgKzEzNDgsNiBAQCBmYXN0L2NhbnZhcy9jYW52YXMt ZmlsbFJlY3QtZ3JhZGllbnQtc2hhZG93Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiAjIEtlcm5p bmcsIExpZ2F0dXJlcywgYW5kIFByaW50ZXIgRm9udHMgY2F1c2VkIHRoZXNlIHRlc3RzIHRvIGZh aWwKICMgVGhlIGZvbGxvd2luZyB0ZXN0cyBhcmUgcmVmdGVzdHMKLXdlYmtpdC5vcmcvYi8xMzk5 NjggY3NzMy9mbGV4Ym94L2F1dG8tbWFyZ2lucy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3 ZWJraXQub3JnL2IvMTM5OTY4IGNzczMvZmxleGJveC9jc3N3Zy9mbGV4Ym94X2RpcmVjdGlvbi1y b3ctcmV2ZXJzZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTM5OTY4 IGZhc3QvYm94LWRlY29yYXRpb24tYnJlYWsvYm94LWRlY29yYXRpb24tYnJlYWstcmVuZGVyaW5n Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMzk5NjggZmFzdC9jc3Mt Z2VuZXJhdGVkLWNvbnRlbnQvYWZ0ZXItd2l0aC1pbmxpbmUtY29udGludWF0aW9uLmh0bWwgWyBJ bWFnZU9ubHlGYWlsdXJlIF0K