139948 2014-12-25 17:29:27 -0800 Fix build warning after r177700 2014-12-25 19:52:05 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong hs85.jeong andersca commit-queue gyuyoung.kim gyuyoung.kim kling oldest_to_newest 1057867 0 hs85.jeong 2014-12-25 17:29:27 -0800 ../../Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53:21: warning: unused parameter ‘object’ [-Wunused-parameter] RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object) ^ ../../Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:60:21: warning: unused parameter ‘object’ [-Wunused-parameter] RefPtr<API::Object> WebConnectionToWebProcess::transformObjectsToHandles(API::Object* object) 1057868 1 243751 hs85.jeong 2014-12-25 17:32:34 -0800 Created attachment 243751 Patch 1057869 2 243752 hs85.jeong 2014-12-25 17:35:35 -0800 Created attachment 243752 Patch 1057872 3 243752 gyuyoung.kim 2014-12-25 18:01:13 -0800 Comment on attachment 243752 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243752&action=review > Source/WebKit2/ChangeLog:3 > + Unreviewed, fix build warning after r177700 Build warning should be reviewed. And also it would be good to get a review from WK2 owner. > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53 > RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object) In this case, I would recommend to remove object parameter here instead of UNUSED_PARAM(). > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:63 > + UNUSED_PARAM(object); ditto. 1057873 4 hs85.jeong 2014-12-25 18:13:11 -0800 (In reply to comment #3) > Comment on attachment 243752 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243752&action=review > > > Source/WebKit2/ChangeLog:3 > > + Unreviewed, fix build warning after r177700 > > Build warning should be reviewed. And also it would be good to get a review > from WK2 owner. > Okay, I try to get a review from WK2 owner. > > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53 > > RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object) > > In this case, I would recommend to remove object parameter here instead of > UNUSED_PARAM(). > > > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:63 > > + UNUSED_PARAM(object); > > ditto. I removed the parameter instead of UNUSED_PARAM(). Thanks, 1057874 5 243753 hs85.jeong 2014-12-25 18:15:50 -0800 Created attachment 243753 Patch 1057879 6 243753 commit-queue 2014-12-25 19:52:00 -0800 Comment on attachment 243753 Patch Clearing flags on attachment: 243753 Committed r177743: <http://trac.webkit.org/changeset/177743> 1057880 7 commit-queue 2014-12-25 19:52:05 -0800 All reviewed patches have been landed. Closing bug. 243751 2014-12-25 17:32:34 -0800 2014-12-25 17:35:30 -0800 Patch bug-139948-20141226103235.patch text/plain 1584 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2IzMjljYmYxMWMzMDBl MTU1MmFkOTg3Mjg4ZjE3OWFlOTRlZTE2NC4uYTQzNjBiY2FmMWYxNTU4YTYwOGE2MzA1ZTE3YWMz MjRiZmU4YjIxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEyLTI1ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBVbnJldmlld2Vk LCBmaXggYnVpbGQgd2FybmluZyBhZnRlciByMTc3NzAwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk5NDgKKworICAgICAgICBObyBuZXcgdGVzdHMs IG5vIGJlaGF2aW9yIGNoYW5nZXMKKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb25uZWN0aW9u VG9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29ubmVjdGlvblRvV2ViUHJv Y2Vzczo6dHJhbnNmb3JtSGFuZGxlc1RvT2JqZWN0cyk6CisgICAgICAgIChXZWJLaXQ6OldlYkNv bm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnRyYW5zZm9ybU9iamVjdHNUb0hhbmRsZXMpOgorCiAyMDE0 LTEyLTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g TG9nIGJldHRlciB1c2luZyBGZWF0dXJlQ291bnRlciB3aHkgUGFnZUNhY2hlIGlzIGZhaWxpbmcg ZHVlIHRvIHBydW5lZCByZXNvdXJjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcAppbmRleCAwMzAzZjc0ZTU1OTA1NDJl NzA1M2U4NjA4M2E4OTI0NWMxZDRjYzA1Li43MjYzZWVkNGRmNjU3MWZiYmU1YzAyZDAzZjNhNWMz YTVmMDNhZDgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29ubmVj dGlvblRvV2ViUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNv bm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwCkBAIC01MywxMiArNTMsMTQgQEAgdm9pZCBXZWJDb25u ZWN0aW9uVG9XZWJQcm9jZXNzOjppbnZhbGlkYXRlKCkKIFJlZlB0cjxBUEk6Ok9iamVjdD4gV2Vi Q29ubmVjdGlvblRvV2ViUHJvY2Vzczo6dHJhbnNmb3JtSGFuZGxlc1RvT2JqZWN0cyhBUEk6Ok9i amVjdCogb2JqZWN0KQogewogICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAgVU5VU0VEX1BB UkFNKG9iamVjdCk7CiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIFJlZlB0cjxBUEk6Ok9iamVj dD4gV2ViQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6dHJhbnNmb3JtT2JqZWN0c1RvSGFuZGxlcyhB UEk6Ok9iamVjdCogb2JqZWN0KQogewogICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAgVU5V U0VEX1BBUkFNKG9iamVjdCk7CiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAK 243752 2014-12-25 17:35:35 -0800 2014-12-25 18:15:43 -0800 Patch bug-139948-20141226103537.patch text/plain 1584 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2IzMjljYmYxMWMzMDBl MTU1MmFkOTg3Mjg4ZjE3OWFlOTRlZTE2NC4uYTQzNjBiY2FmMWYxNTU4YTYwOGE2MzA1ZTE3YWMz MjRiZmU4YjIxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEyLTI1ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBVbnJldmlld2Vk LCBmaXggYnVpbGQgd2FybmluZyBhZnRlciByMTc3NzAwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk5NDgKKworICAgICAgICBObyBuZXcgdGVzdHMs IG5vIGJlaGF2aW9yIGNoYW5nZXMKKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb25uZWN0aW9u VG9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29ubmVjdGlvblRvV2ViUHJv Y2Vzczo6dHJhbnNmb3JtSGFuZGxlc1RvT2JqZWN0cyk6CisgICAgICAgIChXZWJLaXQ6OldlYkNv bm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnRyYW5zZm9ybU9iamVjdHNUb0hhbmRsZXMpOgorCiAyMDE0 LTEyLTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g TG9nIGJldHRlciB1c2luZyBGZWF0dXJlQ291bnRlciB3aHkgUGFnZUNhY2hlIGlzIGZhaWxpbmcg ZHVlIHRvIHBydW5lZCByZXNvdXJjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcAppbmRleCAwMzAzZjc0ZTU1OTA1NDJl NzA1M2U4NjA4M2E4OTI0NWMxZDRjYzA1Li43MjYzZWVkNGRmNjU3MWZiYmU1YzAyZDAzZjNhNWMz YTVmMDNhZDgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29ubmVj dGlvblRvV2ViUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNv bm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwCkBAIC01MywxMiArNTMsMTQgQEAgdm9pZCBXZWJDb25u ZWN0aW9uVG9XZWJQcm9jZXNzOjppbnZhbGlkYXRlKCkKIFJlZlB0cjxBUEk6Ok9iamVjdD4gV2Vi Q29ubmVjdGlvblRvV2ViUHJvY2Vzczo6dHJhbnNmb3JtSGFuZGxlc1RvT2JqZWN0cyhBUEk6Ok9i amVjdCogb2JqZWN0KQogewogICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAgVU5VU0VEX1BB UkFNKG9iamVjdCk7CiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIFJlZlB0cjxBUEk6Ok9iamVj dD4gV2ViQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6dHJhbnNmb3JtT2JqZWN0c1RvSGFuZGxlcyhB UEk6Ok9iamVjdCogb2JqZWN0KQogewogICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAgVU5V U0VEX1BBUkFNKG9iamVjdCk7CiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAK 243753 2014-12-25 18:15:50 -0800 2014-12-25 19:52:00 -0800 Patch bug-139948-20141226111552.patch text/plain 1705 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2IzMjljYmYxMWMzMDBl MTU1MmFkOTg3Mjg4ZjE3OWFlOTRlZTE2NC4uYTUzMjg1MDg5MGQyNjYyZjA5YmQ0NGEzODE2OTAw MDkyMWZkZGJkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEyLTI1ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQg d2FybmluZyBhZnRlciByMTc3NzAwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzk5NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6dHJhbnNmb3JtSGFu ZGxlc1RvT2JqZWN0cyk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbm5lY3Rpb25Ub1dlYlByb2Nl c3M6OnRyYW5zZm9ybU9iamVjdHNUb0hhbmRsZXMpOgorCiAyMDE0LTEyLTI1ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gTG9nIGJldHRlciB1c2luZyBG ZWF0dXJlQ291bnRlciB3aHkgUGFnZUNhY2hlIGlzIGZhaWxpbmcgZHVlIHRvIHBydW5lZCByZXNv dXJjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb25uZWN0aW9u VG9XZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb25uZWN0aW9u VG9XZWJQcm9jZXNzLmNwcAppbmRleCAwMzAzZjc0ZTU1OTA1NDJlNzA1M2U4NjA4M2E4OTI0NWMx ZDRjYzA1Li40OTQ3ODU2ZjBhZjBkZjA1MzYwYzQyYWQ5NDFjNjAwNDY1OTdjNGU1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbm5lY3Rpb25Ub1dlYlByb2Nl c3MuY3BwCkBAIC01MCwxMyArNTAsMTMgQEAgdm9pZCBXZWJDb25uZWN0aW9uVG9XZWJQcm9jZXNz OjppbnZhbGlkYXRlKCkKIAogLy8gV2ViQ29ubmVjdGlvbgogCi1SZWZQdHI8QVBJOjpPYmplY3Q+ IFdlYkNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnRyYW5zZm9ybUhhbmRsZXNUb09iamVjdHMoQVBJ OjpPYmplY3QqIG9iamVjdCkKK1JlZlB0cjxBUEk6Ok9iamVjdD4gV2ViQ29ubmVjdGlvblRvV2Vi UHJvY2Vzczo6dHJhbnNmb3JtSGFuZGxlc1RvT2JqZWN0cyhBUEk6Ok9iamVjdCopCiB7CiAgICAg Ly8gRklYTUU6IEltcGxlbWVudC4KICAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAotUmVmUHRyPEFQ STo6T2JqZWN0PiBXZWJDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjp0cmFuc2Zvcm1PYmplY3RzVG9I YW5kbGVzKEFQSTo6T2JqZWN0KiBvYmplY3QpCitSZWZQdHI8QVBJOjpPYmplY3Q+IFdlYkNvbm5l Y3Rpb25Ub1dlYlByb2Nlc3M6OnRyYW5zZm9ybU9iamVjdHNUb0hhbmRsZXMoQVBJOjpPYmplY3Qq KQogewogICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCiAgICAgcmV0dXJuIG51bGxwdHI7Cg==