139943 2014-12-24 22:48:17 -0800 Give extract-localizable-strings an option to treat warnings as errors 2014-12-25 14:45:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 1057822 0 mitz 2014-12-24 22:48:17 -0800 Add a --treat-warnings-as-errors option extract-localizable-strings, which makes it emit its warnings as errors and exit with a non-0 return code. 1057823 1 243740 mitz 2014-12-24 22:53:56 -0800 Created attachment 243740 Add --treat-warnings-as-errors option 1057862 2 mitz 2014-12-25 14:45:51 -0800 Committed <http://trac.webkit.org/r177741>. 243740 2014-12-24 22:53:56 -0800 2014-12-25 14:39:10 -0800 Add --treat-warnings-as-errors option bug-139943-20141224225357.patch text/plain 5527 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzczMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEyLTI0ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgR2l2ZSBleHRyYWN0LWxvY2FsaXph YmxlLXN0cmluZ3MgYW4gb3B0aW9uIHRvIHRyZWF0IHdhcm5pbmdzIGFzIGVycm9ycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5OTQzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgLS10cmVhdC13 YXJuaW5ncy1hcy1lcnJvcnMgb3B0aW9uLCB3aGljaCBtYWtlcyB0aGUgc2NyaXB0IGVtaXQgaXRz IHdhcm5pbmdzIGFzIGVycm9ycworICAgICAgICBhbmQgZXhpdCB3aXRoIGEgbm9uLTAgcmV0dXJu IGNvZGUgaWYgaXQgZW1pdHRlZCBhbnkgd2FybmluZ3MuCisKKyAgICAgICAgKiBleHRyYWN0LWxv Y2FsaXphYmxlLXN0cmluZ3MucGw6CisgICAgICAgIEFkZGVkICR0cmVhdFdhcm5pbmdzQXNFcnJv cnMgdmFyaWFibGUsIHNldCB0byB0cnVlIGlmIHRoZSBvcHRpb24gaXMgcGFzc2VkIGluLgorCisg ICAgICAgIChlbWl0V2FybmluZyk6IEFkZGVkLiBJZiAkdHJlYXRXYXJuaW5nc0FzRXJyb3JzIGlz IHRydWUsIG9taXRzIHRoZSAid2FybmluZzogIiB0b2tlbiBmcm9tCisgICAgICAgIHRoZSBtZXNz YWdlLCB3aGljaCBtYWtlcyBpdCBhcHBlYXIgYXMgYW4gZXJyb3IgaW4gWGNvZGUsIGFuZCBzZXRz ICRzYXdFcnJvciB0byAxLgorCisgICAgICAgIFJlcGxhY2VkIGFsbCBwcmludCBzdGF0ZW1lbnRz IHRoYXQgcHJpbnRlZCB3YXJuaW5ncyB3aXRoIGNhbGxzIHRvIGVtaXRXYXJuaW5nLgorCiAyMDE0 LTEyLTI0ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFNtYWxsIGNsZWFudXAgb2YgUmVuZGVyQmxvY2s6OnBhaW50KCkKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2V4dHJhY3QtbG9jYWxpemFibGUtc3RyaW5ncy5wbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9leHRyYWN0LWxvY2FsaXphYmxlLXN0cmluZ3MucGwJKHJldmlzaW9uIDE3NzczMCkK KysrIFNvdXJjZS9XZWJDb3JlL2V4dHJhY3QtbG9jYWxpemFibGUtc3RyaW5ncy5wbAkod29ya2lu ZyBjb3B5KQpAQCAtNTMsMTYgKzUzLDE4IEBAIG15ICVpc0RlYnVnTWFjcm8gPSAoIEFTU0VSVF9X SVRIX01FU1NBR0UKIG15ICR2ZXJpZnk7CiBteSAkZXhjZXB0aW9uc0ZpbGU7CiBteSBAZGlyZWN0 b3JpZXNUb1NraXAgPSAoKTsKK215ICR0cmVhdFdhcm5pbmdzQXNFcnJvcnM7CiAKIG15ICVvcHRp b25zID0gKAogICAgICd2ZXJpZnknID0+IFwkdmVyaWZ5LAogICAgICdleGNlcHRpb25zPXMnID0+ IFwkZXhjZXB0aW9uc0ZpbGUsCiAgICAgJ3NraXA9cycgPT4gXEBkaXJlY3Rvcmllc1RvU2tpcCwK KyAgICAndHJlYXQtd2FybmluZ3MtYXMtZXJyb3JzJyA9PiBcJHRyZWF0V2FybmluZ3NBc0Vycm9y cywKICk7CiAKIEdldE9wdGlvbnMoJW9wdGlvbnMpOwogCi1AQVJHViA+PSAyIG9yIGRpZSAiVXNh Z2U6IGV4dHJhY3QtbG9jYWxpemFibGUtc3RyaW5ncyBbLS12ZXJpZnldIFstLWV4Y2VwdGlvbnMg PGV4Y2VwdGlvbnMgZmlsZT5dIDxmaWxlIHRvIHVwZGF0ZT4gWy0tc2tpcCBkaXJlY3RvcnkgfCBk aXJlY3RvcnldLi4uXG5EaWQgeW91IG1lYW4gdG8gcnVuIHVwZGF0ZS13ZWJraXQtbG9jYWxpemFi bGUtc3RyaW5ncyBpbnN0ZWFkP1xuIjsKK0BBUkdWID49IDIgb3IgZGllICJVc2FnZTogZXh0cmFj dC1sb2NhbGl6YWJsZS1zdHJpbmdzIFstLXZlcmlmeV0gWy0tdHJlYXQtd2FybmluZ3MtYXMtZXJy b3JzXSBbLS1leGNlcHRpb25zIDxleGNlcHRpb25zIGZpbGU+XSA8ZmlsZSB0byB1cGRhdGU+IFst LXNraXAgZGlyZWN0b3J5IHwgZGlyZWN0b3J5XS4uLlxuRGlkIHlvdSBtZWFuIHRvIHJ1biB1cGRh dGUtd2Via2l0LWxvY2FsaXphYmxlLXN0cmluZ3MgaW5zdGVhZD9cbiI7CiAKIC1mICRleGNlcHRp b25zRmlsZSBvciBkaWUgIkNvdWxkbid0IGZpbmQgZXhjZXB0aW9ucyBmaWxlICRleGNlcHRpb25z RmlsZVxuIiB1bmxlc3MgIWRlZmluZWQgJGV4Y2VwdGlvbnNGaWxlOwogCkBAIC05MCwxOCArOTIs MjYgQEAgbXkgJE5TTG9jYWxpemVDb3VudCA9IDA7CiBteSAlZXhjZXB0aW9uOwogbXkgJXVzZWRF eGNlcHRpb247CiAKK3N1YiBlbWl0V2FybmluZygkJCQpCit7CisgICAgbXkgKCRmaWxlLCAkbGlu ZSwgJG1lc3NhZ2UpID0gQF87CisgICAgbXkgJHByZWZpeCA9ICR0cmVhdFdhcm5pbmdzQXNFcnJv cnMgPyAiIiA6ICJ3YXJuaW5nOiAiOworICAgIHByaW50ICIkZmlsZTokbGluZTogJHByZWZpeCRt ZXNzYWdlXG4iOworICAgICRzYXdFcnJvciA9IDEgaWYgJHRyZWF0V2FybmluZ3NBc0Vycm9yczsK K30KKwogaWYgKGRlZmluZWQgJGV4Y2VwdGlvbnNGaWxlICYmIG9wZW4gRVhDRVBUSU9OUywgJGV4 Y2VwdGlvbnNGaWxlKSB7CiAgICAgd2hpbGUgKDxFWENFUFRJT05TPikgewogICAgICAgICBjaG9t cDsKICAgICAgICAgaWYgKC9eIihbXlxcIl18XFwuKSoiJC8gb3IgL15bLV9cL1x3XHMuXSsuKGh8 bXxtbXxjfGNwcCkkLyBvciAvXlstX1wvXHdccy5dKy4oaHxtfG1tfGN8Y3BwKToiKFteXFwiXXxc XC4pKiIkLykgewogICAgICAgICAgICAgaWYgKCRleGNlcHRpb257JF99KSB7Ci0gICAgICAgICAg ICAgICAgcHJpbnQgIiRleGNlcHRpb25zRmlsZTokLjogd2FybmluZzogZXhjZXB0aW9uIGZvciAk XyBhcHBlYXJzIHR3aWNlXG4iOwotICAgICAgICAgICAgICAgIHByaW50ICIkZXhjZXB0aW9uc0Zp bGU6JGV4Y2VwdGlvbnskX306IHdhcm5pbmc6IGZpcnN0IGFwcGVhcmFuY2VcbiI7CisgICAgICAg ICAgICAgICAgZW1pdFdhcm5pbmcoJGV4Y2VwdGlvbnNGaWxlLCAkLiwgImV4Y2VwdGlvbiBmb3Ig JF8gYXBwZWFycyB0d2ljZSIpOworICAgICAgICAgICAgICAgIGVtaXRXYXJuaW5nKCRleGNlcHRp b25zRmlsZSwgJGV4Y2VwdGlvbnskX30sICJmaXJzdCBhcHBlYXJhbmNlIik7CiAgICAgICAgICAg ICB9IGVsc2UgewogICAgICAgICAgICAgICAgICRleGNlcHRpb257JF99ID0gJC47CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBwcmludCAiJGV4Y2VwdGlvbnNG aWxlOiQuOiB3YXJuaW5nOiBzeW50YXggZXJyb3JcbiI7CisgICAgICAgICAgICBlbWl0V2Fybmlu ZygkZXhjZXB0aW9uc0ZpbGUsICQuLCAic3ludGF4IGVycm9yIik7CiAgICAgICAgIH0KICAgICB9 CiAgICAgY2xvc2UgRVhDRVBUSU9OUzsKQEAgLTIwNCw3ICsyMTQsNyBAQCBoYW5kbGVTdHJpbmc6 CiAgICAgICAgICAgICAgICAgICAgIH0gZWxzaWYgKCRleGNlcHRpb257IiRmaWxlOlwiJHN0cmlu Z1wiIn0pIHsKICAgICAgICAgICAgICAgICAgICAgICAgICR1c2VkRXhjZXB0aW9ueyIkZmlsZTpc IiRzdHJpbmdcIiJ9ID0gMTsKICAgICAgICAgICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAg ICAgICAgICAgICAgICAgIHByaW50ICIkZmlsZTokc3RyaW5nTGluZTogd2FybmluZzogXCIkc3Ry aW5nXCIgaXMgbm90IG1hcmtlZCBmb3IgbG9jYWxpemF0aW9uXG4iIGlmICR3YXJuQWJvdXRVbmxv Y2FsaXplZFN0cmluZ3M7CisgICAgICAgICAgICAgICAgICAgICAgICBlbWl0V2FybmluZygkZmls ZSwgJHN0cmluZ0xpbmUsICJcIiRzdHJpbmdcIiBpcyBub3QgbWFya2VkIGZvciBsb2NhbGl6YXRp b24iKSBpZiAkd2FybkFib3V0VW5sb2NhbGl6ZWRTdHJpbmdzOwogICAgICAgICAgICAgICAgICAg ICAgICAgJG5vdExvY2FsaXplZENvdW50Kys7CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICB9CkBAIC0zNDMsMTQgKzM1MywxNCBAQCBzdWIgSGFuZGxlVUlTdHJpbmcKICAg ICB9CiAgICAgCiAgICAgaWYgKCRzdHJpbmdCeUtleXska2V5fSAmJiAkc3RyaW5nQnlLZXl7JGtl eX0gbmUgJHN0cmluZykgewotICAgICAgICBwcmludCAiJGZpbGU6JGxpbmU6IHdhcm5pbmc6IGVu Y291bnRlcmVkIHRoZSBzYW1lIGtleSwgXCIka2V5XCIsIHR3aWNlLCB3aXRoIGRpZmZlcmVudCBz dHJpbmdzXG4iOwotICAgICAgICBwcmludCAiJGZpbGVCeUtleXska2V5fTokbGluZUJ5S2V5eyRr ZXl9OiB3YXJuaW5nOiBwcmV2aW91cyBvY2N1cnJlbmNlXG4iOworICAgICAgICBlbWl0V2Fybmlu ZygkZmlsZSwgJGxpbmUsICJlbmNvdW50ZXJlZCB0aGUgc2FtZSBrZXksIFwiJGtleVwiLCB0d2lj ZSwgd2l0aCBkaWZmZXJlbnQgc3RyaW5ncyIpOworICAgICAgICBlbWl0V2FybmluZygkZmlsZUJ5 S2V5eyRrZXl9LCAkbGluZUJ5S2V5eyRrZXl9LCAicHJldmlvdXMgb2NjdXJyZW5jZSIpOwogICAg ICAgICAka2V5Q29sbGlzaW9uQ291bnQrKzsKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBp ZiAoJGNvbW1lbnRCeUtleXska2V5fSAmJiAkY29tbWVudEJ5S2V5eyRrZXl9IG5lICRjb21tZW50 KSB7Ci0gICAgICAgIHByaW50ICIkZmlsZTokbGluZTogd2FybmluZzogZW5jb3VudGVyZWQgdGhl IHNhbWUga2V5LCBcIiRrZXlcIiwgdHdpY2UsIHdpdGggZGlmZmVyZW50IGNvbW1lbnRzXG4iOwot ICAgICAgICBwcmludCAiJGZpbGVCeUtleXska2V5fTokbGluZUJ5S2V5eyRrZXl9OiB3YXJuaW5n OiBwcmV2aW91cyBvY2N1cnJlbmNlXG4iOworICAgICAgICBlbWl0V2FybmluZygkZmlsZSwgJGxp bmUsICJlbmNvdW50ZXJlZCB0aGUgc2FtZSBrZXksIFwiJGtleVwiLCB0d2ljZSwgd2l0aCBkaWZm ZXJlbnQgY29tbWVudHMiKTsKKyAgICAgICAgZW1pdFdhcm5pbmcoJGZpbGVCeUtleXska2V5fSwg JGxpbmVCeUtleXska2V5fSwgInByZXZpb3VzIG9jY3VycmVuY2UiKTsKICAgICAgICAgJGtleUNv bGxpc2lvbkNvdW50Kys7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0zNjYsNyArMzc2LDcg QEAgcHJpbnQgIlxuIiBpZiAkc2F3RXJyb3IgfHwgJG5vdExvY2FsaXplZAogbXkgQHVudXNlZEV4 Y2VwdGlvbnMgPSBzb3J0IGdyZXAgeyAhJHVzZWRFeGNlcHRpb257JF99IH0ga2V5cyAlZXhjZXB0 aW9uOwogaWYgKEB1bnVzZWRFeGNlcHRpb25zKSB7CiAgICAgZm9yIG15ICR1bnVzZWQgKEB1bnVz ZWRFeGNlcHRpb25zKSB7Ci0gICAgICAgIHByaW50ICIkZXhjZXB0aW9uc0ZpbGU6JGV4Y2VwdGlv bnskdW51c2VkfTogd2FybmluZzogZXhjZXB0aW9uICR1bnVzZWQgbm90IHVzZWRcbiI7CisgICAg ICAgIGVtaXRXYXJuaW5nKCRleGNlcHRpb25zRmlsZSwgJGV4Y2VwdGlvbnskdW51c2VkfSwgImV4 Y2VwdGlvbiAkdW51c2VkIG5vdCB1c2VkIik7CiAgICAgfQogICAgIHByaW50ICJcbiI7CiB9Cg==