139942 2014-12-24 22:03:55 -0800 [Cocoa] WebKit private headers shouldn’t contain “inappropriate” macros 2014-12-24 22:29:08 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 1057812 0 mitz 2014-12-24 22:03:55 -0800 The Check For Inappropriate Macros in External Headers build phase should check PrivateHeaders as well. 1057813 1 243739 mitz 2014-12-24 22:05:35 -0800 Created attachment 243739 Check private headers for inappropriate macros 1057820 2 mitz 2014-12-24 22:29:08 -0800 Committed <http://trac.webkit.org/r177732>. 243739 2014-12-24 22:05:35 -0800 2014-12-24 22:22:15 -0800 Check private headers for inappropriate macros bug-139942-20141224220536.patch text/plain 1812 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzczMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTI0ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBXZWJLaXQgcHJpdmF0 ZSBoZWFkZXJzIHNob3VsZG7igJl0IGNvbnRhaW4g4oCcaW5hcHByb3ByaWF0ZeKAnSBtYWNyb3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTk0Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0 Mi54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOiBJbiB0aGUgQ2hlY2sgRm9yIEluYXBwcm9wcmlh dGUgTWFjcm9zIGluIEV4dGVybmFsCisgICAgICAgIEhlYWRlcnMgc2NyaXB0IGJ1aWxkIHBoYXNl LCBjaGVjayB0aGUgUHJpdmF0ZUhlYWRlcnMgZGlyZWN0b3J5IGFzIHdlbGwuCisKIDIwMTQtMTIt MjQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGRyZXNzZWQg YSBsaW5rZXIgd2FybmluZyBhYm91dCB0aGUgZGVmaW5pdGlvbiBvZiBhIG1ldGhvZCBpbiBhIGNh dGVnb3J5IG92ZXJyaWRuZyBhIG1ldGhvZCBmcm9tIHRoZSBjbGFzcy4KSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1dlYktpdDIueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvago9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9XZWJLaXQyLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHJldmlzaW9u IDE3NzczMCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYktpdDIueGNvZGVwcm9qL3Byb2plY3QucGJ4 cHJvagkod29ya2luZyBjb3B5KQpAQCAtODczNSw3ICs4NzM1LDcgQEAKIAkJCSk7CiAJCQlydW5P bmx5Rm9yRGVwbG95bWVudFBvc3Rwcm9jZXNzaW5nID0gMDsKIAkJCXNoZWxsUGF0aCA9IC9iaW4v c2g7Ci0JCQlzaGVsbFNjcmlwdCA9ICJpZiBbIFwiJHtBQ1RJT059XCIgPSBcImluc3RhbGxoZHJz XCIgXTsgdGhlblxuICAgIGV4aXQgMDtcbmZpXG5cbmlmIFsgLWYgLi4vLi4vVG9vbHMvU2NyaXB0 cy9jaGVjay1mb3ItaW5hcHByb3ByaWF0ZS1tYWNyb3MtaW4tZXh0ZXJuYWwtaGVhZGVycyBdOyB0 aGVuXG4gICAgLi4vLi4vVG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItaW5hcHByb3ByaWF0ZS1tYWNy b3MtaW4tZXh0ZXJuYWwtaGVhZGVycyBIZWFkZXJzIHx8IGV4aXQgJD9cbmZpIjsKKwkJCXNoZWxs U2NyaXB0ID0gImlmIFsgXCIke0FDVElPTn1cIiA9IFwiaW5zdGFsbGhkcnNcIiBdOyB0aGVuXG4g ICAgZXhpdCAwO1xuZmlcblxuaWYgWyAtZiAuLi8uLi9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci1p bmFwcHJvcHJpYXRlLW1hY3Jvcy1pbi1leHRlcm5hbC1oZWFkZXJzIF07IHRoZW5cbiAgICAuLi8u Li9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci1pbmFwcHJvcHJpYXRlLW1hY3Jvcy1pbi1leHRlcm5h bC1oZWFkZXJzIEhlYWRlcnMgUHJpdmF0ZUhlYWRlcnMgfHwgZXhpdCAkP1xuZmkiOwogCQl9Owog CQlCQ0ZGQ0E4QTE2MEQ2REVBMDAzREYzMTUgLyogQWRkIGN1cnJlbnQgdmVyc2lvbiBzeW1saW5r cyAqLyA9IHsKIAkJCWlzYSA9IFBCWFNoZWxsU2NyaXB0QnVpbGRQaGFzZTsK