139941 2014-12-24 21:48:17 -0800 Engineering builds of MiniBrowser ignore deprecated declaration warnings 2014-12-24 22:27:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz darin oldest_to_newest 1057810 0 mitz 2014-12-24 21:48:17 -0800 MiniBrowser builds with GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS=NO even in the engineering configurations. 1057811 1 243738 mitz 2014-12-24 21:52:02 -0800 Created attachment 243738 Enable deprecation warnings 1057816 2 243738 darin 2014-12-24 22:22:04 -0800 Comment on attachment 243738 Enable deprecation warnings View in context: https://bugs.webkit.org/attachment.cgi?id=243738&action=review > Tools/MiniBrowser/mac/AppDelegate.m:167 > +#pragma clang diagnostic push > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" > if (result != NSOKButton) > return; > +#pragma clang diagnostic pop I think we should be using NSFileHandlingPanelOKButton here instead of NSOKButton (not NSModalResponseOK), but I guess maybe that is not available in OS X 10.8 either. > Tools/MiniBrowser/mac/AppDelegate.m:181 > +#pragma clang diagnostic push > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" > if (result != NSOKButton) > return; > +#pragma clang diagnostic pop Ditto. 1057818 3 mitz 2014-12-24 22:27:54 -0800 (In reply to comment #2) > Comment on attachment 243738 [details] > Enable deprecation warnings > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243738&action=review > > > Tools/MiniBrowser/mac/AppDelegate.m:167 > > +#pragma clang diagnostic push > > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" > > if (result != NSOKButton) > > return; > > +#pragma clang diagnostic pop > > I think we should be using NSFileHandlingPanelOKButton here instead of > NSOKButton (not NSModalResponseOK), but I guess maybe that is not available > in OS X 10.8 either. Thanks for the suggestion! NSFileHandlingPanelOKButton is more appropriate and has been available since 10.10. Fixed in <http://trac.webkit.org/r177731>. 243738 2014-12-24 21:52:02 -0800 2014-12-24 22:22:04 -0800 Enable deprecation warnings bug-139941-20141224215203.patch text/plain 3610 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NzczMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE0LTEyLTI0ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgRW5naW5lZXJpbmcgYnVpbGRzIG9mIE1pbmlCcm93c2VyIGlnbm9yZSBkZXByZWNh dGVkIGRlY2xhcmF0aW9uIHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzk5NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25m aWc6IEFkZGVkIHNlbWljb2xvbi4KKyAgICAgICAgKiBNaW5pQnJvd3Nlci9Db25maWd1cmF0aW9u cy9EZWJ1Z1JlbGVhc2UueGNjb25maWc6IFNldCBHQ0NfV0FSTl9BQk9VVF9ERVBSRUNBVEVEX0ZV TkNUSU9OUworICAgICAgICB0byBZRVMuCisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL0FwcERl bGVnYXRlLm06CisgICAgICAgICgtW0Jyb3dzZXJBcHBEZWxlZ2F0ZSBvcGVuRG9jdW1lbnQ6XSk6 IElnbm9yZSBkZXByZWNhdGlvbiB3YXJuaW5ncyBmb3IgYW4gZW51bSB2YWx1ZQorICAgICAgICB0 aGF04oCZcyBkZXByZWNhdGVkIGluIE9TIFggMTAuMTAsIGJlY2F1c2UgaXRzIHJlcGxhY2VtZW50 IGlzIG5vdCBhdmFpbGFibGUgaW4gT1MgWCAxMC44LgorCiAyMDE0LTEyLTI0ICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgVzNDIHRlc3QgaW1w b3J0ZXIgc2hvdWxkIGhhdmUgYW4gb3B0aW9uIHRvIGRpc2FibGUgdGVzdGhhcm5lc3MuanMvdGVz dGhhcm5lc3NyZXBvcnQuanMgbGluayBjb252ZXJzaW9uCkluZGV4OiBUb29scy9NaW5pQnJvd3Nl ci9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlC cm93c2VyL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcJKHJldmlzaW9uIDE3NzczMCkKKysr IFRvb2xzL01pbmlCcm93c2VyL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcJKHdvcmtpbmcg Y29weSkKQEAgLTM3LDcgKzM3LDcgQEAgQ0xBTkdfV0FSTl9FTlVNX0NPTlZFUlNJT04gPSBZRVM7 CiBDTEFOR19XQVJOX0lOVF9DT05WRVJTSU9OID0gWUVTOwogQ0xBTkdfV0FSTl9VTlJFQUNIQUJM RV9DT0RFID0gWUVTOwogR0NDX1dBUk5fNjRfVE9fMzJfQklUX0NPTlZFUlNJT04gPSBZRVM7Ci1H Q0NfV0FSTl9BQk9VVF9ERVBSRUNBVEVEX0ZVTkNUSU9OUyA9IE5PCitHQ0NfV0FSTl9BQk9VVF9E RVBSRUNBVEVEX0ZVTkNUSU9OUyA9IE5POwogR0NDX1dBUk5fQUJPVVRfUkVUVVJOX1RZUEUgPSBZ RVM7CiBHQ0NfV0FSTl9VTklOSVRJQUxJWkVEX0FVVE9TID0gWUVTOwogR0NDX1dBUk5fVU5VU0VE X0ZVTkNUSU9OID0gWUVTCkluZGV4OiBUb29scy9NaW5pQnJvd3Nlci9Db25maWd1cmF0aW9ucy9E ZWJ1Z1JlbGVhc2UueGNjb25maWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvTWluaUJyb3dzZXIvQ29u ZmlndXJhdGlvbnMvRGVidWdSZWxlYXNlLnhjY29uZmlnCShyZXZpc2lvbiAxNzc3MzApCisrKyBU b29scy9NaW5pQnJvd3Nlci9Db25maWd1cmF0aW9ucy9EZWJ1Z1JlbGVhc2UueGNjb25maWcJKHdv cmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDggQEAgTUFDT1NYX0RFUExPWU1FTlRfVEFSR0VUXzEw OTAgPSAxMC45OwogTUFDT1NYX0RFUExPWU1FTlRfVEFSR0VUXzEwMTAwMCA9IDEwLjEwOwogTUFD T1NYX0RFUExPWU1FTlRfVEFSR0VUXzEwMTEwMCA9IDEwLjExOwogCitHQ0NfV0FSTl9BQk9VVF9E RVBSRUNBVEVEX0ZVTkNUSU9OUyA9IFlFUzsKKwogT1RIRVJfQ0ZMQUdTID0gJChBU0FOX09USEVS X0NGTEFHUyk7CiBPVEhFUl9DUExVU1BMVVNGTEFHUyA9ICQoQVNBTl9PVEhFUl9DUExVU1BMVVNG TEFHUyk7CiBPVEhFUl9MREZMQUdTID0gJChBU0FOX09USEVSX0xERkxBR1MpOwpJbmRleDogVG9v bHMvTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvTWlu aUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0JKHJldmlzaW9uIDE3NzczMCkKKysrIFRvb2xzL01p bmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5tCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAsOCArMTYw LDExIEBAIC0gKElCQWN0aW9uKW9wZW5Eb2N1bWVudDooaWQpc2VuZGVyCiAgICAgaWYgKGJyb3dz ZXJXaW5kb3dDb250cm9sbGVyKSB7CiAgICAgICAgIE5TT3BlblBhbmVsICpvcGVuUGFuZWwgPSBb W05TT3BlblBhbmVsIG9wZW5QYW5lbF0gcmV0YWluXTsKICAgICAgICAgW29wZW5QYW5lbCBiZWdp blNoZWV0TW9kYWxGb3JXaW5kb3c6YnJvd3NlcldpbmRvd0NvbnRyb2xsZXIud2luZG93IGNvbXBs ZXRpb25IYW5kbGVyOl4oTlNJbnRlZ2VyIHJlc3VsdCkgeworI3ByYWdtYSBjbGFuZyBkaWFnbm9z dGljIHB1c2gKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV2RlcHJlY2F0ZWQt ZGVjbGFyYXRpb25zIgogICAgICAgICAgICAgaWYgKHJlc3VsdCAhPSBOU09LQnV0dG9uKQogICAg ICAgICAgICAgICAgIHJldHVybjsKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKIAogICAg ICAgICAgICAgTlNVUkwgKnVybCA9IFtvcGVuUGFuZWwuVVJMcyBvYmplY3RBdEluZGV4OjBdOwog ICAgICAgICAgICAgW2Jyb3dzZXJXaW5kb3dDb250cm9sbGVyIGxvYWRVUkxTdHJpbmc6W3VybCBh YnNvbHV0ZVN0cmluZ11dOwpAQCAtMTcxLDggKzE3NCwxMSBAQCAtIChJQkFjdGlvbilvcGVuRG9j dW1lbnQ6KGlkKXNlbmRlcgogCiAgICAgTlNPcGVuUGFuZWwgKm9wZW5QYW5lbCA9IFtOU09wZW5Q YW5lbCBvcGVuUGFuZWxdOwogICAgIFtvcGVuUGFuZWwgYmVnaW5XaXRoQ29tcGxldGlvbkhhbmRs ZXI6XihOU0ludGVnZXIgcmVzdWx0KSB7CisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAor I3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XZGVwcmVjYXRlZC1kZWNsYXJhdGlv bnMiCiAgICAgICAgIGlmIChyZXN1bHQgIT0gTlNPS0J1dHRvbikKICAgICAgICAgICAgIHJldHVy bjsKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKIAogICAgICAgICBCcm93c2VyV2luZG93 Q29udHJvbGxlciAqbmV3QnJvd3NlcldpbmRvd0NvbnRyb2xsZXIgPSBbW1dLMUJyb3dzZXJXaW5k b3dDb250cm9sbGVyIGFsbG9jXSBpbml0V2l0aFdpbmRvd05pYk5hbWU6QCJCcm93c2VyV2luZG93 Il07CiAgICAgICAgIFtuZXdCcm93c2VyV2luZG93Q29udHJvbGxlci53aW5kb3cgbWFrZUtleUFu ZE9yZGVyRnJvbnQ6c2VsZl07Cg==