139936 2014-12-24 14:46:35 -0800 ANGLE extern symbols are not hidden by default, but should be 2014-12-24 15:10:33 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136172 1 mitz mitz andersca commit-queue dino kondapallykalyan mrowe roger_fong sam thorton oldest_to_newest 1057777 0 mitz 2014-12-24 14:46:35 -0800 Once WebCore stops using an exports file, the default visibility of ANGLE symbols will carry over to WebCore. WebCore shouldn’t export any ANGLE symbols, so ANGLE should build with -fvisibility=hidden. 1057778 1 243729 mitz 2014-12-24 14:50:28 -0800 Created attachment 243729 Change GCC_SYMBOLS_PRIVATE_EXTERN to YES 1057779 2 commit-queue 2014-12-24 14:53:21 -0800 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1057780 3 mitz 2014-12-24 15:10:33 -0800 Fixed in <http://trac.webkit.org/r177724>. 243729 2014-12-24 14:50:28 -0800 2014-12-24 15:09:28 -0800 Change GCC_SYMBOLS_PRIVATE_EXTERN to YES bug-139936-20141224145029.patch text/plain 1242 mitz SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzcyMykKKysrIFNv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDEyIEBACisyMDE0LTEyLTI0ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAg ICAgICAgQU5HTEUgZXh0ZXJuIHN5bWJvbHMgYXJlIG5vdCBoaWRkZW4gYnkgZGVmYXVsdCwgYnV0 IHNob3VsZCBiZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM5OTM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBDb25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOiBDaGFuZ2VkIEdDQ19TWU1CT0xTX1BS SVZBVEVfRVhURVJOIHRvIFlFUy4KKwogMjAxNC0xMi0yNCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZWQgdGhlIERlcml2ZWQgU291cmNlcyB0YXJnZXQu CkluZGV4OiBTb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29u ZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25z L0Jhc2UueGNjb25maWcJKHJldmlzaW9uIDE3NzcyMCkKKysrIFNvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTI4LDcg KzI4LDcgQEAgR0NDX01PREVMX1RVTklOR1tzZGs9bWFjb3N4Kl0gPSBHNTsKIEdDQ19PQkpDX0NB TExfQ1hYX0NEVE9SUyA9IFlFUzsKIEdDQ19PUFRJTUlaQVRJT05fTEVWRUwgPSBzOwogR0NDX1BS RUNPTVBJTEVfUFJFRklYX0hFQURFUiA9IE5POwotR0NDX1NZTUJPTFNfUFJJVkFURV9FWFRFUk4g PSBOTzsKK0dDQ19TWU1CT0xTX1BSSVZBVEVfRVhURVJOID0gWUVTOwogR0NDX1RIUkVBRFNBRkVf U1RBVElDUyA9IE5POwogR0NDX1RSRUFUX1dBUk5JTkdTX0FTX0VSUk9SUyA9IFlFUzsKIEdDQ19W RVJTSU9OID0gY29tLmFwcGxlLmNvbXBpbGVycy5sbHZtLmNsYW5nLjFfMDsK