139933 2014-12-23 22:35:54 -0800 DumpRenderTree crashes are mis-reported as timeouts on Yosemite 2014-12-24 00:35:20 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=139143 P2 Normal --- 1 ap ap commit-queue dbates ddkilzer glenn mrowe oldest_to_newest 1057756 0 ap 2014-12-23 22:35:54 -0800 Generating a crash log takes ~2 minutes on my machine, which is longer than what run-webkit-tests waits before deciding that the tool crashed. Looking at bots, crashes are mis-reported as timeouts too. See also: <rdar://problem/18701447>. 1057758 1 243727 ap 2014-12-23 23:16:09 -0800 Created attachment 243727 proposed fix 1057762 2 243727 dbates 2014-12-23 23:51:14 -0800 Comment on attachment 243727 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=243727&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1141 > NSString *identifier = [[NSBundle mainBundle] bundleIdentifier]; > const char *stdinPath = [[NSString stringWithFormat:@"/tmp/%@_IN", identifier] UTF8String]; > const char *stdoutPath = [[NSString stringWithFormat:@"/tmp/%@_OUT", identifier] UTF8String]; This code (lines 1139 thru 1149 in the proposed patch) is specific to the iOS LayoutTestRelay infrastructure (*) and hence should be guarded with PLATFORM(IOS). That is, we should only move the SIGNAL(3) calls outside the PLATFORM(IOS)-guard (lines 1151 thru 1154 in the proposed patch). (*) On iOS we indirectly launch DumpRenderTree.app/WebKitTestRunnerApp.app using a helper app, LayoutTestRelay. We use FIFOs (see MKFIFO(1)) as the communication medium between LayoutTestRelay and DumpRenderTree.app/WebKitTestRunnerApp.app instead of using pipes because of limitations with respect to launching a process in the iOS Simulator. 1057764 3 ap 2014-12-24 00:35:20 -0800 Ah, so that's what this sorcery is about. Thanks! Committed <http://trac.webkit.org/r177722>. 243727 2014-12-23 23:16:09 -0800 2014-12-23 23:51:14 -0800 proposed fix YosemiteCrash.txt text/plain 3428 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NzcyMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI3IEBACisyMDE0LTEyLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIER1bXBSZW5kZXJUcmVlIGNyYXNoZXMgYXJlIG1pcy1yZXBvcnRlZCBhcyB0 aW1lb3V0cyBvbiBZb3NlbWl0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM5OTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ3Jhc2ggbG9ncyB0YWtlIGEgdmVyeSBsb25nIHRpbWUgdG8gYmUgZ2VuZXJh dGVkIG9uIFlvc2VtaXRlIChyZGFyOi8vcHJvYmxlbS8xODcwMTQ0NyksCisgICAgICAgIGFuZCB0 aGVyZSBpcyBubyB3YXkgZm9yIHJ1bi13ZWJraXQtdGVzdHMgdG8gdGVsbCBhIGNyYXNoZWQgcHJv Y2VzcyBmcm9tIGEgZnJvemVuIG9uZQorICAgICAgICB1bnRpbCBSZXBvcnRDcmFzaCBsZXRzIGl0 IGdvLgorCisgICAgICAgIFJldXNlIGV4aXN0aW5nIG1hY2hpbmVyeSB0aGF0IHRlbGxzIHJ1bi13 ZWJraXQtdGVzdHMgYWJvdXQgY3Jhc2hlcy4gVGhlIHNjcmlwdCBtYXkKKyAgICAgICAgZXZlbiBn ZXQgdGhlIGFjdHVhbCBjcmFzaCBsb2cgZXZlbnR1YWxseSAtIGV2ZW4gd2hlbiBpdCB0aW1lcyBv dXQgd2FpdGluZyBmb3IgdGhlIGxvZywgaXQKKyAgICAgICAgbWFrZXMgYSBzZWNvbmQgbG9va3Vw IGF0IHRoZSB2ZXJ5IGVuZCwgYWZ0ZXIgYWxsIHRlc3RzIGZpbmlzaC4gVGhlcmUgbWF5IGJlIGZ1 cnRoZXIKKyAgICAgICAgaW1wcm92ZW1lbnRzIG5lZWRlZCBoZXJlLCBidXQgdGhpcyBzbWFsbCBm aXggYWRkcmVzc2VzIG1vc3QgY2FzZXMgdGhhdCBoYXBwZW4gaW4gcHJhY3RpY2UuCisKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAgICAgICh3cml0 ZUNyYXNoZWRNZXNzYWdlT25GYXRhbEVycm9yKToKKyAgICAgICAgKGR1bXBSZW5kZXJUcmVlKToK KyAgICAgICAgUmVtb3ZlZCBQTEFURk9STShJT1MpIGlmZGVmcywgdGhpcyBjb2RlIGlzIGp1c3Qg YXMgaGVscGZ1bCBvbiBNYWMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJp dmVyLnB5OiAoRHJpdmVyLl9jaGVja19mb3JfZHJpdmVyX2NyYXNoKTogUmVtb3ZlZCBhbgorICAg ICAgICB1bmhlbHBmdWwgY29tbWVudC4KKwogMjAxNC0xMi0yMyAgQWxleGV5IFByb3NrdXJ5YWtv diAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCBmb3JjZSAtTzEgZm9yIGRlYnVnIEFT YW4gYnVpbGRzCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVl Lm1tCShyZXZpc2lvbiAxNzc3MTMpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJl bmRlclRyZWUubW0JKHdvcmtpbmcgY29weSkKQEAgLTExMjEsNyArMTEyMSw2IEBAIHN0YXRpYyB2 b2lkIHByZXBhcmVDb25zaXN0ZW50VGVzdGluZ0VudmkKICNlbmRpZgogfQogCi0jaWYgUExBVEZP Uk0oSU9TKQogY29uc3QgY2hhciBjcmFzaGVkTWVzc2FnZVtdID0gIiNDUkFTSEVEXG4iOwogCiB2 b2lkIHdyaXRlQ3Jhc2hlZE1lc3NhZ2VPbkZhdGFsRXJyb3IoaW50IHNpZ25hbENvZGUpCkBAIC0x MTM0LDExICsxMTMzLDkgQEAgdm9pZCB3cml0ZUNyYXNoZWRNZXNzYWdlT25GYXRhbEVycm9yKGlu dAogICAgIHdyaXRlKFNUREVSUl9GSUxFTk8sICZjcmFzaGVkTWVzc2FnZVswXSwgc2l6ZW9mKGNy YXNoZWRNZXNzYWdlKSAtIDEpOwogICAgIGZzeW5jKFNUREVSUl9GSUxFTk8pOwogfQotI2VuZGlm CiAKIHZvaWQgZHVtcFJlbmRlclRyZWUoaW50IGFyZ2MsIGNvbnN0IGNoYXIgKmFyZ3ZbXSkKIHsK LSNpZiBQTEFURk9STShJT1MpCiAgICAgTlNTdHJpbmcgKmlkZW50aWZpZXIgPSBbW05TQnVuZGxl IG1haW5CdW5kbGVdIGJ1bmRsZUlkZW50aWZpZXJdOwogICAgIGNvbnN0IGNoYXIgKnN0ZGluUGF0 aCA9IFtbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIi90bXAvJUBfSU4iLCBpZGVudGlmaWVy XSBVVEY4U3RyaW5nXTsKICAgICBjb25zdCBjaGFyICpzdGRvdXRQYXRoID0gW1tOU1N0cmluZyBz dHJpbmdXaXRoRm9ybWF0OkAiL3RtcC8lQF9PVVQiLCBpZGVudGlmaWVyXSBVVEY4U3RyaW5nXTsK QEAgLTExNTUsNyArMTE1Miw2IEBAIHZvaWQgZHVtcFJlbmRlclRyZWUoaW50IGFyZ2MsIGNvbnN0 IGNoYXIKICAgICBzaWduYWwoU0lHRlBFLCAmd3JpdGVDcmFzaGVkTWVzc2FnZU9uRmF0YWxFcnJv cik7CiAgICAgc2lnbmFsKFNJR0JVUywgJndyaXRlQ3Jhc2hlZE1lc3NhZ2VPbkZhdGFsRXJyb3Ip OwogICAgIHNpZ25hbChTSUdTRUdWLCAmd3JpdGVDcmFzaGVkTWVzc2FnZU9uRmF0YWxFcnJvcik7 Ci0jZW5kaWYKIAogICAgIGluaXRpYWxpemVHbG9iYWxzRnJvbUNvbW1hbmRMaW5lT3B0aW9ucyhh cmdjLCBhcmd2KTsKICAgICBwcmVwYXJlQ29uc2lzdGVudFRlc3RpbmdFbnZpcm9ubWVudCgpOwpJ bmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5CShyZXZpc2lvbiAxNzc3MTMp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5CSh3b3JraW5nIGNvcHkp CkBAIC0zNzQsOCArMzc0LDYgQEAgY2xhc3MgRHJpdmVyKG9iamVjdCk6CiAKICAgICBkZWYgX2No ZWNrX2Zvcl9kcml2ZXJfY3Jhc2goc2VsZiwgZXJyb3JfbGluZSk6CiAgICAgICAgIGlmIGVycm9y X2xpbmUgPT0gIiNDUkFTSEVEXG4iOgotICAgICAgICAgICAgIyBUaGlzIGlzIHVzZWQgb24gV2lu ZG93cyBhbmQgaU9TIHRvIHJlcG9ydCB0aGF0IHRoZSBwcm9jZXNzIGhhcyBjcmFzaGVkCi0gICAg ICAgICAgICAjIFNlZSBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC82NTUzNy4KICAg ICAgICAgICAgIHNlbGYuX2NyYXNoZWRfcHJvY2Vzc19uYW1lID0gc2VsZi5fc2VydmVyX3Byb2Nl c3MubmFtZSgpCiAgICAgICAgICAgICBzZWxmLl9jcmFzaGVkX3BpZCA9IHNlbGYuX3NlcnZlcl9w cm9jZXNzLnBpZCgpCiAgICAgICAgIGVsaWYgKGVycm9yX2xpbmUuc3RhcnRzd2l0aCgiI0NSQVNI RUQgLSAiKQo=