139926 2014-12-23 16:58:17 -0800 Don't force -O1 for debug ASan builds 2014-12-23 20:43:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap dburkart ddkilzer mrowe zalan oldest_to_newest 1057707 0 ap 2014-12-23 16:58:17 -0800 We can now build debug with ASan, and it's not helpful to enable optimizations. 1057708 1 243713 ap 2014-12-23 16:59:20 -0800 Created attachment 243713 proposed fix 1057713 2 243713 mrowe 2014-12-23 17:08:42 -0800 Comment on attachment 243713 proposed fix Is there a reason to set this via OTHER_CFLAGS rather than overriding GCC_OPTIMIZATION_LEVEL? 1057727 3 ap 2014-12-23 18:18:47 -0800 The reason is that I didn't think of it. Now that I try it, I can't make it work. Replacing ASAN_OPTIMIZATION_LEVEL with the below, I get -O1 regardless of whether I do "make debug" or "make release". GCC_OPTIMIZATION_LEVEL = $(GCC_OPTIMIZATION_LEVEL_$(CURRENT_VARIANT)); GCC_OPTIMIZATION_LEVEL_normal = 3; GCC_OPTIMIZATION_LEVEL_debug = 0; 1057728 4 ap 2014-12-23 18:22:09 -0800 Err, the normal variant value is of course 1 when I try this, not 3. 1057729 5 243718 ap 2014-12-23 18:38:07 -0800 Created attachment 243718 proposed fix Perhaps as asan.xcconfig is evaluated globally, and variant is only defined by targets? 1057746 6 ap 2014-12-23 20:43:27 -0800 Committed <http://trac.webkit.org/r177718>. 243713 2014-12-23 16:59:20 -0800 2014-12-23 18:38:07 -0800 proposed fix DebugASan.txt text/plain 1394 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NzcwNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE0LTEyLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIERvbid0IGZvcmNlIC1PMSBmb3IgZGVidWcgQVNhbiBidWlsZHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTkyNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNhbi9hc2FuLnhj Y29uZmlnOgorCiAyMDE0LTEyLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIFNpbXBsaWZ5IGJ1aWxkaW5nIHdpdGggQVNhbgpJbmRleDogVG9vbHMvYXNh bi9hc2FuLnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL2FzYW4vYXNhbi54Y2NvbmZpZwko cmV2aXNpb24gMTc3NzAzKQorKysgVG9vbHMvYXNhbi9hc2FuLnhjY29uZmlnCSh3b3JraW5nIGNv cHkpCkBAIC01LDcgKzUsMTIgQEAgVE9PTENIQUlOU19tYWNvc3hfMTA5MCA9IGRlZmF1bHQ7CiBU T09MQ0hBSU5TX21hY29zeF8xMDEwMDAgPSBkZWZhdWx0OwogVE9PTENIQUlOU19tYWNvc3hfMTAx MTAwID0gJChUT09MQ0hBSU5TKTsKIAotQVNBTl9PVEhFUl9DRkxBR1MgPSAtZnNhbml0aXplPWFk ZHJlc3MgLU8xIC1mc2FuaXRpemUtYmxhY2tsaXN0PSQoQVNBTl9JR05PUkUpIC1mbm8tb21pdC1m cmFtZS1wb2ludGVyIC1nIC1EVVNFX1NZU1RFTV9NQUxMT0M9MTsKK0FTQU5fT1BUSU1JWkFUSU9O X0xFVkVMID0gJChBU0FOX09QVElNSVpBVElPTl9MRVZFTF8kKENPTkZJR1VSQVRJT04pKTsKK0FT QU5fT1BUSU1JWkFUSU9OX0xFVkVMX0RlYnVnID0gLU8wOworQVNBTl9PUFRJTUlaQVRJT05fTEVW RUxfUHJvZHVjdGlvbiA9IC1PMTsKK0FTQU5fT1BUSU1JWkFUSU9OX0xFVkVMX1JlbGVhc2UgPSAt TzE7CisKK0FTQU5fT1RIRVJfQ0ZMQUdTID0gLWZzYW5pdGl6ZT1hZGRyZXNzIC1mc2FuaXRpemUt YmxhY2tsaXN0PSQoQVNBTl9JR05PUkUpIC1mbm8tb21pdC1mcmFtZS1wb2ludGVyIC1nIC1EVVNF X1NZU1RFTV9NQUxMT0M9MSAkKEFTQU5fT1BUSU1JWkFUSU9OX0xFVkVMKTsKIEFTQU5fT1RIRVJf Q1BMVVNQTFVTRkxBR1MgPSAkKEFTQU5fT1RIRVJfQ0ZMQUdTKTsKIEFTQU5fT1RIRVJfTERGTEFH UyA9IC1mc2FuaXRpemU9YWRkcmVzczsKIAo= 243718 2014-12-23 18:38:07 -0800 2014-12-23 20:22:18 -0800 proposed fix DebugASan.txt text/plain 1356 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NzcxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE0LTEyLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIERvbid0IGZvcmNlIC1PMSBmb3IgZGVidWcgQVNhbiBidWlsZHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTkyNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNhbi9hc2FuLnhj Y29uZmlnOgorCiAyMDE0LTEyLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIFNpbXBsaWZ5IGJ1aWxkaW5nIHdpdGggQVNhbgpJbmRleDogVG9vbHMvYXNh bi9hc2FuLnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL2FzYW4vYXNhbi54Y2NvbmZpZwko cmV2aXNpb24gMTc3NzEzKQorKysgVG9vbHMvYXNhbi9hc2FuLnhjY29uZmlnCSh3b3JraW5nIGNv cHkpCkBAIC01LDcgKzUsMTIgQEAgVE9PTENIQUlOU19tYWNvc3hfMTA5MCA9IGRlZmF1bHQ7CiBU T09MQ0hBSU5TX21hY29zeF8xMDEwMDAgPSBkZWZhdWx0OwogVE9PTENIQUlOU19tYWNvc3hfMTAx MTAwID0gJChUT09MQ0hBSU5TKTsKIAotQVNBTl9PVEhFUl9DRkxBR1MgPSAtZnNhbml0aXplPWFk ZHJlc3MgLU8xIC1mc2FuaXRpemUtYmxhY2tsaXN0PSQoQVNBTl9JR05PUkUpIC1mbm8tb21pdC1m cmFtZS1wb2ludGVyIC1nIC1EVVNFX1NZU1RFTV9NQUxMT0M9MTsKK0dDQ19PUFRJTUlaQVRJT05f TEVWRUwgPSAkKEdDQ19PUFRJTUlaQVRJT05fTEVWRUxfJChDT05GSUdVUkFUSU9OKSk7CitHQ0Nf T1BUSU1JWkFUSU9OX0xFVkVMX0RlYnVnID0gMDsKK0dDQ19PUFRJTUlaQVRJT05fTEVWRUxfUHJv ZHVjdGlvbiA9IDE7CitHQ0NfT1BUSU1JWkFUSU9OX0xFVkVMX1JlbGVhc2UgPSAxOworCitBU0FO X09USEVSX0NGTEFHUyA9IC1mc2FuaXRpemU9YWRkcmVzcyAtZnNhbml0aXplLWJsYWNrbGlzdD0k KEFTQU5fSUdOT1JFKSAtZm5vLW9taXQtZnJhbWUtcG9pbnRlciAtZyAtRFVTRV9TWVNURU1fTUFM TE9DPTE7CiBBU0FOX09USEVSX0NQTFVTUExVU0ZMQUdTID0gJChBU0FOX09USEVSX0NGTEFHUyk7 CiBBU0FOX09USEVSX0xERkxBR1MgPSAtZnNhbml0aXplPWFkZHJlc3M7CiAK