139893 2014-12-22 19:19:12 -0800 Make it possible to transform Objective-C object graphs, replacing certain elements with others 2021-09-20 14:02:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 230467 230508 1 andersca andersca commit-queue oldest_to_newest 1057524 0 andersca 2014-12-22 19:19:12 -0800 Make it possible to transform Objective-C object graphs, replacing certain elements with others 1057525 1 243657 andersca 2014-12-22 19:20:55 -0800 Created attachment 243657 Patch 1057526 2 commit-queue 2014-12-22 19:24:01 -0800 Attachment 243657 did not pass style-queue: ERROR: Source/WebKit2/Shared/mac/ObjCObjectGraph.mm:50: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/ObjCObjectGraph.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1057527 3 andersca 2014-12-22 19:24:08 -0800 Committed r177677: <http://trac.webkit.org/changeset/177677> 243657 2014-12-22 19:20:55 -0800 2014-12-22 19:22:52 -0800 Patch bug-139893-20141222192056.patch text/plain 4020 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjg0ZTAwMzY1M2E0NGI5 ZTRjZGViNTdjMjhiNjc1YTkzOTNjMWQwMS4uZmM4N2RhMTg4MTY2Mzk1OWJkZWM1OWE1YTFkNTQ0 YmRiNzY5YzY0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTEyLTIyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBpdCBwb3Nz aWJsZSB0byB0cmFuc2Zvcm0gT2JqZWN0aXZlLUMgb2JqZWN0IGdyYXBocywgcmVwbGFjaW5nIGNl cnRhaW4gZWxlbWVudHMgd2l0aCBvdGhlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzOTg5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2hhcmVkL21hYy9PYmpDT2JqZWN0R3JhcGguaDoKKyAgICAg ICAgKFdlYktpdDo6T2JqQ09iamVjdEdyYXBoOjpUcmFuc2Zvcm1lcjo6flRyYW5zZm9ybWVyKToK KyAgICAgICAgKiBTaGFyZWQvbWFjL09iakNPYmplY3RHcmFwaC5tbToKKyAgICAgICAgKFdlYktp dDo6ZHluYW1pY19vYmpjX2Nhc3QpOgorICAgICAgICAoV2ViS2l0OjpzaG91bGRUcmFuc2Zvcm0p OgorICAgICAgICAoV2ViS2l0OjpPYmpDT2JqZWN0R3JhcGg6OnRyYW5zZm9ybSk6CisKKzIwMTQt MTItMjIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBD b252ZXJ0IHBhZ2VzIGFuZCBwYWdlIGdyb3VwcyB0byB0aGVpciByZXNwZWN0aXZlIGhhbmRsZSBv YmplY3RzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Mzk4OTEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9PYmpDT2JqZWN0 R3JhcGguaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvT2JqQ09iamVjdEdyYXBoLmgKaW5k ZXggZDIzMTBiZjJiYjAzMGVkZDE4NTA4Njk0MmFjN2JhNjI5Nzk0ZmU1Ni4uNjI2YTc3NGE3ZDAx YTk5MzUxNjNkMjNiMjA4NTM5YmM3MzAwNjU1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv U2hhcmVkL21hYy9PYmpDT2JqZWN0R3JhcGguaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv bWFjL09iakNPYmplY3RHcmFwaC5oCkBAIC00MCw2ICs0MCwxMyBAQCBwdWJsaWM6CiAKICAgICBp ZCByb290T2JqZWN0KCkgY29uc3QgeyByZXR1cm4gbV9yb290T2JqZWN0LmdldCgpOyB9CiAKKyAg ICBzdHJ1Y3QgVHJhbnNmb3JtZXIgeworICAgICAgICB2aXJ0dWFsIH5UcmFuc2Zvcm1lcigpIHsg fQorICAgICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkVHJhbnNmb3JtT2JqZWN0T2ZUeXBlKENsYXNz KSBjb25zdCA9IDA7CisgICAgICAgIHZpcnR1YWwgUmV0YWluUHRyPGlkPiB0cmFuc2Zvcm1PYmpl Y3QoaWQpIGNvbnN0ID0gMDsKKyAgICB9OworICAgIHN0YXRpYyBSZXRhaW5QdHI8aWQ+IHRyYW5z Zm9ybShpZCwgY29uc3QgVHJhbnNmb3JtZXImKTsKKwogcHJpdmF0ZToKICAgICBleHBsaWNpdCBP YmpDT2JqZWN0R3JhcGgoaWQgcm9vdE9iamVjdCkKICAgICAgICAgOiBtX3Jvb3RPYmplY3Qocm9v dE9iamVjdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvT2JqQ09iamVj dEdyYXBoLm1tIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9PYmpDT2JqZWN0R3JhcGgubW0K aW5kZXggODIyZWRkMTUxZTk3NzVhNmM2ODhkMThiODQ0ZmJkMjhjMGJjMDFiNC4uYmU1NTM1OGI2 NjI3NjcyYTE5YTcyMTUyMzk1YTYwM2NlMzkwMzNmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvU2hhcmVkL21hYy9PYmpDT2JqZWN0R3JhcGgubW0KKysrIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL21hYy9PYmpDT2JqZWN0R3JhcGgubW0KQEAgLTI1LDMgKzI1LDY3IEBACiAKICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJPYmpDT2JqZWN0R3JhcGguaCIKKworbmFtZXNwYWNlIFdl YktpdCB7CisKK3RlbXBsYXRlPHR5cGVuYW1lIFQ+IFQqIGR5bmFtaWNfb2JqY19jYXN0KGlkIG9i amVjdCkKK3sKKyAgICBpZiAoW29iamVjdCBpc0tpbmRPZkNsYXNzOltUIGNsYXNzXV0pCisgICAg ICAgIHJldHVybiAoVCAqKW9iamVjdDsKKworICAgIHJldHVybiBuaWw7Cit9CisKK3N0YXRpYyBi b29sIHNob3VsZFRyYW5zZm9ybShpZCBvYmplY3QsIGNvbnN0IE9iakNPYmplY3RHcmFwaDo6VHJh bnNmb3JtZXImIHRyYW5zZm9ybWVyKQoreworICAgIGlmIChOU0FycmF5ICphcnJheSA9IGR5bmFt aWNfb2JqY19jYXN0PE5TQXJyYXk+KG9iamVjdCkpIHsKKyAgICAgICAgZm9yIChpZCBlbGVtZW50 IGluIGFycmF5KSB7CisgICAgICAgICAgICBpZiAoc2hvdWxkVHJhbnNmb3JtKGVsZW1lbnQsIHRy YW5zZm9ybWVyKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQorICAg IH0KKworICAgIGlmIChOU0RpY3Rpb25hcnkgKmRpY3Rpb25hcnkgPSBkeW5hbWljX29iamNfY2Fz dDxOU0RpY3Rpb25hcnk+KG9iamVjdCkpIHsKKyAgICAgICAgYm9vbCByZXN1bHQgPSBmYWxzZTsK KyAgICAgICAgW2RpY3Rpb25hcnkgZW51bWVyYXRlS2V5c0FuZE9iamVjdHNVc2luZ0Jsb2NrOlsm dHJhbnNmb3JtZXIsICZyZXN1bHRdKGlkIGtleSwgaWQgb2JqZWN0LCBCT09MKiBzdG9wKSB7Cisg ICAgICAgICAgICBpZiAoc2hvdWxkVHJhbnNmb3JtKG9iamVjdCwgdHJhbnNmb3JtZXIpKSB7Cisg ICAgICAgICAgICAgICAgcmVzdWx0ID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAqc3RvcCA9IFlF UzsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfV07CisKKyAgICAgICAgcmV0dXJuIHJlc3VsdDsK KyAgICB9CisKKyAgICByZXR1cm4gdHJhbnNmb3JtZXIuc2hvdWxkVHJhbnNmb3JtT2JqZWN0T2ZU eXBlKFtvYmplY3QgY2xhc3NdKTsKK30KKworUmV0YWluUHRyPGlkPiBPYmpDT2JqZWN0R3JhcGg6 OnRyYW5zZm9ybShpZCBvYmplY3QsIGNvbnN0IFRyYW5zZm9ybWVyJiB0cmFuc2Zvcm1lcikKK3sK KyAgICBpZiAoIW9iamVjdCkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICBpZiAoIXNo b3VsZFRyYW5zZm9ybShvYmplY3QsIHRyYW5zZm9ybWVyKSkKKyAgICAgICAgcmV0dXJuIG9iamVj dDsKKworICAgIGlmIChOU0FycmF5ICphcnJheSA9IGR5bmFtaWNfb2JqY19jYXN0PE5TQXJyYXk+ KG9iamVjdCkpIHsKKyAgICAgICAgYXV0byByZXN1bHQgPSBhZG9wdE5TKFtbTlNNdXRhYmxlQXJy YXkgYWxsb2NdIGluaXRXaXRoQ2FwYWNpdHk6YXJyYXkuY291bnRdKTsKKyAgICAgICAgZm9yIChp ZCBlbGVtZW50IGluIGFycmF5KQorICAgICAgICAgICAgW3Jlc3VsdCBhZGRPYmplY3Q6dHJhbnNm b3JtKGVsZW1lbnQsIHRyYW5zZm9ybWVyKS5nZXQoKV07CisKKyAgICAgICAgcmV0dXJuIHJlc3Vs dDsKKyAgICB9CisKKyAgICBpZiAoTlNEaWN0aW9uYXJ5ICpkaWN0aW9uYXJ5ID0gZHluYW1pY19v YmpjX2Nhc3Q8TlNEaWN0aW9uYXJ5PihvYmplY3QpKSB7CisgICAgICAgIGF1dG8gcmVzdWx0ID0g YWRvcHROUyhbW05TTXV0YWJsZURpY3Rpb25hcnkgYWxsb2NdIGluaXRXaXRoQ2FwYWNpdHk6ZGlj dGlvbmFyeS5jb3VudF0pOworICAgICAgICBbZGljdGlvbmFyeSBlbnVtZXJhdGVLZXlzQW5kT2Jq ZWN0c1VzaW5nQmxvY2s6WyZyZXN1bHQsICZ0cmFuc2Zvcm1lcl0oaWQga2V5LCBpZCBvYmplY3Qs IEJPT0wqKSB7CisgICAgICAgICAgICBbcmVzdWx0IHNldE9iamVjdDp0cmFuc2Zvcm1lci50cmFu c2Zvcm1PYmplY3Qob2JqZWN0KS5nZXQoKSBmb3JLZXk6a2V5XTsKKyAgICAgICAgfV07CisKKyAg ICAgICAgcmV0dXJuIHJlc3VsdDsKKyAgICB9CisKKyAgICByZXR1cm4gdHJhbnNmb3JtZXIudHJh bnNmb3JtT2JqZWN0KG9iamVjdCk7Cit9CisKK30K