139888 2014-12-22 17:25:28 -0800 Saturated arithmetics: Incorrect float/double clamping. 2015-01-01 00:32:33 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan commit-queue simon.fraser oldest_to_newest 1057503 0 zalan 2014-12-22 17:25:28 -0800 #if ENABLE(SATURATED_LAYOUT_ARITHMETIC) - m_value = clampTo<float>(value * kFixedPointDenominator, static_cast<float>(INT_MIN), static_cast<float>(INT_MAX)); + m_value = clampToInteger(value * kFixedPointDenominator); #else 1057506 1 zalan 2014-12-22 17:28:02 -0800 rdar://problem/19330885 1057507 2 243653 zalan 2014-12-22 17:29:55 -0800 Created attachment 243653 Patch 1058310 3 243858 zalan 2014-12-31 22:56:07 -0800 Created attachment 243858 Patch 1058318 4 243858 commit-queue 2015-01-01 00:32:29 -0800 Comment on attachment 243858 Patch Clearing flags on attachment: 243858 Committed r177845: <http://trac.webkit.org/changeset/177845> 1058319 5 commit-queue 2015-01-01 00:32:33 -0800 All reviewed patches have been landed. Closing bug. 243653 2014-12-22 17:29:55 -0800 2014-12-31 22:56:05 -0800 Patch bug-139888-20141222172955.patch text/plain 3766 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRhMGRhOWYxY2JmMzM5 ZWFiN2QzZDEwYWUyZGFjMWU5OWZkYTlmMy4uZDYwYTg4MWVlMjIxNzQ1MTBkNmUwYzc1ZmJlOGI4 MTlkYjRjNTc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTEyLTIyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU2F0dXJhdGVkIGFyaXRobWV0 aWNzOiBJbmNvcnJlY3QgZmxvYXQvZG91YmxlIGNsYW1waW5nLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5ODg4CisgICAgICAgIHJkYXI6Ly9wcm9i bGVtLzE5MzMwODg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2xhbXAgZmxvYXQgYW5kIGRvdWJsZSB2YWx1ZXMgY29ycmVjdGx5IHdoZW4gYXBwbHlp bmcgc2F0dXJhdGVkIGFyaXRobWV0aWNzLgorCisgICAgICAgIFRlc3Q6IExheW91dFVuaXQgdGVz dCBmb3IgZmxvYXQgb3ZlcmZsb3cuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9MYXlvdXRVbml0Lmg6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRVbml0OjpMYXlvdXRVbml0KToKKwogMjAxNC0xMi0y MCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEdldCByaWQgb2Yg ZXJyb3ItcHJvbmUgUmVsZWFzZVBhcnNlZENhbGNWYWx1ZUNvbmRpdGlvbiBhcmd1bWVudCBpbiBD U1NQYXJzZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91dFVuaXQu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91dFVuaXQuaAppbmRleCA1OTcwZGU5MTMy MzgxYTc4NGY1OTRhNzFhNWJjNWRiNzk4OWQ2MDQ1Li4zMTk1NWYyNGFmNDIyNmI3N2IzNThlZGEw ZTJlYzhkMDllNTYxMDg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MYXlv dXRVbml0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oCkBAIC04 Niw3ICs4Niw3IEBAIHB1YmxpYzoKICAgICBMYXlvdXRVbml0KGZsb2F0IHZhbHVlKQogICAgIHsK ICNpZiBFTkFCTEUoU0FUVVJBVEVEX0xBWU9VVF9BUklUSE1FVElDKQotICAgICAgICBtX3ZhbHVl ID0gY2xhbXBUbzxmbG9hdD4odmFsdWUgKiBrRml4ZWRQb2ludERlbm9taW5hdG9yLCBzdGF0aWNf Y2FzdDxmbG9hdD4oSU5UX01JTiksIHN0YXRpY19jYXN0PGZsb2F0PihJTlRfTUFYKSk7CisgICAg ICAgIG1fdmFsdWUgPSBjbGFtcFRvSW50ZWdlcih2YWx1ZSAqIGtGaXhlZFBvaW50RGVub21pbmF0 b3IpOwogI2Vsc2UKICAgICAgICAgUkVQT1JUX09WRVJGTE9XKGlzSW5Cb3VuZHModmFsdWUpKTsK ICAgICAgICAgbV92YWx1ZSA9IHZhbHVlICoga0ZpeGVkUG9pbnREZW5vbWluYXRvcjsKQEAgLTk1 LDcgKzk1LDcgQEAgcHVibGljOgogICAgIExheW91dFVuaXQoZG91YmxlIHZhbHVlKQogICAgIHsK ICNpZiBFTkFCTEUoU0FUVVJBVEVEX0xBWU9VVF9BUklUSE1FVElDKQotICAgICAgICBtX3ZhbHVl ID0gY2xhbXBUbzxkb3VibGU+KHZhbHVlICoga0ZpeGVkUG9pbnREZW5vbWluYXRvciwgc3RhdGlj X2Nhc3Q8ZG91YmxlPihJTlRfTUlOKSwgc3RhdGljX2Nhc3Q8ZG91YmxlPihJTlRfTUFYKSk7Cisg ICAgICAgIG1fdmFsdWUgPSBjbGFtcFRvSW50ZWdlcih2YWx1ZSAqIGtGaXhlZFBvaW50RGVub21p bmF0b3IpOwogI2Vsc2UKICAgICAgICAgUkVQT1JUX09WRVJGTE9XKGlzSW5Cb3VuZHModmFsdWUp KTsKICAgICAgICAgbV92YWx1ZSA9IHZhbHVlICoga0ZpeGVkUG9pbnREZW5vbWluYXRvcjsKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0YzY3ZmY5 ZWNkMjE5ZjBiOGM4YTJkNzA2ZjUxZDZiODE2NTdjZTFhLi40NTNlYzNlZTI3MzhhZDRjMzU5MDkz ZjNjM2I5Zjc2MjExNDE3Y2Y1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMTItMjIgIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBTYXR1cmF0ZWQgYXJpdGhtZXRpY3M6IEluY29y cmVjdCBmbG9hdC9kb3VibGUgY2xhbXBpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk4ODgKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTkzMzA4 ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGFt cCBmbG9hdCBhbmQgZG91YmxlIHZhbHVlcyBjb3JyZWN0bHkgd2hlbiBhcHBseWluZyBzYXR1cmF0 ZWQgYXJpdGhtZXRpY3MuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUv TGF5b3V0VW5pdC5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxNC0x Mi0xOSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2lu XSBSZXZpc2UgRFJUIGxvZ2ljIHRvIG1hdGNoIE1hYy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9MYXlvdXRVbml0LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViQ29yZS9MYXlvdXRVbml0LmNwcAppbmRleCAxNjM3MmM2MTgwZDg5YjFlYTQx ZjdkNmQ3NWNkNDcwYjkyMTdiOWI4Li5jZTc4NTkwMWE3MzBmZDYyZTIzMmM0ZDk5ODU4NDJjZWNk Y2IwYWVmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTGF5 b3V0VW5pdC5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0xheW91 dFVuaXQuY3BwCkBAIC03NSw3ICs3NSwxMSBAQCBURVNUKFdlYkNvcmVMYXlvdXRVbml0LCBMYXlv dXRVbml0RmxvYXQpCiAgICAgQVNTRVJUX05FQVIoTGF5b3V0VW5pdCgzNDU2MzQpLnRvRmxvYXQo KSwgMzQ1NjM0LjBmLCB0b2xlcmFuY2UpOwogICAgIEFTU0VSVF9ORUFSKExheW91dFVuaXQoMzQ1 NjM0LjEyMzM1ZikudG9GbG9hdCgpLCAzNDU2MzQuMTIzMzVmLCB0b2xlcmFuY2UpOwogICAgIEFT U0VSVF9ORUFSKExheW91dFVuaXQoLTM0NTYzNC4xMjMzNWYpLnRvRmxvYXQoKSwgLTM0NTYzNC4x MjMzNWYsIHRvbGVyYW5jZSk7Ci0gICAgQVNTRVJUX05FQVIoTGF5b3V0VW5pdCgtMzQ1NjM0KS50 b0Zsb2F0KCksIC0zNDU2MzQuMGYsIHRvbGVyYW5jZSk7ICAgIAorICAgIEFTU0VSVF9ORUFSKExh eW91dFVuaXQoLTM0NTYzNCkudG9GbG9hdCgpLCAtMzQ1NjM0LjBmLCB0b2xlcmFuY2UpOworICAg IEFTU0VSVF9ORUFSKExheW91dFVuaXQoMzM1NTQ0MzIpLnRvRmxvYXQoKSwgMzM1NTQ0MzIuMGYs IHRvbGVyYW5jZSk7CisgICAgQVNTRVJUX05FQVIoTGF5b3V0VW5pdCgtMzM1NTQ0MzIpLnRvRmxv YXQoKSwgLTMzNTU0NDMyLjBmLCB0b2xlcmFuY2UpOworICAgIEFTU0VSVF9ORUFSKExheW91dFVu aXQoMzM1NTQ0MzIpLnRvRG91YmxlKCksIDMzNTU0NDMyLjAsIHRvbGVyYW5jZSk7CisgICAgQVNT RVJUX05FQVIoTGF5b3V0VW5pdCgtMzM1NTQ0MzIpLnRvRG91YmxlKCksIC0zMzU1NDQzMi4wLCB0 b2xlcmFuY2UpOwogfQogCiBURVNUKFdlYkNvcmVMYXlvdXRVbml0LCBMYXlvdXRVbml0Um91bmRp bmcpCg== 243858 2014-12-31 22:56:07 -0800 2015-01-01 00:32:29 -0800 Patch bug-139888-20141231225610.patch text/plain 3588 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU4N2VmMWQxNDNjYTM5 NDJmZmJiZWI2ZmFjZTZmZjNkOWQ1Y2VlOC4uN2E0Y2YzZTM4MDkzNzlkNTRlOWU5ZGNmOGUzNzhi NDIwMDgwYTgyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTEyLTMxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU2F0dXJhdGVkIGFyaXRobWV0 aWNzOiBJbmNvcnJlY3QgZmxvYXQvZG91YmxlIGNsYW1waW5nLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5ODg4CisgICAgICAgIHJkYXI6Ly9wcm9i bGVtLzE5MzMwODg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAg ICAgIENsYW1wIGZsb2F0IGFuZCBkb3VibGUgdmFsdWVzIGNvcnJlY3RseSB3aGVuIGFwcGx5aW5n IHNhdHVyYXRlZCBhcml0aG1ldGljcy4KKworICAgICAgICBUZXN0OiBMYXlvdXRVbml0IHRlc3Qg Zm9yIGZsb2F0IG92ZXJmbG93LgorCisgICAgICAgICogcGxhdGZvcm0vTGF5b3V0VW5pdC5oOgor ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0VW5pdDo6TGF5b3V0VW5pdCk6CisKIDIwMTQtMTItMzEg IERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXhlZCB0aGUgaU9T IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oCmluZGV4IDU5NzBkZTkxMzIz ODFhNzg0ZjU5NGE3MWE1YmM1ZGI3OTg5ZDYwNDUuLjMxOTU1ZjI0YWY0MjI2Yjc3YjM1OGVkYTBl MmVjOGQwOWU1NjEwODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91 dFVuaXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MYXlvdXRVbml0LmgKQEAgLTg2 LDcgKzg2LDcgQEAgcHVibGljOgogICAgIExheW91dFVuaXQoZmxvYXQgdmFsdWUpCiAgICAgewog I2lmIEVOQUJMRShTQVRVUkFURURfTEFZT1VUX0FSSVRITUVUSUMpCi0gICAgICAgIG1fdmFsdWUg PSBjbGFtcFRvPGZsb2F0Pih2YWx1ZSAqIGtGaXhlZFBvaW50RGVub21pbmF0b3IsIHN0YXRpY19j YXN0PGZsb2F0PihJTlRfTUlOKSwgc3RhdGljX2Nhc3Q8ZmxvYXQ+KElOVF9NQVgpKTsKKyAgICAg ICAgbV92YWx1ZSA9IGNsYW1wVG9JbnRlZ2VyKHZhbHVlICoga0ZpeGVkUG9pbnREZW5vbWluYXRv cik7CiAjZWxzZQogICAgICAgICBSRVBPUlRfT1ZFUkZMT1coaXNJbkJvdW5kcyh2YWx1ZSkpOwog ICAgICAgICBtX3ZhbHVlID0gdmFsdWUgKiBrRml4ZWRQb2ludERlbm9taW5hdG9yOwpAQCAtOTUs NyArOTUsNyBAQCBwdWJsaWM6CiAgICAgTGF5b3V0VW5pdChkb3VibGUgdmFsdWUpCiAgICAgewog I2lmIEVOQUJMRShTQVRVUkFURURfTEFZT1VUX0FSSVRITUVUSUMpCi0gICAgICAgIG1fdmFsdWUg PSBjbGFtcFRvPGRvdWJsZT4odmFsdWUgKiBrRml4ZWRQb2ludERlbm9taW5hdG9yLCBzdGF0aWNf Y2FzdDxkb3VibGU+KElOVF9NSU4pLCBzdGF0aWNfY2FzdDxkb3VibGU+KElOVF9NQVgpKTsKKyAg ICAgICAgbV92YWx1ZSA9IGNsYW1wVG9JbnRlZ2VyKHZhbHVlICoga0ZpeGVkUG9pbnREZW5vbWlu YXRvcik7CiAjZWxzZQogICAgICAgICBSRVBPUlRfT1ZFUkZMT1coaXNJbkJvdW5kcyh2YWx1ZSkp OwogICAgICAgICBtX3ZhbHVlID0gdmFsdWUgKiBrRml4ZWRQb2ludERlbm9taW5hdG9yOwpkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGQ2YWM0Y2Rk MmVkZWQ2MWQwZmRjZGMxMzk3YzFhNGEzM2FlYWM4MGEuLmM1OTE1NGIwZmRlOGNiZWMyMDVlNmNi MGRhNzI3M2E3NjUxMmUxMmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNC0xMi0zMSAgWmFsYW4gQnVqdGFzICA8 emFsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFNhdHVyYXRlZCBhcml0aG1ldGljczogSW5jb3Jy ZWN0IGZsb2F0L2RvdWJsZSBjbGFtcGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzOTg4OAorICAgICAgICByZGFyOi8vcHJvYmxlbS8xOTMzMDg4 NQorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAgICBDbGFtcCBm bG9hdCBhbmQgZG91YmxlIHZhbHVlcyBjb3JyZWN0bHkgd2hlbiBhcHBseWluZyBzYXR1cmF0ZWQg YXJpdGhtZXRpY3MuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTGF5 b3V0VW5pdC5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxNC0xMi0z MCAgS3J6eXN6dG9mIEN6ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZM XSBCdW1wIHZlcnNpb24gb2YgQVRLIHVzZWQgYnkgamhidWlsZCB0byAyLjE1LjIKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9MYXlvdXRVbml0LmNwcCBiL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9MYXlvdXRVbml0LmNwcAppbmRleCAxNjM3 MmM2MTgwZDg5YjFlYTQxZjdkNmQ3NWNkNDcwYjkyMTdiOWI4Li5mZTg4MGVmOTFiMzA2MmFjZjc5 MjAwYTRhMDliODdhN2Q4OTcyNTM1IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYkNvcmUvTGF5b3V0VW5pdC5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJDb3JlL0xheW91dFVuaXQuY3BwCkBAIC03Niw2ICs3NiwxMCBAQCBURVNUKFdlYkNvcmVM YXlvdXRVbml0LCBMYXlvdXRVbml0RmxvYXQpCiAgICAgQVNTRVJUX05FQVIoTGF5b3V0VW5pdCgz NDU2MzQuMTIzMzVmKS50b0Zsb2F0KCksIDM0NTYzNC4xMjMzNWYsIHRvbGVyYW5jZSk7CiAgICAg QVNTRVJUX05FQVIoTGF5b3V0VW5pdCgtMzQ1NjM0LjEyMzM1ZikudG9GbG9hdCgpLCAtMzQ1NjM0 LjEyMzM1ZiwgdG9sZXJhbmNlKTsKICAgICBBU1NFUlRfTkVBUihMYXlvdXRVbml0KC0zNDU2MzQp LnRvRmxvYXQoKSwgLTM0NTYzNC4wZiwgdG9sZXJhbmNlKTsgICAgCisgICAgQVNTRVJUX05FQVIo TGF5b3V0VW5pdCgzMzU1NDQzMi5mKS50b0Zsb2F0KCksIDMzNTU0NDMyLmYsIHRvbGVyYW5jZSk7 CisgICAgQVNTRVJUX05FQVIoTGF5b3V0VW5pdCgtMzM1NTQ0MzIuZikudG9GbG9hdCgpLCAtMzM1 NTQ0MzIuZiwgdG9sZXJhbmNlKTsKKyAgICBBU1NFUlRfTkVBUihMYXlvdXRVbml0KDMzNTU0NDMy LmYpLnRvRG91YmxlKCksIDMzNTU0NDMyLmYsIHRvbGVyYW5jZSk7CisgICAgQVNTRVJUX05FQVIo TGF5b3V0VW5pdCgtMzM1NTQ0MzIuZikudG9Eb3VibGUoKSwgLTMzNTU0NDMyLmYsIHRvbGVyYW5j ZSk7CiB9CiAKIFRFU1QoV2ViQ29yZUxheW91dFVuaXQsIExheW91dFVuaXRSb3VuZGluZykK