139883 2014-12-22 16:33:51 -0800 [Mac] Engineering builds of WebCore on OS X 10.8 and 10.9 shouldn't build with -gline-tables-only 2014-12-22 18:24:31 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrowe mrowe commit-queue oldest_to_newest 1057481 0 mrowe 2014-12-22 16:33:51 -0800 The logic I added in r177254 was incorrect with regards to the precedence of conditional build settings vs unconditional ones. This has resulted in engineering builds of WebCore on OS X 10.8 and 10.9 being incorrectly built with -gline-tables-only. <rdar://problem/19297261> 1057482 1 243647 mrowe 2014-12-22 16:37:37 -0800 Created attachment 243647 Patch 1057508 2 243647 ap 2014-12-22 17:31:57 -0800 Comment on attachment 243647 Patch rs=me 1057520 3 243647 commit-queue 2014-12-22 18:24:28 -0800 Comment on attachment 243647 Patch Clearing flags on attachment: 243647 Committed r177674: <http://trac.webkit.org/changeset/177674> 1057521 4 commit-queue 2014-12-22 18:24:31 -0800 All reviewed patches have been landed. Closing bug. 243647 2014-12-22 16:37:37 -0800 2014-12-22 18:24:28 -0800 Patch bug-139883-20141222163738.patch text/plain 1590 mrowe U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTgxZjAxMTE3MjYwNDYy OGZjMmZkZDNjNTdmMThlMzFhN2EzNmQwMi4uNDE2OGRiMDE2N2E2ZTAwZWFiNDcyMzdjYTZjYmU4 NTIzNWFjM2Q1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTIyICBNYXJr IFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gRW5naW5lZXJpbmcgYnVp bGRzIG9mIFdlYkNvcmUgb24gT1MgWCAxMC44IGFuZCAxMC45IHNob3VsZG4ndCBidWlsZCB3aXRo IC1nbGluZS10YWJsZXMtb25seQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM5ODgz PiAvIDxyZGFyOi8vcHJvYmxlbS8xOTI5NzI2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2Nv bmZpZzogT3ZlcnJpZGUgdGhlIHNldHRpbmcgdXNpbmcgY29uZGl0aW9uYWwgc2V0dGluZ3MKKyAg ICAgICAgc28gdGhhdCB0aGV5IHRha2UgcHJlY2VkZW5jZSBvdmVyIHRoZSBjb25kaXRpb25hbCBz ZXR0aW5ncyBpbiBCYXNlLnhjY29uZmlnLgorCiAyMDE0LTEyLTIyICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gTG9nIHVzaW5nIEZlYXR1cmVDb3VudGVy IHdoZW4gYSBQYWNoZUNhY2hlIGVudHJ5IGlzIG5vdCByZXVzZWQgYmVjYXVzZSBpdCBleHBpcmVk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9EZWJ1Z1JlbGVhc2Uu eGNjb25maWcgYi9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9EZWJ1Z1JlbGVhc2UueGNj b25maWcKaW5kZXggYjI2ZTg1NDU1MDE3YzZhNjYxNjViNzBiNjdmZjU5NDYxYTExNTI4MC4uODYz MzNkNTlmNzkwZGJjMTg4ZmMxMGQ0NTE0ZTY1NzNiNzMzMTE2MCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvRGVidWdSZWxlYXNlLnhjY29uZmlnCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2NvbmZpZwpAQCAtMzUsNyAr MzUsOSBAQCBNQUNPU1hfREVQTE9ZTUVOVF9UQVJHRVRfbWFjb3N4XzEwMTEwMCA9IDEwLjExOwog CiBHQ0NfV0FSTl9BQk9VVF9ERVBSRUNBVEVEX0ZVTkNUSU9OUyA9IFlFUzsKIERFQlVHX0lORk9S TUFUSU9OX0ZPUk1BVCA9IGR3YXJmOwotQ0xBTkdfREVCVUdfSU5GT1JNQVRJT05fTEVWRUwgPSBk ZWZhdWx0OworCitDTEFOR19ERUJVR19JTkZPUk1BVElPTl9MRVZFTFtzZGs9bWFjb3N4MTAuOCpd ID0gZGVmYXVsdDsKK0NMQU5HX0RFQlVHX0lORk9STUFUSU9OX0xFVkVMW3Nkaz1tYWNvc3gxMC45 Kl0gPSBkZWZhdWx0OwogCiBPVEhFUl9DRkxBR1MgPSAkKEFTQU5fT1RIRVJfQ0ZMQUdTKTsKIE9U SEVSX0NQTFVTUExVU0ZMQUdTID0gJChBU0FOX09USEVSX0NQTFVTUExVU0ZMQUdTKTsK