139868 2014-12-22 11:06:48 -0800 Too large plugins are crashing (tryFastMalloc is broken with bmalloc) 2022-06-27 16:18:30 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 142443 1 rgabor webkit-unassigned ahmad.saleem792 andersca ap aroben commit-queue darin ggaren rniwa webkit-bug-importer oldest_to_newest 1057405 0 rgabor 2014-12-22 11:06:48 -0800 Too large plugins are crashing. Test case: <html> <object width="9999999999" data="test.swf"></object> </html> 1057411 1 243629 rgabor 2014-12-22 11:19:52 -0800 Created attachment 243629 proposed fix 1057421 2 243629 andersca 2014-12-22 11:53:49 -0800 Comment on attachment 243629 proposed fix Patch looks good, but the test needs to use the test plug-in. 1057463 3 rgabor 2014-12-22 15:13:31 -0800 (In reply to comment #2) > Comment on attachment 243629 [details] > proposed fix > > Patch looks good, but the test needs to use the test plug-in. Do you mean x-webkit-test-netscape? I tried it but this only happens with x-shockwave-flash. I can change it to <embed width="9999999999" src="foo.swf" type="application/x-shockwave-flash"> if you prefer that. 1057469 4 andersca 2014-12-22 15:40:21 -0800 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 243629 [details] > > proposed fix > > > > Patch looks good, but the test needs to use the test plug-in. > > Do you mean x-webkit-test-netscape? I tried it but this only happens with > x-shockwave-flash. > I can change it to > <embed width="9999999999" src="foo.swf" type="application/x-shockwave-flash"> > if you prefer that. My point is that we can't have tests that rely on Flash, because then we'd require people to install Flash. Maybe we can make the test plug-in crash somehow? 1058187 5 243826 rgabor 2014-12-30 09:56:45 -0800 Created attachment 243826 proposed fix 2 This way its crashing with the test plug-in. 1058194 6 243826 commit-queue 2014-12-30 10:40:28 -0800 Comment on attachment 243826 proposed fix 2 Clearing flags on attachment: 243826 Committed r177824: <http://trac.webkit.org/changeset/177824> 1058195 7 commit-queue 2014-12-30 10:40:31 -0800 All reviewed patches have been landed. Closing bug. 1058217 8 ap 2014-12-30 16:24:41 -0800 The new test crashes on Mac with a RELEASE_ASSERT: https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r177825%20(1624)/plugins/large-plugin-crash-crash-log.txt Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010867bc32 bmalloc::Heap::allocateXLarge(std::__1::lock_guard<bmalloc::StaticMutex>&, unsigned long) + 98 1 com.apple.JavaScriptCore 0x000000010867a7e7 bmalloc::Allocator::allocateXLarge(unsigned long) + 71 2 com.apple.JavaScriptCore 0x000000010865a537 WTF::fastMalloc(unsigned long) + 151 3 com.apple.JavaScriptCore 0x000000010865a5b1 WTF::tryFastMalloc(unsigned long) + 17 EWS did see the problem, but the patch got landed before the bubble turned red. What's the next step here, should the patch be rolled out? 1058231 9 ap 2014-12-31 00:40:54 -0800 It's making bots way too red, and it's the only test for this fix, so skipping is not really appropriate. Rolling out. 1069403 10 rgabor 2015-02-16 04:04:05 -0800 Now thats a problem on Gtk as well after enabling bmalloc. PassRefPtr<ShareableBitmap> ShareableBitmap::create(const IntSize& size, Flags flags) using tryFastMalloc to allocate memory but it seems if it can't allocate enough memory it will just crash instead of returning with null. I think we should implement the tryFastMalloc correctly or if we don't want to support this then rename it and clear the return value checks to prevent confusion. 1069463 11 ap 2015-02-16 09:33:07 -0800 So, we need to fixes to address this bug: 1. the fix to PluginProxy::updateBackingStore(), 2. and a fix to bmalloc to have tryFastMalloc actually work. 1069464 12 webkit-bug-importer 2015-02-16 09:33:23 -0800 <rdar://problem/19846625> 1878614 13 ahmad.saleem792 2022-06-27 15:59:48 -0700 Attached patch was updated "PluginProxy.cpp" file, which is now removed from Webkit source (checked on Github), it was removed in following commit: https://github.com/WebKit/WebKit/commit/043ef2367e62a2cc7e9facb1bdc42b0867b8dd6d Is this applicable now? or this can be marked as "RESOLVED WONTFIX"? Thanks! 243629 2014-12-22 11:19:52 -0800 2014-12-30 09:56:45 -0800 proposed fix plugin.patch text/plain 2942 rgabor SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzYzMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTIyICBHYWJvciBS YXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBUb28gbGFyZ2UgcGx1Z2lu cyBhcmUgY3Jhc2hpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzk4NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm94eS5jcHA6CisgICAgICAgIChX ZWJLaXQ6OlBsdWdpblByb3h5Ojp1cGRhdGVCYWNraW5nU3RvcmUpOiBSZXR1cm4gZmFsc2UgaWYg YmFja2luZ1N0b3JlIGNhbm5vdCBiZSBhbGxvY2F0ZWQuCisKIDIwMTQtMTItMjEgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gYXZvaWQgV2Vi VmlkZW9GdWxsc2NyZWVuTWFuYWdlciBjcmFzaApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9QbHVnaW5zL1BsdWdpblByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuY3BwCShyZXZpc2lvbiAxNzc2MjIpCisr KyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01OTYsNiArNTk2LDggQEAgYm9vbCBQbHVnaW5Qcm94eTo6dXBkYXRlQmFj a2luZ1N0b3JlKCkKICAgICAKICAgICBpZiAoIW1fYmFja2luZ1N0b3JlKSB7CiAgICAgICAgIG1f YmFja2luZ1N0b3JlID0gU2hhcmVhYmxlQml0bWFwOjpjcmVhdGUoYmFja2luZ1N0b3JlU2l6ZSwg U2hhcmVhYmxlQml0bWFwOjpTdXBwb3J0c0FscGhhKTsKKyAgICAgICAgaWYgKCFtX2JhY2tpbmdT dG9yZSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAg ICAgfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzc2MzMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNC0xMi0yMiAgR2Fib3IgUmFw Y3NhbnlpICA8cmdhYm9yQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVG9vIGxhcmdlIHBsdWdpbnMg YXJlIGNyYXNoaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM5ODY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGxheW91dCB0ZXN0IHRvIGNvdmVyIHRoaXMgY3Jhc2guCisKKyAgICAgICAgKiBw bHVnaW5zL2xhcmdlLXBsdWdpbi1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IHBsdWdpbnMvbGFyZ2UtcGx1Z2luLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDE0LTEyLTIyICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIGpzL3Byb21pc2Vz LXRlc3RzL3Byb21pc2VzLXRlc3RzLTItMy0zLmh0bWwgc29tZXRpbWVzIGNyYXNoZXMgdW5kZXIg REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZQpJbmRleDogTGF5b3V0VGVzdHMvcGx1Z2lucy9s YXJnZS1wbHVnaW4tY3Jhc2gtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L3BsdWdpbnMvbGFyZ2UtcGx1Z2luLWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL3BsdWdpbnMvbGFyZ2UtcGx1Z2luLWNyYXNoLWV4cGVjdGVkLnR4dAkod29y a2luZyBjb3B5KQpAQCAtMCwwICsxLDUgQEAKK0J1ZyAxMzk4Njg6IExhcmdlIHBsdWdpbiBjcmFz aC4KKworVGhpcyB0ZXN0IFBBU1NFUyBpZiBpdCBkb2VzIG5vdCBDUkFTSC4KKworCkluZGV4OiBM YXlvdXRUZXN0cy9wbHVnaW5zL2xhcmdlLXBsdWdpbi1jcmFzaC5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3BsdWdpbnMvbGFyZ2UtcGx1Z2luLWNyYXNoLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9wbHVnaW5zL2xhcmdlLXBsdWdpbi1jcmFzaC5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0wLDAgKzEsMTQgQEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c2Ny aXB0PgorICAgICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICAgICAgICAg IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgICA8L3NjcmlwdD4KKyAgICA8L2hlYWQ+ CisgICAgPGJvZHk+CisgICAgICAgIDxwPkJ1ZyA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5ODY4Ij4xMzk4Njg8L2E+OiBMYXJnZSBwbHVnaW4gY3Jh c2guPC9wPgorICAgICAgICA8cD5UaGlzIHRlc3QgUEFTU0VTIGlmIGl0IGRvZXMgbm90IENSQVNI LjwvcD4KKworICAgICAgICA8b2JqZWN0IHdpZHRoPSI5OTk5OTk5OTk5IiBkYXRhPSJ0ZXN0LnN3 ZiI+PC9vYmplY3Q+CisgICAgPC9ib2R5PgorPC9odG1sPgo= 243826 2014-12-30 09:56:45 -0800 2014-12-30 10:40:28 -0800 proposed fix 2 plugin.patch text/plain 3047 rgabor SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzYzMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTIyICBHYWJvciBS YXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBUb28gbGFyZ2UgcGx1Z2lu cyBhcmUgY3Jhc2hpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzk4NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm94eS5jcHA6CisgICAgICAgIChX ZWJLaXQ6OlBsdWdpblByb3h5Ojp1cGRhdGVCYWNraW5nU3RvcmUpOiBSZXR1cm4gZmFsc2UgaWYg YmFja2luZ1N0b3JlIGNhbm5vdCBiZSBhbGxvY2F0ZWQuCisKIDIwMTQtMTItMjEgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gYXZvaWQgV2Vi VmlkZW9GdWxsc2NyZWVuTWFuYWdlciBjcmFzaApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9QbHVnaW5zL1BsdWdpblByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuY3BwCShyZXZpc2lvbiAxNzc2MjIpCisr KyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01OTYsNiArNTk2LDggQEAgYm9vbCBQbHVnaW5Qcm94eTo6dXBkYXRlQmFj a2luZ1N0b3JlKCkKICAgICAKICAgICBpZiAoIW1fYmFja2luZ1N0b3JlKSB7CiAgICAgICAgIG1f YmFja2luZ1N0b3JlID0gU2hhcmVhYmxlQml0bWFwOjpjcmVhdGUoYmFja2luZ1N0b3JlU2l6ZSwg U2hhcmVhYmxlQml0bWFwOjpTdXBwb3J0c0FscGhhKTsKKyAgICAgICAgaWYgKCFtX2JhY2tpbmdT dG9yZSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAg ICAgfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzc2MzMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNC0xMi0yMiAgR2Fib3IgUmFw Y3NhbnlpICA8cmdhYm9yQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVG9vIGxhcmdlIHBsdWdpbnMg YXJlIGNyYXNoaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM5ODU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGxheW91dCB0ZXN0IHRvIGNvdmVyIHRoaXMgY3Jhc2guCisKKyAgICAgICAgKiBw bHVnaW5zL2xhcmdlLXBsdWdpbi1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IHBsdWdpbnMvbGFyZ2UtcGx1Z2luLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDE0LTEyLTIyICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIGpzL3Byb21pc2Vz LXRlc3RzL3Byb21pc2VzLXRlc3RzLTItMy0zLmh0bWwgc29tZXRpbWVzIGNyYXNoZXMgdW5kZXIg REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZQpJbmRleDogTGF5b3V0VGVzdHMvcGx1Z2lucy9s YXJnZS1wbHVnaW4tY3Jhc2gtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L3BsdWdpbnMvbGFyZ2UtcGx1Z2luLWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL3BsdWdpbnMvbGFyZ2UtcGx1Z2luLWNyYXNoLWV4cGVjdGVkLnR4dAkod29y a2luZyBjb3B5KQpAQCAtMCwwICsxLDUgQEAKK0J1ZyAxMzk4NTY6IExhcmdlIHBsdWdpbiBjcmFz aC4KKworVGhpcyB0ZXN0IFBBU1NFUyBpZiBpdCBkb2VzIG5vdCBDUkFTSC4KKworCkluZGV4OiBM YXlvdXRUZXN0cy9wbHVnaW5zL2xhcmdlLXBsdWdpbi1jcmFzaC5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3BsdWdpbnMvbGFyZ2UtcGx1Z2luLWNyYXNoLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9wbHVnaW5zL2xhcmdlLXBsdWdpbi1jcmFzaC5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0wLDAgKzEsMTUgQEAKKzxodG1sPgorICAgIDxib2R5PgorICAgICAgICA8cD5C dWcgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTg1 NiI+MTM5ODU2PC9hPjogTGFyZ2UgcGx1Z2luIGNyYXNoLjwvcD4KKyAgICAgICAgPHA+VGhpcyB0 ZXN0IFBBU1NFUyBpZiBpdCBkb2VzIG5vdCBDUkFTSC48L3A+CisKKyAgICAgICAgPGVtYmVkIGlk PSJwbHVnaW4iIHdpZHRoPSI5OTk5OTk5OTk5OTk5OTk5OSIgdHlwZT0iYXBwbGljYXRpb24veC13 ZWJraXQtdGVzdC1uZXRzY2FwZSI+PC9lbWJlZD4KKworICAgICAgICA8c2NyaXB0PgorICAgICAg ICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIu ZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3BsdWdp bicpLnN0eWxlLndlYmtpdFRyYW5zZm9ybSA9ICdzY2FsZSgxKSc7CisgICAgICAgIDwvc2NyaXB0 PgorCisgICAgPC9ib2R5PgorPC9odG1sPgo=