139852 2014-12-20 10:41:01 -0800 [iOS] avoid WebVideoFullscreenManager crash 2014-12-21 09:01:19 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1057274 0 eric.carlson 2014-12-20 10:41:01 -0800 Avoid a couple of potential NULL dereferences. 1057275 1 webkit-bug-importer 2014-12-20 10:41:36 -0800 <rdar://problem/19319302> 1057276 2 243606 eric.carlson 2014-12-20 10:47:15 -0800 Created attachment 243606 Proposed patch. 1057301 3 243606 darin 2014-12-20 19:51:57 -0800 Comment on attachment 243606 Proposed patch. Regression test? 1057314 4 243606 commit-queue 2014-12-21 09:01:13 -0800 Comment on attachment 243606 Proposed patch. Clearing flags on attachment: 243606 Committed r177625: <http://trac.webkit.org/changeset/177625> 1057315 5 commit-queue 2014-12-21 09:01:19 -0800 All reviewed patches have been landed. Closing bug. 243606 2014-12-20 10:47:15 -0800 2014-12-21 09:01:13 -0800 Proposed patch. wk2_crash_patch_2.txt text/plain 2257 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzYyMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEyLTIwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGF2b2lkIFdl YlZpZGVvRnVsbHNjcmVlbk1hbmFnZXIgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTg1MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTkz MTkzMDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyLm1tOgorICAgICAgICAo V2ViS2l0OjpXZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyOjpkaWRFeGl0RnVsbHNjcmVlbik6IE5V TEwtY2hlY2sgbV9sYXllckhvc3RpbmdDb250ZXh0IGFuZCBtX3BhZ2UuCisgICAgICAgIChXZWJL aXQ6OldlYlZpZGVvRnVsbHNjcmVlbk1hbmFnZXI6OnNldFZpZGVvTGF5ZXJGcmFtZUZlbmNlZCk6 IE5VTEwtY2hlY2sgbV9sYXllckhvc3RpbmdDb250ZXh0LgorCiAyMDE0LTEyLTIwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIGFkZCBvcHRp bWl6ZWQgZnVsbHNjcmVlbiBBUEkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvaW9z L1dlYlZpZGVvRnVsbHNjcmVlbk1hbmFnZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlci5tbQkocmV2aXNpb24g MTc3NjIxKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9pb3MvV2ViVmlkZW9GdWxsc2Ny ZWVuTWFuYWdlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMjIwLDkgKzIyMCwxMiBAQCB2b2lkIFdl YlZpZGVvRnVsbHNjcmVlbk1hbmFnZXI6OmRpZEV4aXRGCiAgICAgX19ibG9jayBSZWZQdHI8V2Vi VmlkZW9GdWxsc2NyZWVuTW9kZWxWaWRlb0VsZW1lbnQ+IHByb3RlY3QodGhpcyk7CiAKICAgICBk aXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBeewotICAgICAgICBtX2xh eWVySG9zdGluZ0NvbnRleHQtPnNldFJvb3RMYXllcihudWxscHRyKTsKLSAgICAgICAgbV9sYXll ckhvc3RpbmdDb250ZXh0ID0gbnVsbHB0cjsKLSAgICAgICAgbV9wYWdlLT5zZW5kKE1lc3NhZ2Vz OjpXZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHk6OkNsZWFudXBGdWxsc2NyZWVuKCksIG1f cGFnZS0+cGFnZUlEKCkpOworICAgICAgICBpZiAobV9sYXllckhvc3RpbmdDb250ZXh0KSB7Cisg ICAgICAgICAgICBtX2xheWVySG9zdGluZ0NvbnRleHQtPnNldFJvb3RMYXllcihudWxscHRyKTsK KyAgICAgICAgICAgIG1fbGF5ZXJIb3N0aW5nQ29udGV4dCA9IG51bGxwdHI7CisgICAgICAgIH0K KyAgICAgICAgaWYgKG1fcGFnZSkKKyAgICAgICAgICAgIG1fcGFnZS0+c2VuZChNZXNzYWdlczo6 V2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5OjpDbGVhbnVwRnVsbHNjcmVlbigpLCBtX3Bh Z2UtPnBhZ2VJRCgpKTsKICAgICAgICAgcHJvdGVjdC5jbGVhcigpOwogICAgIH0pOwogfQpAQCAt MjUyLDcgKzI1NSw4IEBAIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlcjo6c2V0VmlkZW8K ICAgICAKIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlcjo6c2V0VmlkZW9MYXllckZyYW1l RmVuY2VkKFdlYkNvcmU6OkZsb2F0UmVjdCBib3VuZHMsIElQQzo6QXR0YWNobWVudCBmZW5jZVBv cnQpCiB7Ci0gICAgbV9sYXllckhvc3RpbmdDb250ZXh0LT5zZXRGZW5jZVBvcnQoZmVuY2VQb3J0 LnBvcnQoKSk7CisgICAgaWYgKG1fbGF5ZXJIb3N0aW5nQ29udGV4dCkKKyAgICAgICAgbV9sYXll ckhvc3RpbmdDb250ZXh0LT5zZXRGZW5jZVBvcnQoZmVuY2VQb3J0LnBvcnQoKSk7CiAgICAgc2V0 VmlkZW9MYXllckZyYW1lKGJvdW5kcyk7CiAgICAgbWFjaF9wb3J0X2RlYWxsb2NhdGUobWFjaF90 YXNrX3NlbGYoKSwgZmVuY2VQb3J0LnBvcnQoKSk7CiB9Cg==