139842 2014-12-19 15:50:06 -0800 Preview popovers don't show an arrow for large links 2014-12-19 16:13:41 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned oldest_to_newest 1057207 0 bdakin 2014-12-19 15:50:06 -0800 Popovers are too large on apple.com image. rdar://problem/19301470 1057213 1 243585 bdakin 2014-12-19 16:08:13 -0800 Created attachment 243585 Patch 1057215 2 bdakin 2014-12-19 16:13:41 -0800 http://trac.webkit.org/changeset/177601 Thank you! 243585 2014-12-19 16:08:13 -0800 2014-12-19 16:12:47 -0800 Patch for-review.txt text/plain 7403 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzYwMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTEyLTE5ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBQcmV2aWV3IHBvcG92ZXJzIGRvbid0 IHNob3cgYW4gYXJyb3cgZm9yIGxhcmdlIGxpbmtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk4NDIKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5n LQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTkzMDE0NzA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRyZXNzZXMgdGhlIGNh c2Ugd2hlcmUgdGhlIGxpbmsgaXMgc28gbGFyZ2UgdGhhdCB0aGVyZSBpcyBubyAKKyAgICAgICAg YXZhaWxhYmxlIHNwYWNlIG9uIGFueSBzaWRlIG9uY2UgeW91IGZhY3RvciBpbiBzY3JlZW4gcGFk ZGluZy4gSW4gdGhhdCBjYXNlLCB3ZSAKKyAgICAgICAgc2hvdWxkIGdpdmUgdXAgZWFybHkgb24g bm90IG9ic2N1cmluZyB0aGUgbGluay4KKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLUHJldmll d1BvcG92ZXJBbmltYXRpb25Db250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS1ByZXZpZXdQb3Bv dmVyQW5pbWF0aW9uQ29udHJvbGxlciBfdGFyZ2V0U2l6ZUZvclBhZ2VQcmV2aWV3XSk6CisgICAg ICAgICgtW1dLUHJldmlld1BvcG92ZXJBbmltYXRpb25Db250cm9sbGVyIF9lZmZlY3RpdmVQYWRk aW5nV2l0aFByZXZpZXdQYWRkaW5nOl0pOgorICAgICAgICAoLVtXS1ByZXZpZXdQb3BvdmVyQW5p bWF0aW9uQ29udHJvbGxlciBfbWF4U3BhY2VBdmFpbGFibGVPbllFZGdlRm9yT3JpZ2luUmVjdDp3 aXRoU2NyZWVuUmVjdDpwcmV2aWV3UGFkZGluZzpdKToKKyAgICAgICAgKC1bV0tQcmV2aWV3UG9w b3ZlckFuaW1hdGlvbkNvbnRyb2xsZXIgX21heFNwYWNlQXZhaWxhYmxlT25YRWRnZUZvck9yaWdp blJlY3Q6d2l0aFNjcmVlblJlY3Q6cHJldmlld1BhZGRpbmc6XSk6CisgICAgICAgICgtW1dLUHJl dmlld1BvcG92ZXJBbmltYXRpb25Db250cm9sbGVyIF9wcmVmZXJyZWRQb3BvdmVyU2l6ZVdpdGhQ cmV2aWV3UGFkZGluZzpmb3JUYXJnZXRTaXplOl0pOgorCiAyMDE0LTEyLTE5ICBUaW1vdGh5IEhv cnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBXS1ZpZXcncyBpZ25v cmVzTm9uV2hlZWxFdmVudHMgc2hvdWxkIGlnbm9yZSBpbW1lZGlhdGUgYWN0aW9ucwpJbmRleDog U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS1ByZXZpZXdQb3BvdmVyQW5pbWF0aW9uQ29u dHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dL UHJldmlld1BvcG92ZXJBbmltYXRpb25Db250cm9sbGVyLm1tCShyZXZpc2lvbiAxNzc1OTEpCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLUHJldmlld1BvcG92ZXJBbmltYXRpb25D b250cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0Miw4IEBAIHVzaW5nIG5hbWVz cGFjZSBXZWJLaXQ7CiBAaW50ZXJmYWNlIFdLUHJldmlld1BvcG92ZXJBbmltYXRpb25Db250cm9s bGVyICgpIDxXS1BhZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXJEZWxlZ2F0ZSwgTlNQb3BvdmVyRGVs ZWdhdGU+CiBAZW5kCiAKK3N0YXRpYyBjb25zdCBDR0Zsb2F0IHByZWZlcnJlZFBvcG92ZXJUb1Zp ZXdTY2FsZSA9IDAuNzU7CisKIEBpbXBsZW1lbnRhdGlvbiBXS1ByZXZpZXdQb3BvdmVyQW5pbWF0 aW9uQ29udHJvbGxlcgogCiArIChib29sKV9zaG91bGRJbW1lZGlhdGVseVNob3dQcmV2aWV3CkBA IC0xOTMsMTcgKzE5NSwzOCBAQCAtIChOU1NpemUpbGFyZ2VzdFBvcG92ZXJTaXplCiAKIC0gKE5T U2l6ZSlfdGFyZ2V0U2l6ZUZvclBhZ2VQcmV2aWV3CiB7Ci0gICAgc3RhdGljIGNvbnN0IENHRmxv YXQgcHJlZmVycmVkUG9wb3ZlclRvVmlld1NjYWxlID0gMC43NTsKICAgICBOU1JlY3Qgd2tWaWV3 Qm91bmRzID0gX3drVmlldy5ib3VuZHM7CiAgICAgcmV0dXJuIE5TTWFrZVNpemUoTlNXaWR0aCh3 a1ZpZXdCb3VuZHMpICogcHJlZmVycmVkUG9wb3ZlclRvVmlld1NjYWxlLCBOU0hlaWdodCh3a1Zp ZXdCb3VuZHMpICogcHJlZmVycmVkUG9wb3ZlclRvVmlld1NjYWxlKTsKIH0KIAotLSAoTlNTaXpl KV9wcmVmZXJyZWRQb3BvdmVyU2l6ZVdpdGhQcmV2aWV3UGFkZGluZzooTlNTaXplKXByZXZpZXdQ YWRkaW5nIGZvclRhcmdldFNpemU6KE5TU2l6ZSl0YXJnZXRTaXplCistIChOU1NpemUpX2VmZmVj dGl2ZVBhZGRpbmdXaXRoUHJldmlld1BhZGRpbmc6KE5TU2l6ZSlwcmV2aWV3UGFkZGluZwogewog ICAgIHN0YXRpYyBjb25zdCBOU1NpemUgc2NyZWVuUGFkZGluZyA9IE5TTWFrZVNpemUoNDAsIDQw KTsKLSAgICBzdGF0aWMgY29uc3QgTlNTaXplIHNtYWxsZXN0UG9wb3ZlclNpemUgPSBOU01ha2VT aXplKDUwMCwgNTAwKTsKKyAgICBOU1NpemUgZWZmZWN0aXZlUGFkZGluZyA9IE5TTWFrZVNpemUo c2NyZWVuUGFkZGluZy53aWR0aCArIHByZXZpZXdQYWRkaW5nLndpZHRoLCBzY3JlZW5QYWRkaW5n LmhlaWdodCArIHByZXZpZXdQYWRkaW5nLmhlaWdodCk7CisgICAgcmV0dXJuIGVmZmVjdGl2ZVBh ZGRpbmc7Cit9CiAKLSAgICBjb25zdCBOU1NpemUgZWZmZWN0aXZlUGFkZGluZyA9IE5TTWFrZVNp emUoc2NyZWVuUGFkZGluZy53aWR0aCArIHByZXZpZXdQYWRkaW5nLndpZHRoLCBzY3JlZW5QYWRk aW5nLmhlaWdodCArIHByZXZpZXdQYWRkaW5nLmhlaWdodCk7CistIChOU1NpemUpX21heFNwYWNl QXZhaWxhYmxlT25ZRWRnZUZvck9yaWdpblJlY3Q6KE5TUmVjdClvcmlnaW5SZWN0IHdpdGhTY3Jl ZW5SZWN0OihOU1JlY3Qpc2NyZWVuUmVjdCBwcmV2aWV3UGFkZGluZzooTlNTaXplKXByZXZpZXdQ YWRkaW5nCit7CisgICAgQ0dGbG9hdCBhdmFpbGFibGVTcGFjZUFib3ZlID0gTlNNYXhZKHNjcmVl blJlY3QpIC0gTlNNYXhZKG9yaWdpblJlY3QpOworICAgIENHRmxvYXQgYXZhaWxhYmxlU3BhY2VC ZWxvdyA9IE5TTWluWShvcmlnaW5SZWN0KSAtIE5TTWluWShzY3JlZW5SZWN0KTsKKyAgICBOU1Np emUgZWZmZWN0aXZlUGFkZGluZyA9IFtzZWxmIF9lZmZlY3RpdmVQYWRkaW5nV2l0aFByZXZpZXdQ YWRkaW5nOnByZXZpZXdQYWRkaW5nXTsKKyAgICBDR0Zsb2F0IG1heEF2YWlsYWJsZVZlcnRpY2Fs U3BhY2UgPSBmbWF4KGF2YWlsYWJsZVNwYWNlQWJvdmUsIGF2YWlsYWJsZVNwYWNlQmVsb3cpIC0g ZWZmZWN0aXZlUGFkZGluZy5oZWlnaHQ7CisgICAgcmV0dXJuIE5TTWFrZVNpemUoc2NyZWVuUmVj dC5zaXplLndpZHRoIC0gZWZmZWN0aXZlUGFkZGluZy5oZWlnaHQsIG1heEF2YWlsYWJsZVZlcnRp Y2FsU3BhY2UpOworfQorCistIChOU1NpemUpX21heFNwYWNlQXZhaWxhYmxlT25YRWRnZUZvck9y aWdpblJlY3Q6KE5TUmVjdClvcmlnaW5SZWN0IHdpdGhTY3JlZW5SZWN0OihOU1JlY3Qpc2NyZWVu UmVjdCBwcmV2aWV3UGFkZGluZzooTlNTaXplKXByZXZpZXdQYWRkaW5nCit7CisgICAgQ0dGbG9h dCBhdmFpbGFibGVTcGFjZUF0TGVmdCA9IE5TTWluWChvcmlnaW5SZWN0KSAtIE5TTWluWChzY3Jl ZW5SZWN0KTsKKyAgICBDR0Zsb2F0IGF2YWlsYWJsZVNwYWNlQXRSaWdodCA9IE5TTWF4WChzY3Jl ZW5SZWN0KSAtIE5TTWF4WChvcmlnaW5SZWN0KTsKKyAgICBOU1NpemUgZWZmZWN0aXZlUGFkZGlu ZyA9IFtzZWxmIF9lZmZlY3RpdmVQYWRkaW5nV2l0aFByZXZpZXdQYWRkaW5nOnByZXZpZXdQYWRk aW5nXTsKKyAgICBDR0Zsb2F0IG1heEF2YWlsYWJsZUhvcml6b250YWxTcGFjZSA9IGZtYXgoYXZh aWxhYmxlU3BhY2VBdExlZnQsIGF2YWlsYWJsZVNwYWNlQXRSaWdodCkgLSBlZmZlY3RpdmVQYWRk aW5nLndpZHRoOworICAgIHJldHVybiBOU01ha2VTaXplKG1heEF2YWlsYWJsZUhvcml6b250YWxT cGFjZSwgc2NyZWVuUmVjdC5zaXplLmhlaWdodCAtIGVmZmVjdGl2ZVBhZGRpbmcud2lkdGgpOwor fQorCistIChOU1NpemUpX3ByZWZlcnJlZFBvcG92ZXJTaXplV2l0aFByZXZpZXdQYWRkaW5nOihO U1NpemUpcHJldmlld1BhZGRpbmcgZm9yVGFyZ2V0U2l6ZTooTlNTaXplKXRhcmdldFNpemUKK3sK KyAgICBzdGF0aWMgY29uc3QgTlNTaXplIHNtYWxsZXN0UG9wb3ZlclNpemUgPSBOU01ha2VTaXpl KDUwMCwgNTAwKTsKIAogICAgIE5TV2luZG93ICp3aW5kb3cgPSBfd2tWaWV3LndpbmRvdzsKICAg ICBOU1JlY3Qgb3JpZ2luU2NyZWVuUmVjdCA9IFt3aW5kb3cgY29udmVydFJlY3RUb1NjcmVlbjpb X3drVmlldyBjb252ZXJ0UmVjdDpfcG9wb3Zlck9yaWdpblJlY3QgdG9WaWV3Om5pbF1dOwpAQCAt MjExLDIwICsyMzQsMjQgQEAgLSAoTlNTaXplKV9wcmVmZXJyZWRQb3BvdmVyU2l6ZVdpdGhQcmV2 aQogCiAgICAgTlNTaXplIGxhcmdlc3RQb3BvdmVyU2l6ZSA9IFtzZWxmIGxhcmdlc3RQb3BvdmVy U2l6ZV07CiAKLSAgICBDR0Zsb2F0IGF2YWlsYWJsZVNwYWNlQWJvdmUgPSBOU01heFkoc2NyZWVu RnJhbWUpIC0gTlNNYXhZKG9yaWdpblNjcmVlblJlY3QpOwotICAgIENHRmxvYXQgYXZhaWxhYmxl U3BhY2VCZWxvdyA9IE5TTWluWShvcmlnaW5TY3JlZW5SZWN0KSAtIE5TTWluWShzY3JlZW5GcmFt ZSk7Ci0gICAgQ0dGbG9hdCBtYXhBdmFpbGFibGVWZXJ0aWNhbFNwYWNlID0gZm1heChhdmFpbGFi bGVTcGFjZUFib3ZlLCBhdmFpbGFibGVTcGFjZUJlbG93KSAtIGVmZmVjdGl2ZVBhZGRpbmcuaGVp Z2h0OwotICAgIE5TU2l6ZSBtYXhTcGFjZUF2YWlsYWJsZU9uWUVkZ2UgPSBOU01ha2VTaXplKHNj cmVlbkZyYW1lLnNpemUud2lkdGggLSBlZmZlY3RpdmVQYWRkaW5nLmhlaWdodCwgbWF4QXZhaWxh YmxlVmVydGljYWxTcGFjZSk7CisgICAgTlNTaXplIG1heFNwYWNlQXZhaWxhYmxlT25ZRWRnZSA9 IFtzZWxmIF9tYXhTcGFjZUF2YWlsYWJsZU9uWUVkZ2VGb3JPcmlnaW5SZWN0Om9yaWdpblNjcmVl blJlY3Qgd2l0aFNjcmVlblJlY3Q6c2NyZWVuRnJhbWUgcHJldmlld1BhZGRpbmc6cHJldmlld1Bh ZGRpbmddOwogICAgIGlmICh0YXJnZXRTaXplRml0c0luQXZhaWxhYmxlU3BhY2UodGFyZ2V0U2l6 ZSwgbWF4U3BhY2VBdmFpbGFibGVPbllFZGdlKSAmJiB0YXJnZXRTaXplRml0c0luQXZhaWxhYmxl U3BhY2UodGFyZ2V0U2l6ZSwgbGFyZ2VzdFBvcG92ZXJTaXplKSkKICAgICAgICAgcmV0dXJuIHRh cmdldFNpemU7CiAKLSAgICBDR0Zsb2F0IGF2YWlsYWJsZVNwYWNlQXRMZWZ0ID0gTlNNaW5YKG9y aWdpblNjcmVlblJlY3QpIC0gTlNNaW5YKHNjcmVlbkZyYW1lKTsKLSAgICBDR0Zsb2F0IGF2YWls YWJsZVNwYWNlQXRSaWdodCA9IE5TTWF4WChzY3JlZW5GcmFtZSkgLSBOU01heFgob3JpZ2luU2Ny ZWVuUmVjdCk7Ci0gICAgQ0dGbG9hdCBtYXhBdmFpbGFibGVIb3Jpem9udGFsU3BhY2UgPSBmbWF4 KGF2YWlsYWJsZVNwYWNlQXRMZWZ0LCBhdmFpbGFibGVTcGFjZUF0UmlnaHQpIC0gZWZmZWN0aXZl UGFkZGluZy53aWR0aDsKLSAgICBOU1NpemUgbWF4U3BhY2VBdmFpbGFibGVPblhFZGdlID0gTlNN YWtlU2l6ZShtYXhBdmFpbGFibGVIb3Jpem9udGFsU3BhY2UsIHNjcmVlbkZyYW1lLnNpemUuaGVp Z2h0IC0gZWZmZWN0aXZlUGFkZGluZy53aWR0aCk7CisgICAgTlNTaXplIG1heFNwYWNlQXZhaWxh YmxlT25YRWRnZSA9IFtzZWxmIF9tYXhTcGFjZUF2YWlsYWJsZU9uWEVkZ2VGb3JPcmlnaW5SZWN0 Om9yaWdpblNjcmVlblJlY3Qgd2l0aFNjcmVlblJlY3Q6c2NyZWVuRnJhbWUgcHJldmlld1BhZGRp bmc6cHJldmlld1BhZGRpbmddOwogICAgIGlmICh0YXJnZXRTaXplRml0c0luQXZhaWxhYmxlU3Bh Y2UodGFyZ2V0U2l6ZSwgbWF4U3BhY2VBdmFpbGFibGVPblhFZGdlKSAmJiB0YXJnZXRTaXplRml0 c0luQXZhaWxhYmxlU3BhY2UodGFyZ2V0U2l6ZSwgbGFyZ2VzdFBvcG92ZXJTaXplKSkKICAgICAg ICAgcmV0dXJuIHRhcmdldFNpemU7CiAKKyAgICAvLyBJZiB0aGUgb3JpZ2luU2NyZWVuUmVjdCBp cyB2ZXJ5IGxhcmdlLCB0aGVuIGl0J3MgcG9zc2libGUgdGhhdCB3ZSBoYXZlIG5lZ2F0aXZlIGF2 YWlsYWJsZSBzcGFjZSBvbmNlIHRoZSBzY3JlZW4gcGFkZGluZworICAgIC8vIHdhcyB0YWtlbiBp bnRvIGFjY291bnQuIElmIHRoYXQgaXMgdGhlIGNhc2UsIGdpdmUgdXAgbm90IG9uIG5vdCB0cnlp bmcgdG8gb2JzY3VyZSB0aGUgb3JpZ2luIFVSTC4KKyAgICBpZiAoKG1heFNwYWNlQXZhaWxhYmxl T25ZRWRnZS53aWR0aCA8IDAgfHwgbWF4U3BhY2VBdmFpbGFibGVPbllFZGdlLmhlaWdodCA8IDAp ICYmIChtYXhTcGFjZUF2YWlsYWJsZU9uWEVkZ2Uud2lkdGggPCAwIHx8IG1heFNwYWNlQXZhaWxh YmxlT25YRWRnZS5oZWlnaHQgPCAwKSkgeworICAgICAgICBfcG9wb3Zlck9yaWdpblJlY3Qub3Jp Z2luID0gX2V2ZW50TG9jYXRpb25JblZpZXc7CisgICAgICAgIF9wb3BvdmVyT3JpZ2luUmVjdC5z aXplID0gTlNNYWtlU2l6ZSgxLCAxKTsKKyAgICAgICAgb3JpZ2luU2NyZWVuUmVjdCA9IFt3aW5k b3cgY29udmVydFJlY3RUb1NjcmVlbjpbX3drVmlldyBjb252ZXJ0UmVjdDpfcG9wb3Zlck9yaWdp blJlY3QgdG9WaWV3Om5pbF1dOworICAgICAgICBtYXhTcGFjZUF2YWlsYWJsZU9uWUVkZ2UgPSBb c2VsZiBfbWF4U3BhY2VBdmFpbGFibGVPbllFZGdlRm9yT3JpZ2luUmVjdDpvcmlnaW5TY3JlZW5S ZWN0IHdpdGhTY3JlZW5SZWN0OnNjcmVlbkZyYW1lIHByZXZpZXdQYWRkaW5nOnByZXZpZXdQYWRk aW5nXTsKKyAgICAgICAgbWF4U3BhY2VBdmFpbGFibGVPblhFZGdlID0gW3NlbGYgX21heFNwYWNl QXZhaWxhYmxlT25YRWRnZUZvck9yaWdpblJlY3Q6b3JpZ2luU2NyZWVuUmVjdCB3aXRoU2NyZWVu UmVjdDpzY3JlZW5GcmFtZSBwcmV2aWV3UGFkZGluZzpwcmV2aWV3UGFkZGluZ107CisgICAgfQor CiAgICAgLy8gQWRqdXN0IHRoZSBtYXhpbXVtIHNwYWNlIGF2YWlsYWJsZSBpZiBpdCBpcyBsYXJn ZXIgdGhhbiB0aGUgbGFyZ2VzdCBwb3BvdmVyIHNpemUuCiAgICAgaWYgKG1heFNwYWNlQXZhaWxh YmxlT25ZRWRnZS53aWR0aCA+IGxhcmdlc3RQb3BvdmVyU2l6ZS53aWR0aCAmJiBtYXhTcGFjZUF2 YWlsYWJsZU9uWUVkZ2UuaGVpZ2h0ID4gbGFyZ2VzdFBvcG92ZXJTaXplLmhlaWdodCkKICAgICAg ICAgbWF4U3BhY2VBdmFpbGFibGVPbllFZGdlID0gbGFyZ2VzdFBvcG92ZXJTaXplOwo=