139838 2014-12-19 15:34:33 -0800 Web Inspector: Inspector does not reopen correctly after Inspector Process crashes 2014-12-19 16:58:04 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck andersca ap commit-queue graouts joepeck jonowells mattbaker mkwst nvasilyev timothy webkit-bug-importer oldest_to_newest 1057196 0 joepeck 2014-12-19 15:34:33 -0800 * SUMMARY Inspector does not reopen correctly after Inspector Process crashes. There are two issues: (1) Debug Build hits an ASSERT: (2) Ignoring the ASSERT, the Inspector window opens blank (when forced to show). Closing and reopening the inspector, it then works. * STEPS TO REPRODUCE 1. Open inspector 2. shell> kill -9 <pid-of-inspector-process> 3. Reopen inspector => ASSERT || broken inspector * NOTES ASSERTION FAILED: !WebInspectorProxy::isInspectorPage(*this) Source/WebKit2/UIProcess/WebPageProxy.cpp(717) : bool WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle(const WebCore::URL &, SandboxExtension::Handle &) 1 0x10457ed00 WTFCrashWithSecurityImplication 2 0x106b46584 WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle(WebCore::URL const&, WebKit::SandboxExtension::Handle&) 3 0x106b466c2 WebKit::WebPageProxy::loadRequest(WebCore::ResourceRequest const&, API::Object*) 4 0x106a7e530 WebKit::WebInspectorProxy::createInspectorPage(IPC::Attachment, bool, bool) 5 0x106a9319a void IPC::callMemberFunctionImpl ... 1057197 1 webkit-bug-importer 2014-12-19 15:34:44 -0800 <rdar://problem/19314136> 1057202 2 243583 joepeck 2014-12-19 15:42:14 -0800 Created attachment 243583 [PATCH] Proposed Fix 1057203 3 joepeck 2014-12-19 15:42:43 -0800 Better Radar: <rdar://problem/19124870> 1057233 4 243583 commit-queue 2014-12-19 16:58:00 -0800 Comment on attachment 243583 [PATCH] Proposed Fix Clearing flags on attachment: 243583 Committed r177610: <http://trac.webkit.org/changeset/177610> 1057234 5 commit-queue 2014-12-19 16:58:04 -0800 All reviewed patches have been landed. Closing bug. 243583 2014-12-19 15:42:14 -0800 2014-12-19 16:58:00 -0800 [PATCH] Proposed Fix fix-relaunch.patch text/plain 6947 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NjgwNGY3Li41NWRkMzc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDAg QEAKKzIwMTQtMTItMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0b3IgZG9lcyBub3QgcmVvcGVuIGNvcnJlY3Rs eSBhZnRlciBJbnNwZWN0b3IgUHJvY2VzcyBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk4MzgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRoZSBXZWJDb250ZW50UHJvY2VzcyBob2xk aW5nIHRoZSBJbnNwZWN0b3IgRnJvbnRlbmQgY3Jhc2hlcywgd2UKKyAgICAgICAgd291bGQgcHJv cGVybHkgdGVhciBkb3duIHRoZSBpbnNwZWN0b3Igb2JqZWN0cy4gSG93ZXZlciwgdGhlIG5leHQg dGltZQorICAgICAgICB0aGUgaW5zcGVjdG9yIGlzIG9wZW5lZCwgd2hlbiBjcmVhdGluZyB0aGUg bmV3IHBhZ2UgaW4gdGhlIEluc3BlY3RvcgorICAgICAgICBQYWdlIEdyb3VwLCBhIFdlYlBhZ2VQ cm94eSBpcyBjcmVhdGVkIHdpdGggYSBUZXJtaW5hdGVkIFdlYlByb2Nlc3NQcm94eS4KKworICAg ICAgICBUaGF0IFRlcm1pbmF0ZWQgV2ViUHJvY2Vzc1Byb3h5IGlzIGF1dG9tYXRpY2FsbHkgcmVw bGFjZWQgd2l0aCB0aGUgbmV4dAorICAgICAgICBsb2FkIHJlcXVlc3QgaXMgZ2l2ZW4uIFRoZSBu ZXdseSBjcmVhdGVkIHByb2Nlc3Mgd2FzIG1pc3NpbmcgdGhlCisgICAgICAgIG1lc3NhZ2UgbGlz dGVuZXJzIGFuZCBhc3N1bWVkIFVSTCBhY2Nlc3Mgc2V0dGluZ3MgdGhhdCB0aGUKKyAgICAgICAg V2ViSW5zcGVjdG9yUHJveHkgaGFkIHNldCBvbiB0aGUgb2xkIHByb2Nlc3MuCisKKyAgICAgICAg U28sIFdlYkluc3BlY3RvclByb3h5IG5vdyBsaXN0ZW5zIGZvciBhbmQgcmVzZXRzIHRoZSBwcm9j ZXNzIHByb3BlcnRpZXMKKyAgICAgICAgd2hlbiB0aGUgaW5zcGVjdG9yIHByb2Nlc3MgaXMgcmVj cmVhdGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5Lmg6CisgICAg ICAgICogVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViSW5zcGVjdG9yUHJveHk6OmRpZFJlbGF1bmNoSW5zcGVjdG9yUGFnZVByb2Nlc3MpOgorICAg ICAgICBSZXNldCBwcm9jZXNzIHByb3BlcnRpZXMgd2hlbiB0aGUgcHJvY2VzcyBpcyByZWxhdW5j aGVkLgorCisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpjcmVhdGVJbnNwZWN0 b3JQYWdlKToKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OmRpZENsb3NlKToK KyAgICAgICAgU2F2ZSBjb25uZWN0aW9uIGlkZW50aWZpZXIgaWYgd2UgbmVlZCB0byBlc3RhYmxp c2ggY29ubmVjdGlvbnMgbGF0ZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dlYkluc3Bl Y3RvclByb3h5TWFjLm1tOgorICAgICAgICAoLVtXS1dlYkluc3BlY3RvclByb3h5T2JqQ0FkYXB0 ZXIgZGlkUmVsYXVuY2hQcm9jZXNzXSk6CisgICAgICAgICgtW1dLV2ViSW5zcGVjdG9yV0tWaWV3 IF9kaWRSZWxhdW5jaFByb2Nlc3NdKToKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJv eHk6OmNsb3NlVGltZXJGaXJlZCk6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5 OjpwbGF0Zm9ybUNyZWF0ZUluc3BlY3RvclBhZ2UpOgorICAgICAgICBTZW5kIFdlYkluc3BlY3Rv clByb3h5IGEgbWVzc2FnZSB3aGVuIHRoZSBwcm9jZXNzIHVuZGVybHlpbmcgdGhlCisgICAgICAg IFdLVmlldyBpcyByZWxhdW5jaGVkLgorCiAyMDE0LTEyLTE5ICBBbmRyZWFzIEtsaW5nICA8YWts aW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWYtaWZ5IFRleHRJdGVyYXRvciBBUEkuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAppbmRleCAyYjIw ZTZmLi43ZDljNmY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5z cGVjdG9yUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0 b3JQcm94eS5jcHAKQEAgLTIzNiw2ICsyMzYsMTcgQEAgdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6 Y2xvc2UoKQogICAgIGRpZENsb3NlKCk7CiB9CiAKK3ZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OmRp ZFJlbGF1bmNoSW5zcGVjdG9yUGFnZVByb2Nlc3MoKQoreworICAgIG1faW5zcGVjdG9yUGFnZS0+ cHJvY2VzcygpLmFkZE1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6V2ViSW5zcGVjdG9yUHJveHk6 Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSwgbV9wYWdlLT5wYWdlSUQoKSwgKnRoaXMpOworICAgIG1f aW5zcGVjdG9yUGFnZS0+cHJvY2VzcygpLmFzc3VtZVJlYWRBY2Nlc3NUb0Jhc2VVUkwoaW5zcGVj dG9yQmFzZVVSTCgpKTsKKworICAgIC8vIFdoZW4gZGlkUmVsYXVuY2hJbnNwZWN0b3JQYWdlUHJv Y2VzcyBpcyBjYWxsZWQgd2UgY2FuIGFzc3VtZSBpdCBpcyBkdXJpbmcgYSBsb2FkIHJlcXVlc3Qu CisgICAgLy8gQW55IG1lc3NhZ2VzIHdlIHdvdWxkIGhhdmUgc2VudCB0byBhIHRlcm1pbmF0ZWQg cHJvY2VzcyBuZWVkIHRvIGJlIHJlLXNlbnQuCisKKyAgICBtX2luc3BlY3RvclBhZ2UtPnByb2Nl c3MoKS5zZW5kKE1lc3NhZ2VzOjpXZWJJbnNwZWN0b3JVSTo6RXN0YWJsaXNoQ29ubmVjdGlvbiht X2Nvbm5lY3Rpb25JZGVudGlmaWVyLCBtX3BhZ2UtPnBhZ2VJRCgpLCBtX3VuZGVyVGVzdCksIG1f aW5zcGVjdG9yUGFnZS0+cGFnZUlEKCkpOworfQorCiB2b2lkIFdlYkluc3BlY3RvclByb3h5Ojpz aG93Q29uc29sZSgpCiB7CiAgICAgaWYgKCFtX3BhZ2UpCkBAIC01MjYsOCArNTM3LDkgQEAgdm9p ZCBXZWJJbnNwZWN0b3JQcm94eTo6Y3JlYXRlSW5zcGVjdG9yUGFnZShJUEM6OkF0dGFjaG1lbnQg Y29ubmVjdGlvbklkZW50aWZpZXIKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV91bmRlclRlc3Qg PSB1bmRlclRlc3Q7CisgICAgbV9jb25uZWN0aW9uSWRlbnRpZmllciA9IGNvbm5lY3Rpb25JZGVu dGlmaWVyOwogCi0gICAgbV9pbnNwZWN0b3JQYWdlLT5wcm9jZXNzKCkuc2VuZChNZXNzYWdlczo6 V2ViSW5zcGVjdG9yVUk6OkVzdGFibGlzaENvbm5lY3Rpb24oY29ubmVjdGlvbklkZW50aWZpZXIs IG1fcGFnZS0+cGFnZUlEKCksIG1fdW5kZXJUZXN0KSwgbV9pbnNwZWN0b3JQYWdlLT5wYWdlSUQo KSk7CisgICAgbV9pbnNwZWN0b3JQYWdlLT5wcm9jZXNzKCkuc2VuZChNZXNzYWdlczo6V2ViSW5z cGVjdG9yVUk6OkVzdGFibGlzaENvbm5lY3Rpb24obV9jb25uZWN0aW9uSWRlbnRpZmllciwgbV9w YWdlLT5wYWdlSUQoKSwgbV91bmRlclRlc3QpLCBtX2luc3BlY3RvclBhZ2UtPnBhZ2VJRCgpKTsK IAogICAgIGlmICghbV91bmRlclRlc3QpIHsKICAgICAgICAgbV9jYW5BdHRhY2ggPSBjYW5BdHRh Y2g7CkBAIC01ODEsNiArNTkzLDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6ZGlkQ2xvc2Uo KQogICAgIG1faXNBdHRhY2hlZCA9IGZhbHNlOwogICAgIG1fY2FuQXR0YWNoID0gZmFsc2U7CiAg ICAgbV91bmRlclRlc3QgPSBmYWxzZTsKKyAgICBtX2Nvbm5lY3Rpb25JZGVudGlmaWVyID0gSVBD OjpBdHRhY2htZW50KCk7CiAKICAgICBwbGF0Zm9ybURpZENsb3NlKCk7CiB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oCmluZGV4IDZlMzFiZDUuLmY4YmQ3 YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94 eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oCkBA IC05NCw2ICs5NCw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHNob3coKTsKICAgICB2b2lkIGhpZGUo KTsKICAgICB2b2lkIGNsb3NlKCk7CisKKyAgICB2b2lkIGRpZFJlbGF1bmNoSW5zcGVjdG9yUGFn ZVByb2Nlc3MoKTsKICAgICAKICNpZiBQTEFURk9STShNQUMpCiAgICAgdm9pZCBjcmVhdGVJbnNw ZWN0b3JXaW5kb3coKTsKQEAgLTIyNCw2ICsyMjYsOCBAQCBwcml2YXRlOgogICAgIC8vIGFsbCB0 aGUgaW5zcGVjdG9ycyBpbiB0aGUgc2FtZSBncm91cCB3aWxsIG1ha2UgaXQgaW1wb3NzaWJsZSB0 byBkZWJ1ZwogICAgIC8vIHRoZSBpbnNwZWN0b3IgY29kZSwgc28gd2UgdXNlIHRoZSBsZXZlbCB0 byBtYWtlIGRpZmZlcmVudCBwYWdlIGdyb3Vwcy4KICAgICB1bnNpZ25lZCBtX2xldmVsOworICAg IAorICAgIElQQzo6QXR0YWNobWVudCBtX2Nvbm5lY3Rpb25JZGVudGlmaWVyOwogCiAgICAgQXR0 YWNobWVudFNpZGUgbV9hdHRhY2htZW50U2lkZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbSBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KaW5kZXggOGFiOGNhMy4uOTMy NTI0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0 b3JQcm94eU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3Bl Y3RvclByb3h5TWFjLm1tCkBAIC0zNSw3ICszNSw3IEBACiAjaW1wb3J0ICJXS09wZW5QYW5lbFJl c3VsdExpc3RlbmVyLmgiCiAjaW1wb3J0ICJXS1JldGFpblB0ci5oIgogI2ltcG9ydCAiV0tVUkxD Ri5oIgotI2ltcG9ydCAiV0tWaWV3UHJpdmF0ZS5oIgorI2ltcG9ydCAiV0tWaWV3SW50ZXJuYWwu aCIKICNpbXBvcnQgIldlYkNvbnRleHQuaCIKICNpbXBvcnQgIldlYkluc3BlY3Rvck1lc3NhZ2Vz LmgiCiAjaW1wb3J0ICJXZWJJbnNwZWN0b3JVSU1lc3NhZ2VzLmgiCkBAIC04Niw2ICs4Niw3IEBA IHN0YXRpYyBjb25zdCB1bnNpZ25lZCB3ZWJWaWV3Q2xvc2VUaW1lb3V0ID0gNjA7CiAKIC0gKGlk KWluaXRXaXRoV2ViSW5zcGVjdG9yUHJveHk6KFdlYkluc3BlY3RvclByb3h5KilpbnNwZWN0b3JQ cm94eTsKIC0gKHZvaWQpY2xvc2U7CistICh2b2lkKWRpZFJlbGF1bmNoUHJvY2VzczsKIAogQGVu ZAogCkBAIC0xMjMsNiArMTI0LDExIEBAIHN0YXRpYyBjb25zdCB1bnNpZ25lZCB3ZWJWaWV3Q2xv c2VUaW1lb3V0ID0gNjA7CiAgICAgX2luc3BlY3RvclByb3h5ID0gbnVsbHB0cjsKIH0KIAorLSAo dm9pZClkaWRSZWxhdW5jaFByb2Nlc3MKK3sKKyAgICBzdGF0aWNfY2FzdDxXZWJJbnNwZWN0b3JQ cm94eSo+KF9pbnNwZWN0b3JQcm94eSktPmRpZFJlbGF1bmNoSW5zcGVjdG9yUGFnZVByb2Nlc3Mo KTsKK30KKwogLSAodm9pZCl3aW5kb3dEaWRNb3ZlOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNh dGlvbgogewogICAgIHN0YXRpY19jYXN0PFdlYkluc3BlY3RvclByb3h5Kj4oX2luc3BlY3RvclBy b3h5KS0+d2luZG93RnJhbWVEaWRDaGFuZ2UoKTsKQEAgLTE2NSw2ICsxNzEsNyBAQCBzdGF0aWMg Y29uc3QgdW5zaWduZWQgd2ViVmlld0Nsb3NlVGltZW91dCA9IDYwOwogQGVuZAogCiBAaW50ZXJm YWNlIFdLV2ViSW5zcGVjdG9yV0tWaWV3IDogV0tWaWV3CitAcHJvcGVydHkgKG5vbmF0b21pYywg YXNzaWduKSBXS1dlYkluc3BlY3RvclByb3h5T2JqQ0FkYXB0ZXIgKmluc3BlY3RvclByb3h5T2Jq Q0FkYXB0ZXI7CiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBXS1dlYkluc3BlY3RvcldLVmlldwpA QCAtMTc0LDYgKzE4MSwxMyBAQCBzdGF0aWMgY29uc3QgdW5zaWduZWQgd2ViVmlld0Nsb3NlVGlt ZW91dCA9IDYwOwogICAgIHJldHVybiBXS0luc3BlY3RvclZpZXdUYWc7CiB9CiAKKy0gKHZvaWQp X2RpZFJlbGF1bmNoUHJvY2VzcworeworICAgIFtzdXBlciBfZGlkUmVsYXVuY2hQcm9jZXNzXTsK KworICAgIFtzZWxmLmluc3BlY3RvclByb3h5T2JqQ0FkYXB0ZXIgZGlkUmVsYXVuY2hQcm9jZXNz XTsKK30KKwogQGVuZAogCiBAaW50ZXJmYWNlIE5TVmlldyAoQXBwS2l0RGV0YWlscykKQEAgLTI5 NCw2ICszMDgsNyBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpjbG9zZVRpbWVyRmlyZWQoKQog ICAgIGlmIChtX2luc3BlY3RvclZpZXcpIHsKICAgICAgICAgV2ViUGFnZVByb3h5KiBpbnNwZWN0 b3JQYWdlID0gdG9JbXBsKG1faW5zcGVjdG9yVmlldy5nZXQoKS5wYWdlUmVmKTsKICAgICAgICAg aW5zcGVjdG9yUGFnZS0+Y2xvc2UoKTsKKyAgICAgICAgW21faW5zcGVjdG9yVmlldyBzZXRJbnNw ZWN0b3JQcm94eU9iakNBZGFwdGVyOm5pbF07CiAgICAgICAgIG1faW5zcGVjdG9yVmlldyA9IG5p bDsKICAgICB9CiAKQEAgLTQ2OSw2ICs0ODQsOCBAQCBXZWJQYWdlUHJveHkqIFdlYkluc3BlY3Rv clByb3h5OjpwbGF0Zm9ybUNyZWF0ZUluc3BlY3RvclBhZ2UoKQogICAgIG1faW5zcGVjdG9yUHJv eHlPYmpDQWRhcHRlciA9IGFkb3B0TlMoW1tXS1dlYkluc3BlY3RvclByb3h5T2JqQ0FkYXB0ZXIg YWxsb2NdIGluaXRXaXRoV2ViSW5zcGVjdG9yUHJveHk6dGhpc10pOwogICAgIEFTU0VSVChtX2lu c3BlY3RvclByb3h5T2JqQ0FkYXB0ZXIpOwogCisgICAgW21faW5zcGVjdG9yVmlldyBzZXRJbnNw ZWN0b3JQcm94eU9iakNBZGFwdGVyOm1faW5zcGVjdG9yUHJveHlPYmpDQWRhcHRlci5nZXQoKV07 CisKICAgICBXZWJQYWdlUHJveHkqIGluc3BlY3RvclBhZ2UgPSB0b0ltcGwobV9pbnNwZWN0b3JW aWV3LmdldCgpLnBhZ2VSZWYpOwogICAgIEFTU0VSVChpbnNwZWN0b3JQYWdlKTsKIAo=