139832 2014-12-19 13:05:33 -0800 Plug leak below LLVMCopyStringRepOfTargetData(). 2014-12-19 14:14:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue msaboff oldest_to_newest 1057149 0 kling 2014-12-19 13:05:33 -0800 Plug leak below LLVMCopyStringRepOfTargetData(). 1057152 1 243571 kling 2014-12-19 13:11:36 -0800 Created attachment 243571 Patch 1057161 2 243571 msaboff 2014-12-19 13:33:35 -0800 Comment on attachment 243571 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243571&action=review r=me > Source/JavaScriptCore/ftl/FTLCompile.cpp:648 > + llvm->SetDataLayout(state.module, stringRepOfTargetData); Does SetDataLayout need the string after it returns or does it copy out its contents? 1057162 3 kling 2014-12-19 13:37:47 -0800 (In reply to comment #2) > Comment on attachment 243571 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243571&action=review > > r=me You forgot to tick r+ :-) > > Source/JavaScriptCore/ftl/FTLCompile.cpp:648 > > + llvm->SetDataLayout(state.module, stringRepOfTargetData); > > Does SetDataLayout need the string after it returns or does it copy out its > contents? It assigns it to an std::string internally, making a copy. 1057173 4 243571 commit-queue 2014-12-19 14:14:25 -0800 Comment on attachment 243571 Patch Clearing flags on attachment: 243571 Committed r177597: <http://trac.webkit.org/changeset/177597> 1057174 5 commit-queue 2014-12-19 14:14:29 -0800 All reviewed patches have been landed. Closing bug. 243571 2014-12-19 13:11:36 -0800 2014-12-19 14:14:25 -0800 Patch bug-139832.diff text/plain 1623 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDA2MTk0OTQuLmQ3M2RiMjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEyLTE5ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBQbHVnIGxlYWsgYmVsb3cgTExWTUNvcHlT dHJpbmdSZXBPZlRhcmdldERhdGEoKS4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEz OTgzMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBM TFZNQ29weVN0cmluZ1JlcE9mVGFyZ2V0RGF0YSgpIHJldHVybnMgYSBzdHJkdXAoKSdlZCBzdHJp bmcsIHNvIG1ha2Ugc3VyZQorICAgICAgICB0byBmcmVlKCkgaXQgYWZ0ZXIgd2UncmUgZG9uZSB1 c2luZyBpdC4KKworICAgICAgICAqIGZ0bC9GVExDb21waWxlLmNwcDoKKyAgICAgICAgKEpTQzo6 RlRMOjptbUFsbG9jYXRlRGF0YVNlY3Rpb24pOgorCiAyMDE0LTEyLTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ1JBU0gg aW5zcGVjdG9yLXByb3RvY29sL2RlYnVnZ2VyL2JyZWFrcG9pbnQtYWN0aW9uLWRldGFjaC5odG1s CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENvbXBpbGUuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExDb21waWxlLmNwcAppbmRleCBiZDgxYWQ5Li5j ODYxMmM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENvbXBpbGUu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ29tcGlsZS5jcHAKQEAgLTY0 NCw3ICs2NDQsOSBAQCB2b2lkIGNvbXBpbGUoU3RhdGUmIHN0YXRlLCBTYWZlcG9pbnQ6OlJlc3Vs dCYgc2FmZXBvaW50UmVzdWx0KQogICAgICAgICAvLyBpdCB0byB0aGUgbW9kdWxlLgogICAgICAg ICBMTFZNVGFyZ2V0TWFjaGluZVJlZiB0YXJnZXRNYWNoaW5lID0gbGx2bS0+R2V0RXhlY3V0aW9u RW5naW5lVGFyZ2V0TWFjaGluZShlbmdpbmUpOwogICAgICAgICBMTFZNVGFyZ2V0RGF0YVJlZiB0 YXJnZXREYXRhID0gbGx2bS0+R2V0RXhlY3V0aW9uRW5naW5lVGFyZ2V0RGF0YShlbmdpbmUpOwot ICAgICAgICBsbHZtLT5TZXREYXRhTGF5b3V0KHN0YXRlLm1vZHVsZSwgbGx2bS0+Q29weVN0cmlu Z1JlcE9mVGFyZ2V0RGF0YSh0YXJnZXREYXRhKSk7CisgICAgICAgIGNoYXIqIHN0cmluZ1JlcE9m VGFyZ2V0RGF0YSA9IGxsdm0tPkNvcHlTdHJpbmdSZXBPZlRhcmdldERhdGEodGFyZ2V0RGF0YSk7 CisgICAgICAgIGxsdm0tPlNldERhdGFMYXlvdXQoc3RhdGUubW9kdWxlLCBzdHJpbmdSZXBPZlRh cmdldERhdGEpOworICAgICAgICBmcmVlKHN0cmluZ1JlcE9mVGFyZ2V0RGF0YSk7CiAKICAgICAg ICAgTExWTVBhc3NNYW5hZ2VyUmVmIGZ1bmN0aW9uUGFzc2VzID0gMDsKICAgICAgICAgTExWTVBh c3NNYW5hZ2VyUmVmIG1vZHVsZVBhc3NlczsK