139830 2014-12-19 12:54:13 -0800 [WinCairo] Crash after failing to create GL context in accelerated compositing mode. 2014-12-19 14:06:29 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue oldest_to_newest 1057143 0 peavo 2014-12-19 12:54:13 -0800 There is missing a null pointer check. 1057145 1 243569 peavo 2014-12-19 12:57:31 -0800 Created attachment 243569 Patch 1057154 2 243569 alex.christensen 2014-12-19 13:25:34 -0800 Comment on attachment 243569 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243569&action=review > Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:99 > + m_context = GLContext::createContextForWindow(m_window, GLContext::sharingContext()); What if we already have a context? Shouldn't this also be in an if (!m_context)? 1057156 3 243572 peavo 2014-12-19 13:30:20 -0800 Created attachment 243572 Patch 1057157 4 peavo 2014-12-19 13:31:02 -0800 (In reply to comment #2) > Comment on attachment 243569 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243569&action=review > > > Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:99 > > + m_context = GLContext::createContextForWindow(m_window, GLContext::sharingContext()); > > What if we already have a context? Shouldn't this also be in an if > (!m_context)? Thanks for reviewing :) Updated patch. 1057169 5 243572 commit-queue 2014-12-19 14:06:24 -0800 Comment on attachment 243572 Patch Clearing flags on attachment: 243572 Committed r177595: <http://trac.webkit.org/changeset/177595> 1057170 6 commit-queue 2014-12-19 14:06:29 -0800 All reviewed patches have been landed. Closing bug. 243569 2014-12-19 12:57:31 -0800 2014-12-19 13:30:10 -0800 Patch bug-139830-20141219215712.patch text/plain 1510 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzU5MCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEyLTE5 ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5D YWlyb10gQ3Jhc2ggYWZ0ZXIgZmFpbGluZyB0byBjcmVhdGUgR0wgY29udGV4dCBpbiBhY2NlbGVy YXRlZCBjb21wb3NpdGluZyBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM5ODMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlcmUgaXMgbWlzc2luZyBhIG51bGwgcG9pbnRlciBjaGVjay4KKwor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0LmNw cDoKKyAgICAgICAgKEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0Ojppbml0aWFsaXplKToK KwogMjAxNC0xMi0xOSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBbV2luXSBBZGQgYWNjZXNzb3IgZm9yIHNlcmlhbGl6aW5nIEhUVFAgbG9hZHMuCkluZGV4 OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5n Q29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBv cnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiAxNzc1MDEpCisr KyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5n Q29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk2LDggKzk2LDEwIEBAIHZvaWQgQWNjZWxl cmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OmluaXQKICAgICBtX25vbkNvbXBvc2l0ZWRDb250ZW50 TGF5ZXItPnNldE5lZWRzRGlzcGxheSgpOwogCiAgICAgLy8gVGhlIGNyZWF0aW9uIG9mIHRoZSBU ZXh0dXJlTWFwcGVyIG5lZWRzIGFuIGFjdGl2ZSBPcGVuR0wgY29udGV4dC4KKyAgICBtX2NvbnRl eHQgPSBHTENvbnRleHQ6OmNyZWF0ZUNvbnRleHRGb3JXaW5kb3cobV93aW5kb3csIEdMQ29udGV4 dDo6c2hhcmluZ0NvbnRleHQoKSk7CisKICAgICBpZiAoIW1fY29udGV4dCkKLSAgICAgICAgbV9j b250ZXh0ID0gR0xDb250ZXh0OjpjcmVhdGVDb250ZXh0Rm9yV2luZG93KG1fd2luZG93LCBHTENv bnRleHQ6OnNoYXJpbmdDb250ZXh0KCkpOworICAgICAgICByZXR1cm47CiAKICAgICBtX2NvbnRl eHQtPm1ha2VDb250ZXh0Q3VycmVudCgpOwogCg== 243572 2014-12-19 13:30:20 -0800 2014-12-19 14:06:24 -0800 Patch bug-139830-20141219223002.patch text/plain 1385 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzU5MCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEyLTE5 ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5D YWlyb10gQ3Jhc2ggYWZ0ZXIgZmFpbGluZyB0byBjcmVhdGUgR0wgY29udGV4dCBpbiBhY2NlbGVy YXRlZCBjb21wb3NpdGluZyBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM5ODMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlcmUgaXMgbWlzc2luZyBhIG51bGwgcG9pbnRlciBjaGVjay4KKwor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0LmNw cDoKKyAgICAgICAgKEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0Ojppbml0aWFsaXplKToK KwogMjAxNC0xMi0xOSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBbV2luXSBBZGQgYWNjZXNzb3IgZm9yIHNlcmlhbGl6aW5nIEhUVFAgbG9hZHMuCkluZGV4 OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5n Q29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBv cnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiAxNzc1MDEpCisr KyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5n Q29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk5LDYgKzk5LDkgQEAgdm9pZCBBY2NlbGVy YXRlZENvbXBvc2l0aW5nQ29udGV4dDo6aW5pdAogICAgIGlmICghbV9jb250ZXh0KQogICAgICAg ICBtX2NvbnRleHQgPSBHTENvbnRleHQ6OmNyZWF0ZUNvbnRleHRGb3JXaW5kb3cobV93aW5kb3cs IEdMQ29udGV4dDo6c2hhcmluZ0NvbnRleHQoKSk7CiAKKyAgICBpZiAoIW1fY29udGV4dCkKKyAg ICAgICAgcmV0dXJuOworCiAgICAgbV9jb250ZXh0LT5tYWtlQ29udGV4dEN1cnJlbnQoKTsKIAog ICAgIG1fdGV4dHVyZU1hcHBlciA9IFRleHR1cmVNYXBwZXJHTDo6Y3JlYXRlKFRleHR1cmVNYXBw ZXI6Ok9wZW5HTE1vZGUpOwo=