139827 2014-12-19 12:12:11 -0800 Stop pretending that the LexicalEnvironment local var is captured 2015-04-13 13:02:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 141174 InRadar P2 Normal --- 140093 140097 139524 1 mark.lam mark.lam mark.lam webkit-bug-importer oldest_to_newest 1057129 0 mark.lam 2014-12-19 12:12:11 -0800 The current code pretends that the LexicalEnvironment local var is captured. This is a short cut to keeping that local var alive (even when it doesn't need to be). However, this pretense does have negative side-effects (see https://bugs.webkit.org/show_bug.cgi?id=139524). So, let's fix it. 1057131 1 webkit-bug-importer 2014-12-19 12:14:35 -0800 <rdar://problem/19311474> 1058766 2 243988 mark.lam 2015-01-05 12:40:52 -0800 Created attachment 243988 the patch. This patch is just to track the work being done. It is not ready for landing because applying this patch will expose other issues manifesting as esc-stress-test failures. Bugs tracking those issues will be documented shortly. 1058768 3 mark.lam 2015-01-05 12:42:19 -0800 (In reply to comment #2) > ... esc-stress-test failures. ... typo: /esc-stress-test/jsc-stress-test/ 1084928 4 mark.lam 2015-04-13 13:02:42 -0700 The offending code was deleted when CodeBlock::isCaptured() was deleted as part of the fix to https://bugs.webkit.org/show_bug.cgi?id=141174. So, I'll resolve this as a dup to 141174. *** This bug has been marked as a duplicate of bug 141174 *** 243988 2015-01-05 12:40:52 -0800 2015-01-05 12:40:52 -0800 the patch. bug-139827.patch text/plain 1411 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc3OTE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTAxLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBT dG9wIHByZXRlbmRpbmcgdGhhdCB0aGUgTGV4aWNhbEVudmlyb25tZW50IGxvY2FsIHZhciBpcyBj YXB0dXJlZC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzOTgyNz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVC bG9jay5jcHA6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6aXNDYXB0dXJlZCk6CisKIDIwMTUt MDEtMDMgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jh c2ggaW4gb3BlcmF0aW9uTmV3RnVuY3Rpb24gd2hlbiBzY3JvbGxpbmcgb24gR29vZ2xlKwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHJldmlz aW9uIDE3NzkxNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2su Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTAyLDExICsyOTAyLDYgQEAgYm9vbCBDb2RlQmxvY2s6 OmlzQ2FwdHVyZWQoVmlydHVhbFJlZ2lzdAogICAgIGlmIChpbmxpbmVDYWxsRnJhbWUpCiAgICAg ICAgIHJldHVybiBpbmxpbmVDYWxsRnJhbWUtPmNhcHR1cmVkVmFycy5nZXQob3BlcmFuZC50b0xv Y2FsKCkpOwogCi0gICAgLy8gVGhlIGxleGljYWwgZW52aXJvbm1lbnQgb2JqZWN0IGlzbid0IGlu IHRoZSBjYXB0dXJlZCByZWdpb24sIGJ1dCBpdCdzICJjYXB0dXJlZCIKLSAgICAvLyBpbiB0aGUg c2Vuc2UgdGhhdCBzdG9yZXMgdG8gaXRzIGxvY2F0aW9uIGNhbiBiZSBvYnNlcnZlZCBpbmRpcmVj dGx5LgotICAgIGlmIChuZWVkc0FjdGl2YXRpb24oKSAmJiBvcGVyYW5kID09IGFjdGl2YXRpb25S ZWdpc3RlcigpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLQogICAgIC8vIERpdHRvIGZvciB0aGUg YXJndW1lbnRzIG9iamVjdC4KICAgICBpZiAodXNlc0FyZ3VtZW50cygpICYmIG9wZXJhbmQgPT0g YXJndW1lbnRzUmVnaXN0ZXIoKSkKICAgICAgICAgcmV0dXJuIHRydWU7Cg==